Re: RFR: 8356126: Duplication handling and optimization of CaptureCallState [v4]

2025-05-05 Thread Jaikiran Pai
On Mon, 5 May 2025 15:52:38 GMT, Chen Liang wrote: >> src/java.base/share/classes/jdk/internal/util/OperatingSystem.java line 139: >> >>> 137: */ >>> 138: private static OperatingSystem initOS() { >>> 139: // Called lazily, valueOf has overhead >> >> Hello Chen, in context of t

Re: JavaDoc: NPE in java.net.http.HttpHeaders

2025-05-05 Thread Alan Bateman
On 05/05/2025 21:05, Steffen Nießing wrote: Hello, recently I've discovered that the JavaDoc of the instance methods of java.net.http.HttpHeaders lacks the throws declarations for NullPointerExceptions. The static creator method `of` contains such a declaration. So the snippet `HttpHeaders.of

Withdrawn: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava

2025-05-05 Thread duke
On Wed, 24 Jul 2024 19:11:42 GMT, Brian Burkhalter wrote: > This proposed change would move the native objects required for NIO file > interaction from the libnio native library to the libjava native library on > Linux, macOS, and Windows. This pull request has been closed without being integr

Withdrawn: 8349543: LinkedBlockingDeque does not immediately throw InterrruptedException in put/take

2025-05-05 Thread duke
On Wed, 5 Feb 2025 15:36:15 GMT, kabutz wrote: > The LinkedBlockingDeque does not behave consistently with other concurrency > components. If we call putFirst(), putLast(), takeFirst(), or takeLast() with > a thread that is interrupted, it does not immediately throw an > InterruptedException,

Re: RFR: 8356219: jpackage places libapplauncher.so in incorrect location in the app image [v2]

2025-05-05 Thread Alexey Semenyuk
> - Refactor PathGroup > - Add test cases to PathGroupTest > - Update UsrTreeTest to verify "libapplauncher.so" is placed in the correct > location in the package > - Refactor UsrTreeTest to use JPackageCommand assert functions Alexey Semenyuk has updated the pull request incrementally with tw

Re: RFR: 8356219: jpackage places libapplauncher.so in incorrect location in the app image [v2]

2025-05-05 Thread Alexey Semenyuk
On Tue, 6 May 2025 02:36:27 GMT, Alexander Matveev wrote: >> Alexey Semenyuk has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update copyright year >> - Fix a typo in ApplicationLayout > > test/jdk/tools/jpackage/helpers/jdk/jpackage/t

Re: RFR: 8356219: jpackage places libapplauncher.so in incorrect location in the app image

2025-05-05 Thread Alexander Matveev
On Mon, 5 May 2025 21:44:36 GMT, Alexey Semenyuk wrote: > - Refactor PathGroup > - Add test cases to PathGroupTest > - Update UsrTreeTest to verify "libapplauncher.so" is placed in the correct > location in the package > - Refactor UsrTreeTest to use JPackageCommand assert functions Looks go

Re: RFR: 8355698: JDK not supporting sleef could cause exception at runtime after JDK-8353786

2025-05-05 Thread Vladimir Ivanov
On Mon, 28 Apr 2025 10:34:49 GMT, Hamlin Li wrote: > Hi, > Can you help to review this patch? > > Before [JDK-8353786](https://bugs.openjdk.org/browse/JDK-8353786), when a > released jdk not supportting sleef (for any reason, e.g. low gcc version, > intrinsic not supported, rvv not supported,

Re: RFR: 8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer [v11]

2025-05-05 Thread Joe Darcy
On Thu, 1 May 2025 17:18:07 GMT, Markus KARG wrote: >> There are subtleties and perhaps surprises in `@inheritDoc`, but that >> doesn't necessarily imply the current behavior is buggy. > > So it is actually *wanted* behavior that in one situation the text *is* > inherited, but at `String.java`

Re: RFR: 8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer [v11]

2025-05-05 Thread Jaikiran Pai
On Thu, 1 May 2025 08:45:06 GMT, Markus KARG wrote: >> This Pull Request proposes an implementation for >> [JDK-8343110](https://bugs.openjdk.org/browse/JDK-8343110): Adding the new >> method `public void getChars(int srcBegin, int srcEnd, char[] dst, int >> dstBegin)` to the `CharSequence` in

Re: RFR: 8351443: Improve robustness of StringBuilder [v5]

2025-05-05 Thread Jaikiran Pai
On Mon, 5 May 2025 17:32:19 GMT, Roger Riggs wrote: >> Refactor AbstractStringBuilder to maintain consistency among count, coder, >> and value buffers while the buffer capacity is being expanded and/or >> inflated from Latin1 to UTF16 representations. >> The refactoring pattern is to read and

Re: RFR: 8355573: Remove kludge_c++11.h from jpackage code

2025-05-05 Thread Alexander Matveev
On Tue, 6 May 2025 00:49:35 GMT, Julian Waters wrote: >> src/jdk.jpackage/windows/native/common/MsiUtils.h line 35: >> >>> 33: #include >>> 34: #include >>> 35: #include >> >> Why this include was added? > > It seemed to be needed to compile successfully back when I removed the kludge > hea

Re: RFR: 8351443: Improve robustness of StringBuilder [v5]

2025-05-05 Thread Jaikiran Pai
On Mon, 5 May 2025 17:32:19 GMT, Roger Riggs wrote: >> Refactor AbstractStringBuilder to maintain consistency among count, coder, >> and value buffers while the buffer capacity is being expanded and/or >> inflated from Latin1 to UTF16 representations. >> The refactoring pattern is to read and

Re: RFR: 8355573: Remove kludge_c++11.h from jpackage code

2025-05-05 Thread Alexander Matveev
On Fri, 25 Apr 2025 06:14:36 GMT, Julian Waters wrote: > kludge_c++11.h was introduced to work around older C++ versions not having > access to C++ utilities like std::unique_ptr. Since we are already on C++14 > (And hopefully will get C++17 soon) this workaround can be removed from > jpackage

Re: RFR: 8356219: jpackage places libapplauncher.so in incorrect location in the app image

2025-05-05 Thread Alexey Semenyuk
On Mon, 5 May 2025 21:44:36 GMT, Alexey Semenyuk wrote: > - Refactor PathGroup > - Add test cases to PathGroupTest > - Update UsrTreeTest to verify "libapplauncher.so" is placed in the correct > location in the package > - Refactor UsrTreeTest to use JPackageCommand assert functions @sashama

RFR: 8356219: jpackage places libapplauncher.so in incorrect location in the app image

2025-05-05 Thread Alexey Semenyuk
- Refactor PathGroup - Add test cases to PathGroupTest - Update UsrTreeTest to verify "libapplauncher.so" is placed in the correct location in the package - Refactor UsrTreeTest to use JPackageCommand assert functions - Commit messages: - Make JPackageCommand.assertFileInAppImage

Re: RFR: 8351443: Improve robustness of StringBuilder [v5]

2025-05-05 Thread Jaikiran Pai
On Mon, 5 May 2025 17:32:19 GMT, Roger Riggs wrote: >> Refactor AbstractStringBuilder to maintain consistency among count, coder, >> and value buffers while the buffer capacity is being expanded and/or >> inflated from Latin1 to UTF16 representations. >> The refactoring pattern is to read and

Re: RFR: 8351443: Improve robustness of StringBuilder [v5]

2025-05-05 Thread Jaikiran Pai
On Mon, 5 May 2025 17:32:19 GMT, Roger Riggs wrote: >> Refactor AbstractStringBuilder to maintain consistency among count, coder, >> and value buffers while the buffer capacity is being expanded and/or >> inflated from Latin1 to UTF16 representations. >> The refactoring pattern is to read and

Re: RFR: 8355573: Remove kludge_c++11.h from jpackage code

2025-05-05 Thread Julian Waters
On Mon, 5 May 2025 22:23:04 GMT, Alexander Matveev wrote: >> kludge_c++11.h was introduced to work around older C++ versions not having >> access to C++ utilities like std::unique_ptr. Since we are already on C++14 >> (And hopefully will get C++17 soon) this workaround can be removed from >> j

Re: RFR: 8351443: Improve robustness of StringBuilder [v5]

2025-05-05 Thread Shaojin Wen
On Mon, 5 May 2025 17:32:19 GMT, Roger Riggs wrote: >> Refactor AbstractStringBuilder to maintain consistency among count, coder, >> and value buffers while the buffer capacity is being expanded and/or >> inflated from Latin1 to UTF16 representations. >> The refactoring pattern is to read and

Re: RFR: 8355798: Implement JEP 514: Ahead-of-Time Command Line Ergonomics [v3]

2025-05-05 Thread Vladimir Kozlov
On Mon, 5 May 2025 01:00:31 GMT, Ioi Lam wrote: >> This is the implementation of the draft [JEP: Ahead-of-time Command Line >> Ergonomics](https://bugs.openjdk.org/browse/JDK-8350022) >> >> - Implemented new flag `AOTCacheOutput`, which can be used to create an AOT >> cache using the "one-comm

Re: RFR: 8355798: Implement JEP 514: Ahead-of-Time Command Line Ergonomics [v3]

2025-05-05 Thread Ioi Lam
On Mon, 5 May 2025 16:21:56 GMT, Vladimir Kozlov wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @vnkozlov comments > > src/hotspot/share/cds/cdsConfig.cpp line 412: > >> 410: log_debug(aot,codecache,init)("AOTCach

Re: RFR: 8355992: Add unsignedMultiplyExact and *powExact methods to Math and StrictMath [v2]

2025-05-05 Thread Joe Darcy
On Fri, 2 May 2025 17:49:54 GMT, Raffaello Giulietti wrote: > Yes, I'm familiar with both this Java code and the intrinsic code. > > Compare this with the much simpler proposed code. The checked multiplication > `unsignedMultiplyExact` apparently performs two 64x64->64 multiplications, > but

Re: RFR: 8354890: AOT-initialize j.l.i.MethodHandleImpl and inner classes [v2]

2025-05-05 Thread Chen Liang
On Mon, 5 May 2025 23:50:31 GMT, Ioi Lam wrote: >> This is a general fix for all the "points to a static field that may hold a >> different value" failures related to `java/lang/invoke/MethodHandleImpl`. >> E.g., [JDK-8354840](https://bugs.openjdk.org/browse/JDK-8354840), >> [JDK-8353330](http

Re: RFR: 8354890: AOT-initialize j.l.i.MethodHandleImpl and inner classes [v2]

2025-05-05 Thread Ioi Lam
> This is a general fix for all the "points to a static field that may hold a > different value" failures related to `java/lang/invoke/MethodHandleImpl`. > E.g., [JDK-8354840](https://bugs.openjdk.org/browse/JDK-8354840), > [JDK-8353330](https://bugs.openjdk.org/browse/JDK-8353330). > > AOT-cac

Re: RFR: 8354890: AOT-initialize j.l.i.MethodHandleImpl and inner classes

2025-05-05 Thread Ioi Lam
On Thu, 1 May 2025 18:52:22 GMT, Andrew Dinn wrote: > @iklam We have seen this problem with Red Hat deployments in jdk24 as well as > jdk25-ea. > > I'm saying that mostly for information. However, I do have to ask: If this is > fixed for jdk25 is there any question of also fixing it in jdk24?

Re: RFR: 8351230: Collections.synchronizedList returns a list that is not thread-safe [v2]

2025-05-05 Thread Stuart Marks
On Sun, 4 May 2025 17:51:48 GMT, Luca Kellermann wrote: >> Stuart Marks has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reversed view of SynchronizedRandomAccessList should also be RandomAccess. >> Add tests to ensure RandomAccess is p

Re: RFR: 8351230: Collections.synchronizedList returns a list that is not thread-safe [v2]

2025-05-05 Thread Stuart Marks
> Collections.synchronizedList() returns a List implementation that doesn't do > proper locking. This PR does the following on the synchronized wrapper: > > - overrides and adds locking to SequencedCollection methods; > - performs instance management of reversed synchronized views; > - adds test

Re: RFR: 8353888: Implement JEP 510: Key Derivation Function API [v6]

2025-05-05 Thread Valerie Peng
On Fri, 2 May 2025 18:49:34 GMT, Weijun Wang wrote: >> Finalize the KDF API. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > fine tuning debug log and exception message Looks good. - Marked as reviewed by vale

Re: RFR: 8355573: Remove kludge_c++11.h from jpackage code

2025-05-05 Thread Alexander Matveev
On Fri, 25 Apr 2025 06:14:36 GMT, Julian Waters wrote: > kludge_c++11.h was introduced to work around older C++ versions not having > access to C++ utilities like std::unique_ptr. Since we are already on C++14 > (And hopefully will get C++17 soon) this workaround can be removed from > jpackage

Re: JavaDoc: NPE in java.net.http.HttpHeaders

2025-05-05 Thread Chen Liang
Hello Steffen, I think this is fine. In the package summary of java.net.http, the last sentence says: Unless otherwise stated, null parameter values will cause methods of all classes in this package to throw NullPointerException. The method you mentioned in particular does mention NPE, but that

Re: RFR: 8351443: Improve robustness of StringBuilder [v5]

2025-05-05 Thread Brent Christian
On Mon, 5 May 2025 17:32:19 GMT, Roger Riggs wrote: >> Refactor AbstractStringBuilder to maintain consistency among count, coder, >> and value buffers while the buffer capacity is being expanded and/or >> inflated from Latin1 to UTF16 representations. >> The refactoring pattern is to read and

Re: RFR: 8342576: [macos] AppContentTest still fails after JDK-8341443 for same reason on older macOS versions

2025-05-05 Thread Alexey Semenyuk
On Fri, 25 Oct 2024 01:49:01 GMT, Alexander Matveev wrote: > - It is not clear on which macOS versions codesign fails if application > bundle contains additional content. > - As a result test was modified to generate only application image, since PKG > or DMG cannot be generated if signing fai

Re: RFR: 8353888: Implement JEP 510: Key Derivation Function API [v6]

2025-05-05 Thread Weijun Wang
On Mon, 5 May 2025 20:04:46 GMT, Valerie Peng wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fine tuning debug log and exception message > > test/jdk/com/sun/crypto/provider/KDF/HKDFSaltIKMTest.java line 26: > >>

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v5]

2025-05-05 Thread Andrey Turbanov
On Mon, 5 May 2025 17:29:33 GMT, Raffaello Giulietti wrote: >> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Increased min heap size to 8G. Marked as r

Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v14]

2025-05-05 Thread Brian Burkhalter
On Fri, 2 May 2025 19:38:11 GMT, Rémi Forax wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8354724: Fix readAllChars gaffe in Reader returned by Readed.of and >> account for it in test > > test/jdk/java/io/Bu

Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v15]

2025-05-05 Thread Brian Burkhalter
> Implement the requested methods and add a test thereof. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8354724: Fix potential NPE in test - Changes: - all: https://git.openjdk.org/jdk/pull/24728/files - new: h

Re: RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter [v2]

2025-05-05 Thread Chen Liang
On Mon, 5 May 2025 18:59:29 GMT, Steffen Nießing wrote: >> JavaDoc only: This PR fixes a typo in the `bytecode behavior` table entry >> for Lookup.findGetter. > > Steffen Nießing has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes th

Integrated: 8356119: Typo in bytecode behavior for Lookup.findGetter

2025-05-05 Thread Steffen Nießing
On Sun, 4 May 2025 16:45:11 GMT, Steffen Nießing wrote: > JavaDoc only: This PR fixes a typo in the `bytecode behavior` table entry for > Lookup.findGetter. This pull request has now been integrated. Changeset: 2a4f37cc Author:Steffen Nießing Committer: Chen Liang URL: https://git

Re: RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter [v2]

2025-05-05 Thread duke
On Mon, 5 May 2025 18:59:29 GMT, Steffen Nießing wrote: >> JavaDoc only: This PR fixes a typo in the `bytecode behavior` table entry >> for Lookup.findGetter. > > Steffen Nießing has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes th

Re: RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter [v2]

2025-05-05 Thread Steffen Nießing
On Mon, 5 May 2025 18:59:29 GMT, Steffen Nießing wrote: >> JavaDoc only: This PR fixes a typo in the `bytecode behavior` table entry >> for Lookup.findGetter. > > Steffen Nießing has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes th

Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v14]

2025-05-05 Thread Brian Burkhalter
On Thu, 1 May 2025 18:00:54 GMT, Stuart Marks wrote: > I'd suggest not having this method's implementation depend on an overridable > method. I'm jumping the gun here by referring to an implementation detail, but the overridable method problem could be circumvented using an approach taken in

Re: RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter [v2]

2025-05-05 Thread Chen Liang
On Mon, 5 May 2025 18:59:29 GMT, Steffen Nießing wrote: >> JavaDoc only: This PR fixes a typo in the `bytecode behavior` table entry >> for Lookup.findGetter. > > Steffen Nießing has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes th

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v5]

2025-05-05 Thread Chen Liang
On Mon, 5 May 2025 17:29:33 GMT, Raffaello Giulietti wrote: >> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Increased min heap size to 8G. Test update

Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v14]

2025-05-05 Thread Brian Burkhalter
On Fri, 2 May 2025 19:00:42 GMT, Stuart Marks wrote: > I think it's still ambiguous. [...] Without addressing the specific comments, I would simply like to point out that "as if" and "equivalent" is common phrasing in this area, e.g., - [File.toPath](https://docs.oracle.com/en/java/javase/24/

Re: RFR: 8353888: Implement JEP 510: Key Derivation Function API [v6]

2025-05-05 Thread Valerie Peng
On Fri, 2 May 2025 18:49:34 GMT, Weijun Wang wrote: >> Finalize the KDF API. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > fine tuning debug log and exception message test/jdk/com/sun/crypto/provider/KDF/HKDFSaltIKMTest.j

JavaDoc: NPE in java.net.http.HttpHeaders

2025-05-05 Thread Steffen Nießing
Hello, recently I've discovered that the JavaDoc of the instance methods of java.net.http.HttpHeaders lacks the throws declarations for NullPointerExceptions. The static creator method `of` contains such a declaration. So the snippet `HttpHeaders.of(null, null)` is documented to throw an NPE,

Re: RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter [v2]

2025-05-05 Thread Steffen Nießing
On Sun, 4 May 2025 17:01:54 GMT, Chen Liang wrote: > Thanks for the mailing list communication and reply. > > Check out https://openjdk.org/guide/ for more steps. For example, a patch > should usually wait 24 hours for sufficient reviews. @liach Thanks for the fast review and the creation of th

Integrated: 8353489: Increase timeout and improve Windows compatibility in test/jdk/java/lang/ProcessBuilder/Basic.java

2025-05-05 Thread Oleksii Sylichenko
On Thu, 6 Mar 2025 13:34:07 GMT, Oleksii Sylichenko wrote: > This PR proposes three improvements to the `Basic.java` test: > > 1. Increase Timeout >- The current timeout is insufficient when running the test in IntelliJ > IDEA. >- I propose increasing it by one minute. >- The timeou

Re: RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter

2025-05-05 Thread Steffen Nießing
On Sun, 4 May 2025 17:20:29 GMT, Eirik Bjørsnøs wrote: > Nit: Would be nice if the PR title/description made it clear for the casual > reader that this is a documentation/Javadoc typo, as opposed to a code issue. Thanks for the hint. I've updated the PR accordingly. > This gives reviewers som

Re: RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter [v2]

2025-05-05 Thread Steffen Nießing
> JavaDoc only: This PR fixes a typo in the `bytecode behavior` table entry for > Lookup.findGetter. Steffen Nießing has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull req

Re: RFR: 8353489: Increase timeout and improve Windows compatibility in test/jdk/java/lang/ProcessBuilder/Basic.java [v3]

2025-05-05 Thread duke
On Sat, 3 May 2025 13:02:34 GMT, Oleksii Sylichenko wrote: >> This PR proposes three improvements to the `Basic.java` test: >> >> 1. Increase Timeout >>- The current timeout is insufficient when running the test in IntelliJ >> IDEA. >>- I propose increasing it by one minute. >>- The

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v4]

2025-05-05 Thread Andrey Turbanov
On Mon, 5 May 2025 17:47:02 GMT, Raffaello Giulietti wrote: >> _Really_ fails with Xmx7G > > Yes, the required heap size was not enough for the reverted variant to throw > a non-OOME exception/error. > > Just out of curiosity, is JDK-8356152 a real-world issue you stumbled upon, > or did you

Re: RFR: 8353489: Increase timeout and improve Windows compatibility in test/jdk/java/lang/ProcessBuilder/Basic.java [v3]

2025-05-05 Thread Roger Riggs
On Sat, 3 May 2025 13:02:34 GMT, Oleksii Sylichenko wrote: >> This PR proposes three improvements to the `Basic.java` test: >> >> 1. Increase Timeout >>- The current timeout is insufficient when running the test in IntelliJ >> IDEA. >>- I propose increasing it by one minute. >>- The

Integrated: 8354334: Remove @ValueBased from ProcessHandle

2025-05-05 Thread Roger Riggs
On Thu, 1 May 2025 13:36:13 GMT, Roger Riggs wrote: > Remove internal ValueBased annotation from the ProcessHandle interface > declaration. > The implementation remains value based as described in the javadoc. > Remove unnecessary "public" keyword in interfaces and cleanup javadoc. This pull r

Re: RFR: 8351443: Improve robustness of StringBuilder [v3]

2025-05-05 Thread Roger Riggs
On Fri, 2 May 2025 17:49:20 GMT, Shaojin Wen wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Optimize StringUTF16.putCharsAt a bit. >> Fixup hotspot Helper of putCharsAt to remove return value to match >> StringU

Re: RFR: 8347408: Create an internal method handle adapter for system calls with errno [v3]

2025-05-05 Thread ExE Boss
On Mon, 5 May 2025 17:13:02 GMT, Per Minborg wrote: >> As we advance, converting older JDK code to use the relatively new FFM API >> requires system calls that can provide `errno` and the likes to explicitly >> allocate a MemorySegment to capture potential error states. This can lead to >> neg

Re: RFR: 8328821: Map.of() derived view collection mutators should throw UnsupportedOperationException [v10]

2025-05-05 Thread Liam Miller-Cushon
On Sat, 26 Apr 2025 04:09:03 GMT, Chen Liang wrote: > I think our next steps are: In early 26, if a corpus search proved no > definitive incompatibility, integrate this change and post a message to > quality-discuss. Same for #15614. If any incompatibility surfaces, we have > sufficient time t

Re: RFR: 8351443: Improve robustness of StringBuilder [v5]

2025-05-05 Thread Jaikiran Pai
On Mon, 5 May 2025 17:58:09 GMT, Roger Riggs wrote: >> In fact, `StringUTF16` and `StringLatin1` are both package-private, so >> technically all their method access modifiers should either be >> package-private or private. > > How about in another PR. None of the `public static ` methods in St

Re: RFR: 8351443: Improve robustness of StringBuilder [v5]

2025-05-05 Thread Roger Riggs
On Mon, 5 May 2025 17:38:55 GMT, Chen Liang wrote: >> src/java.base/share/classes/java/lang/StringUTF16.java line 1531: >> >>> 1529: } >>> 1530: >>> 1531: public static void putCharsAt(byte[] value, int i, char c1, char >>> c2, char c3, char c4) { >> >> Hello Roger, can this (pre-exis

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v4]

2025-05-05 Thread Raffaello Giulietti
On Mon, 5 May 2025 17:11:46 GMT, Andrey Turbanov wrote: >> test/jdk/java/lang/String/concat/HugeConcatTest.java line 38: >> >>> 36: import static org.junit.Assert.assertThrows; >>> 37: >>> 38: public class HugeConcatTest { >> >> I've tried to execute the test with reverting changes in >> `Str

Re: RFR: 8351443: Improve robustness of StringBuilder [v5]

2025-05-05 Thread Chen Liang
On Mon, 5 May 2025 17:34:43 GMT, Jaikiran Pai wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refactor to consistently use `isLatin1(coder)` within >> AbstractStringBuilder. > > src/java.base/share/classes/java/lan

Re: RFR: 8351443: Improve robustness of StringBuilder [v5]

2025-05-05 Thread Jaikiran Pai
On Mon, 5 May 2025 17:32:19 GMT, Roger Riggs wrote: >> Refactor AbstractStringBuilder to maintain consistency among count, coder, >> and value buffers while the buffer capacity is being expanded and/or >> inflated from Latin1 to UTF16 representations. >> The refactoring pattern is to read and

Re: RFR: 8351443: Improve robustness of StringBuilder [v5]

2025-05-05 Thread Roger Riggs
> Refactor AbstractStringBuilder to maintain consistency among count, coder, > and value buffers while the buffer capacity is being expanded and/or inflated > from Latin1 to UTF16 representations. > The refactoring pattern is to read and write AbstractStringBuilder fields > once using locals fo

Re: RFR: 8356096: ISO 4217 Amendment 179 Update

2025-05-05 Thread Iris Clark
On Fri, 2 May 2025 20:51:31 GMT, Justin Lu wrote: > Please review this PR which implements ISO 4217 update 179. > > The _Arab Accounting Dinar_ currency is added under an _agency_, (not > _country_) entity. As a result it is not added as an entry in the country to > currency mapping in `curren

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v5]

2025-05-05 Thread Raffaello Giulietti
> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Increased min heap size to 8G. - Changes: - all: https://git.openjdk.org/jdk/pull/25038/files - ne

Re: RFR: 8356096: ISO 4217 Amendment 179 Update

2025-05-05 Thread Naoto Sato
On Fri, 2 May 2025 20:51:31 GMT, Justin Lu wrote: > Please review this PR which implements ISO 4217 update 179. > > The _Arab Accounting Dinar_ currency is added under an _agency_, (not > _country_) entity. As a result it is not added as an entry in the country to > currency mapping in `curren

Re: RFR: 8351443: Improve robustness of StringBuilder [v4]

2025-05-05 Thread Roger Riggs
> Refactor AbstractStringBuilder to maintain consistency among count, coder, > and value buffers while the buffer capacity is being expanded and/or inflated > from Latin1 to UTF16 representations. > The refactoring pattern is to read and write AbstractStringBuilder fields > once using locals fo

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v4]

2025-05-05 Thread Andrey Turbanov
On Mon, 5 May 2025 14:38:05 GMT, Raffaello Giulietti wrote: >> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Added language concat + to test. test/jdk/

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v4]

2025-05-05 Thread Andrey Turbanov
On Mon, 5 May 2025 17:09:37 GMT, Andrey Turbanov wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added language concat + to test. > > test/jdk/java/lang/String/concat/HugeConcatTest.java line 38: > >> 36: i

Re: RFR: 8347408: Create an internal method handle adapter for system calls with errno [v3]

2025-05-05 Thread Per Minborg
> As we advance, converting older JDK code to use the relatively new FFM API > requires system calls that can provide `errno` and the likes to explicitly > allocate a MemorySegment to capture potential error states. This can lead to > negative performance implications if not designed carefully a

Re: RFR: 8347408: Create an internal method handle adapter for system calls with errno

2025-05-05 Thread Per Minborg
On Mon, 5 May 2025 16:53:58 GMT, Per Minborg wrote: > As we advance, converting older JDK code to use the relatively new FFM API > requires system calls that can provide `errno` and the likes to explicitly > allocate a MemorySegment to capture potential error states. This can lead to > negativ

Re: RFR: 8347408: Create an internal method handle adapter for system calls with errno [v2]

2025-05-05 Thread Per Minborg
> As we advance, converting older JDK code to use the relatively new FFM API > requires system calls that can provide `errno` and the likes to explicitly > allocate a MemorySegment to capture potential error states. This can lead to > negative performance implications if not designed carefully a

RFR: 8347408: Create an internal method handle adapter for system calls with errno

2025-05-05 Thread Per Minborg
As we advance, converting older JDK code to use the relatively new FFM API requires system calls that can provide `errno` and the likes to explicitly allocate a MemorySegment to capture potential error states. This can lead to negative performance implications if not designed carefully and also

Re: RFR: 8347408: Create an internal method handle adapter for system calls with errno [v6]

2025-05-05 Thread Per Minborg
On Tue, 29 Apr 2025 12:33:34 GMT, Per Minborg wrote: >> As we advance, converting older JDK code to use the relatively new FFM API >> requires system calls that can provide `errno` and the likes to explicitly >> allocate a `MemorySegment` to capture potential error states. This can lead >> to

Integrated: 8356040: java/util/PluggableLocale/LocaleNameProviderTest.java timed out

2025-05-05 Thread Justin Lu
On Fri, 2 May 2025 15:49:03 GMT, Justin Lu wrote: > Please review this PR which reduces the amount of combinations tested by > `LocaleNameProviderTest`. > > This test was exhaustively testing over 1000x1000 `Locale` combinations which > was expensive and caused a timeout in tier 5. Narrowing d

Re: RFR: 8356126: Duplicaton handling and optimization of CaptureCallState [v4]

2025-05-05 Thread Chen Liang
On Mon, 5 May 2025 04:50:30 GMT, Chen Liang wrote: >> Credit to @lukellmann that the duplication arg handling in #24742 avoided >> throwing exceptions but produced a wrong option. This patch fixes that and >> removed stream usages in CaptureCallState to speed up bootstrap. >> >> Also, the prev

Re: RFR: 8356126: Duplicaton handling and optimization of CaptureCallState [v5]

2025-05-05 Thread Chen Liang
> Credit to @lukellmann that the duplication arg handling in #24742 avoided > throwing exceptions but produced a wrong option. This patch fixes that and > removed stream usages in CaptureCallState to speed up bootstrap. > > Also, the previous patch affected the toString display of the option; I

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v5]

2025-05-05 Thread Vicente Romero
> This PR is defining a new internal annotation, > `@jdk.internal.RequiresIdentity`, with target types PARAMETER and > TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation > that an argument to a given method or constructor parameter will be an object > with a unique ident

Re: RFR: 8355798: Implement JEP 514: Ahead-of-Time Command Line Ergonomics [v3]

2025-05-05 Thread Vladimir Kozlov
On Mon, 5 May 2025 01:00:31 GMT, Ioi Lam wrote: >> This is the implementation of the draft [JEP: Ahead-of-time Command Line >> Ergonomics](https://bugs.openjdk.org/browse/JDK-8350022) >> >> - Implemented new flag `AOTCacheOutput`, which can be used to create an AOT >> cache using the "one-comm

Re: RFR: 8355798: Implement JEP 514: Ahead-of-Time Command Line Ergonomics [v3]

2025-05-05 Thread Vladimir Kozlov
On Mon, 5 May 2025 01:00:31 GMT, Ioi Lam wrote: >> This is the implementation of the draft [JEP: Ahead-of-time Command Line >> Ergonomics](https://bugs.openjdk.org/browse/JDK-8350022) >> >> - Implemented new flag `AOTCacheOutput`, which can be used to create an AOT >> cache using the "one-comm

Re: RFR: 8355536: Create version constants to model preview language and vm features [v5]

2025-05-05 Thread Chen Liang
> Sometimes, for version-specific feature access APIs, we wish to access the > preview features of the current Java SE release. To reduce the impact of > adding one preview-specific version on every site, we can add a constant > modeling the preview features as a fake version. Chen Liang has up

Re: RFR: 8356126: Revisit CaptureCallState [v4]

2025-05-05 Thread Chen Liang
On Mon, 5 May 2025 08:16:31 GMT, Jaikiran Pai wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> No env to test > > src/java.base/share/classes/jdk/internal/util/OperatingSystem.java line 139: > >> 137: */ >> 138:

Re: RFR: 8356126: Revisit CaptureCallState [v4]

2025-05-05 Thread Chen Liang
On Mon, 5 May 2025 05:31:33 GMT, ExE Boss wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> No env to test > > src/java.base/share/classes/jdk/internal/foreign/abi/CapturableState.java > line 96: > >> 94: public

Re: RFR: 8355249: Remove the use of WMIC from the entire source code [v2]

2025-05-05 Thread Magnus Ihse Bursie
On Tue, 22 Apr 2025 07:41:43 GMT, Daishi Tabata wrote: >> After searching the entire JDK source code, I found that WMIC is only used >> in four files. These WMIC calls can be replaced with PowerShell for WMI. >> >> The primary challenge in this replacement is to make it work the same as >> bef

Re: RFR: 8351443: Improve robustness of StringBuilder [v3]

2025-05-05 Thread Chen Liang
On Fri, 2 May 2025 17:24:06 GMT, Roger Riggs wrote: >> Refactor AbstractStringBuilder to maintain consistency among count, coder, >> and value buffers while the buffer capacity is being expanded and/or >> inflated from Latin1 to UTF16 representations. >> The refactoring pattern is to read and

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v4]

2025-05-05 Thread Vicente Romero
On Mon, 5 May 2025 09:40:16 GMT, Yudi Zheng wrote: >> Vicente Romero has updated the pull request incrementally with one >> additional commit since the last revision: >> >> changes to test > > src/jdk.compiler/share/classes/com/sun/tools/javac/code/Type.java line 669: > >> 667: >> 668:

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v3]

2025-05-05 Thread Raffaello Giulietti
On Mon, 5 May 2025 14:23:11 GMT, Andrey Turbanov wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added '@requires' to test. > > test/jdk/java/lang/String/concat/HugeConcatTest.java line 38: > >> 36: import

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v4]

2025-05-05 Thread Raffaello Giulietti
> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Added language concat + to test. - Changes: - all: https://git.openjdk.org/jdk/pull/25038/files -

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v3]

2025-05-05 Thread Andrey Turbanov
On Mon, 5 May 2025 14:06:27 GMT, Raffaello Giulietti wrote: >> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Added '@requires' to test. test/jdk/java/l

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v3]

2025-05-05 Thread Raffaello Giulietti
> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Added '@requires' to test. - Changes: - all: https://git.openjdk.org/jdk/pull/25038/files - new: h

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v2]

2025-05-05 Thread Raffaello Giulietti
On Mon, 5 May 2025 13:51:13 GMT, Jaikiran Pai wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Simplified test slightly. > > test/jdk/java/lang/String/concat/HugeConcatTest.java line 29: > >> 27: * @summary

Re: RFR: 8355573: Remove kludge_c++11.h from jpackage code

2025-05-05 Thread Alexey Semenyuk
On Fri, 25 Apr 2025 06:14:36 GMT, Julian Waters wrote: > kludge_c++11.h was introduced to work around older C++ versions not having > access to C++ utilities like std::unique_ptr. Since we are already on C++14 > (And hopefully will get C++17 soon) this workaround can be removed from > jpackage

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v2]

2025-05-05 Thread Jaikiran Pai
On Mon, 5 May 2025 13:36:05 GMT, Raffaello Giulietti wrote: >> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Simplified test slightly. test/jdk/java/la

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v2]

2025-05-05 Thread Chen Liang
On Mon, 5 May 2025 13:36:05 GMT, Raffaello Giulietti wrote: >> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Simplified test slightly. Looks good. So t

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v2]

2025-05-05 Thread Raffaello Giulietti
> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Simplified test slightly. - Changes: - all: https://git.openjdk.org/jdk/pull/25038/files - new: ht

RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException

2025-05-05 Thread Raffaello Giulietti
A fix to throw `OutOfMemoryError`, as done in releases ≤ 23. - Commit messages: - 8356152: String.concat can throw StringIndexOutOfBoundsException Changes: https://git.openjdk.org/jdk/pull/25038/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25038&range=00 Issue: https:/

Integrated: 8352730: RISC-V: Disable tests in qemu-user

2025-05-05 Thread Robbin Ehn
On Tue, 25 Mar 2025 14:19:55 GMT, Robbin Ehn wrote: > Hi, for you to consider. > > These tests constantly fails in qemu-user. > Either the require host to be same arch explicit or implicit (sysroot). > E.g. "ptrace(PTRACE_ATTACH, ..) failed for 405157: Function not implemented'" > for SA tests.

Re: RFR: 8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset [v8]

2025-05-05 Thread Lance Andersen
On Wed, 30 Apr 2025 14:14:28 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix an issue >> `java.util.zip.ZipFile` which would cause failures when multiple instances >> of `ZipFile` using non-UTF8 `Charset` were operating against the same >> underlying

Re: RFR: 8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset [v8]

2025-05-05 Thread Eirik Bjørsnøs
On Wed, 30 Apr 2025 14:14:28 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix an issue >> `java.util.zip.ZipFile` which would cause failures when multiple instances >> of `ZipFile` using non-UTF8 `Charset` were operating against the same >> underlying

  1   2   >