On Tue, 6 May 2025 00:49:35 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> src/jdk.jpackage/windows/native/common/MsiUtils.h line 35: >> >>> 33: #include <new> >>> 34: #include <map> >>> 35: #include <memory> >> >> Why this include was added? > > It seemed to be needed to compile successfully back when I removed the kludge > header (I couldn't figure out why). I can try again without the memory > include using GitHub Actions to test instead if that is preferred. I think it is required for `std::unique_ptr` in this file. Strange that it did compiled before. Maybe it was included indirectly somehow. Looks fine. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24868#discussion_r2074537642
