On Sat, 3 May 2025 09:30:17 GMT, Markus KARG wrote:
>> src/java.base/share/classes/java/io/Reader.java line 213:
>>
>>> 211: public String readAllChars() throws IOException {
>>> 212: ensureOpen();
>>> 213: return cs.toString().substring(next);
>>
>>
I have created https://bugs.openjdk.org/browse/JDK-8356119 for you. You can
proceed to create a patch.
From: core-libs-dev on behalf of Steffen
Nießing
Sent: Saturday, May 3, 2025 3:07 PM
To: core-libs-dev@openjdk.org
Subject: Documentation fix in MethodHandles
On Sun, 4 May 2025 03:49:44 GMT, Brent Christian wrote:
> Right now, the test just it prints a single line: `waitForReferenceProcessing
> returned: false` and I expect this to continue to be true.
If reference processing is being slow because of load, that will be different.
> For intermittent
On Thu, 1 May 2025 21:47:01 GMT, Brent Christian wrote:
>> I propose some cleanups to `FinalizerHistogramTest.java` to hopefully clear
>> up the intermittent failures:
>>
>> * run with `othervm`: this test blocks the (global) finalizer thread, and
>> also requires the (global) finalizer thread
On Sat, 3 May 2025 00:35:44 GMT, Kim Barrett wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove unneeded 'trappedCount'
>
> test/jdk/java/lang/ref/FinalizerHistogramTest.java line 78:
>
>> 76:
On Sat, 3 May 2025 20:56:00 GMT, Alexey Semenyuk wrote:
> jpackage doesn't produce a notarizable app image if --app-content is used.
> Filed [JDK-8356117](https://bugs.openjdk.org/browse/JDK-8356117)
Actually, this is a regression as it worked in JDK23 where we just used it
recently
https://g
> On May 3, 2025, at 3:58 PM, Alexey Semenyuk wrote:
>
> On Fri, 25 Oct 2024 01:49:01 GMT, Alexander Matveev
> wrote:
>
>> - It is not clear on which macOS versions codesign fails if application
>> bundle contains additional content.
>> - As a result test was modified to generate only appl
On Fri, 25 Oct 2024 01:49:01 GMT, Alexander Matveev
wrote:
> - It is not clear on which macOS versions codesign fails if application
> bundle contains additional content.
> - As a result test was modified to generate only application image, since PKG
> or DMG cannot be generated if signing fai
On Sat, 3 May 2025 15:51:39 GMT, Michael Hall wrote:
> After creating the app image we put additional content in it under Resources.
> That probably affects the integrity? of the whole stuff
Right, if you modify the app image, you need to resign it. I'm glad you figured
out a workaround. But i
Hello,
I've found a small documentation inconvenience in the MethodHandles.Lookup
class documentation. In the Lookup Factory Methods table the field types of the
member and bytecode definitions for lookup.findGetter diverge:
https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes
On Sat, 3 May 2025 05:03:36 GMT, Shaojin Wen wrote:
>> The byte[] allocated in Integer/Long.toString is fully filled, so we can use
>> StringConcatHelper::newArray to create byte[] to improve performance.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit si
> On May 3, 2025, at 10:49 AM, Michael Hall wrote:
>
>> **Deep** is like going recursively through the files. But should be avoided.
>> I will try without as well
There was something in the man about behavior when using deep in combination
with force. I’m not sure what eliminating one will d
On Fri, 2 May 2025 07:13:21 GMT, Shaojin Wen wrote:
> > > ```java
> > > > char[] ca = new char[end - off];
> > > ```
> > > Your code here has a memory allocation, which may cause slowdown
> >
> > This is exactly what I wanted to express with my posting.
>
> I agree with you that this PR
> On May 3, 2025, at 10:49 AM, Michael Hall wrote:
>
>
>
>> On May 3, 2025, at 10:33 AM, Christoph wrote:
>>
>> On Fri, 25 Oct 2024 01:49:01 GMT, Alexander Matveev
>> wrote:
>>
>>> - It is not clear on which macOS versions codesign fails if application
>>> bundle contains additional con
> On May 3, 2025, at 10:33 AM, Christoph wrote:
>
> On Fri, 25 Oct 2024 01:49:01 GMT, Alexander Matveev
> wrote:
>
>> - It is not clear on which macOS versions codesign fails if application
>> bundle contains additional content.
>> - As a result test was modified to generate only applicati
On Fri, 25 Oct 2024 01:49:01 GMT, Alexander Matveev
wrote:
> - It is not clear on which macOS versions codesign fails if application
> bundle contains additional content.
> - As a result test was modified to generate only application image, since PKG
> or DMG cannot be generated if signing fai
> 3. re-sign the content manually with
>
> # Sign the final artifact
> codesign --force --deep --sign "Developer ID Application: JabRef
> e.V. (6792V39SK3)" \
>--entitlements buildres/mac/jabref.entitlements \
>--options runtime --timestamp build/distr
On Sat, 3 May 2025 12:46:55 GMT, Eirik Bjørsnøs wrote:
>> Would a comment with the following text be sufficient:
>>
>> In Windows CMD (`cmd.exe`), `echo/` outputs a newline (i.e., an empty line).
>> Wrapping it with `cmd.exe /c` ensures compatibility in both native Windows
>> and Cygwin environ
> This PR proposes three improvements to the `Basic.java` test:
>
> 1. Increase Timeout
>- The current timeout is insufficient when running the test in IntelliJ
> IDEA.
>- I propose increasing it by one minute.
>- The timeout value was last modified on May 13, 2010 (commit
> [5613186
On Sat, 3 May 2025 12:44:08 GMT, Oleksii Sylichenko wrote:
>> test/jdk/java/lang/ProcessBuilder/Basic.java line 1843:
>>
>>> 1841:
>>> //
>>> 1842: try {
>>> 1843: String[] cmdp = Windows.is() ? new Stri
On Sat, 3 May 2025 12:19:54 GMT, Eirik Bjørsnøs wrote:
>> Oleksii Sylichenko has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8353489: replace `echo.` with `echo/`
>
> test/jdk/java/lang/ProcessBuilder/Basic.java line 1843:
>
>> 1841:
On Sat, 3 May 2025 11:46:03 GMT, Oleksii Sylichenko wrote:
>> This PR proposes three improvements to the `Basic.java` test:
>>
>> 1. Increase Timeout
>>- The current timeout is insufficient when running the test in IntelliJ
>> IDEA.
>>- I propose increasing it by one minute.
>>- The
> This PR proposes three improvements to the `Basic.java` test:
>
> 1. Increase Timeout
>- The current timeout is insufficient when running the test in IntelliJ
> IDEA.
>- I propose increasing it by one minute.
>- The timeout value was last modified on May 13, 2010 (commit
> [5613186
On Fri, 2 May 2025 22:04:15 GMT, Roger Riggs wrote:
>> On the other hand, the test can be modified as follows: on Windows, pass an
>> empty string as an argument to `echo` and expect two double quotes followed
>> by a newline character as the valid result:
>>
>>
>> String[] cmdp = Windows.is(
On Wed, 23 Apr 2025 22:04:25 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Fix readAllChars gaffe in Reader returned by
On Sat, 3 May 2025 07:25:09 GMT, Markus KARG wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8354724: Fix readAllChars gaffe in Reader returned by Readed.of and
>> account for it in test
>
> src/java.base/shar
On Wed, 23 Apr 2025 22:04:25 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Fix readAllChars gaffe in Reader returned by
On Fri, 25 Oct 2024 01:49:01 GMT, Alexander Matveev
wrote:
> - It is not clear on which macOS versions codesign fails if application
> bundle contains additional content.
> - As a result test was modified to generate only application image, since PKG
> or DMG cannot be generated if signing fai
On Wed, 23 Apr 2025 22:04:25 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Fix readAllChars gaffe in Reader returned by
29 matches
Mail list logo
