Re: RFR: 8354774: DocumentBuilderFactory getAttribute throws NPE [v2]

2025-04-19 Thread Joe Wang
On Sun, 20 Apr 2025 03:05:20 GMT, SendaoYan wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove unused variable pName; remove unused imports > > test/jaxp/javax/xml/jaxp/unittest/common/PropertiesTest.java line 47:

Re: RFR: 8354898: jdk/internal/loader/NativeLibraries/Main.java fails on static JDK

2025-04-19 Thread SendaoYan
On Wed, 16 Apr 2025 23:41:40 GMT, Jiangli Zhou wrote: > Please review this simple test change that skips the test case loading using > JDK `libzip.so` on static JDK in > test/jdk/jdk/internal/loader/NativeLibraries/Main.java. AFAICT, the test case > using `NativeLibrariesTest.LIB_NAME` (`libna

Re: RFR: 8351623: VectorAPI: Refactor subword gather load and add SVE implementation

2025-04-19 Thread SendaoYan
On Wed, 16 Apr 2025 08:58:34 GMT, Xiaohong Gong wrote: > ### Summary: > [JDK-8318650](http://java-service.client.nvidia.com/?q=8318650) added the > hotspot intrinsifying of subword gather load APIs for X86 platforms [1]. This > patch aims at implementing the equivalent functionality for AArch64

Re: RFR: 8354774: DocumentBuilderFactory getAttribute throws NPE [v2]

2025-04-19 Thread SendaoYan
On Fri, 18 Apr 2025 21:26:23 GMT, Joe Wang wrote: >> Fix a NPE on calling DocumentBuilderFactory::getAttribute, refer to the bug >> report. >> >> Also in this patch: consolidates get and set properties to use the same Util >> methods to reduce potential errors when code changes. >> >> Test: >

Re: RFR: 8352504: RISC-V: implement and enable CMoveI/L [v9]

2025-04-19 Thread Fei Yang
On Sat, 19 Apr 2025 20:09:59 GMT, Hamlin Li wrote: >> Hi, >> Can you help to review this patch? >> On riscv, CMoveI/L already were implemented, but there are some gap: >> 1. CMoveI/L does not support comparison with float/double, corresponding >> tests are not turn on either. >> 2. Some optimiza

Re: RFR: 8352504: RISC-V: implement and enable CMoveI/L [v8]

2025-04-19 Thread Hamlin Li
On Wed, 16 Apr 2025 00:05:44 GMT, Fei Yang wrote: >> Hamlin Li has updated the pull request incrementally with one additional >> commit since the last revision: >> >> minors > > test/hotspot/jtreg/compiler/vectorapi/TestVectorTest.java line 2: > >> 1: /* >> 2: * Copyright (c) 2022, 2025,Ora

Re: RFR: 8352504: RISC-V: implement and enable CMoveI/L [v9]

2025-04-19 Thread Hamlin Li
> Hi, > Can you help to review this patch? > On riscv, CMoveI/L already were implemented, but there are some gap: > 1. CMoveI/L does not support comparison with float/double, corresponding > tests are not turn on either. > 2. Some optimization of C2 is not turned on, e.g. `Phi -> CMove -> min_max`

Re: RFR: 8077587: BigInteger Roots [v18]

2025-04-19 Thread fabioromano1
> This PR implements nth root computation for `BigInteger`s using Newton method > and optimizes `BigInteger.pow(int)` method. > [Here is a proof of convergence of the recurrence > used.](https://github.com/user-attachments/files/19785045/nth_root_newton_proof_integers.pdf) fabioromano1 has updat

Re: RFR: 8077587: BigInteger Roots [v17]

2025-04-19 Thread fabioromano1
> This PR implements nth root computation for `BigInteger`s using Newton method > and optimizes `BigInteger.pow(int)` method. > [Here is a proof of convergence of the recurrence > used.](https://github.com/user-attachments/files/19785045/nth_root_newton_proof_integers.pdf) fabioromano1 has updat

Re: RFR: 8077587: BigInteger Roots [v16]

2025-04-19 Thread fabioromano1
> This PR implements nth root computation for `BigInteger`s using Newton method > and optimizes `BigInteger.pow(int)` method. > [Here is a proof of convergence of the recurrence > used.](https://github.com/user-attachments/files/19785045/nth_root_newton_proof_integers.pdf) fabioromano1 has updat

Re: RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version

2025-04-19 Thread Chen Liang
On Fri, 18 Apr 2025 20:33:27 GMT, Chen Liang wrote: > Take the class file version to reject flags not yet defined, redefined, or > obsoleted. The non-cffv version can return the preview flags when the current > runtime is in preview. That is tracked in a separate bug linked as a dependent on t

Re: RFR: 8077587: BigInteger Roots [v15]

2025-04-19 Thread fabioromano1
> This PR implements nth root computation for `BigInteger`s using Newton method > and optimizes `BigInteger.pow(int)` method. > [Here is a proof of convergence of the recurrence > used.](https://github.com/user-attachments/files/19785045/nth_root_newton_proof_integers.pdf) fabioromano1 has updat

Re: RFR: 8077587: BigInteger Roots [v14]

2025-04-19 Thread fabioromano1
> This PR implements nth root computation for `BigInteger`s using Newton method > and optimizes `BigInteger.pow(int)` method. > [Here is a proof of convergence of the recurrence > used.](https://github.com/user-attachments/files/19785045/nth_root_newton_proof_integers.pdf) fabioromano1 has updat

Re: RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version

2025-04-19 Thread ExE Boss
On Fri, 18 Apr 2025 20:33:27 GMT, Chen Liang wrote: > Take the class file version to reject flags not yet defined, redefined, or > obsoleted. The non-cffv version can return the preview flags when the current > runtime is in preview. With this, the **Class‑File API** needs to be updated to pas

Re: RFR: 8077587: BigInteger Roots [v13]

2025-04-19 Thread fabioromano1
> This PR implements nth root computation for `BigInteger`s using Newton method > and optimizes `BigInteger.pow(int)` method. > [Here is a proof of convergence of the recurrence > used.](https://github.com/user-attachments/files/19785045/nth_root_newton_proof_integers.pdf) fabioromano1 has updat