On Mon, 7 Apr 2025 18:40:35 GMT, Roger Riggs wrote:
>> Now that the Security Manager is permanently disabled, the following
>> permission classes in the core libraries area can be deprecated for removal
>> as they are no longer useful: FilePermission, LinkPermission,
>> LoggingPermission, Prop
On Sun, 16 Feb 2025 11:44:23 GMT, Jaikiran Pai wrote:
> Can I please get a review of this doc-only change which proposes to improve
> the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`,
> `InflaterInputStream` and `InflaterOutputStream` classes?
>
> As noted in https://bugs
On Mon, 7 Apr 2025 09:05:36 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to improve
>> the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`,
>> `InflaterInputStream` and `InflaterOutputStream` classes?
>>
>> As noted in https://
On Wed, 26 Mar 2025 16:19:16 GMT, Viktor Klang wrote:
> I'm breaking this change out as a separate improvement, since it will not be
> generally possible to adjust these limits on the j.u.c primitives since they
> might already use a backing `long` to pack in information which needs to be
> up
On Sat, 5 Apr 2025 05:30:25 GMT, Shaojin Wen wrote:
>> Improve the performance of UUID::toString by using Long.expand and SWAR
>> (SIMD within a register) instead of table lookup. Eliminating the table
>> lookup can also avoid the performance degradation problem when the cache
>> misses.
>
> S
On Mon, 7 Apr 2025 06:34:11 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the
> increase in memory footprint of an application that uses signed JAR files,
> signed with `SHA-384` digest algorithm? This addresses
> https://bugs.openjdk.org/browse/
On Mon, 7 Apr 2025 17:44:33 GMT, Chen Liang wrote:
>> Vladimir Ivanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> features_string -> cpu_info_string
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/CPUFeatures.java
>
> Migrate Vector API math library (SVML and SLEEF) linkage from native code (in
> JVM) to Java FFM API.
>
> Since FFM API doesn't support vector calling conventions yet, migration
> affects only symbol lookup for now. But it still enables significant
> simplifications on JVM side.
>
> The patc
On Mon, 7 Apr 2025 17:15:34 GMT, Naoto Sato wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix comment from file.encoding to native.encoding
>
> src/java.base/share/native/libjava/System.c line 153:
>
>> 151:
On Sun, 6 Apr 2025 12:36:43 GMT, Viktor Klang wrote:
> This PR reverts the deactivation changes of the updates to FJP introduced in
> JDK-8319447.
Looks good. Thanks for tracking this down.
-
Marked as reviewed by dl (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24473#p
On Mon, 7 Apr 2025 23:03:03 GMT, Vladimir Ivanov wrote:
>> Migrate Vector API math library (SVML and SLEEF) linkage from native code
>> (in JVM) to Java FFM API.
>>
>> Since FFM API doesn't support vector calling conventions yet, migration
>> affects only symbol lookup for now. But it still en
> Migrate Vector API math library (SVML and SLEEF) linkage from native code (in
> JVM) to Java FFM API.
>
> Since FFM API doesn't support vector calling conventions yet, migration
> affects only symbol lookup for now. But it still enables significant
> simplifications on JVM side.
>
> The patc
On Wed, 2 Apr 2025 22:27:14 GMT, Justin Lu wrote:
> Please review this PR which provides unit tests for
> `ChoiceFormat#parse(String, ParsePosition)` to check default, multi match,
> and no match behavior. There were no existing relevant tests.
This pull request has now been integrated.
Chang
> Migrate Vector API math library (SVML and SLEEF) linkage from native code (in
> JVM) to Java FFM API.
>
> Since FFM API doesn't support vector calling conventions yet, migration
> affects only symbol lookup for now. But it still enables significant
> simplifications on JVM side.
>
> The patc
On Mon, 7 Apr 2025 19:44:40 GMT, Stuart Marks wrote:
>> Can we rephrase the 1st sentence to read:
>> "The `readln()` and `readln(String)` methods in this class decode bytes read
>> from `System.in` into characters."
>>
>> And remove the last "these internal objects" sentence.
>>
>> And for the
> This is a PR that implements JEP: Compact Source Files and Instance Main
> Methods. Changes include:
> - `java.io.IO` moved to `java.lang.IO`, and no longer uses `System.console()`
> to implement the methods (thanks to @stuart-marks)
> - `java. ... .IO` is no longer automatically imported in an
On Wed, 2 Apr 2025 19:46:12 GMT, Justin Lu wrote:
>> Please review this PR which specifies the `ChoiceFormat#parse(String,
>> ParsePosition)` method. A corresponding CSR is filed. The current
>> specification is simply "Parses a Number from the input text" which does not
>> indicate how the va
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Fix typo in return type
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- new: https://git.open
On Tue, 1 Apr 2025 16:45:26 GMT, Justin Lu wrote:
> Please review this PR which specifies the `ChoiceFormat#parse(String,
> ParsePosition)` method. A corresponding CSR is filed. The current
> specification is simply "Parses a Number from the input text" which does not
> indicate how the value
On Mon, 7 Apr 2025 18:13:29 GMT, Jan Lahoda wrote:
>> This is a PR that implements JEP: Compact Source Files and Instance Main
>> Methods. Changes include:
>> - `java.io.IO` moved to `java.lang.IO`, and no longer uses
>> `System.console()` to implement the methods (thanks to @stuart-marks)
>> -
On Sat, 5 Apr 2025 01:19:39 GMT, Shaojin Wen wrote:
>> The byte[] allocated in Integer/Long.toString is fully filled, so we can use
>> StringConcatHelper::newArray to create byte[] to improve performance.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit si
On Sun, 6 Apr 2025 08:09:27 GMT, Zihao Lin wrote:
>> Modify the cache in MethodTypeForm that currently stores the LF_INTERPRET
>> Lambda form. Instead of caching the entire LambdaForm, change it to store a
>> SoftReference. This will avoid unnecessary memory usage.
>
> Zihao Lin has updated the
On Sun, 6 Apr 2025 08:05:42 GMT, Zihao Lin wrote:
>> src/java.base/share/classes/java/lang/invoke/MethodTypeForm.java line 71:
>>
>>> 69: // Indexes into lambdaForms:
>>> 70: static final int
>>> 71: LF_INVVIRTUAL = 0, // DMH invokeVirtual
>>
>> You can remove
On Fri, 4 Apr 2025 23:42:26 GMT, Stuart Marks wrote:
> Some of the code that creates various encoding properties at JVM
> initialization time, such as file.encoding and native.encoding, could use
> some cleaning up. Cleanup is fairly minimal and should be mostly
> behavior-preserving. Changes
On Mon, 7 Apr 2025 09:05:36 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to improve
>> the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`,
>> `InflaterInputStream` and `InflaterOutputStream` classes?
>>
>> As noted in https://
On Mon, 7 Apr 2025 09:18:37 GMT, Alan Bateman wrote:
>> This implementation is not to be emulated by beginners. If an Exception.is
>> thrown here, a user might be tempted to add handlers in their code, while
>> this is an issue with the setup.
>
> Someone is bound to ask why the readln method t
On Mon, 7 Apr 2025 18:10:20 GMT, Jan Lahoda wrote:
>> This is a PR that implements JEP: Compact Source Files and Instance Main
>> Methods. Changes include:
>> - `java.io.IO` moved to `java.lang.IO`, and no longer uses
>> `System.console()` to implement the methods (thanks to @stuart-marks)
>> -
> This is a PR that implements JEP: Compact Source Files and Instance Main
> Methods. Changes include:
> - `java.io.IO` moved to `java.lang.IO`, and no longer uses `System.console()`
> to implement the methods (thanks to @stuart-marks)
> - `java. ... .IO` is no longer automatically imported in an
On Sat, 5 Apr 2025 00:55:55 GMT, Luca Kellermann wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use local variable for System.out in print().
>
> src/java.base/share/classes/java/lang/IO.java line 122:
>
>> 120:
> Now that the Security Manager is permanently disabled, the following
> permission classes in the core libraries area can be deprecated for removal
> as they are no longer useful: FilePermission, LinkPermission,
> LoggingPermission, PropertyPermission, ReflectPermission, RuntimePermission,
> a
On Fri, 4 Apr 2025 22:52:24 GMT, Vladimir Ivanov wrote:
> Migrate Vector API math library (SVML and SLEEF) linkage from native code (in
> JVM) to Java FFM API.
>
> Since FFM API doesn't support vector calling conventions yet, migration
> affects only symbol lookup for now. But it still enables
On Fri, 4 Apr 2025 23:03:23 GMT, Justin Lu wrote:
>> Please review this PR which improves some Currency
>> `IllegalArgumentException`s by including the input in the message. This
>> could be a currency code, country code, or locale. This change also includes
>> tests to check the messages for
On Tue, 1 Apr 2025 17:33:43 GMT, Alan Bateman wrote:
> `jmod create` maps the contents of the module to a set of packages. This
> mapping derives illegal package names when class resources are located in
> non-package locations, e.g. in the META-INF tree. `jlink` also has an issue
> in this ar
> I'm breaking this change out as a separate improvement, since it will not be
> generally possible to adjust these limits on the j.u.c primitives since they
> might already use a backing `long` to pack in information which needs to be
> updated atomically (would require 128-bit atomics to widen
On Mon, 7 Apr 2025 15:08:56 GMT, Roger Riggs wrote:
>> `jmod create` maps the contents of the module to a set of packages. This
>> mapping derives illegal package names when class resources are located in
>> non-package locations, e.g. in the META-INF tree. `jlink` also has an issue
>> in this
On Tue, 1 Apr 2025 17:33:43 GMT, Alan Bateman wrote:
> `jmod create` maps the contents of the module to a set of packages. This
> mapping derives illegal package names when class resources are located in
> non-package locations, e.g. in the META-INF tree. `jlink` also has an issue
> in this ar
On Sun, 6 Apr 2025 12:36:43 GMT, Viktor Klang wrote:
> This PR reverts the deactivation changes of the updates to FJP introduced in
> JDK-8319447.
This pull request has now been integrated.
Changeset: 40210333
Author:Viktor Klang
URL:
https://git.openjdk.org/jdk/commit/402103331bcd
On Mon, 7 Apr 2025 14:03:13 GMT, Alan Bateman wrote:
>> Viktor Klang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> commits s
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Fix typo
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- new: https://git.openjdk.org/jdk/pul
> Alternative approach to #24012
>
> This keeps the current handling of *.pdb vs *.stripped.pdb which allows
> debugging at the cost of a little hack in jlink. Maybe the code in jlink can
> be improved, e.g. make it more conditional.
>
> I'm running this through our testing still to see whether
Hi,
Can you help to review this patch?
On riscv, CMoveI/L already were implemented, but there are some gap:
1. CMoveI/L does not support comparison with float/double, corresponding tests
are not turn on either.
2. Some optimization of C2 is not turned on, e.g. `Phi -> CMove -> min_max`.
3. lack of
On Mon, 7 Apr 2025 13:55:27 GMT, Viktor Klang wrote:
>> I'm breaking this change out as a separate improvement, since it will not be
>> generally possible to adjust these limits on the j.u.c primitives since they
>> might already use a backing `long` to pack in information which needs to be
>>
On Sun, 6 Apr 2025 12:36:43 GMT, Viktor Klang wrote:
> This PR reverts the deactivation changes of the updates to FJP introduced in
> JDK-8319447.
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/24473#pullrequestreview-2746919024
On Wed, 2 Apr 2025 13:09:01 GMT, Viktor Klang wrote:
>> test/jdk/java/util/concurrent/tck/ReentrantReadWriteLock20Test.java line 94:
>>
>>> 92: next.join();
>>> 93: } catch (InterruptedException ie) {
>>> 94: }
>>
>> I don't think
> For JEP 493-enabled builds there are no JMODs. Certain files come from the
> installed JDK image when a user creates a custom run-time from it. This is
> problematic for example for files that often come from a different package
> (e.g. `cacerts` file for Linux distro builds of OpenJDK package
On Mon, 7 Apr 2025 12:49:45 GMT, Sean Mullan wrote:
> I suggest making this a P3 since it sounds like it would be useful to
> backport to 21.
Done - I've marked it as a P3, and I agree that this is worth backporting.
-
PR Comment: https://git.openjdk.org/jdk/pull/24475#issuecommen
On Tue, 1 Apr 2025 09:13:45 GMT, Joachim Kern wrote:
> In the JDK launcher, there is a codepath which would set/modify the
> LD_LIBRARY_PATH. This happens unconditionally on AIX and Linux/musl and can
> also happen on other Linux platforms if an LD_LIBRARY_PATH is pre-set which
> contains a li
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Change double to int
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- new: https://git.openjdk
Thank you Brian, I’m sorry I missed this point! The hint in this case is the
parameter on the overloaded constructor; if set high enough, the
initially-allocated buffer will guarantee exactly one array allocation with no
growth. This is identical to the ByteArrayOutputStream behavior describ
On Sat, 5 Apr 2025 04:45:00 GMT, Christoph Langer wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> c
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with two additional
commits since the last revision:
- Update examples
- Remove parantheses
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- new:
On Mon, 7 Apr 2025 12:14:28 GMT, Christoph Langer wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments from Christoph
>
> test/jdk/tools/jlink/runtimeImage/UpgradeableFileCacertsTest.java line 42:
>
On Fri, 4 Apr 2025 09:22:10 GMT, Joachim Kern wrote:
>> In the JDK launcher, there is a codepath which would set/modify the
>> LD_LIBRARY_PATH. This happens unconditionally on AIX and Linux/musl and can
>> also happen on other Linux platforms if an LD_LIBRARY_PATH is pre-set which
>> contains
On Mon, 7 Apr 2025 12:11:51 GMT, Severin Gehwolf wrote:
>> For JEP 493-enabled builds there are no JMODs. Certain files come from the
>> installed JDK image when a user creates a custom run-time from it. This is
>> problematic for example for files that often come from a different package
>> (
> For JEP 493-enabled builds there are no JMODs. Certain files come from the
> installed JDK image when a user creates a custom run-time from it. This is
> problematic for example for files that often come from a different package
> (e.g. `cacerts` file for Linux distro builds of OpenJDK package
On Fri, 4 Apr 2025 21:11:52 GMT, Ioi Lam wrote:
>> All the opening and reading is handled by `URLClassPath` (it's not just
>> JARs, can also be directories). I used only `defineClass` from
>> `URLClassLoader` to minimize the behavior difference with the old code —
>> besides defining the class
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Only use partial functions
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- new: https://git.o
Hello,
I had a look here, and can reproduce the error.
jnativescan does have handling for Multi-Release jars. By default it
uses the current JDK version, which in your case would be 24. An exact
version can be specified using --release. The issue in this case is that
the error originates fr
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Add note an partial and total functions
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- new:
On Mon, 7 Apr 2025 09:34:37 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add note an partial and total functions
Here are the latest g
On Thu, 3 Apr 2025 14:26:15 GMT, Quan Anh Mai wrote:
>> I don't think we should promise this even though it might be the case.
>
> What is the benefit of not promising it? Promising helps the supplier to have
> a well-defined order of execution. Furthermore, even if you do not promise
> it, it
On Sat, 5 Apr 2025 02:30:33 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/IO.java line 147:
>>
>>> 145: } catch (IOException ioe) {
>>> 146: throw new IOError(ioe);
>>> 147: }
>>
>> Was `UncheckedIOException` considered? It might be better for begin
On Fri, 4 Apr 2025 07:20:23 GMT, Jan Lahoda wrote:
> This is a PR that implements JEP: Compact Source Files and Instance Main
> Methods. Changes include:
> - `java.io.IO` moved to `java.lang.IO`, and no longer uses `System.console()`
> to implement the methods (thanks to @stuart-marks)
> - `jav
On Tue, 1 Apr 2025 16:12:39 GMT, Alan Bateman wrote:
> > @AlanBateman Any more thoughts on this? We'd need to include a patch like
> > this one for getting the Fedora JDK 24+ builds to work with JEP 493
> > enabled. Thanks!
>
> Allowing for a small number of upgradable files is needed, I see y
> Can I please get a review of this doc-only change which proposes to improve
> the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`,
> `InflaterInputStream` and `InflaterOutputStream` classes?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8066583 some of the
> construct
On Mon, 7 Apr 2025 09:02:04 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to improve
>> the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`,
>> `InflaterInputStream` and `InflaterOutputStream` classes?
>>
>> As noted in https://
On Sat, 5 Apr 2025 04:49:03 GMT, Christoph Langer wrote:
> I see that you're actively on the upgradeable files. What about #24190?
Let's keep the discussion on #24190, please.
-
PR Comment: https://git.openjdk.org/jdk/pull/24388#issuecomment-2782507174
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Add comment about stable fun/coll and fix typos
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 295 commits:
- Update doces
- Merge branch 'master' into implement-jep502
- Merge branch 'master' into implement
> If a base class is package-private then its subclasses should have the same
> package name and defining class loader, otherwise `IllegalAccessError` is
> thrown when linking a subclass. Currently when dumping a static archive
> separate `URLClassLoader`s are used for each unregistered classes'
On Mon, 7 Apr 2025 06:34:11 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the
> increase in memory footprint of an application that uses signed JAR files,
> signed with `SHA-384` digest algorithm? This addresses
> https://bugs.openjdk.org/browse/
On Fri, 4 Apr 2025 07:20:23 GMT, Jan Lahoda wrote:
> This is a PR that implements JEP: Compact Source Files and Instance Main
> Methods. Changes include:
> - `java.io.IO` moved to `java.lang.IO`, and no longer uses `System.console()`
> to implement the methods (thanks to @stuart-marks)
> - `jav
On Sat, 5 Apr 2025 00:55:55 GMT, Luca Kellermann wrote:
>> This is a PR that implements JEP: Compact Source Files and Instance Main
>> Methods. Changes include:
>> - `java.io.IO` moved to `java.lang.IO`, and no longer uses
>> `System.console()` to implement the methods (thanks to @stuart-marks)
This is a PR that implements JEP: Compact Source Files and Instance Main
Methods. Changes include:
- `java.io.IO` moved to `java.lang.IO`, and no longer uses `System.console()`
to implement the methods (thanks to @stuart-marks)
- `java. ... .IO` is no longer automatically imported in any compilat
On Sat, 5 Apr 2025 00:20:29 GMT, Chen Liang wrote:
>> This is a PR that implements JEP: Compact Source Files and Instance Main
>> Methods. Changes include:
>> - `java.io.IO` moved to `java.lang.IO`, and no longer uses
>> `System.console()` to implement the methods (thanks to @stuart-marks)
>> -
On Fri, 4 Apr 2025 07:20:23 GMT, Jan Lahoda wrote:
> This is a PR that implements JEP: Compact Source Files and Instance Main
> Methods. Changes include:
> - `java.io.IO` moved to `java.lang.IO`, and no longer uses `System.console()`
> to implement the methods (thanks to @stuart-marks)
> - `jav
On Fri, 4 Apr 2025 07:20:23 GMT, Jan Lahoda wrote:
> This is a PR that implements JEP: Compact Source Files and Instance Main
> Methods. Changes include:
> - `java.io.IO` moved to `java.lang.IO`, and no longer uses `System.console()`
> to implement the methods (thanks to @stuart-marks)
> - `jav
77 matches
Mail list logo
