On Tue, 1 Apr 2025 07:22:57 GMT, Jaikiran Pai wrote:
>> Does the original specification imply a default decompressor is created, or
>> is such a default decompressor simply used?
>
> Hello Chen, if you mean whether multiple instances of these streams can share
> the same default decompressor, t
On Tue, 1 Apr 2025 20:00:22 GMT, Chris Plummer wrote:
>> Calling ThreadGroupReference.groups() from an event handler can cause a
>> deadlock. Details in first comment. Tested with :jdk_lang on all supported
>> platforms and tier1, tier2, tier3, and tier5 svc testing.
>
> Chris Plummer has updat
On Tue, 1 Apr 2025 13:22:47 GMT, Magnus Ihse Bursie wrote:
> there was already a pragma but due to incorrect restrictions it did not apply
> to clang.
How does the `__GNUC__` check affect clang?? Isn't that just for gcc?
-
PR Comment: https://git.openjdk.org/jdk/pull/24357#issueco
On Thu, 20 Mar 2025 04:46:21 GMT, Ioi Lam wrote:
> `-XX:+AOTClassLinking` requires the CDS archived full module graph (FMG).
>
> - Before this PR, when `--add-export` is specified, FMG is disabled, so AOT
> caches created with `-XX:+AOTClassLinking` cannot be loaded.
> - After this PR, if the
On Tue, 25 Mar 2025 04:15:11 GMT, Calvin Cheung wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase.
>
> Code changes look clean. I just have two minor commen
On Tue, 1 Apr 2025 20:00:22 GMT, Chris Plummer wrote:
>> Calling ThreadGroupReference.groups() from an event handler can cause a
>> deadlock. Details in first comment. Tested with :jdk_lang on all supported
>> platforms and tier1, tier2, tier3, and tier5 svc testing.
>
> Chris Plummer has updat
On Tue, 1 Apr 2025 20:32:45 GMT, Justin Lu wrote:
>> Please review this PR which specifies the `ChoiceFormat#parse(String,
>> ParsePosition)` method. A corresponding CSR is filed. The current
>> specification is simply "Parses a Number from the input text" which does not
>> indicate how the va
> jpackage app laucnher will expand environment variables in .cfg files.
>
> Previously jpackage app launcher only replaced `$APPDIR`, `$BINDIR`, and
> `$ROOTDIR` tokens with the corresponding path values. With this patch, any
> environment variable can be expanded. The syntax is shell-like
> `
On Tue, 1 Apr 2025 19:00:56 GMT, Alexey Semenyuk wrote:
>> Make tools/jpackage/share/ErrorTest.java test safely handle the case when
>> native bundling is unavailable on the test host.
>>
>> Additionally:
>> - If native bundling is unavailable on the test host, PackageTest will
>> throw `jtre
On Tue, 1 Apr 2025 09:43:28 GMT, Kim Barrett wrote:
>> Please review this change which adds a native method providing the
>> implementation of Reference::get. Referece::get is an intrinsic candidate,
>> so
>> this native method implementation is only used when the intrinsic is not.
>>
>> Curre
On Mon, 24 Mar 2025 21:29:29 GMT, Chen Liang wrote:
>> Core reflection's generic signature parsing system is used for many aspects,
>> including annotations and enclosing methods, yet it is under-tested. It is
>> better for us to set up tests to ensure that sensitive error behaviors of
>> core
> jpackage app laucnher will expand environment variables in .cfg files.
>
> Previously jpackage app launcher only replaced `$APPDIR`, `$BINDIR`, and
> `$ROOTDIR` tokens with the corresponding path values. With this patch, any
> environment variable can be expanded. The syntax is shell-like
> `
> jpackage app laucnher will expand environment variables in .cfg files.
>
> Previously jpackage app launcher only replaced `$APPDIR`, `$BINDIR`, and
> `$ROOTDIR` tokens with the corresponding path values. With this patch, any
> environment variable can be expanded. The syntax is shell-like
> `
On Tue, 1 Apr 2025 12:07:09 GMT, SendaoYan wrote:
>> Hi all,
>> File src/java.base/share/native/libjli/java.c compile error: control reaches
>> end of non-void function [-Werror=return-type] with gcc options
>> -fsanitize=address -O0. The function int JavaMain(void* _args) in this file
>> will
> jpackage app laucnher will expand environment variables in .cfg files.
>
> Previously jpackage app launcher only replaced `$APPDIR`, `$BINDIR`, and
> `$ROOTDIR` tokens with the corresponding path values. With this patch, any
> environment variable can be expanded. The syntax is shell-like
> `
On Tue, 1 Apr 2025 19:36:04 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reflect Naoto's review
>
> src/java.base/share/classes/java/text/ChoiceFormat.java line 564:
>
>> 562: * {@code Double}
On Tue, 1 Apr 2025 20:00:22 GMT, Chris Plummer wrote:
>> Calling ThreadGroupReference.groups() from an event handler can cause a
>> deadlock. Details in first comment. Tested with :jdk_lang on all supported
>> platforms and tier1, tier2, tier3, and tier5 svc testing.
>
> Chris Plummer has updat
> Please review this PR which specifies the `ChoiceFormat#parse(String,
> ParsePosition)` method. A corresponding CSR is filed. The current
> specification is simply "Parses a Number from the input text" which does not
> indicate how the value is returned. The criteria for a match, as well as no
> Make tools/jpackage/share/ErrorTest.java test safely handle the case when
> native bundling is unavailable on the test host.
>
> Additionally:
> - If native bundling is unavailable on the test host, PackageTest will throw
> `jtreg.SkippedException` and mark the test as skipped instead of sile
> Calling ThreadGroupReference.groups() from an event handler can cause a
> deadlock. Details in first comment. Tested with :jdk_lang on all supported
> platforms and tier1, tier2, tier3, and tier5 svc testing.
Chris Plummer has updated the pull request incrementally with one additional
commit
On Thu, 27 Mar 2025 22:13:02 GMT, Ioi Lam wrote:
>> `-XX:+AOTClassLinking` requires the CDS archived full module graph (FMG).
>>
>> - Before this PR, when `--add-export` is specified, FMG is disabled, so
>> AOT caches created with `-XX:+AOTClassLinking` cannot be loaded.
>> - After this PR, i
On Tue, 1 Apr 2025 19:04:25 GMT, Justin Lu wrote:
>> Please review this PR which specifies the `ChoiceFormat#parse(String,
>> ParsePosition)` method. A corresponding CSR is filed. The current
>> specification is simply "Parses a Number from the input text" which does not
>> indicate how the va
On Tue, 1 Apr 2025 13:22:47 GMT, Magnus Ihse Bursie wrote:
> The proper way to disable warnings is to use the DISABLED_WARNINGS arguments.
> In this particular case, there was already a pragma but due to incorrect
> restrictions it did not apply to clang.
Marked as reviewed by erikj (Reviewer)
On Tue, 1 Apr 2025 14:20:17 GMT, Arno Zeller wrote:
>> Make tools/jpackage/share/ErrorTest.java test safely handle the case when
>> native bundling is unavailable on the test host.
>>
>> Additionally:
>> - If native bundling is unavailable on the test host, PackageTest will
>> throw `jtreg.Sk
On Tue, 1 Apr 2025 18:17:12 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reflect Naoto's review
>
> src/java.base/share/classes/java/text/ChoiceFormat.java line 576:
>
>> 574: *
>> 575: *
> Please review this PR which specifies the `ChoiceFormat#parse(String,
> ParsePosition)` method. A corresponding CSR is filed. The current
> specification is simply "Parses a Number from the input text" which does not
> indicate how the value is returned. The criteria for a match, as well as no
On Tue, 1 Apr 2025 16:45:26 GMT, Justin Lu wrote:
> Please review this PR which specifies the `ChoiceFormat#parse(String,
> ParsePosition)` method. A corresponding CSR is filed. The current
> specification is simply "Parses a Number from the input text" which does not
> indicate how the value
On Tue, 1 Apr 2025 17:10:08 GMT, Alan Bateman wrote:
>> My opinion is that: if it is possible for another implementation to share
>> the backing in/deflator (such as via thread-local instances) that does not
>> always need to be closed when an in/output stream is closed, then we should
>> not
On Tue, 1 Apr 2025 07:22:45 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to improve
>> the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`,
>> `InflaterInputStream` and `InflaterOutputStream` classes?
>>
>> As noted in https://
On Tue, 1 Apr 2025 14:50:01 GMT, Chen Liang wrote:
>> It's hard for me to guess what prompted that question, but I'll take a guess
>> - are you asking this question to decide whether we should reword the
>> pre-existing javadoc on these constructors to explicitly state that a new
>> decompress
Please review this PR which specifies the `ChoiceFormat#parse(String,
ParsePosition)` method. A corresponding CSR is filed. The current specification
is simply "Parses a Number from the input text" which does not indicate how the
value is returned. The criteria for a match, as well as no match s
On Wed, 26 Mar 2025 14:50:11 GMT, Alan Bateman wrote:
>>> > The cacerts issue mentioned in the JBS issue relates to an RPM
>>> > installation of the JDK where the cacerts file is a symlink to the distro
>>> > provided one. So I think that's "use system" issue.
>>> > TZ updates would potentially
On Fri, 28 Mar 2025 20:17:30 GMT, Naoto Sato wrote:
> Proposing to remove the `java.locale.useOldISOCodes` system property. This
> property is for backward compatibility introduced back in JDK17 and I believe
> it is now fine to remove it. In this PR targeting JDK25, it emits a
> deprecate-for
On Fri, 28 Mar 2025 20:17:30 GMT, Naoto Sato wrote:
> Proposing to remove the `java.locale.useOldISOCodes` system property. This
> property is for backward compatibility introduced back in JDK17 and I believe
> it is now fine to remove it. In this PR targeting JDK25, it emits a
> deprecate-for
On Fri, 11 Oct 2024 15:49:33 GMT, Chen Liang wrote:
>> Please review this patch that:
>> 1. Implemented `forEach` to optimize for 1 or 2 element collections.
>> 2. Implemented `spliterator` to optimize for a single element.
>>
>> The default implementations for multiple-element immutable collect
On Fri, 11 Oct 2024 15:49:33 GMT, Chen Liang wrote:
>> Please review this patch that:
>> 1. Implemented `forEach` to optimize for 1 or 2 element collections.
>> 2. Implemented `spliterator` to optimize for a single element.
>>
>> The default implementations for multiple-element immutable collect
On Fri, 21 Feb 2025 07:01:42 GMT, Nicole Xu wrote:
>> The UnsafeOps JMH benchmark fails with the following error:
>>
>> ```
>> java.lang.IllegalAccessError: class
>> org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot
>> access class jdk.internal.misc.Unsafe
On Mon, 31 Mar 2025 17:42:20 GMT, Joe Wang wrote:
> Refactor XMLSecurityPropertyManager.
> The Xerces and Xalan components each had its own XMLSecurityManager and
> XMLSecurityPropertyManager. In a previous fix, the former had been unified as
> part of that changeset. This change will allow fut
On Fri, 28 Mar 2025 15:02:05 GMT, Alexey Semenyuk wrote:
> Make tools/jpackage/share/ErrorTest.java test safely handle the case when
> native bundling is unavailable on the test host.
>
> Additionally:
> - If native bundling is unavailable on the test host, PackageTest will throw
> `jtreg.Ski
On Fri, 14 Mar 2025 11:47:44 GMT, Joachim Kern wrote:
> The test `testEcoFriendly()` checks if the launcher pollutes the
> `LD_LIBRARY_PATH` environment variable.
> Because aix and musl intentionally pollute the `LD_LIBRARY_PATH`, it does not
> make sense to make this test somehow passing with
> Please review this fix for cgroups-based metrics reporting in the
> `jdk.internal.platform` package. This fix is supposed to address wrong
> reporting of certain limits if the limits aren't set at the leaf nodes.
>
> For example, on cg v2, the memory limit interface file is `memory.max`.
> Co
On Tue, 1 Apr 2025 14:22:22 GMT, Jaikiran Pai wrote:
>> Is it impossible for another compliant implementation of Java SE to do so?
>
> It's hard for me to guess what prompted that question, but I'll take a guess
> - are you asking this question to decide whether we should reword the
> pre-exist
On Tue, 1 Apr 2025 11:18:14 GMT, Jan Lahoda wrote:
>> src/jdk.internal.le/share/classes/jdk/internal/console/SimpleConsoleReader.java
>> line 75:
>>
>>> 73: }
>>> 74: continue READ;
>>> 75: case '\033':
>>
>> If this is meant to be platfo
On Tue, 1 Apr 2025 13:24:08 GMT, Chen Liang wrote:
>> Hello Chen, if you mean whether multiple instances of these streams can
>> share the same default decompressor, then no, they can't (and they don't).
>> Each creates its own instance of default decompressor/compressor.
>
> Is it impossible f
On Fri, 28 Mar 2025 15:02:05 GMT, Alexey Semenyuk wrote:
> Make tools/jpackage/share/ErrorTest.java test safely handle the case when
> native bundling is unavailable on the test host.
>
> Additionally:
> - If native bundling is unavailable on the test host, PackageTest will throw
> `jtreg.Ski
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with two additional
commits since the last revision:
- Add lazy toSting for StableMap::values
- Make toString for reversed and sublist lazy
-
Changes:
- all: https:
On Tue, 1 Apr 2025 10:56:25 GMT, Alan Bateman wrote:
> ForkJoinPool20Test::testFixedDelaySequence is failing intermittently. The
> assert that checks that the periodically tasks only executes 8 times is
> removed, it may run more than this before it cancelled.
This pull request has now been in
On Tue, 1 Apr 2025 10:56:25 GMT, Alan Bateman wrote:
> ForkJoinPool20Test::testFixedDelaySequence is failing intermittently. The
> assert that checks that the periodically tasks only executes 8 times is
> removed, it may run more than this before it cancelled.
Marked as reviewed by vklang (Rev
> Hi all,
> File src/java.base/share/native/libjli/java.c compile error: control reaches
> end of non-void function [-Werror=return-type] with gcc options
> -fsanitize=address -O0. The function int JavaMain(void* _args) in this file
> will execute return ret in LEAVE() macro, but gcc with -O0 is
ForkJoinPool20Test::testFixedDelaySequence is failing intermittently. The
assert that checks that the periodically tasks only executes 8 times is
removed, it may run more than this before it cancelled.
-
Commit messages:
- Drop assert
Changes: https://git.openjdk.org/jdk/pull/2435
On Mon, 17 Mar 2025 02:56:11 GMT, Chen Liang wrote:
>> Per Minborg has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 246 commits:
>>
>> - Merge branch 'master' into implement-jep502
>> - Clean up exception messages and fix comment
On Mon, 24 Mar 2025 12:17:22 GMT, Leo Korinth wrote:
> WhileOpTest.java is a TestNG test (`TestNG.dirs` is set in Find file:
> `test/jdk/java/util/stream/test/TEST.properties`)
>
> As such, the `@run main/timeout=240` annotation is ignored. If that was not
> the case, it would complain about n
On Mon, 24 Mar 2025 12:17:22 GMT, Leo Korinth wrote:
> WhileOpTest.java is a TestNG test (`TestNG.dirs` is set in Find file:
> `test/jdk/java/util/stream/test/TEST.properties`)
>
> As such, the `@run main/timeout=240` annotation is ignored. If that was not
> the case, it would complain about n
On Mon, 31 Mar 2025 16:03:57 GMT, Per Minborg wrote:
> Here are the results of the new `MethodHandle` benchmarks:
>
> ```
> Benchmark Mode Cnt Score Error Units
> StableMethodHandleBenchmark.atomic avgt 10 3.676 ? 0.206 ns/op
> StableMethodHandleBenchm
On Mon, 17 Mar 2025 02:35:01 GMT, Chen Liang wrote:
>> src/hotspot/share/ci/ciField.cpp line 254:
>>
>>> 252:
>>> 253: static bool trust_final_non_static_fields_of_type(Symbol* signature) {
>>> 254: return signature == vmSymbols::java_lang_StableValue_signature();
>>
>> Just a note that we w
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Add additional benchmarks with maps holding method handles
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23
On Tue, 1 Apr 2025 01:54:13 GMT, Chen Liang wrote:
>> Kim Barrett has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> parameterized return type of native get0
>
> src/java.base/share/classes/java/lang/ref/Reference.java line 365:
>
>> 363:
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Add benchmarks and update copyright years
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- new
> Please review this change which adds a native method providing the
> implementation of Reference::get. Referece::get is an intrinsic candidate, so
> this native method implementation is only used when the intrinsic is not.
>
> Currently there is intrinsic support by the interpreter, C1, C2, and
Sure, Volkan.
Let me explain with a sample use case (I also have the source code
available on GitHub at https://github.com/sathishk/parse-number ).
> When developing *REST APIs or Data Engineering applications*, we often
> deal with *untyped JSON documents*, which are loaded into Java as Map Obje
On Wed, 26 Mar 2025 14:50:11 GMT, Alan Bateman wrote:
>>> > The cacerts issue mentioned in the JBS issue relates to an RPM
>>> > installation of the JDK where the cacerts file is a symlink to the distro
>>> > provided one. So I think that's "use system" issue.
>>> > TZ updates would potentially
> Can I please get a review of this doc-only change which proposes to improve
> the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`,
> `InflaterInputStream` and `InflaterOutputStream` classes?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8066583 some of the
> construct
On Mon, 31 Mar 2025 14:49:12 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 12 additional
>> commits s
On Fri, 28 Mar 2025 17:04:03 GMT, Joachim Kern wrote:
>> The test `testEcoFriendly()` checks if the launcher pollutes the
>> `LD_LIBRARY_PATH` environment variable.
>> Because aix and musl intentionally pollute the `LD_LIBRARY_PATH`, it does
>> not make sense to make this test somehow passing w
64 matches
Mail list logo
