On Thu, 27 Feb 2025 21:40:23 GMT, Magnus Ihse Bursie wrote:
> If you want to see that implemented, the first step is to open an enhancement
> issue on JBS.
For now I would probably be happy with fixing/adding the 'requires' statements
of the tests, where they are missing.
This would allow jtre
On Fri, 28 Feb 2025 01:29:32 GMT, David Holmes wrote:
> IIRC you still need the modules for the unsupported pieces because the API's
> themselves are not optional and you have to be able to ask if something is
> supported.
In this case it's a JDK-specific module, and since JDK 9 it has been
p
On Fri, 28 Feb 2025 01:34:22 GMT, Alexander Matveev
wrote:
> With `->` it should not fall into next case. Maybe I am missing something.
Right, but there are two `siwtch` blocks in the function. Without `return` the
control flow will get to the second one. `return`-s prevents this.
---
On Fri, 28 Feb 2025 01:17:19 GMT, Alexey Semenyuk wrote:
> Yes. It should exit the function early to avoid jumping in the next switch
> block.
With `->` it should not fall into next case. Maybe I am missing something.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/23825#dis
On Thu, 27 Feb 2025 10:19:51 GMT, Matthias Baesken wrote:
>> While testing a bit with a minimal JVM, it has been noticed that some
>> java/lang jtreg tests use jfr but do not declare it with a "requires
>> vm.hasJFR" ; that leads to test errors in a JVM setup with no JFR .
>
> Matthias Baesken
> Add a test to verify jpackage is using a custom MSI condition blocking
> package installation depending on the version of Windows where the package
> installer runs. Support for this MSI condition was added in
> [JDK-8150442](https://bugs.openjdk.org/browse/JDK-8150442).
>
> The test adds an
The scope was updated to support multithread configuration (jmh option '-t 2')
. No other changes needed.
-
Commit messages:
- JDK-8350909 [JMH] test ThreadOnSpinWaitShared failed for 2 threads config
Changes: https://git.openjdk.org/jdk/pull/23834/files
Webrev: https://webrevs.o
On Thu, 27 Feb 2025 23:48:19 GMT, Alexander Matveev
wrote:
> Do we really need return here and at line 495?
Yes. It should exit the function early to avoid jumping in the next `switch`
block.
> do you think it might be better to make `switch` consistent?
Totally!
-
PR Review Co
On Thu, 27 Feb 2025 17:15:56 GMT, David Beaumont wrote:
>> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
>> publish() method.
>>
>> 1. Remove synchronization of calls to publish() in Handlers in
>> java.util.logging package.
>> 2. Add explanatory comments to various affe
On Thu, 27 Feb 2025 17:15:56 GMT, David Beaumont wrote:
>> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
>> publish() method.
>>
>> 1. Remove synchronization of calls to publish() in Handlers in
>> java.util.logging package.
>> 2. Add explanatory comments to various affe
On Tue, 25 Feb 2025 01:21:40 GMT, Stuart Marks wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Tweaking @implNote for better rendering.
>
> src/java.logging/share/classes/java/util/logging/StreamHandler.java line
On Thu, 27 Feb 2025 13:51:27 GMT, Jason Mehrens wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rewording notes and spec changes in docs.
>> Small change to read formatter once in streamhander methods.
>> Rev
On Thu, 27 Feb 2025 14:17:30 GMT, Alexey Semenyuk wrote:
> Add a test to verify jpackage is using a custom MSI condition blocking
> package installation depending on the version of Windows where the package
> installer runs. Support for this MSI condition was added in
> [JDK-8150442](https://b
On Thu, 27 Feb 2025 06:43:19 GMT, Xiaohong Gong wrote:
> Method `checkMaskFromIndexSize` is called by some vector masked APIs like
> `fromArray/intoArray/fromMemorySegment/...`. It is used to check whether the
> index of any active lanes in a mask will reach out of the boundary of the
> given
On Thu, 27 Feb 2025 15:33:47 GMT, Matthias Baesken wrote:
>> No, there is nothing for that. There is a conceptual leap between
>> determining how to compile hotspot and how to decide which modules to
>> include in the image, and is not at all clear how you would want to
>> integrate these two.
On Tue, 25 Feb 2025 21:35:22 GMT, Vladimir Ivanov wrote:
> The 'size' parameters was used instead of hardcoded constant to improve
> support for different sizes.
@IvaVladimir
Your change (at version b45da29c5bf50c5961f59500cd22d84a35a09be4) is now ready
to be sponsored by a Committer.
--
On Wed, 5 Feb 2025 23:41:19 GMT, Chen Liang wrote:
> `MethodHandles.byteArrayViewVarHandle` exposes checked multi-byte access to
> byte arrays via VarHandle. This larger access speeds up many operations, yet
> it cannot be used in early bootstrap, and as a result, people tend to use
> `Unsafe`
On Wed, 5 Feb 2025 23:41:19 GMT, Chen Liang wrote:
> `MethodHandles.byteArrayViewVarHandle` exposes checked multi-byte access to
> byte arrays via VarHandle. This larger access speeds up many operations, yet
> it cannot be used in early bootstrap, and as a result, people tend to use
> `Unsafe`
On Mon, 24 Feb 2025 16:21:33 GMT, He-Pin(kerr) wrote:
>> Motivation:
>> When a user passes a wrong parameter, the current implementation throws an
>> IllegalArgumentException with an error message `null`, which is not helpful.
>>
>> Modification:
>> Add detail error messages.
>>
>> Result:
>>
On Wed, 26 Feb 2025 13:40:31 GMT, Viktor Klang wrote:
>> He-Pin(kerr) has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> chore: update tests
>
> src/java.base/share/classes/java/util/concurrent/ThreadPoolExecutor.java line
> 1513:
>
>> 15
On Tue, 25 Feb 2025 21:35:22 GMT, Vladimir Ivanov wrote:
> The 'size' parameters was used instead of hardcoded constant to improve
> support for different sizes.
This pull request has now been integrated.
Changeset: f1398ecb
Author:Vladimir Ivanov
Committer: Derek White
URL:
https
On Mon, 24 Feb 2025 16:21:33 GMT, He-Pin(kerr) wrote:
>> Motivation:
>> When a user passes a wrong parameter, the current implementation throws an
>> IllegalArgumentException with an error message `null`, which is not helpful.
>>
>> Modification:
>> Add detail error messages.
>>
>> Result:
>>
> On Feb 27, 2025, at 11:47 AM, Michael Hall wrote:
>
> Now, mostly about how the JavaVirtualMachines MacOS specific JRE’s might be
> built.
Copied the MacOS directory and Info.plist file from another JavaVirtualMachines
bundle.
Updated the Info.plist version settings from the prior versio
On Tue, 25 Feb 2025 21:35:22 GMT, Vladimir Ivanov wrote:
> The 'size' parameters was used instead of hardcoded constant to improve
> support for different sizes.
looks good!
-
PR Comment: https://git.openjdk.org/jdk/pull/23785#issuecomment-2689055310
On Fri, 10 Jan 2025 21:53:20 GMT, Chen Liang wrote:
>> The Type and AnnotatedType hierarchies have been enigmatic to new users:
>> users have no clue how to categorize arbitrary type objects, when it is safe
>> to cast to more specific types, and the exact conditions for method
>> contracts.
>
> The Type and AnnotatedType hierarchies have been enigmatic to new users:
> users have no clue how to categorize arbitrary type objects, when it is safe
> to cast to more specific types, and the exact conditions for method contracts.
>
> A manifest is [JDK-8306039](https://bugs.openjdk.org/brow
On Thu, 27 Feb 2025 18:08:35 GMT, Justin Lu wrote:
>> Please review this PR which clarifies some behavior regarding NumberFormat
>> grouping specifically in the grouping related methods.
>>
>> Please see the corresponding CSR for further detail. Note that an
>> alternative would be to specify
On Thu, 27 Feb 2025 14:17:30 GMT, Alexey Semenyuk wrote:
> Add a test to verify jpackage is using a custom MSI condition blocking
> package installation depending on the version of Windows where the package
> installer runs. Support for this MSI condition was added in
> [JDK-8150442](https://b
On Thu, 11 Jul 2024 06:24:31 GMT, Stuart Marks wrote:
>> Liam Miller-Cushon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update test/jdk/java/util/Collection/MOAT.java
>>
>> Co-authored-by: Chen Liang
>
> Please see the analysis
On Tue, 25 Feb 2025 21:35:22 GMT, Vladimir Ivanov wrote:
> The 'size' parameters was used instead of hardcoded constant to improve
> support for different sizes.
Thanks for your review!
-
PR Comment: https://git.openjdk.org/jdk/pull/23785#issuecomment-2688965214
On Thu, 27 Feb 2025 19:39:53 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Naoto review - include strict parsing example. Also remove 'might' wording
>
> src/java.base/share/classes/java/text/NumberF
> Please review this PR which clarifies some behavior regarding NumberFormat
> grouping specifically in the grouping related methods.
>
> Please see the corresponding CSR for further detail. Note that an alternative
> would be to specify this at the DecimalFormat level, allowing NumberFormat
>
> This change overrides mutator methods in the implementation returned by
> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
Liam Miller-Cushon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
br
On Wed, 27 Mar 2024 17:36:28 GMT, Liam Miller-Cushon wrote:
> This change overrides mutator methods in the implementation returned by
> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
This pull request has been closed without being integrated.
-
PR: https://git.ope
On Thu, 27 Feb 2025 16:37:59 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Naoto review - include strict parsing example. Also remove 'might' wording
>
> src/java.base/share/classes/java/text/NumberF
On Thu, 27 Feb 2025 12:46:36 GMT, David Beaumont wrote:
>> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
>> publish() method.
>>
>> 1. Remove synchronization of calls to publish() in Handlers in
>> java.util.logging package.
>> 2. Add explanatory comments to various affe
On Tue, 25 Feb 2025 15:13:43 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> please review this change that implements (currently Draft) JEP: G1:
>> Improve Application Throughput with a More Efficient Write-Barrier.
>>
>> The reason for posting this early is that this is a large change, and the
On Tue, 25 Feb 2025 01:24:54 GMT, Stuart Marks wrote:
>> As for the example you gave there, that is interesting. Keeping an
>> unformatted log record around for any time after the log statement that
>> created it has exited would be quite problematic (it prevents GC of
>> arbitrary things).
>>
Hi Mukul,
Xalan-J's XSL 3 implementation has not been integrated into any Xalan
releases. I understand it implemented most of the XSLT 3.0
specification, but not all of them, esp. the Streaming feature. Was the
incompleteness the reason why it was not included in an Xalan release?
What's your
Note that many/most of the changes in the head branch are directory reshuffles,
as we moved things around to conform to Maven's expectations. There are
relatively few actual code changes, as can be confirmed by comparing files by
package/class rather than by which subtree they are in. The git h
> Please review this PR which clarifies some behavior regarding NumberFormat
> grouping specifically in the grouping related methods.
>
> Please see the corresponding CSR for further detail. Note that an alternative
> would be to specify this at the DecimalFormat level, allowing NumberFormat
>
Hi Michael,
See my comments inline.
On 2/27/2025 11:11 AM, Michael Hall wrote:
On Feb 26, 2025, at 9:22 PM, Michael Hall wrote:
I don’t get that if I delete the existing dmg first.
Full verbose output at…
http://mikehall.pairserver.com/rt.txt
Is there a how-to on using --runtime-im
Thanks, mainly curious.
Now, mostly about how the JavaVirtualMachines MacOS specific JRE’s might be
built.
> On Feb 27, 2025, at 11:43 AM, Alexey Semenyuk
> wrote:
>
> Hi Michael,
>
> See my comments inline.
>
> On 2/27/2025 11:11 AM, Michael Hall wrote:
>>
>>
>>> On Feb 26, 2025, at 9:22
> Core reflection's generic signature parsing system is used for many aspects,
> including annotations and enclosing methods, yet it is under-tested. It is
> better for us to set up tests to ensure that sensitive error behaviors of
> core reflection remain the same across implementation updates,
Add a test to verify jpackage is using a custom MSI condition blocking package
installation depending on the version of Windows where the package installer
runs. Support for this MSI condition was added in
[JDK-8150442](https://bugs.openjdk.org/browse/JDK-8150442).
The test adds an unconditiona
> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
> publish() method.
>
> 1. Remove synchronization of calls to publish() in Handlers in
> java.util.logging package.
> 2. Add explanatory comments to various affected methods.
> 3. Add a test to ensure deadlocks no longer occu
On Sat, 24 Aug 2024 05:12:42 GMT, Julian Waters wrote:
>> snprintf has been available for all officially and unofficially supported
>> compilers for Windows, Visual Studio since version 2015 and gcc since, well,
>> forever. snprintf is conforming to C99 since the start when compiling using
>>
> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
> publish() method.
>
> 1. Remove synchronization of calls to publish() in Handlers in
> java.util.logging package.
> 2. Add explanatory comments to various affected methods.
> 3. Add a test to ensure deadlocks no longer occu
On Sat, 24 Aug 2024 05:12:42 GMT, Julian Waters wrote:
>> snprintf has been available for all officially and unofficially supported
>> compilers for Windows, Visual Studio since version 2015 and gcc since, well,
>> forever. snprintf is conforming to C99 since the start when compiling using
>>
On Sat, 24 Aug 2024 05:12:42 GMT, Julian Waters wrote:
>> snprintf has been available for all officially and unofficially supported
>> compilers for Windows, Visual Studio since version 2015 and gcc since, well,
>> forever. snprintf is conforming to C99 since the start when compiling using
>>
On Thu, 27 Feb 2025 06:54:30 GMT, Emanuel Peter wrote:
> Detect "extreme" probability scalar cmove, and replace them with branching
> code. This should take care of all regressions here. This one has high
> priority, as it fixes the regression caused by this patch here. But it would
> also hel
On Fri, 7 Feb 2025 12:39:24 GMT, Galder Zamarreño wrote:
>> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in
>> order to help improve vectorization performance.
>>
>> Currently vectorization does not kick in for loops containing either of
>> these calls because of t
On Wed, 26 Feb 2025 22:18:17 GMT, Justin Lu wrote:
> Please review this PR which clarifies some behavior regarding NumberFormat
> grouping specifically in the grouping related methods.
>
> Please see the corresponding CSR for further detail. Note that an alternative
> would be to specify this
> On Feb 26, 2025, at 9:22 PM, Michael Hall wrote:
>
>>
>> I don’t get that if I delete the existing dmg first.
>>
>> Full verbose output at…
>>
>> http://mikehall.pairserver.com/rt.txt
>
Is there a how-to on using --runtime-image on MacOS? How are you supposed to
get a valid runtime to p
On Thu, 27 Feb 2025 16:00:47 GMT, Chen Liang wrote:
>> Simplify the layout access var handles to be direct in some common cases.
>> Also made `VarHandle::isAccessModeSupported` report if an access mode is
>> supported for a VH.
>>
>> Reduces the instructions to execute this code in a simple ma
> Simplify the layout access var handles to be direct in some common cases.
> Also made `VarHandle::isAccessModeSupported` report if an access mode is
> supported for a VH.
>
> Reduces the instructions to execute this code in a simple main by 47%:
>
> long[] arr = new long[8];
> var ms = Memory
> Simplify the layout access var handles to be direct in some common cases.
> Also made `VarHandle::isAccessModeSupported` report if an access mode is
> supported for a VH.
>
> Reduces the instructions to execute this code in a simple main by 47%:
>
> long[] arr = new long[8];
> var ms = Memory
On Thu, 27 Feb 2025 15:11:49 GMT, Magnus Ihse Bursie wrote:
> No, there is nothing for that. There is a conceptual leap between determining
> how to compile hotspot and how to decide which modules to include in the
> image, and is not at all clear how you would want to integrate these two.
> L
On Thu, 27 Feb 2025 13:36:26 GMT, Matthias Baesken wrote:
>> when I list the modules of the minimal JVM I see a number of modules that
>> will most likely not work because the related JVM features are not present
>>
>>
>> images/jdk/bin/java --list-modules
>> ...
>> jdk.jdi@25.0.0.1-interna
On Wed, 26 Feb 2025 19:53:45 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/invoke/X-VarHandleSegmentView.java.template
>> line 83:
>>
>>> 81: bb.unsafeGetBase(),
>>> 82: offset(bb, base, offset),
>>> 83: handle.be);
>
On Wed, 26 Feb 2025 19:54:59 GMT, Chen Liang wrote:
>> I suggest maybe renaming `noStride` to something like
>> `fixedOffsetInEnclosing`
>
> In last revision I called it `fixedOffset`, but it becomes confusing with the
> actual fixed value of the offset.
Maybe something like `isOffsetFixed` or
On Thu, 27 Feb 2025 13:24:16 GMT, Chen Liang wrote:
> ... creation in clinit is super costly
You mean because threads can not race to initialize? I'd think the extra walks
to create 3 lookups might offset that though...
-
PR Review Comment: https://git.openjdk.org/jdk/pull/23720#
On Thu, 27 Feb 2025 02:53:26 GMT, Alexander Matveev
wrote:
> - Fixed by increasing test timeout. Fix verified on host which reproduced
> issue.
Marked as reviewed by asemenyuk (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/23816#pullrequestreview-2647877433
On Thu, 27 Feb 2025 09:12:10 GMT, Matthias Baesken wrote:
> when I list the modules of the minimal JVM I see a number of modules that
> will most likely not work because the related JVM features are not present
>
> ```
> images/jdk/bin/java --list-modules
> ...
> jdk.jdi@25.0.0.1-internal
> jd
On Wed, 26 Feb 2025 15:47:52 GMT, Matthias Baesken wrote:
> While testing a bit with a minimal JVM, it has been noticed that some
> java/lang jtreg tests use jfr but do not declare it with a "requires
> vm.hasJFR" ; that leads to test errors in a JVM setup with no JFR .
This pull request has n
On Thu, 27 Feb 2025 10:19:51 GMT, Matthias Baesken wrote:
>> While testing a bit with a minimal JVM, it has been noticed that some
>> java/lang jtreg tests use jfr but do not declare it with a "requires
>> vm.hasJFR" ; that leads to test errors in a JVM setup with no JFR .
>
> Matthias Baesken
On Thu, 27 Feb 2025 10:26:29 GMT, Jorn Vernee wrote:
>> This emulates how MethodHandleImpl does the cache.
>
> Ok. I think the benefit is that each element is individually lazy
> initialized. I'm not sure about the setup with the array though. It seems
> like having 3 stable fields would be sim
On Thu, 27 Feb 2025 10:19:51 GMT, Matthias Baesken wrote:
>> While testing a bit with a minimal JVM, it has been noticed that some
>> java/lang jtreg tests use jfr but do not declare it with a "requires
>> vm.hasJFR" ; that leads to test errors in a JVM setup with no JFR .
>
> Matthias Baesken
On Sun, 23 Feb 2025 15:26:48 GMT, Doug Lea wrote:
>> (Copied from https://bugs.openjdk.org/browse/JDK-8319447)
>>
>> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is
>> both ill-suited for many (if not most) of its applications, and is a
>> performance bottleneck (a
> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
> publish() method.
>
> 1. Remove synchronization of calls to publish() in Handlers in
> java.util.logging package.
> 2. Add explanatory comments to various affected methods.
> 3. Add a test to ensure deadlocks no longer occu
On 27/02/2025 10:43, David Gregory wrote:
Hi Maurizio,
On 21/02/2025 18:42, Maurizio Cimadamore wrote:
There's different meaning for the word "trusted". If, by that, you
mean that fields of type StableValue should be trusted the same
way that record components are trusted (e.g. where "final"
Hi Maurizio,
On 21/02/2025 18:42, Maurizio Cimadamore wrote:
There's different meaning for the word "trusted". If, by that, you
mean that fields of type StableValue should be trusted the same way
that record components are trusted (e.g. where "final" really means
"final"), this is something we
On Wed, 26 Feb 2025 19:56:04 GMT, Chen Liang wrote:
>> src/java.base/share/classes/jdk/internal/foreign/Utils.java line 74:
>>
>>> 72: return ret;
>>> 73: return computeFilterHandle(index);
>>> 74: }
>>
>> Why is this using an array, instead of just having 3 fields?
>
>
> While testing a bit with a minimal JVM, it has been noticed that some
> java/lang jtreg tests use jfr but do not declare it with a "requires
> vm.hasJFR" ; that leads to test errors in a JVM setup with no JFR .
Matthias Baesken has updated the pull request incrementally with one additional
co
On Wed, 26 Feb 2025 15:47:52 GMT, Matthias Baesken wrote:
> While testing a bit with a minimal JVM, it has been noticed that some
> java/lang jtreg tests use jfr but do not declare it with a "requires
> vm.hasJFR" ; that leads to test errors in a JVM setup with no JFR .
I assume you've bumping
On Thu, 27 Feb 2025 08:43:32 GMT, Matthias Baesken wrote:
>> test/jdk/java/lang/Thread/ThreadSleepEvent.java line 28:
>>
>>> 26: * @summary Test that Thread.sleep emits a JFR jdk.ThreadSleep event
>>> 27: * @requires vm.hasJFR
>>> 28: * @modules jdk.jfr
>>
>> These tests already have `@modul
On Thu, 27 Feb 2025 08:49:43 GMT, Alan Bateman wrote:
>> A minimal JVM (**--with-jvm-features=minimal --with-jvm-variants=minimal**)
>> is tested. This contains no JFR in Hotspot.
>> If you configure the build without JVM feature JFR (like minimal) , the
>> tests need the correct requires tag
On Thu, 27 Feb 2025 08:36:58 GMT, Alan Bateman wrote:
>> While testing a bit with a minimal JVM, it has been noticed that some
>> java/lang jtreg tests use jfr but do not declare it with a "requires
>> vm.hasJFR" ; that leads to test errors in a JVM setup with no JFR .
>
> test/jdk/java/lang/Th
On Wed, 26 Feb 2025 15:47:52 GMT, Matthias Baesken wrote:
> While testing a bit with a minimal JVM, it has been noticed that some
> java/lang jtreg tests use jfr but do not declare it with a "requires
> vm.hasJFR" ; that leads to test errors in a JVM setup with no JFR .
test/jdk/java/lang/Thre
On 26/02/2025 15:59, Mukul Gandhi wrote:
Hi Alan,
I've just seen this mail from you. Apologies for a delayed response.
My mail box has had few issues due to the volume of mails that I get
from mailing lists.
On Sun, Feb 2, 2025 at 9:38 PM Alan Bateman wrote:
The stats for that branch
80 matches
Mail list logo
