On Wed, 26 Feb 2025 19:53:45 GMT, Chen Liang <li...@openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/invoke/X-VarHandleSegmentView.java.template
>>  line 83:
>> 
>>> 81:                     bb.unsafeGetBase(),
>>> 82:                     offset(bb, base, offset),
>>> 83:                     handle.be);
>> 
>> Why do we not have a call to `convEndian` here?
>
> This is just how it was. Refer to line 141 in old diff.

Ah, right, the unaligned Unsafe routines support specifying the endianess 
already, but for the aligned variants it has to be emulated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23720#discussion_r1973675226

Reply via email to