Hi all,
Test test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.java run passes
unexpectedly when missing the depentdent file
test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.xsd. This PR add a NULL
check after call `getResourceAsStream("CR6740048.xsd")`.
This PR do not change the or
Can I please get a review of this change which proposes to properly close the
`Inflater` instance used in
`jdk.internal.jimage.decompressor.ZipDecompressor.decompress()` method? This
addresses https://bugs.openjdk.org/browse/JDK-8349909.
As noted in that issue, in the exceptional case in the `d
On Thu, 13 Feb 2025 16:27:03 GMT, Sean Mullan wrote:
> This change adds an API note to these methods recommending that the caller
> should perform further validation steps on the code signers that signed the
> JAR file, such as validating the code signer's certificate chain, and
> determining
On Mon, 10 Feb 2025 09:28:45 GMT, Aleksey Shipilev wrote:
>> @AlanBateman I've not done any work on JDK-8305186. There has also been
>> discussion about making
>> that function non-private or even public (though with concerns about
>> specification difficulty) for use in
>> places like this.
>
On Thu, 6 Feb 2025 12:07:57 GMT, David Beaumont wrote:
> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
> publish() method.
>
> 1. Remove synchronization of calls to publish() in Handlers in
> java.util.logging package.
> 2. Add explanatory comments to various affected me
On Thu, 13 Feb 2025 22:43:59 GMT, David Beaumont wrote:
>Yes, it's certainly something you can deliberately provoke in a way that
>wasn't possible before.
Setting limit to 1 byte with a large count is a way to make sure each log file
contains 0 or 1 log record. I think this patch breaks that
Hi all,
The newly added JMH tests
'org.openjdk.bench.jdk.incubator.vector.VectorMultiplyOptBenchmark' fails
"java.lang.NoClassDefFoundError: jdk/incubator/vector/Float16" by below test
command:
make test MICRO="FORK=1;WARMUP_ITER=2"
TEST="micro:org.openjdk.bench.jdk.incubator.vector.VectorMu
On Thu, 13 Feb 2025 08:35:47 GMT, Nicole Xu wrote:
> As is suggested in
> [JDK-8342958](https://bugs.openjdk.org/browse/JDK-8342958), `jvmArgs` should
> be used consistently in microbenchmarks to 'align with the intuition that
> when you use jvmArgsAppend/-Prepend intent is to add to a set of
On Fri, 14 Feb 2025 01:40:59 GMT, Alexey Semenyuk wrote:
>> Convert jpackage test library tests in JUnit format. This simplifies running
>> them in IDE.
>>
>> Added
>> [JUnitAdapter](https://github.com/openjdk/jdk/pull/23615/files#diff-8719943fb769c04daf413427dc812650763f588cbd0ef6b50cccd11260
> Convert jpackage test library tests in JUnit format. This simplifies running
> them in IDE.
>
> Added
> [JUnitAdapter](https://github.com/openjdk/jdk/pull/23615/files#diff-8719943fb769c04daf413427dc812650763f588cbd0ef6b50cccd11260353c0a)
> class to simplify running jpackage test-lib tests wit
On Thu, 13 Feb 2025 23:49:24 GMT, Alexander Matveev
wrote:
>> Convert jpackage test library tests in JUnit format. This simplifies running
>> them in IDE.
>>
>> Added
>> [JUnitAdapter](https://github.com/openjdk/jdk/pull/23615/files#diff-8719943fb769c04daf413427dc812650763f588cbd0ef6b50cccd11
On Thu, 13 Feb 2025 14:37:50 GMT, Alexey Semenyuk wrote:
> Convert jpackage test library tests in JUnit format. This simplifies running
> them in IDE.
>
> Added
> [JUnitAdapter](https://github.com/openjdk/jdk/pull/23615/files#diff-8719943fb769c04daf413427dc812650763f588cbd0ef6b50cccd11260353c0
> This fix makes some minor changes to the internals of the
> `CertificateBuilder` and `SimpleOCSPServer` test classes. They would break
> when ML-DSA was selected as key and signing algorithms. Also RSASSA-PSS
> works better now with these changes. I've also taken this opportunity to do
> s
On Thu, 13 Feb 2025 14:37:50 GMT, Alexey Semenyuk wrote:
> Convert jpackage test library tests in JUnit format. This simplifies running
> them in IDE.
>
> Added
> [JUnitAdapter](https://github.com/openjdk/jdk/pull/23615/files#diff-8719943fb769c04daf413427dc812650763f588cbd0ef6b50cccd11260353c0
Convert jpackage test library tests in JUnit format. This simplifies running
them in IDE.
Added
[JUnitAdapter](https://github.com/openjdk/jdk/pull/23615/files#diff-8719943fb769c04daf413427dc812650763f588cbd0ef6b50cccd11260353c0a)
class to simplify running jpackage test-lib tests with JUnit.
`J
On Thu, 13 Feb 2025 12:43:57 GMT, Alexey Semenyuk wrote:
> Make jpackage capable of using wix3 when Federal Information Processing
> Standard (FIPS) mode is enabled on Windows.
>
> When FIPS mode is enabled, running `candle.exe -?` prints:
>
> candle.exe : error CNDL0308 : The Federal Informat
On Thu, 13 Feb 2025 19:38:47 GMT, Jason Mehrens wrote:
>> We could, but I don't think it matters. This issue is the first one pointed
>> out in the CSR, and my current feeling is that since it's stated that the
>> limit is "best effort" and there's always the chance that the final log
>> befor
On Thu, 13 Feb 2025 19:34:04 GMT, Sean Mullan wrote:
>> Jamil Nimeh has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix JBS ID and summary in test
>
> test/lib/jdk/test/lib/security/CertificateBuilder.java line 462:
>
>> 460:
> This fix makes some minor changes to the internals of the
> `CertificateBuilder` and `SimpleOCSPServer` test classes. They would break
> when ML-DSA was selected as key and signing algorithms. Also RSASSA-PSS
> works better now with these changes. I've also taken this opportunity to do
> s
On Thu, 13 Feb 2025 19:52:32 GMT, Sean Mullan wrote:
> Also, should it be moved to somewhere else like
> jdk/test/sun/security/provider/certpath?
Hmmm...not sure about that, but maybe an explanation is in order: Because the
JDK only implements the client side with OCSP, we rely on CertPathVali
Indeed. I hope I didn't sound discouraging about the possibility to propagate
the stream size information.
I merely want to emphasize that it may necessitate a slightly broader take on
the problem of propagation of stream-instance metadata, especially in the face
of Gatherers becoming a finaliz
On Wed, 12 Feb 2025 19:34:19 GMT, Justin Lu wrote:
> Please review this PR which prevents a (non-specified) `AIOOBE` from leaking
> out of the range accepting endpoints in `Locale.LanguageRange`.
>
> In the reported error case, the invalid range is a lone "-" which is `split`
> into an empty a
On Thu, 6 Feb 2025 14:30:30 GMT, Per Minborg wrote:
>> `MethodHandles.byteArrayViewVarHandle` exposes checked multi-byte access to
>> byte arrays via VarHandle. This larger access speeds up many operations, yet
>> it cannot be used in early bootstrap, and as a result, people tend to use
>> `Un
On Thu, 13 Feb 2025 12:43:57 GMT, Alexey Semenyuk wrote:
> Make jpackage capable of using wix3 when Federal Information Processing
> Standard (FIPS) mode is enabled on Windows.
>
> When FIPS mode is enabled, running `candle.exe -?` prints:
>
> candle.exe : error CNDL0308 : The Federal Informat
On Mon, 10 Feb 2025 09:17:51 GMT, Per Minborg wrote:
> This PR seems to be targeting performance, yet no benchmarks are provided
> comparing the current vs. proposed branch with respect to performance. We
> need to understand the upside of the proposed changes.
At my request, reimplementing Bi
On Thu, 13 Feb 2025 20:51:26 GMT, Stuart Marks wrote:
>> A couple adjustments to the specs for four methods of StringBuilder and
>> StringBuffer so that they no longer require new Strings to be created, just
>> a String with the right contents. No implementation changes. Note that the
>> actua
On Wed, 12 Feb 2025 19:35:18 GMT, Naoto Sato wrote:
> Fixing the regression caused by the JDK-8342550 fix. Since the logging
> facility depends on TimeZone class, it should not use the logging facility.
> Replacing the logging with simple System.err.printf() will fix the issue.
This pull reque
On Wed, 12 Feb 2025 23:07:26 GMT, Naoto Sato wrote:
>> Fixing the regression caused by the JDK-8342550 fix. Since the logging
>> facility depends on TimeZone class, it should not use the logging facility.
>> Replacing the logging with simple System.err.printf() will fix the issue.
>
> Naoto Sat
> A couple adjustments to the specs for four methods of StringBuilder and
> StringBuffer so that they no longer require new Strings to be created, just a
> String with the right contents. No implementation changes. Note that the
> actual specs (and implementations) are actually in AbstractString
On Wed, 12 Feb 2025 23:07:26 GMT, Naoto Sato wrote:
>> Fixing the regression caused by the JDK-8342550 fix. Since the logging
>> facility depends on TimeZone class, it should not use the logging facility.
>> Replacing the logging with simple System.err.printf() will fix the issue.
>
> Naoto Sat
On Thu, 13 Feb 2025 08:35:47 GMT, Nicole Xu wrote:
> As is suggested in
> [JDK-8342958](https://bugs.openjdk.org/browse/JDK-8342958), `jvmArgs` should
> be used consistently in microbenchmarks to 'align with the intuition that
> when you use jvmArgsAppend/-Prepend intent is to add to a set of
On Thu, 13 Feb 2025 19:49:37 GMT, Sean Mullan wrote:
> That's a good question. I usually add the `noreg-self` label even it it is a
> brand new test and not a fix to an existing test and there is no other JDK
> code changes. @JesperIRL do you have any advice for this situation?
`noreg-self` is
On Wed, 12 Feb 2025 19:55:29 GMT, Stuart Marks wrote:
> A couple adjustments to the specs for four methods of StringBuilder and
> StringBuffer so that they no longer require new Strings to be created, just a
> String with the right contents. No implementation changes. Note that the
> actual sp
On Thu, 13 Feb 2025 19:45:19 GMT, Sean Mullan wrote:
>> This fix makes some minor changes to the internals of the
>> `CertificateBuilder` and `SimpleOCSPServer` test classes. They would break
>> when ML-DSA was selected as key and signing algorithms. Also RSASSA-PSS
>> works better now with
On Thu, 13 Feb 2025 18:58:00 GMT, Sean Mullan wrote:
>> This fix makes some minor changes to the internals of the
>> `CertificateBuilder` and `SimpleOCSPServer` test classes. They would break
>> when ML-DSA was selected as key and signing algorithms. Also RSASSA-PSS
>> works better now with
On Tue, 11 Feb 2025 17:50:45 GMT, Jamil Nimeh wrote:
> This fix makes some minor changes to the internals of the
> `CertificateBuilder` and `SimpleOCSPServer` test classes. They would break
> when ML-DSA was selected as key and signing algorithms. Also RSASSA-PSS
> works better now with thes
On Thu, 13 Feb 2025 09:32:29 GMT, David Beaumont wrote:
>> hmmm... Thanks for chiming in Jason. Good point. So what can happen here is
>> that if multiple threads log concurrently to the same FileHandler then log
>> records might continue to get written to the file after the limit has been
>>
On Wed, 12 Feb 2025 19:55:29 GMT, Stuart Marks wrote:
> A couple adjustments to the specs for four methods of StringBuilder and
> StringBuffer so that they no longer require new Strings to be created, just a
> String with the right contents. No implementation changes. Note that the
> actual sp
On Thu, 13 Feb 2025 18:58:00 GMT, Sean Mullan wrote:
>> This fix makes some minor changes to the internals of the
>> `CertificateBuilder` and `SimpleOCSPServer` test classes. They would break
>> when ML-DSA was selected as key and signing algorithms. Also RSASSA-PSS
>> works better now with
On Tue, 11 Feb 2025 17:50:45 GMT, Jamil Nimeh wrote:
> This fix makes some minor changes to the internals of the
> `CertificateBuilder` and `SimpleOCSPServer` test classes. They would break
> when ML-DSA was selected as key and signing algorithms. Also RSASSA-PSS
> works better now with thes
My latest thoughts; please advise if I have misunderstood anything.
On Jan 24, 2025, at 3:11 AM, Jan Kowalski wrote:
I'd say that, if it's possible, we should reduce the arithmetic artifacts,
rather than introduce them through not really needed, and not visible at the
first sight, type conver
Hi Fabian,
Thanks for sharing and reaching out with the idea before getting too beholden
to it.
I logged this is quite a while ago. It seemed like a possible good idea at the
time, although I never liked the duplication of suppliers. I have become less
enthusiastic overtime, especially so as G
On Tue, 11 Feb 2025 17:50:45 GMT, Jamil Nimeh wrote:
> This fix makes some minor changes to the internals of the
> `CertificateBuilder` and `SimpleOCSPServer` test classes. They would break
> when ML-DSA was selected as key and signing algorithms. Also RSASSA-PSS
> works better now with thes
On Thu, 13 Feb 2025 09:36:08 GMT, David Beaumont wrote:
>> test/jdk/java/util/logging/LoggingDeadlock5.java line 115:
>>
>>> 113:
>>> 114: private static class DeadLocker {
>>> 115: private final static Duration JOIN_WAIT =
>>> Duration.ofMillis(500);
>>
>> You might want to use `
On Thu, 13 Feb 2025 16:43:22 GMT, Roland Westrelin wrote:
> The current transformation from the parsed version of min/max to a
> conditional move to a Max/Min node depends on the conditional move
> transformation which has its own set of heuristics and while it happens on
> simple test cases,
This change adds an API note to these methods recommending that the caller
should perform further validation steps on the code signers that signed the JAR
file, such as validating the code signer's certificate chain, and determining
if the signer should be trusted. There was already a similar wa
On Thu, 13 Feb 2025 11:46:35 GMT, Emanuel Peter wrote:
> Do we see any other wins with your patch, that are not due to vectorization,
> but just scalar code?
I think there are some.
The current transformation from the parsed version of min/max to a conditional
move to a `Max`/`Min` node depe
>I could see that being useful for properties such as non-nullness,
which would allow collections such as ImmutableList to skip the null
check in the end.
I'm thinking things like ordered/unordered, whether the stream is parallel or
not (might want to use different representation for a sequential
On Thu, Feb 13, 2025 at 3:06 PM Viktor Klang wrote:
> While it may look enticing to merely propagate expected element count as an
> input parameter to the supplier function,
> I think it deserves some extra thought, specifically if it may make more
> sense to pass some sort of StreamInfo type wh
On Wed, 12 Feb 2025 19:55:29 GMT, Stuart Marks wrote:
> A couple adjustments to the specs for four methods of StringBuilder and
> StringBuffer so that they no longer require new Strings to be created, just a
> String with the right contents. No implementation changes. Note that the
> actual sp
Hi Fabian,
Thanks for your patience, it took a bit of time to swap back in my thoughts on
the matter, as I was considering this JBS issue as I was working on Gatherers
(JEP461, JEP473, JEP485).
While it may look enticing to merely propagate expected element count as an
input parameter to the s
On Thu, 13 Feb 2025 12:43:57 GMT, Alexey Semenyuk wrote:
> Make jpackage capable of using wix3 when Federal Information Processing
> Standard (FIPS) mode is enabled on Windows.
>
> When FIPS mode is enabled, running `candle.exe -?` prints:
>
> candle.exe : error CNDL0308 : The Federal Informat
8285624: jpackage fails to create exe, msi when Windows OS is in FIPS mode
-
Commit messages:
- Update copyright year
- 8285624: jpackage fails to create exe, msi when Windows OS is in FIPS mode
Changes: https://git.openjdk.org/jdk/pull/23612/files
Webrev: https://webrevs.openjdk
On Thu, 13 Feb 2025 12:06:09 GMT, Jatin Bhateja wrote:
>> Suite MaskedLogicOpts.maskedLogicOperationsLong512() failed on both x86 and
>> AArch64 with the following error:
>>
>>
>> java.lang.IndexOutOfBoundsException: Index 252 out of bounds for length 249
>>
>>
>> The variable `long256_arr_i
On Wed, 8 Jan 2025 09:04:47 GMT, Nicole Xu wrote:
> Suite MaskedLogicOpts.maskedLogicOperationsLong512() failed on both x86 and
> AArch64 with the following error:
>
>
> java.lang.IndexOutOfBoundsException: Index 252 out of bounds for length 249
>
>
> The variable `long256_arr_idx` is misuse
On Wed, 12 Feb 2025 14:09:49 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change in
> `jdk.tools.jlink.internal.plugins.ZipPlugin` which proposes to close the
> `Deflater` instance cleanly? This addresses
> https://bugs.openjdk.org/browse/JDK-8349907.
>
> As noted in that issu
On Wed, 12 Feb 2025 16:47:29 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change in
>> `jdk.tools.jlink.internal.plugins.ZipPlugin` which proposes to close the
>> `Deflater` instance cleanly? This addresses
>> https://bugs.openjdk.org/browse/JDK-8349907.
>>
>> As noted in tha
On Mon, 10 Feb 2025 09:26:32 GMT, Galder Zamarreño wrote:
>> @eastig is helping with the results on aarch64, so I will verify the numbers
>> in same way done below for x86_64 once he provides me with the results.
>>
>> Here is a summary of the benchmarking results I'm seeing on x86_64 (I will
On Mon, 10 Feb 2025 09:26:32 GMT, Galder Zamarreño wrote:
>> @eastig is helping with the results on aarch64, so I will verify the numbers
>> in same way done below for x86_64 once he provides me with the results.
>>
>> Here is a summary of the benchmarking results I'm seeing on x86_64 (I will
On Wed, 12 Feb 2025 16:04:53 GMT, Per Minborg wrote:
>> Going forward, converting older JDK code to use the relatively new FFM API
>> requires system calls that can provide `errno` and the likes to explicitly
>> allocate a `MemorySegment` to capture potential error states. This can lead
>> to
On Fri, 7 Feb 2025 14:46:06 GMT, Per Minborg wrote:
> Going forward, converting older JDK code to use the relatively new FFM API
> requires system calls that can provide `errno` and the likes to explicitly
> allocate a `MemorySegment` to capture potential error states. This can lead
> to negat
On Tue, 11 Feb 2025 10:17:48 GMT, Christoph Langer wrote:
>> The change for JDK-8346434 added a new test case to
>> tools/jpackage/share/JLinkOptionsTest.java which does not respect the
>> constraint of the linkable runtime (JEP 493) that no jdk.jlink module can be
>> part of the target image.
On Wed, 5 Feb 2025 04:14:21 GMT, Alexey Semenyuk wrote:
> Clean warnings found in jpackage tests when building them with `-Xlint:all`
> option in Eclipse IDE.
>
> They are:
> - redundant imports (solution: remove)
> - unused function/fields (solution: remove)
> - missing SuppressWarnings-s
On Fri, 7 Feb 2025 13:13:24 GMT, Christoph Langer wrote:
> The change for JDK-8346434 added a new test case to
> tools/jpackage/share/JLinkOptionsTest.java which does not respect the
> constraint of the linkable runtime (JEP 493) that no jdk.jlink module can be
> part of the target image.
> Th
On Wed, 12 Feb 2025 16:47:29 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change in
>> `jdk.tools.jlink.internal.plugins.ZipPlugin` which proposes to close the
>> `Deflater` instance cleanly? This addresses
>> https://bugs.openjdk.org/browse/JDK-8349907.
>>
>> As noted in tha
On Wed, 12 Feb 2025 18:28:19 GMT, Daniel Fuchs wrote:
> The code changes look reasonable. WRT to detecting deadlocks a possibility is
> also to use `ManagementFactory.getThreadMXBean().findDeadlockedThreads();`
>
> See for instance
>
> https://github.com/openjdk/jdk/blob/336d0d8592aed734e7b813
On Wed, 12 Feb 2025 20:07:51 GMT, Daniel Fuchs wrote:
>> src/java.logging/share/classes/java/util/logging/FileHandler.java line 755:
>>
>>> 753: synchronized(this) {
>>> 754: flush();
>>> 755: if (limit > 0 && (meter.written >= limit || meter.written
>>> < 0)) {
On Thu, 13 Feb 2025 00:30:14 GMT, Stuart Marks wrote:
> A couple days ago the bot warned
>
> > This pull request contains merges that bring in commits not present in the
> > target repository.
>
> I'm not sure why this happened. It might be because of this commit earlier in
> this branch:
>
On Wed, 12 Feb 2025 19:55:29 GMT, Stuart Marks wrote:
> A couple adjustments to the specs for four methods of StringBuilder and
> StringBuffer so that they no longer require new Strings to be created, just a
> String with the right contents. No implementation changes. Note that the
> actual sp
On Thu, 13 Feb 2025 07:52:30 GMT, Nicole Xu wrote:
>> Oh, the OCA-verify is still stuck. I'm sorry about that 🙈
>> I pinged my manager @TobiHartmann , he will reach out to see what's the
>> issue.
>
> Hi @eme64, do you see any risks here? Would you please help to review the
> patch? Thanks.
@
As is suggested in [JDK-8342958](https://bugs.openjdk.org/browse/JDK-8342958),
`jvmArgs` should be used consistently in microbenchmarks to 'align with the
intuition that when you use jvmArgsAppend/-Prepend intent is to add to a set of
existing flags, while if you supply jvmArgs intent is "run wi
On Wed, 12 Feb 2025 19:55:29 GMT, Stuart Marks wrote:
> A couple adjustments to the specs for four methods of StringBuilder and
> StringBuffer so that they no longer require new Strings to be created, just a
> String with the right contents. No implementation changes. Note that the
> actual sp
72 matches
Mail list logo
