On Wed, 12 Feb 2025 14:09:49 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review of this change in > `jdk.tools.jlink.internal.plugins.ZipPlugin` which proposes to close the > `Deflater` instance cleanly? This addresses > https://bugs.openjdk.org/browse/JDK-8349907. > > As noted in that issue, the `Deflater` instance wasn't being closed in the > exception code path of this method. The commit in this PR merely changes the > code to use a try-with-resources block on the `Deflater` instance. > > No new tests have been introduced given the nature of the change. I've added > a `noreg-hard` to the issue. Existing tier1, tier2 and tier3 tests continue > to pass with this change without any related failures. This pull request has now been integrated. Changeset: 5b75ff72 Author: Jaikiran Pai <j...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/5b75ff7283340291bc87f83aba0e4416479899e3 Stats: 32 lines in 1 file changed: 13 ins; 13 del; 6 mod 8349907: jdk.tools.jlink.internal.plugins.ZipPlugin does not close the Deflater in exceptional cases Reviewed-by: liach, alanb, sundar, lancea ------------- PR: https://git.openjdk.org/jdk/pull/23588
