On Tue, 4 Feb 2025 18:55:25 GMT, Emanuel Peter wrote:
>> Suite MaskedLogicOpts.maskedLogicOperationsLong512() failed on both x86 and
>> AArch64 with the following error:
>>
>>
>> java.lang.IndexOutOfBoundsException: Index 252 out of bounds for length 249
>>
>>
>> The variable `long256_arr_id
On Wed, 12 Feb 2025 08:27:22 GMT, Alan Bateman wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Set started as final
>
> Marked as reviewed by alanb (Reviewer).
Thanks @AlanBateman for the review.
-
PR C
On Wed, 12 Feb 2025 03:24:07 GMT, SendaoYan wrote:
> Hi all,
>
> Test test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java run passed
> unexpected without native library or with the incorrect native library path.
> The test command with incorrect native library path shows below. We will se
On Tue, 11 Feb 2025 08:10:24 GMT, Alan Bateman wrote:
> That's okay with me. I'm hoping Magnus will jump in when he gets a chance as
> he has experience with the "other" static build configurations.
@magicus Any thoughts and input on this?
-
PR Comment: https://git.openjdk.org/jdk
On Thu, 6 Feb 2025 12:07:57 GMT, David Beaumont wrote:
> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
> publish() method.
>
> 1. Remove synchronization of calls to publish() in Handlers in
> java.util.logging package.
> 2. Add explanatory comments to various affected me
On Wed, 12 Feb 2025 23:07:26 GMT, Naoto Sato wrote:
>> Fixing the regression caused by the JDK-8342550 fix. Since the logging
>> facility depends on TimeZone class, it should not use the logging facility.
>> Replacing the logging with simple System.err.printf() will fix the issue.
>
> Naoto Sat
> Fixing the regression caused by the JDK-8342550 fix. Since the logging
> facility depends on TimeZone class, it should not use the logging facility.
> Replacing the logging with simple System.err.printf() will fix the issue.
Naoto Sato has updated the pull request incrementally with one additi
On Wed, 12 Feb 2025 22:06:34 GMT, Justin Lu wrote:
>> Please review this PR which prevents a (non-specified) `AIOOBE` from leaking
>> out of the range accepting endpoints in `Locale.LanguageRange`.
>>
>> In the reported error case, the invalid range is a lone "-" which is `split`
>> into an em
On Tue, 10 Dec 2024 23:45:37 GMT, Volodymyr Paprotski
wrote:
> (Also see `8319429: Resetting MXCSR flags degrades ecore`)
>
> This PR fixes two issues:
> - the original issue is a crash caused by `__ warn` corrupting the stack on
> Windows only
> - This issue also uncovered that -Xcheck:jni te
On Wed, 12 Feb 2025 19:35:18 GMT, Naoto Sato wrote:
> Fixing the regression caused by the JDK-8342550 fix. Since the logging
> facility depends on TimeZone class, it should not use the logging facility.
> Replacing the logging with simple System.err.printf() will fix the issue.
lgtm
test/jdk/
On Wed, 12 Feb 2025 15:47:04 GMT, Volodymyr Paprotski
wrote:
>> (Also see `8319429: Resetting MXCSR flags degrades ecore`)
>>
>> This PR fixes two issues:
>> - the original issue is a crash caused by `__ warn` corrupting the stack on
>> Windows only
>> - This issue also uncovered that -Xcheck:
On Wed, 12 Feb 2025 19:35:18 GMT, Naoto Sato wrote:
> Fixing the regression caused by the JDK-8342550 fix. Since the logging
> facility depends on TimeZone class, it should not use the logging facility.
> Replacing the logging with simple System.err.printf() will fix the issue.
Marked as revie
On Wed, 12 Feb 2025 21:40:48 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Naoto's review - Include test in LanguageRangeTest instead. Additionally,
>> bundle existing LRToString test into LanguageR
> Please review this PR which prevents a (non-specified) `AIOOBE` from leaking
> out of the range accepting endpoints in `Locale.LanguageRange`.
>
> In the reported error case, the invalid range is a lone "-" which is `split`
> into an empty array. Checking if the range ends with "-" first, avoi
On Wed, 12 Feb 2025 19:35:18 GMT, Naoto Sato wrote:
> Fixing the regression caused by the JDK-8342550 fix. Since the logging
> facility depends on TimeZone class, it should not use the logging facility.
> Replacing the logging with simple System.err.printf() will fix the issue.
Marked as revie
On Wed, 12 Feb 2025 15:47:04 GMT, Volodymyr Paprotski
wrote:
>> (Also see `8319429: Resetting MXCSR flags degrades ecore`)
>>
>> This PR fixes two issues:
>> - the original issue is a crash caused by `__ warn` corrupting the stack on
>> Windows only
>> - This issue also uncovered that -Xcheck:
On Wed, 12 Feb 2025 19:34:19 GMT, Justin Lu wrote:
> Please review this PR which prevents a (non-specified) `AIOOBE` from leaking
> out of the range accepting endpoints in `Locale.LanguageRange`.
>
> In the reported error case, the invalid range is a lone "-" which is `split`
> into an empty a
On Wed, 12 Feb 2025 15:47:04 GMT, Volodymyr Paprotski
wrote:
>> (Also see `8319429: Resetting MXCSR flags degrades ecore`)
>>
>> This PR fixes two issues:
>> - the original issue is a crash caused by `__ warn` corrupting the stack on
>> Windows only
>> - This issue also uncovered that -Xcheck:
On Thu, 6 Feb 2025 23:12:48 GMT, Alexey Semenyuk wrote:
>> Clean warnings found in jpackage tests when building them with `-Xlint:all`
>> option in Eclipse IDE.
>>
>> They are:
>> - redundant imports (solution: remove)
>> - unused function/fields (solution: remove)
>> - missing SuppressWarn
Fixing the regression caused by the JDK-8342550 fix. Since the logging facility
depends on TimeZone class, it should not use the logging facility. Replacing
the logging with simple System.err.printf() will fix the issue.
-
Commit messages:
- initial commit
Changes: https://git.ope
On Wed, 12 Feb 2025 19:41:44 GMT, Jason Mehrens wrote:
>> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
>> publish() method.
>>
>> 1. Remove synchronization of calls to publish() in Handlers in
>> java.util.logging package.
>> 2. Add explanatory comments to various affec
On Thu, 6 Feb 2025 12:07:57 GMT, David Beaumont wrote:
> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
> publish() method.
>
> 1. Remove synchronization of calls to publish() in Handlers in
> java.util.logging package.
> 2. Add explanatory comments to various affected me
Please review this PR which prevents a (non-specified) `AIOOBE` from leaking
out of the range accepting endpoints in `Locale.LanguageRange`.
In the reported error case, the invalid range is a lone "-" which is `split`
into an empty array. Checking if the range ends with "-" first, avoids indexin
On Thu, 6 Feb 2025 12:07:57 GMT, David Beaumont wrote:
> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
> publish() method.
>
> 1. Remove synchronization of calls to publish() in Handlers in
> java.util.logging package.
> 2. Add explanatory comments to various affected me
On Thu, 6 Feb 2025 12:07:57 GMT, David Beaumont wrote:
> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
> publish() method.
>
> 1. Remove synchronization of calls to publish() in Handlers in
> java.util.logging package.
> 2. Add explanatory comments to various affected me
On Thu, 6 Feb 2025 12:07:57 GMT, David Beaumont wrote:
> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
> publish() method.
>
> 1. Remove synchronization of calls to publish() in Handlers in
> java.util.logging package.
> 2. Add explanatory comments to various affected me
On Wed, 12 Feb 2025 16:47:29 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change in
>> `jdk.tools.jlink.internal.plugins.ZipPlugin` which proposes to close the
>> `Deflater` instance cleanly? This addresses
>> https://bugs.openjdk.org/browse/JDK-8349907.
>>
>> As noted in tha
On Wed, 12 Feb 2025 16:47:29 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change in
>> `jdk.tools.jlink.internal.plugins.ZipPlugin` which proposes to close the
>> `Deflater` instance cleanly? This addresses
>> https://bugs.openjdk.org/browse/JDK-8349907.
>>
>> As noted in tha
On Sun, 15 Dec 2024 18:05:02 GMT, Jatin Bhateja wrote:
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of vario
On Wed, 12 Feb 2025 14:46:49 GMT, Paul Sandoz wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments resolutions
>
> Looks good. I merged this PR with master, successfully (at the time) with no
> conflic
On Wed, 12 Feb 2025 15:45:53 GMT, Chen Liang wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Lance's suggestion
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ZipPlugin.java
> line 99:
>
>> 97:
> Can I please get a review of this change in
> `jdk.tools.jlink.internal.plugins.ZipPlugin` which proposes to close the
> `Deflater` instance cleanly? This addresses
> https://bugs.openjdk.org/browse/JDK-8349907.
>
> As noted in that issue, the `Deflater` instance wasn't being closed in the
>
On Thu, 6 Feb 2025 23:12:48 GMT, Alexey Semenyuk wrote:
>> Clean warnings found in jpackage tests when building them with `-Xlint:all`
>> option in Eclipse IDE.
>>
>> They are:
>> - redundant imports (solution: remove)
>> - unused function/fields (solution: remove)
>> - missing SuppressWarn
On Wed, 12 Feb 2025 15:47:04 GMT, Volodymyr Paprotski
wrote:
>> (Also see `8319429: Resetting MXCSR flags degrades ecore`)
>>
>> This PR fixes two issues:
>> - the original issue is a crash caused by `__ warn` corrupting the stack on
>> Windows only
>> - This issue also uncovered that -Xcheck:
On Wed, 12 Feb 2025 16:05:03 GMT, Vladimir Kozlov wrote:
> I submitted our internal testing. Please wait results.
Thanks! Deleted the integrate command
-
PR Comment: https://git.openjdk.org/jdk/pull/22673#issuecomment-2654227936
On Tue, 11 Feb 2025 21:47:31 GMT, Volodymyr Paprotski
wrote:
>> (Also see `8319429: Resetting MXCSR flags degrades ecore`)
>>
>> This PR fixes two issues:
>> - the original issue is a crash caused by `__ warn` corrupting the stack on
>> Windows only
>> - This issue also uncovered that -Xcheck:
On Wed, 12 Feb 2025 15:47:04 GMT, Volodymyr Paprotski
wrote:
>> (Also see `8319429: Resetting MXCSR flags degrades ecore`)
>>
>> This PR fixes two issues:
>> - the original issue is a crash caused by `__ warn` corrupting the stack on
>> Windows only
>> - This issue also uncovered that -Xcheck:
> Going forward, converting older JDK code to use the relatively new FFM API
> requires system calls that can provide `errno` and the likes to explicitly
> allocate a `MemorySegment` to capture potential error states. This can lead
> to negative performance implications if not designed carefully
On Wed, 12 Feb 2025 15:45:25 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change in
>> `jdk.tools.jlink.internal.plugins.ZipPlugin` which proposes to close the
>> `Deflater` instance cleanly? This addresses
>> https://bugs.openjdk.org/browse/JDK-8349907.
>>
>> As noted in tha
On Wed, 12 Feb 2025 15:45:25 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change in
>> `jdk.tools.jlink.internal.plugins.ZipPlugin` which proposes to close the
>> `Deflater` instance cleanly? This addresses
>> https://bugs.openjdk.org/browse/JDK-8349907.
>>
>> As noted in tha
On Wed, 12 Feb 2025 15:38:34 GMT, Julian Waters wrote:
>> Volodymyr Paprotski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comments from Sandhya
>
> src/hotspot/os/windows/os_windows.cpp line 2757:
>
>> 2755:
>> 2756: #if defined(_M
On Tue, 11 Feb 2025 21:47:31 GMT, Volodymyr Paprotski
wrote:
>> (Also see `8319429: Resetting MXCSR flags degrades ecore`)
>>
>> This PR fixes two issues:
>> - the original issue is a crash caused by `__ warn` corrupting the stack on
>> Windows only
>> - This issue also uncovered that -Xcheck:
> (Also see `8319429: Resetting MXCSR flags degrades ecore`)
>
> This PR fixes two issues:
> - the original issue is a crash caused by `__ warn` corrupting the stack on
> Windows only
> - This issue also uncovered that -Xcheck:jni test cases were getting 65k
> lines of warning on HelloWorld (on
On Wed, 12 Feb 2025 15:42:36 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change in
>> `jdk.tools.jlink.internal.plugins.ZipPlugin` which proposes to close the
>> `Deflater` instance cleanly? This addresses
>> https://bugs.openjdk.org/browse/JDK-8349907.
>>
>> As noted in tha
On Wed, 12 Feb 2025 15:39:11 GMT, Chen Liang wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Lance's suggestion
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ZipPlugin.java
> line 99:
>
>> 97:
> Can I please get a review of this change in
> `jdk.tools.jlink.internal.plugins.ZipPlugin` which proposes to close the
> `Deflater` instance cleanly? This addresses
> https://bugs.openjdk.org/browse/JDK-8349907.
>
> As noted in that issue, the `Deflater` instance wasn't being closed in the
>
On Wed, 12 Feb 2025 14:09:49 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change in
> `jdk.tools.jlink.internal.plugins.ZipPlugin` which proposes to close the
> `Deflater` instance cleanly? This addresses
> https://bugs.openjdk.org/browse/JDK-8349907.
>
> As noted in that issu
On Tue, 11 Feb 2025 21:47:31 GMT, Volodymyr Paprotski
wrote:
>> (Also see `8319429: Resetting MXCSR flags degrades ecore`)
>>
>> This PR fixes two issues:
>> - the original issue is a crash caused by `__ warn` corrupting the stack on
>> Windows only
>> - This issue also uncovered that -Xcheck:
On Thu, 6 Feb 2025 16:27:19 GMT, Chen Liang wrote:
>> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
>> publish() method.
>>
>> 1. Remove synchronization of calls to publish() in Handlers in
>> java.util.logging package.
>> 2. Add explanatory comments to various affected
On Thu, 6 Feb 2025 12:07:57 GMT, David Beaumont wrote:
> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
> publish() method.
>
> 1. Remove synchronization of calls to publish() in Handlers in
> java.util.logging package.
> 2. Add explanatory comments to various affected me
8349206: j.u.l.Handler classes create deadlock risk via synchronized publish()
method.
1. Remove synchronization of calls to publish() in Handlers in
java.util.logging package.
2. Add explanatory comments to various affected methods.
3. Add a test to ensure deadlocks no longer occur.
Note that
On Tue, 11 Feb 2025 06:32:56 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Detection
On Sat, 11 Jan 2025 07:10:53 GMT, He-Pin(kerr) wrote:
> Motivation:
> When a user passes a wrong parameter, the current implementation throws an
> IllegalArgumentException with an error message `null`, which is not helpful.
>
> Modification:
> Add detail error messages.
>
> Result:
> Helpful m
On Tue, 11 Feb 2025 08:39:51 GMT, Per Minborg wrote:
>> Motivation:
>> When a user passes a wrong parameter, the current implementation throws an
>> IllegalArgumentException with an error message `null`, which is not helpful.
>>
>> Modification:
>> Add detail error messages.
>>
>> Result:
>> H
Can I please get a review of this change in
`jdk.tools.jlink.internal.plugins.ZipPlugin` which proposes to close the
`Deflater` instance cleanly? This addresses
https://bugs.openjdk.org/browse/JDK-8349907.
As noted in that issue, the `Deflater` instance wasn't being closed in the
exception cod
On Mon, 10 Feb 2025 13:23:49 GMT, Coleen Phillimore wrote:
>> This change removes the native call and injected field for ProtectionDomain
>> in the java.lang.Class instance, and moves the field to be declared in Java.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request wit
On Fri, 10 Jan 2025 14:57:09 GMT, Severin Gehwolf wrote:
>> Please review this fix for cgroups-based metrics reporting in the
>> `jdk.internal.platform` package. This fix is supposed to address wrong
>> reporting of certain limits if the limits aren't set at the leaf nodes.
>>
>> For example,
On Fri, 31 Jan 2025 16:39:35 GMT, Coleen Phillimore wrote:
> This change removes the native call and injected field for ProtectionDomain
> in the java.lang.Class instance, and moves the field to be declared in Java.
> Tested with tier1-4.
This pull request has now been integrated.
Changeset: e
On Mon, 10 Feb 2025 13:23:49 GMT, Coleen Phillimore wrote:
>> This change removes the native call and injected field for ProtectionDomain
>> in the java.lang.Class instance, and moves the field to be declared in Java.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request wit
On Tue, 11 Feb 2025 10:17:48 GMT, Christoph Langer wrote:
>> The change for JDK-8346434 added a new test case to
>> tools/jpackage/share/JLinkOptionsTest.java which does not respect the
>> constraint of the linkable runtime (JEP 493) that no jdk.jlink module can be
>> part of the target image.
As an avid user of Guava's ImmutableCollections, I have been
interested in ways to close the efficiency gap between the built-in
`Stream#toList()` and third-party `Collector` implementations such as
`ImmutableList#toImmutableList()`. I've found the biggest problem to
be the lack of sizing informati
On Mon, 10 Feb 2025 21:23:28 GMT, Paul Sandoz wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing typos
>
> An impressive and substantial change. I focused on the Java code, there are
> some small tweaks, pres
> Hi all,
>
> Test test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java run passed
> unexpected without native library or with the incorrect native library path.
> The test command with incorrect native library path shows below. We will seen
> this tests run passed unexpected before this PR
> Going forward, converting older JDK code to use the relatively new FFM API
> requires system calls that can provide `errno` and the likes to explicitly
> allocate a `MemorySegment` to capture potential error states. This can lead
> to negative performance implications if not designed carefully
On Wed, 12 Feb 2025 08:21:04 GMT, Alan Bateman wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename latch to started, and do the countDown before the while loop
>
> test/jdk/java/lang/Thread/virtual/ThreadPollOnYiel
On Wed, 12 Feb 2025 08:28:16 GMT, SendaoYan wrote:
>> Hi all,
>>
>> Test test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java run passed
>> unexpected without native library or with the incorrect native library path.
>> The test command with incorrect native library path shows below. We wi
On Wed, 12 Feb 2025 07:43:50 GMT, SendaoYan wrote:
>> Hi all,
>>
>> Test test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java run passed
>> unexpected without native library or with the incorrect native library path.
>> The test command with incorrect native library path shows below. We wi
67 matches
Mail list logo
