On Wed, 12 Feb 2025 21:40:48 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Naoto's review - Include test in LanguageRangeTest instead. Additionally,
>> bundle existing LRToString test into LanguageRangeTest as well
>
> test/jdk/java/util/Locale/IllformedRangeTest.java line 40:
>
>> 38: import static org.junit.jupiter.api.Assertions.assertThrows;
>> 39:
>> 40: public class IllformedRangeTest {
>
> Instead of creating a new test file, you might want to add this test into
> `LanguageRangeTest.java`
Moved `IllformedRangeTest.java` as well as the existing `LRToString.java` test
into `LanguageRangeTest.java`, which can now serve as a general class test.
Also converted the test to JUnit.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23596#discussion_r1953464752
