Re: RFR: 8349184: [JMH] jdk.incubator.vector.ColumnFilterBenchmark.filterDoubleColumn fails on linux-aarch64 [v2]

2025-02-02 Thread Hao Sun
On Mon, 3 Feb 2025 04:16:57 GMT, SendaoYan wrote: >> Hi all, >> Several JMH tests fails "Unrecognized VM option 'UseAVX=2'" on >> linux-aarch64. The VM option '-XX:UseAVX=2' only support on x86_64 platform. >> This PR add option '-XX:+IgnoreUnrecognizedVMOptions' to make test run >> normally o

Re: RFR: 8342775: [Graal] java/util/concurrent/locks/Lock/OOMEInAQS.java fails OOME thrown from the UncaughtExceptionHandler [v3]

2025-02-02 Thread David Holmes
On Fri, 31 Jan 2025 22:18:32 GMT, Tom Rodriguez wrote: >> Deoptimization with escape analysis can fail when trying to rematerialize >> objects as described in JDK-8227309. In this test this can happen in Xcomp >> mode in the framework of the test resulting in a test failure. Making the >> nu

Re: RFR: 8342775: [Graal] java/util/concurrent/locks/Lock/OOMEInAQS.java fails OOME thrown from the UncaughtExceptionHandler [v3]

2025-02-02 Thread Jaikiran Pai
On Fri, 31 Jan 2025 22:18:32 GMT, Tom Rodriguez wrote: >> Deoptimization with escape analysis can fail when trying to rematerialize >> objects as described in JDK-8227309. In this test this can happen in Xcomp >> mode in the framework of the test resulting in a test failure. Making the >> nu

Re: RFR: 8342775: [Graal] java/util/concurrent/locks/Lock/OOMEInAQS.java fails OOME thrown from the UncaughtExceptionHandler [v3]

2025-02-02 Thread Tom Rodriguez
On Fri, 31 Jan 2025 22:18:32 GMT, Tom Rodriguez wrote: >> Deoptimization with escape analysis can fail when trying to rematerialize >> objects as described in JDK-8227309. In this test this can happen in Xcomp >> mode in the framework of the test resulting in a test failure. Making the >> nu

Re: RFR: 8349184: [JMH] jdk.incubator.vector.ColumnFilterBenchmark.filterDoubleColumn fails on linux-aarch64 [v2]

2025-02-02 Thread SendaoYan
> Hi all, > Several JMH tests fails "Unrecognized VM option 'UseAVX=2'" on linux-aarch64. > The VM option '-XX:UseAVX=2' only support on x86_64 platform. This PR add > option '-XX:+IgnoreUnrecognizedVMOptions' to make test run normally on non > x86_64 platform. > Change has been verified locally

Re: RFR: 8349184: [JMH] jdk.incubator.vector.ColumnFilterBenchmark.filterDoubleColumn fails on linux-aarch64 [v2]

2025-02-02 Thread SendaoYan
On Mon, 3 Feb 2025 01:49:45 GMT, Hao Sun wrote: >> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add missing , > > test/micro/org/openjdk/bench/jdk/incubator/vector/ColumnFilterBenchmark.java > line 2: > >> 1: /* >> 2: *

Re: [jdk24] RFR: 8347038: [JMH] jdk.incubator.vector.SpiltReplicate fails NoClassDefFoundError

2025-02-02 Thread Hao Sun
On Tue, 7 Jan 2025 15:14:18 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit > [4d8fb807](https://github.com/openjdk/jdk/commit/4d8fb80732fd17352c36254c6dfc1be5dbfbacf1) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository to jdk24. > > The commi

Re: RFR: 8349184: [JMH] jdk.incubator.vector.ColumnFilterBenchmark.filterDoubleColumn fails on linux-aarch64

2025-02-02 Thread Hao Sun
On Sat, 1 Feb 2025 14:37:44 GMT, SendaoYan wrote: > Hi all, > Several JMH tests fails "Unrecognized VM option 'UseAVX=2'" on linux-aarch64. > The VM option '-XX:UseAVX=2' only support on x86_64 platform. This PR add > option '-XX:+IgnoreUnrecognizedVMOptions' to make test run normally on non >

Re: RFR: 8315585: Optimization for decimal to string [v4]

2025-02-02 Thread Shaojin Wen
On Sun, 2 Feb 2025 06:58:21 GMT, Johannes Graham wrote: >> Good suggestion, but DecimalDigits no longer provides a pair method > > Right - you’d need to add it back to try this I tested it on a MacBook M1 Max machine and the results were different from what you said. Using StringBuilder + digit

Re: RFR: 8349107: Remove RMI finalizers

2025-02-02 Thread Abdelhak Zaaim
On Sat, 1 Feb 2025 00:11:31 GMT, Brent Christian wrote: > 3 finalizers in RMI code can be removed, as they do not perform meaningful > cleanup. > > **`jdk.naming.rmi/share/classes/com/sun/jndi/rmi/registry/RegistryContext`** > > `RegistryContext.finalize()` just calls `close()`. The `close()`

RFR: 8349189: Speed up DateTime parse & format via Class File API

2025-02-02 Thread Shaojin Wen
By using the Class File API to dynamically generate a CompositePrinterParser, and defining DateTimePrinterParser[] printerParsers as a specific field, C2 can do TypeProfile optimization. Since the CompositePrinterParser is generated based on the pattern, we can make the following optimizations:

Re: RFR: 8349189: Speed up DateTime parse & format via Class File API

2025-02-02 Thread Shaojin Wen
On Fri, 31 Jan 2025 10:29:53 GMT, Shaojin Wen wrote: > By using the Class File API to dynamically generate a CompositePrinterParser, > and defining DateTimePrinterParser[] printerParsers as a specific field, C2 > can do TypeProfile optimization. > > Since the CompositePrinterParser is generate

Re: adding Xalan's XSL 3 implementation within jdk

2025-02-02 Thread Alan Bateman
On 02/02/2025 14:27, Mukul Gandhi wrote: Hi all, Due to an unknowing issue with the previous mail that I've sent as mentioned within mail trail, the URL of codebase repos branch got specified ashttps://github.com/apache/xalan-java/tree/xalan-j_xslt3.0_mvn. (with an erroneous period suffix ch

Re: adding Xalan's XSL 3 implementation within jdk

2025-02-02 Thread Mukul Gandhi
Hi all, Due to an unknowing issue with the previous mail that I've sent as mentioned within mail trail, the URL of codebase repos branch got specified as https://github.com/apache/xalan-java/tree/xalan-j_xslt3.0_mvn. (with an erroneous period suffix character). The correct URL is https://github

Re: RFR: 8343074: test/jdk/com/sun/net/httpserver/docs/test1/largefile.txt could be generated

2025-02-02 Thread Jaikiran Pai
On Fri, 31 Jan 2025 19:42:55 GMT, Volkan Yazici wrote: > Adds `test.lib.Utils::createTempFileOfSize` to generate > `test/jdk/com/sun/net/httpserver/docs` contents at runtime. This directory > contains `largefile.txt` of size 2.6MiB showing up as the 4th largest file > tracked by git: > > > $

Re: RFR: 8342775: [Graal] java/util/concurrent/locks/Lock/OOMEInAQS.java fails OOME thrown from the UncaughtExceptionHandler [v3]

2025-02-02 Thread Jaikiran Pai
On Fri, 31 Jan 2025 22:18:32 GMT, Tom Rodriguez wrote: >> Deoptimization with escape analysis can fail when trying to rematerialize >> objects as described in JDK-8227309. In this test this can happen in Xcomp >> mode in the framework of the test resulting in a test failure. Making the >> nu

Re: RFR: 8258246: sun.net.www.ParseUtil.decode throws java.lang.IllegalArgumentException: Error decoding percent encoded characters [v2]

2025-02-02 Thread Alan Bateman
On Fri, 31 Jan 2025 12:53:32 GMT, Fabian Meumertzheim wrote: >> `URLClassPath` called into `ParseUtil.fileToEncodedURL`, which misencoded >> characters with a four byte UTF-8 representation. Replacing that function >> with `toPath().toUri().toURL()` (and removing it, since its only used once)