On Fri, 31 Jan 2025 19:42:55 GMT, Volkan Yazici <vyaz...@openjdk.org> wrote:
> Adds `test.lib.Utils::createTempFileOfSize` to generate
> `test/jdk/com/sun/net/httpserver/docs` contents at runtime. This directory
> contains `largefile.txt` of size 2.6MiB showing up as the 4th largest file
> tracked by git:
>
>
> $ git ls-files | while read f; do echo -e $(stat -c %s "$f")"\t$f"; done
> >/tmp/trackedFileSizes.txt
> $ sort -n /tmp/trackedFileSizes.txt | tail -n 4
> 2730088 test/jdk/com/sun/net/httpserver/docs/test1/largefile.txt
> 2798680 src/java.base/share/data/unicodedata/NormalizationTest.txt
> 3574947 test/jdk/java/foreign/libTestDowncallStack.c
> 7128495 test/jdk/java/foreign/libTestUpcallStack.c
>
>
> **Other highlights:**
>
> - `jdk.httpclient.test.lib.common.TestUtil` is removed in favor of similar
> alternatives in `test.lib.Utils` and `test.lib.Asserts`
> - `test.lib.Asserts::assertFileContentsEqual` is added
test/lib/jdk/test/lib/Asserts.java line 623:
> 621: * @throws IOException on I/O failures
> 622: */
> 623: public static void assertFileContentsEqual(Path f1, Path f2) throws
> IOException {
Hello Volkan, is this new method needed? Can its call sites instead be replaced
with `java.nio.file.Files.mismatch(...)` call?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23401#discussion_r1938490806
