On Mon, 27 Jan 2025 22:03:41 GMT, Alexey Semenyuk wrote:
> Rework pointer arithmetic to avoid null pointer
Marked as reviewed by mbaesken (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/23320#pullrequestreview-2577374445
On Tue, 28 Jan 2025 04:04:39 GMT, Vladimir Ivanov wrote:
> Good work, Axel. `Cleaner`-based solution to manage nmethod dependencies on
> `java.lang.invoke.CallSite`s does look redundant. If that's the case, then
> I'd expect that by the time cleanup action is invoked corresponding
> dependency
On Thu, 31 Oct 2024 05:43:11 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> u
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of various Float16 operations through inline expansion or
> patt
On Mon, 20 Jan 2025 08:00:52 GMT, Emanuel Peter wrote:
>> @eme64 I've addressed all the comments. I've not run the `VectorReduction2`
>> for the reasons explained in the previous comment. Happy to add more details
>> to `MinMaxVector` if you feel it's necessary.
>
> @galderz Ah, right. I unders
On Mon, 20 Jan 2025 07:56:49 GMT, Axel Boldt-Christmas
wrote:
> The proposed change here is the following:
> 1. Move the `vmdependencies` list head from the `Context` to the `CallSite`
> object
> 2. Remove the Context object and its corresponding cleaner
>
> (1.) fixes the crash. (2.) is bec
On Tue, 28 Jan 2025 01:24:43 GMT, Shaojin Wen wrote:
>> This is an optimization for decimal Integer.parseInt and Long.parseLong,
>> which improves performance by about 10%. The optimization includes:
>> 1. Improve performance by parsing 2 numbers at a time, which has performance
>> improvements
On Mon, 27 Jan 2025 08:35:44 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Detection
> This is an optimization for decimal Integer.parseInt and Long.parseLong,
> which improves performance by about 10%. The optimization includes:
> 1. Improve performance by parsing 2 numbers at a time, which has performance
> improvements for numbers with length >= 3.
> 2. It uses charAt(0) for t
On Mon, 27 Jan 2025 08:35:44 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Detection
On Mon, 27 Jan 2025 15:16:12 GMT, Chen Liang wrote:
> Please review a non-clean backport of #23277, the final patch in the
> improvements to the Class-File API. The backport is non-clean because a new
> JAVA_25_VERSION constant was added in 25; otherwise the patch applied cleanly.
>
> Tests: N
On Mon, 27 Jan 2025 15:16:12 GMT, Chen Liang wrote:
> Please review a non-clean backport of #23277, the final patch in the
> improvements to the Class-File API. The backport is non-clean because a new
> JAVA_25_VERSION constant was added in 25; otherwise the patch applied cleanly.
>
> Tests: N
On Mon, 27 Jan 2025 22:03:41 GMT, Alexey Semenyuk wrote:
> Rework pointer arithmetic to avoid null pointer
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23320#pullrequestreview-2576723626
Rework pointer arithmetic to avoid null pointer
-
Commit messages:
- Fix compilation error on Linux:
- Bugfix
- Copyright year updated
- 8347272: [ubsan] JvmLauncher.cpp:262:52: runtime error: applying non-zero
offset 40 to null pointer
Changes: https://git.openjdk.org/jdk/pull/
On Mon, 27 Jan 2025 22:03:41 GMT, Alexey Semenyuk wrote:
> Rework pointer arithmetic to avoid null pointer
@sashamatveev, @MBaesken PTAL
-
PR Comment: https://git.openjdk.org/jdk/pull/23320#issuecomment-2616993852
On Thu, 23 Jan 2025 02:11:29 GMT, Jiangli Zhou wrote:
> Please review this trivial cleanup that removes the #ifdef STATIC_BUILD
> around DEF_STATIC_JNI_OnLoad from zip_util.c. Thanks.
I would appreciate if anyone can help take a look of this, thanks.
-
PR Comment: https://git.open
On Sat, 25 Jan 2025 04:01:47 GMT, Shaojin Wen wrote:
>> This is an optimization for decimal Integer.parseInt and Long.parseLong,
>> which improves performance by about 10%. The optimization includes:
>> 1. Improve performance by parsing 2 numbers at a time, which has performance
>> improvements
On Fri, 24 Jan 2025 18:00:06 GMT, Justin Lu wrote:
>> Please review this PR and CSR which add a pair of methods to
>> _java.util.TimeZone_ that return a stream of the available IDs. See the CSR
>> for the motivation.
>>
>> A number of existing tests are modified to use the new methods. See
>>
On Wed, 15 Jan 2025 21:39:05 GMT, Matthias Ernst wrote:
> Certain signatures for foreign function calls (e.g. HVA return by value)
> require allocation of an intermediate buffer to adapt the FFM's to the native
> stub's calling convention. In the current implementation, this buffer is
> malloc
On Mon, 27 Jan 2025 18:30:39 GMT, Justin Lu wrote:
>> Please review this PR which improves the time measurement for cut-over time
>> comparisons when building the available set of currencies in
>> _java.util.Currency._ Currently, a new time was measured for each special
>> case currency. This
On Mon, 27 Jan 2025 18:03:48 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reflect review
>
> src/java.base/share/classes/java/util/Currency.java line 447:
>
>> 445: synchronized(Currency.cl
On Mon, 27 Jan 2025 18:26:46 GMT, Justin Lu wrote:
>> Please review this PR which improves the time measurement for cut-over time
>> comparisons when building the available set of currencies in
>> _java.util.Currency._ Currently, a new time was measured for each special
>> case currency. This
> Please review this PR which improves the time measurement for cut-over time
> comparisons when building the available set of currencies in
> _java.util.Currency._ Currently, a new time was measured for each special
> case currency. This PR updates the behavior to use the same time for all such
On Fri, 24 Jan 2025 19:39:00 GMT, Raffaello Giulietti
wrote:
>> Shaojin Wen has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - remove unused
>> - Update src/java.base/share/classes/jdk/internal/util/DecimalDigits.java
>>
>>Co-au
On Fri, 24 Jan 2025 23:56:46 GMT, Justin Lu wrote:
> Please review this PR which improves the time measurement for cut-over time
> comparisons when building the available set of currencies in
> _java.util.Currency._ Currently, a new time was measured for each special
> case currency. This PR u
On Fri, 24 Jan 2025 21:51:39 GMT, Justin Lu wrote:
> Please review this PR which is a backport of
> [dec93675](https://github.com/openjdk/jdk/commit/dec93675ab3e4c271b14a254df75dc838f1346ea)
> that updates the l10n translations for jdk24.
>
> The commit being backported was authored by Justin
On Fri, 24 Jan 2025 21:51:39 GMT, Justin Lu wrote:
> Please review this PR which is a backport of
> [dec93675](https://github.com/openjdk/jdk/commit/dec93675ab3e4c271b14a254df75dc838f1346ea)
> that updates the l10n translations for jdk24.
>
> The commit being backported was authored by Justin
On Mon, 27 Jan 2025 15:16:12 GMT, Chen Liang wrote:
> Please review a non-clean backport of #23277, the final patch in the
> improvements to the Class-File API. The backport is non-clean because a new
> JAVA_25_VERSION constant was added in 25; otherwise the patch applied cleanly.
>
> Tests: N
Thanks Viktor!
It looks like the current fix ignores interruption.
I want to make sure my concern of it defeating cancellation is heard and
understood.
The scenarios I worry about is for a mapConcurrent() that fans out to
another method call, which internally calls mapConcurrent() as
implementat
Please review a non-clean backport of #23277, the final patch in the
improvements to the Class-File API. The backport is non-clean because a new
JAVA_25_VERSION constant was added in 25; otherwise the patch applied cleanly.
Tests: Submitted tier 1-3
-
Commit messages:
- Backport 1
Hi!
Please see: https://github.com/openjdk/jdk/pull/23100
Cheers,
√
Viktor Klang
Software Architect, Java Platform Group
Oracle
From: Jige Yu
Sent: Sunday, 26 January 2025 23:03
To: Viktor Klang
Cc: core-libs-dev@openjdk.org
Subject: [External] : Re: mapConcu
On Thu, 23 Jan 2025 19:48:55 GMT, Chen Liang wrote:
> This is the last piece in the API documentation improvement of the Class-File
> API.
>
> This includes general documentation about transforms, models (and
> traversals), options, constants, and CodeBuilder factories. In particular,
> this
On Fri, 24 Jan 2025 22:42:27 GMT, Chen Liang wrote:
>> This is the last piece in the API documentation improvement of the
>> Class-File API.
>>
>> This includes general documentation about transforms, models (and
>> traversals), options, constants, and CodeBuilder factories. In particular,
>
On Tue, 22 Oct 2024 10:19:23 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which updates a total of 12 links to external
> documentation or references in `java.base` to use https instead of plain text
> http.
>
> Links in `java.security` and `share/data/tzdata` are excluded from t
On Thu, 23 Jan 2025 17:36:11 GMT, Matthias Ernst wrote:
>> Certain signatures for foreign function calls (e.g. HVA return by value)
>> require allocation of an intermediate buffer to adapt the FFM's to the
>> native stub's calling convention. In the current implementation, this buffer
>> is ma
On Thu, 23 Jan 2025 17:36:11 GMT, Matthias Ernst wrote:
>> Certain signatures for foreign function calls (e.g. HVA return by value)
>> require allocation of an intermediate buffer to adapt the FFM's to the
>> native stub's calling convention. In the current implementation, this buffer
>> is ma
On Thu, 23 Jan 2025 17:36:11 GMT, Matthias Ernst wrote:
>> Certain signatures for foreign function calls (e.g. HVA return by value)
>> require allocation of an intermediate buffer to adapt the FFM's to the
>> native stub's calling convention. In the current implementation, this buffer
>> is ma
On Mon, 27 Jan 2025 07:42:48 GMT, Emanuel Peter wrote:
>> Jatin Bhateja has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 14 commits:
>>
>> - Rebasing to jdk mainline
>> - Merge branch 'master' of http://github.com/openjdk/jdk int
On Sun, 26 Jan 2025 07:30:22 GMT, Alan Bateman wrote:
> Would you mind holding off until Tuesday to give time to get that done?
Sure, there is no rush with this PR. I'll wait.
-
PR Comment: https://git.openjdk.org/jdk/pull/22165#issuecomment-2615197062
On Tue, 21 Jan 2025 13:56:30 GMT, Eirik Bjørsnøs wrote:
>> Please review this cleanup PR which updates a total of 12 links to external
>> documentation or references in `java.base` to use https instead of plain
>> text http.
>>
>> Links in `java.security` and `share/data/tzdata` are excluded f
On Fri, 24 Jan 2025 22:42:27 GMT, Chen Liang wrote:
>> This is the last piece in the API documentation improvement of the
>> Class-File API.
>>
>> This includes general documentation about transforms, models (and
>> traversals), options, constants, and CodeBuilder factories. In particular,
>
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of various Float16 operations through inline expansion or
> patt
42 matches
Mail list logo
