On Fri, 24 Jan 2025 23:56:46 GMT, Justin Lu <j...@openjdk.org> wrote:
> Please review this PR which improves the time measurement for cut-over time
> comparisons when building the available set of currencies in
> _java.util.Currency._ Currently, a new time was measured for each special
> case currency. This PR updates the behavior to use the same time for all such
> cases
Looks good. Please update the copyright year to 2025
src/java.base/share/classes/java/util/Currency.java line 447:
> 445: synchronized(Currency.class) {
> 446: if (available == null) {
> 447: // reuse same time for all special case cut-over date
> checks
The comment is correct, but it might not be necessary, as it would not be
significant unless one knows the background
-------------
PR Review: https://git.openjdk.org/jdk/pull/23309#pullrequestreview-2576192283
PR Review Comment: https://git.openjdk.org/jdk/pull/23309#discussion_r1930978307
