Re: Request for Enhancement: java.io.Writer.of(Appendable) as an efficient alternative to java.io.StringWriter

2024-12-30 Thread Chen Liang
Hi Markus, Thanks for your analysis that a Writer can be seen as a composition as an Appendable, a Flushable, and a Closeable. Given this view, I think we should add a Writer.of(Appenable, Flushable, Closeable) to specify the 3 component behaviors of the returned writer. Each of the 3 arguments can

Re: RFR: 8342486: Implement JEP draft: Structured Concurrency (Fifth Preview) [v2]

2024-12-30 Thread Chen Liang
On Mon, 2 Dec 2024 20:18:27 GMT, Chen Liang wrote: >> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - Pull latest API docs + impl from loom repo >> - Merge branch 'master' into JDK-8342486 >>

Re: RFR: 8346872: tools/jpackage/windows/WinLongPathTest.java fails

2024-12-30 Thread Alexey Semenyuk
On Mon, 30 Dec 2024 21:25:20 GMT, Alexey Semenyuk wrote: > Skip the test (throw `jtreg.SkippedException`) if the volume that owns the > test's work directory doesn't support DOS file names. @MBaesken please try the fix in your test environment. - PR Comment: https://git.openjdk.or

RFR: 8346872: tools/jpackage/windows/WinLongPathTest.java fails

2024-12-30 Thread Alexey Semenyuk
Skip the test (throw `jtreg.SkippedException`) if the volume that owns the test's work directory doesn't support DOS file names. - Commit messages: - 8346872: tools/jpackage/windows/WinLongPathTest.java fails Changes: https://git.openjdk.org/jdk/pull/22896/files Webrev: https://w

Re: RFR: 8345668: ZoneOffset.ofTotalSeconds performance regression [v3]

2024-12-30 Thread Brett Okken
On Fri, 27 Dec 2024 23:24:46 GMT, Chen Liang wrote: >>> For sure we should use result of `putIfAbsent` >> >> Drive-by comment... >> >> From what i can infer, the performance regression being addressed here is >> caused in part by the fact that (for example) >> `ConcurrentHashMap.computeIfAbse

Re: RFR: 8342868: Errors related to unused code on Windows after 8339120 in core libs [v2]

2024-12-30 Thread Julian Waters
On Thu, 31 Oct 2024 05:43:11 GMT, Julian Waters wrote: >> After 8339120, gcc began catching many different instances of unused code in >> the Windows specific codebase. Some of these seem to be bugs. I've taken the >> effort to mark out all the relevant globals and locals that trigger the >> u

[jdk24] Integrated: 8346667: Doccheck: warning about missing before

2024-12-30 Thread Nizar Benalla
On Fri, 20 Dec 2024 10:21:34 GMT, Nizar Benalla wrote: > Hi all, > > This pull request contains a backport of commit > [054c644e](https://github.com/openjdk/jdk/commit/054c644ea6ea38e54abc81e231977106d04bb69e) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit be