On Mon, 2 Dec 2024 20:18:27 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - Pull latest API docs + impl from loom repo >> - Merge branch 'master' into JDK-8342486 >> - Sync up from loom repo >> - Initial commit > > src/java.base/share/classes/java/util/concurrent/StructuredTaskScope.java > line 386: > >> 384: * method can be used to get the result. This is a terminal >> state. >> 385: */ >> 386: SUCCESS, > > We should use all adjectives or all nouns for the enum constants. Since > `UNAVAILABLE` is too hard to convert to a noun, we can consider renaming > `SUCCESS` to `SUCCESSFUL`. > > https://mail.openjdk.org/pipermail/loom-dev/2024-December/007361.html For context, the current name is chosen for parity with [Future.State](https://github.com/openjdk/jdk/blob/24c5ff7ba58cb7cf93df07f81484cd8fae60e31e/src/java.base/share/classes/java/util/concurrent/Future.java#L251). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21934#discussion_r1899924837
