On Mon, 25 Nov 2024 00:33:41 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change that proposes to address the issue
> noted in https://bugs.openjdk.org/browse/JDK-8344908?
>
> With this change, the URLClassPath will no longer propagate the
> `IllegalArgumentException` thrown wh
On Fri, 22 Nov 2024 14:31:23 GMT, Jorn Vernee wrote:
> Allow `captureCallState` and `critical(true)` linker options to be combined.
> This allows passing a Java array to capture call state.
>
> One caveat is that the linker expects the memory to be aligned, which means
> that at least an `int[
On Thu, 28 Nov 2024 00:17:43 GMT, Aleksei Efimov wrote:
> The proposed change cleans-up `SecurityManager`, `doPriviledged`, and
> `AccessController` usages from `java.naming`, `jdk.naming.rmi` and
> `jdk.naming.dns` modules.
>
> One noteworthy change: The `java.naming.rmi.security.manager` JND
On Wed, 27 Nov 2024 23:10:15 GMT, Chen Liang wrote:
> Remove the redundant `@enablePreview` and `--enable-preview` flags for
> enabling ClassFile API in the tests. The remainder of these flags in all
> tests seem to serve preview APIs (such as ScopedValue) or language features
> (primitive pa
On Tue, 26 Nov 2024 06:56:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change that proposes to address the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8344908?
>>
>> With this change, the URLClassPath will no longer propagate the
>> `IllegalArgumentException` thro
On Tue, 26 Nov 2024 06:56:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change that proposes to address the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8344908?
>>
>> With this change, the URLClassPath will no longer propagate the
>> `IllegalArgumentException` thro
On Sun, 6 Oct 2024 02:35:45 GMT, SendaoYan wrote:
> Hi all,
> The newly added test `java/foreign/TestUpcallStress.java` call
> `System.loadLibrary("TestUpcall")` load native library, so this test should
> mark as `/native`.
> The change has been verified locally, trivial fix, no risk.
LGTM. I'
On Wed, 27 Nov 2024 23:10:15 GMT, Chen Liang wrote:
> Remove the redundant `@enablePreview` and `--enable-preview` flags for
> enabling ClassFile API in the tests. The remainder of these flags in all
> tests seem to serve preview APIs (such as ScopedValue) or language features
> (primitive pa
This PR proposes to check for empty layouts in the fallback linker and then
prevent them from being forwarded.
Passes tier5 linker tests.
-
Commit messages:
- Fix fallback linker issues
Changes: https://git.openjdk.org/jdk/pull/22417/files
Webrev: https://webrevs.openjdk.org/?re
On Wed, 27 Nov 2024 16:12:04 GMT, Quan Anh Mai wrote:
> Hi,
>
> This patch resolves some issues I found that the tests wrongly assume
> sufficient alignment from the segment returned by `Arena::allocate`.
>
> Please take a look and leave your reviews, thanks a lot.
This pull request has now b
On Wed, 27 Nov 2024 18:56:02 GMT, Maurizio Cimadamore
wrote:
>> Hi,
>>
>> This patch resolves some issues I found that the tests wrongly assume
>> sufficient alignment from the segment returned by `Arena::allocate`.
>>
>> Please take a look and leave your reviews, thanks a lot.
>
> Marked as
On Wed, 20 Nov 2024 10:46:54 GMT, Sorna Sarathi wrote:
> This PR adds missing Classpath exception in several files.
>
> JBS Issue: [JDK-8334611](https://bugs.openjdk.org/browse/JDK-8344611)
@jerboaa can we get one more approval ?
-
PR Comment: https://git.openjdk.org/jdk/pull/2227
> When lots of classes are loaded during `java -Xshare:dump`, the internal
> arrays used by some of the HashMaps and ArrayLists become too large to be
> archived by CDS (> 256KB).
>
> At the very end of Java bytecode execution during `java -Xshare:dump`, we
> used to call `clear()` on these tab
On Thu, 28 Nov 2024 02:21:55 GMT, David Holmes wrote:
>> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783)
>> was integrated, the handling of certain symbol lookup code can be
>> simplified. The old code needed to support 32-bit Windows, where names had a
>> trailing `@
On Tue, 26 Nov 2024 06:36:44 GMT, David Holmes wrote:
> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) was
> integrated, the handling of certain symbol lookup code can be simplified. The
> old code needed to support 32-bit Windows, where names had a trailing
> `@`. W
On Thu, 28 Nov 2024 02:21:55 GMT, David Holmes wrote:
>> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783)
>> was integrated, the handling of certain symbol lookup code can be
>> simplified. The old code needed to support 32-bit Windows, where names had a
>> trailing `@
On Thu, 28 Nov 2024 01:54:10 GMT, Kim Barrett wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update src/java.base/share/native/libjava/NativeLibraries.c
>>
>> Co-authored-by: Alex Menkov <69548902+alexmen...@
> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) was
> integrated, the handling of certain symbol lookup code can be simplified. The
> old code needed to support 32-bit Windows, where names had a trailing
> `@`. When this special case now is removed, some streamlining
On Wed, 27 Nov 2024 05:20:16 GMT, David Holmes wrote:
>> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783)
>> was integrated, the handling of certain symbol lookup code can be
>> simplified. The old code needed to support 32-bit Windows, where names had a
>> trailing `@
The proposed change cleans-up `SecurityManager`, `doPriviledged`, and
`AccessController` usages from `java.naming`, `jdk.naming.rmi` and
`jdk.naming.dns` modules.
One noteworthy change: The `java.naming.rmi.security.manager` JNDI environment
property can be used to setup the `SecurityManager`:
On Thu, 31 Oct 2024 07:15:16 GMT, Taizo Kurashige wrote:
> For this reason, I use Cygwin's `df`.
Note that the proposed version, while it _does_ work in Cygwin, does **not**
work in WSL 1.
-
PR Comment: https://git.openjdk.org/jdk/pull/21799#issuecomment-2505054032
On Thu, 28 Nov 2024 00:03:32 GMT, Brian Burkhalter wrote:
> If there were also a simpler way to handle the empty drive case, that would
> be good.
Actually this simple patch appears to fix the problem with a CD drive attached
whether it is empty or contains a CD:
--- a/test/jdk/java/io/File/G
> This proposed change would move the native objects required for NIO file
> interaction from the libnio native library to the libjava native library on
> Linux, macOS, and Windows.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase. The pull request
On Thu, 31 Oct 2024 07:15:16 GMT, Taizo Kurashige wrote:
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't g
On Tue, 26 Nov 2024 08:57:04 GMT, Jonathan Lampérth wrote:
>> Very similar and related to: https://bugs.openjdk.org/browse/JDK-8034066
>>
>> This PR includes changes to ensure the indentation of `LineNumberTable` and
>> `LocalVariableTable` behave in the same way both for the `javap -verbose`
Remove the redundant `@enablePreview` and `--enable-preview` flags for enabling
ClassFile API in the tests. The remainder of these flags in all tests seem to
serve preview APIs (such as ScopedValue) or language features (primitive
pattern, module imports, etc.), or testing the enable preview fl
On Wed, 27 Nov 2024 22:08:06 GMT, Maurizio Cimadamore
wrote:
> While I don't disagree with the fix, there's several tests in this folder
> that also depends on native libraries. Perhaps we should fix them all?
For instance, `TestCriticalUpcall` and `TestArrayStruct` both lack the `native`
key
On Sun, 6 Oct 2024 02:35:45 GMT, SendaoYan wrote:
> Hi all,
> The newly added test `java/foreign/TestUpcallStress.java` call
> `System.loadLibrary("TestUpcall")` load native library, so this test should
> mark as `/native`.
> The change has been verified locally, trivial fix, no risk.
While I
On Wed, 27 Nov 2024 16:17:46 GMT, Doug Lea wrote:
>> src/java.base/share/classes/java/util/concurrent/locks/StampedLock.java line
>> 1272:
>>
>>> 1270: if ((interrupted |= Thread.interrupted()) &&
>>> interruptible)
>>> 1271: break;
>>> 1272:
On Wed, 27 Nov 2024 20:01:01 GMT, Severin Gehwolf wrote:
>> Please review this fix to how patched modules are being handled when linking
>> from the run-time image. During review of
>> [JDK-8311302](https://bugs.openjdk.org/browse/JDK-8311302) it was pointed
>> out that module patching should
> Please review this fix to how patched modules are being handled when linking
> from the run-time image. During review of
> [JDK-8311302](https://bugs.openjdk.org/browse/JDK-8311302) it was pointed out
> that module patching should be detected earlier and the link should get
> aborted in that
On Fri, 22 Nov 2024 17:04:38 GMT, Severin Gehwolf wrote:
>> Please review this simple patch which adds a new external system property
>> `jdk.patched` when the runtime has been patched with the `--patch-module`
>> switch. This is useful for two reasons: 1) it allows one to determine at
>> run-
On Wed, 20 Nov 2024 14:26:27 GMT, Severin Gehwolf wrote:
> Please review this simple patch which adds a new external system property
> `jdk.patched` when the runtime has been patched with the `--patch-module`
> switch. This is useful for two reasons: 1) it allows one to determine at
> run-time
On Wed, 27 Nov 2024 16:57:49 GMT, Quan Anh Mai wrote:
>> test/jdk/java/foreign/TestByteBuffer.java line 414:
>>
>>> 412: ByteBuffer bb;
>>> 413: try (Arena arena = Arena.ofConfined()) {
>>> 414: MemorySegment segment = arena.allocate(bytes, Long.BYTES);
>>
>> Why doe
On Wed, 27 Nov 2024 16:12:04 GMT, Quan Anh Mai wrote:
> Hi,
>
> This patch resolves some issues I found that the tests wrongly assume
> sufficient alignment from the segment returned by `Arena::allocate`.
>
> Please take a look and leave your reviews, thanks a lot.
Marked as reviewed by jvern
On Wed, 27 Nov 2024 19:21:30 GMT, Maurizio Cimadamore
wrote:
>> Allow `captureCallState` and `critical(true)` linker options to be combined.
>> This allows passing a Java array to capture call state.
>>
>> One caveat is that the linker expects the memory to be aligned, which means
>> that at
On Fri, 22 Nov 2024 14:31:23 GMT, Jorn Vernee wrote:
> Allow `captureCallState` and `critical(true)` linker options to be combined.
> This allows passing a Java array to capture call state.
>
> One caveat is that the linker expects the memory to be aligned, which means
> that at least an `int[
On Wed, 27 Nov 2024 16:12:04 GMT, Quan Anh Mai wrote:
> Hi,
>
> This patch resolves some issues I found that the tests wrongly assume
> sufficient alignment from the segment returned by `Arena::allocate`.
>
> Please take a look and leave your reviews, thanks a lot.
Looks good. Normally, what
On Wed, 27 Nov 2024 05:20:16 GMT, David Holmes wrote:
>> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783)
>> was integrated, the handling of certain symbol lookup code can be
>> simplified. The old code needed to support 32-bit Windows, where names had a
>> trailing `@
On Wed, 27 Nov 2024 12:03:04 GMT, Jonathan Lampérth wrote:
> I tend to like this approach, especially if I were starting from scratch. But
> considering the current functionality may be depended on, I think the current
> solution is a decent trade off of increasing readability/uniformity, witho
On Mon, 25 Nov 2024 12:57:18 GMT, Jonathan Lampérth wrote:
> Very similar and related to: https://bugs.openjdk.org/browse/JDK-8034066
>
> This PR includes changes to ensure the indentation of `LineNumberTable` and
> `LocalVariableTable` behave in the same way both for the `javap -verbose` and
On Tue, 26 Nov 2024 08:57:04 GMT, Jonathan Lampérth wrote:
>> Very similar and related to: https://bugs.openjdk.org/browse/JDK-8034066
>>
>> This PR includes changes to ensure the indentation of `LineNumberTable` and
>> `LocalVariableTable` behave in the same way both for the `javap -verbose`
On Tue, 26 Nov 2024 08:57:04 GMT, Jonathan Lampérth wrote:
>> Very similar and related to: https://bugs.openjdk.org/browse/JDK-8034066
>>
>> This PR includes changes to ensure the indentation of `LineNumberTable` and
>> `LocalVariableTable` behave in the same way both for the `javap -verbose`
On Sat, 23 Nov 2024 01:38:00 GMT, Brent Christian wrote:
>> Yes, this is a test that says "User allocated lots of Cleaner-carrying
>> objects, and all of them are alive. See if GC chokes in this conditions."
>> This is similar to the cases we are seeing in our prod conditions: these
>> objects
On Wed, 27 Nov 2024 16:41:39 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> This patch resolves some issues I found that the tests wrongly assume
>> sufficient alignment from the segment returned by `Arena::allocate`.
>>
>> Please take a look and leave your reviews, thanks a lot.
>
> test/jdk/java/forei
On Wed, 27 Nov 2024 16:12:04 GMT, Quan Anh Mai wrote:
> Hi,
>
> This patch resolves some issues I found that the tests wrongly assume
> sufficient alignment from the segment returned by `Arena::allocate`.
>
> Please take a look and leave your reviews, thanks a lot.
test/jdk/java/foreign/TestB
On Wed, 27 Nov 2024 15:29:48 GMT, Per Minborg wrote:
> This trivial PR proposes to use the parameter length for two tests as
> originally intended.
Marked as reviewed by jvernee (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22413#pullrequestreview-2465525789
On Wed, 27 Nov 2024 04:28:23 GMT, Taizo Kurashige wrote:
>> It's in my queue to review this and test it on actual hardware.
>
> @bplb
>
> Sorry to bother you, but how is the review going? I would appreciate your
> response.
@kurashige23 Sorry, I've been tied up with other things. I will try to
On Wed, 27 Nov 2024 15:34:50 GMT, Viktor Klang wrote:
>> This applies the same kinds of recovery on OOME (by spinning) and JVM
>> Exceptions (by cancelling) seen in AQS.
>
> src/java.base/share/classes/java/util/concurrent/locks/StampedLock.java line
> 1272:
>
>> 1270: if ((int
Hi,
This patch resolves some issues I found that the tests wrongly assume
sufficient alignment from the segment returned by `Arena::allocate`.
Please take a look and leave your reviews, thanks a lot.
-
Commit messages:
- Some java/foreign tests wrongly assume aligned memory
Chang
On Fri, 22 Nov 2024 23:44:11 GMT, Brian Burkhalter wrote:
> Make the memory used by internal temporary direct buffers not count towards
> the upper limit on direct buffer memory.
This pull request has now been integrated.
Changeset: 0312694c
Author:Brian Burkhalter
URL:
https://git
On Tue, 26 Nov 2024 20:55:03 GMT, Roger Riggs wrote:
> The `java.lang.Sytem.security` field no longer exists; remove it from the
> filterMap.
This pull request has now been integrated.
Changeset: 35bd2f35
Author:Roger Riggs
URL:
https://git.openjdk.org/jdk/commit/35bd2f354ea50ccda3
On Tue, 26 Nov 2024 18:07:41 GMT, Doug Lea wrote:
> This applies the same kinds of recovery on OOME (by spinning) and JVM
> Exceptions (by cancelling) seen in AQS.
src/java.base/share/classes/java/util/concurrent/locks/StampedLock.java line
1272:
> 1270: if ((interrupted |= Th
This trivial PR proposes to use the parameter length for two tests as
originally intended.
-
Commit messages:
- Fix parameter use
Changes: https://git.openjdk.org/jdk/pull/22413/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22413&range=00
Issue: https://bugs.openjdk.or
> Using SharedSecrets, I attempted to expose FileInputStream::path information.
> After implementing the fix, I validated the startup performance tests.
> Observed no consistent pattern of performance drops or gains, can disregard
> the occasional performance drop observed in 1 or 2 runs.
Prasa
On Mon, 25 Nov 2024 15:27:13 GMT, Per Minborg wrote:
> This PR proposes adding a _JDK-internal_ method for calculating hash codes
> for content in a `MemorySegment`.
>
> The internal method uses a polynomial 32-bit hash function equivalent to
> `Arrays::hashCode`. The new method is almost two
On Wed, 27 Nov 2024 11:21:32 GMT, Maurizio Cimadamore
wrote:
>> This PR proposes adding a _JDK-internal_ method for calculating hash codes
>> for content in a `MemorySegment`.
>>
>> The internal method uses a polynomial 32-bit hash function equivalent to
>> `Arrays::hashCode`. The new method
On Tue, 26 Nov 2024 08:57:04 GMT, Jonathan Lampérth wrote:
>> Very similar and related to: https://bugs.openjdk.org/browse/JDK-8034066
>>
>> This PR includes changes to ensure the indentation of `LineNumberTable` and
>> `LocalVariableTable` behave in the same way both for the `javap -verbose`
On Tue, 26 Nov 2024 22:38:14 GMT, Roger Riggs wrote:
>> The `java.lang.Sytem.security` field no longer exists; remove it from the
>> filterMap.
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update copyright
Marked as rev
On Thu, 21 Nov 2024 18:35:56 GMT, Alexey Semenyuk wrote:
> Switched jpackage unit tests to use JUnit5.
> Got rid of dependencies on the "hamcrest".
This pull request has now been integrated.
Changeset: 4a22c1fe
Author:Alexey Semenyuk
URL:
https://git.openjdk.org/jdk/commit/4a22c1fef
Hi,
I'd like to present a new proposal for integration of NMT with OpenJDK's
native/core libraries. This is the third time that such a proposal appears on
the mailing lists. The first two proposals were initiated by Thomas Stüfe, so
thank you to him for taking this on first and opening the disc
On Mon, 28 Oct 2024 13:53:58 GMT, Jorn Vernee wrote:
> There is a subtle race in `UpcallLinker::on_exit` between copying of the old
> frame anchor back into place, and the GC. Since this copy is not atomic, it
> may briefly appear as if a thread has no last Java frame, while still in the
> `_t
On Wed, 27 Nov 2024 10:14:11 GMT, Maurizio Cimadamore
wrote:
> Something like this, yeah, if this is deemed useful
I did implement this locally, but I am not sure of its utility. The values in
`LineNumberTable` refer to PC locations, for which the number of opcodes does
not really provide muc
> Cgroup V1 subsustem fails to initialize mounted controllers properly in
> certain cases, that may lead to controllers left undetected/inactive. We
> observed the behavior in CloudFoundry deployments, it affects also host
> systems.
>
> The relevant /proc/self/mountinfo line is
>
>
> 2207 21
On Fri, 22 Nov 2024 14:31:23 GMT, Jorn Vernee wrote:
> Allow `captureCallState` and `critical(true)` linker options to be combined.
> This allows passing a Java array to capture call state.
>
> One caveat is that the linker expects the memory to be aligned, which means
> that at least an `int[
Allow `captureCallState` and `critical(true)` linker options to be combined.
This allows passing a Java array to capture call state.
One caveat is that the linker expects the memory to be aligned, which means
that at least an `int[]` has to be used (i.e. `byte[]` will no work).
This patch conta
On Mon, 25 Nov 2024 15:27:13 GMT, Per Minborg wrote:
> This PR proposes adding a _JDK-internal_ method for calculating hash codes
> for content in a `MemorySegment`.
>
> The internal method uses a polynomial 32-bit hash function equivalent to
> `Arrays::hashCode`. The new method is almost two
On Mon, 25 Nov 2024 15:27:13 GMT, Per Minborg wrote:
> This PR proposes adding a _JDK-internal_ method for calculating hash codes
> for content in a `MemorySegment`.
>
> The internal method uses a polynomial 32-bit hash function equivalent to
> `Arrays::hashCode`. The new method is almost two
On Wed, 27 Nov 2024 09:11:22 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> syste
On Wed, 27 Nov 2024 09:08:30 GMT, Sergey Chernyshev
wrote:
> Done. Please see the updated PR.
The metrics part still needs the update - in the cgroup version specific
`setPath()`.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/21808#discussion_r1860451322
On Wed, 27 Nov 2024 10:12:56 GMT, Maurizio Cimadamore
wrote:
> Something like this, yeah, if this is deemed useful
Or, if code is skipped, should we also skip code attributes? For the records,
I'm fine for these issues to be tackled also in separate PRs.
-
PR Comment: https://git
On Tue, 26 Nov 2024 09:11:54 GMT, Jonathan Lampérth wrote:
> Do you mean comething as simple as this just counting the number of
> instructions?
Something like this, yeah, if this is deemed useful
-
PR Comment: https://git.openjdk.org/jdk/pull/22359#issuecomment-2503469486
On Mon, 28 Oct 2024 13:53:58 GMT, Jorn Vernee wrote:
> There is a subtle race in `UpcallLinker::on_exit` between copying of the old
> frame anchor back into place, and the GC. Since this copy is not atomic, it
> may briefly appear as if a thread has no last Java frame, while still in the
> `_t
On Mon, 28 Oct 2024 13:53:58 GMT, Jorn Vernee wrote:
> There is a subtle race in `UpcallLinker::on_exit` between copying of the old
> frame anchor back into place, and the GC. Since this copy is not atomic, it
> may briefly appear as if a thread has no last Java frame, while still in the
> `_t
On Mon, 25 Nov 2024 09:44:33 GMT, Severin Gehwolf wrote:
> ```
> "echo '+memory' > /sys/fs/cgroup/memory/cgroup.subtree_control ; "
> ```
>
> ... relies on the user in the container image to be `root`. So depending on
> which base image is being used - by means of
> `-Djdk.test.docker.image.na
On Mon, 25 Nov 2024 09:40:03 GMT, Severin Gehwolf wrote:
> Version specific code can be had in `set_subsystem_path()` of the
> corresponding impl (like an earlier version of your patch). `lowest_limit`
> and `limit_cg_path` fixes are version agnostic and can and should be fixed in
> `CgroupUti
> Cgroup V1 subsustem fails to initialize mounted controllers properly in
> certain cases, that may lead to controllers left undetected/inactive. We
> observed the behavior in CloudFoundry deployments, it affects also host
> systems.
>
> The relevant /proc/self/mountinfo line is
>
>
> 2207 21
On Tue, 26 Nov 2024 22:38:14 GMT, Roger Riggs wrote:
>> The `java.lang.Sytem.security` field no longer exists; remove it from the
>> filterMap.
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update copyright
Marked as rev
On Fri, 15 Nov 2024 12:42:55 GMT, Alan Bateman wrote:
> No changes in this re-preview but need to bump the JEP number in the javadoc.
This pull request has now been integrated.
Changeset: 4ae6ce61
Author:Alan Bateman
URL:
https://git.openjdk.org/jdk/commit/4ae6ce61ea187d6b7aea87cb5e
79 matches
Mail list logo
