On Fri, 15 Nov 2024 18:12:31 GMT, Raffaello Giulietti
wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove redundant suppression
>
> src/java.base/share/classes/jdk/internal/util/random/RandomSupport.java line
On Fri, 15 Nov 2024 21:43:05 GMT, Roger Riggs wrote:
> I'm in the middle of cleanup up the rest of SM removal in java.lang.System,
> Runtime and that's already removed in the change set.
Thanks Roger, then I'll withdraw this PR. Can you add issue JDK-8344336 as an
issue to your PR?
--
On Fri, 15 Nov 2024 19:26:15 GMT, Naoto Sato wrote:
> Removing a `AccessController.doPrivileged()` call from jdk.charsets module
> after JEP486 integration.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22162#pullrequestreview-2439458103
On Fri, 15 Nov 2024 18:34:07 GMT, Alexey Semenyuk wrote:
>> Make jpackage test lib more practical. List of changes:
>>
>> Support multiple args and var args in `@Parameter` annotation:
>>
>> @Test
>> @Parameter({"12", "foo"})
>> @Parameter({"-89", "bar", "more"})
>> @Parameter({"-89", "bar", "m
On Fri, 15 Nov 2024 20:15:10 GMT, Naoto Sato wrote:
>> Removing a `AccessController.doPrivileged()` call from jdk.charsets module
>> after JEP486 integration.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed import
loo
On Fri, 15 Nov 2024 20:17:59 GMT, Naoto Sato wrote:
>> Removing a `AccessController.doPrivileged()` call from jdk.charsets module
>> after JEP486 integration.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed import
Mar
On Fri, 15 Nov 2024 20:17:59 GMT, Naoto Sato wrote:
>> Removing a `AccessController.doPrivileged()` call from jdk.charsets module
>> after JEP486 integration.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed import
Mar
On Fri, 15 Nov 2024 18:18:08 GMT, Alexey Semenyuk wrote:
> Move jpackage tests from "jdk.jpackage.tests" package to the default package.
>
> Remove `WindowsHelper.getTempDirectory()`. It is faulty and found limited
> use. Updated dependent tests accordingly.
@sashamatveev ptal
-
On Fri, 15 Nov 2024 23:23:39 GMT, Justin Lu wrote:
> Please review this PR which removes the lone `AccessController.doPrivileged`
> call from the _java.scripting_ module after JEP486 integration.
Marked as reviewed by naoto (Reviewer).
src/java.scripting/share/classes/javax/script/ScriptEngine
On Sat, 16 Nov 2024 00:03:23 GMT, Justin Lu wrote:
>> Please review this PR which removes the lone `AccessController.doPrivileged`
>> call from the _java.scripting_ module after JEP486 integration.
>
> Justin Lu has updated the pull request incrementally with one additional
> commit since the l
On Thu, 17 Oct 2024 01:37:01 GMT, Brian Burkhalter wrote:
>> Improve support for Windows directory junctions.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8069345: Add os.family == windows to tests
continue;
--
On Sat, 16 Nov 2024 00:03:23 GMT, Justin Lu wrote:
>> Please review this PR which removes the lone `AccessController.doPrivileged`
>> call from the _java.scripting_ module after JEP486 integration.
>
> Justin Lu has updated the pull request incrementally with one additional
> commit since the l
> Please review this PR which removes the lone `AccessController.doPrivileged`
> call from the _java.scripting_ module after JEP486 integration.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
remove local var 'sl'
-
Chang
On Fri, 15 Nov 2024 18:18:08 GMT, Alexey Semenyuk wrote:
> Move jpackage tests from "jdk.jpackage.tests" package to the default package.
>
> Remove `WindowsHelper.getTempDirectory()`. It is faulty and found limited
> use. Updated dependent tests accordingly.
This pull request has now been inte
On Fri, 15 Nov 2024 14:53:18 GMT, Alexey Semenyuk wrote:
>> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TestMethodSupplier.java
>> line 142:
>>
>>> 140: throw ex;
>>> 141: }
>>> 142: }
>>
>> Maybe move this code into `switch` statement under `default`?
On Fri, 15 Nov 2024 01:04:58 GMT, Shaojin Wen wrote:
>> The type of the Unsafe base offset constant is int, which may cause overflow
>> when adding int offsets, such as 8343925 (PR #22012). 8343984 (PR #22027)
>> fixes most of the offset overflows in JDK, but ArraysSupport and CRC32C are
>> st
On Fri, 15 Nov 2024 18:32:58 GMT, Roger Riggs wrote:
> This cleanup of the use of SecurityManager is in the jdk.unsupported module.
> Removed the permission check to call getReflectionFactory().
Thanks. I think these are all to clean up in ReflectionFactory.
-
Marked as reviewed b
When core reflection was migrated to be implemented by Method Handles, somehow,
the method handles are not used for native methods, which are generally
linkable by method handles. This causes significant performance regressions
when reflecting native methods, even if their overrides may be non-
On Fri, 15 Nov 2024 20:17:59 GMT, Naoto Sato wrote:
>> Removing a `AccessController.doPrivileged()` call from jdk.charsets module
>> after JEP486 integration.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed import
Upd
Please review this PR which removes the lone `AccessController.doPrivileged`
call from the _java.scripting_ module after JEP486 integration.
-
Commit messages:
- init
Changes: https://git.openjdk.org/jdk/pull/22170/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22170&rang
On Fri, 15 Nov 2024 18:18:08 GMT, Alexey Semenyuk wrote:
> Move jpackage tests from "jdk.jpackage.tests" package to the default package.
>
> Remove `WindowsHelper.getTempDirectory()`. It is faulty and found limited
> use. Updated dependent tests accordingly.
Looks good.
-
Marked
On Fri, 15 Nov 2024 22:11:17 GMT, Roger Riggs wrote:
> Removed use of SecurityManager to check permissions.
> Relaxed defensive copying of byte arrays (due to lack of SM)
src/java.base/share/classes/java/lang/LiveStackFrame.java line 1:
> 1: /*
Seems you removed "@throws SecurityException" for
On Fri, 15 Nov 2024 22:11:17 GMT, Roger Riggs wrote:
> Removed use of SecurityManager to check permissions.
> Relaxed defensive copying of byte arrays (due to lack of SM)
src/java.base/share/classes/java/lang/String.java line 843:
> 841:
> 842: // Trim the given byte array to the given len
> Remove use of doPrivileged and SecurityManager in java.util.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Correct @see link syntax in AbstractResourceBundleProvider
-
Changes:
- all: https://git.openjdk.org/jdk/pul
On Tue, 22 Oct 2024 16:19:48 GMT, Ioi Lam wrote:
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://openjdk.org/jeps/483).
>
>
> Note: this is a combined PR of the following individual PRs
> - https://github.com/openjdk/jdk/pull/20516
> - https://gith
On Fri, 15 Nov 2024 17:55:30 GMT, Chen Liang wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Do not need -ea -esa in tests, our testing infra adds them already
>
> src/java.base/share/classes/jdk/internal/ref/C
Removed use of SecurityManager to check permissions.
Relaxed defensive copying of byte arrays (due to lack of SM)
-
Commit messages:
- 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker
Changes: https://git.openjdk.org/jdk/pull/22168/files
Webrev: https://webrev
On Fri, 15 Nov 2024 18:32:58 GMT, Roger Riggs wrote:
> This cleanup of the use of SecurityManager is in the jdk.unsupported module.
> Removed the permission check to call getReflectionFactory().
The `jdk.unsupported` module is not part of the specification.
The JEP and CSR covered the removal of
On Fri, 15 Nov 2024 21:36:24 GMT, Eirik Bjørsnøs wrote:
> Please review this trivial cleanup PR which removes the nested static private
> class `System.CallersHolder`.
>
> This class was used pre JEP486 to track callers of
> `System::setSecurityManager` such that warnings were printed only onc
On Fri, 15 Nov 2024 21:36:24 GMT, Eirik Bjørsnøs wrote:
> Please review this trivial cleanup PR which removes the nested static private
> class `System.CallersHolder`.
>
> This class was used pre JEP486 to track callers of
> `System::setSecurityManager` such that warnings were printed only onc
Please review this trivial cleanup PR which removes the nested static private
class `System.CallersHolder`.
This class was used pre JEP486 to track callers of `System::setSecurityManager`
such that warnings were printed only once per caller.
This seems like a leftover from JEP-486 which would b
On Fri, 15 Nov 2024 19:30:06 GMT, Aleksey Shipilev wrote:
>> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
>> linked list with segmented list of arrays. Arrays are easy targets for GC.
>> There are possible improvements here, most glaring is parallelism that is
>>
On Thu, 14 Nov 2024 06:28:25 GMT, Prasadrao Koppula
wrote:
>> src/java.base/share/classes/javax/net/ssl/TrustManagerFactory.java line 283:
>>
>>> 281: if (ks != null && SSLLogger.isOn &&
>>> SSLLogger.isOn("trustmanager")) {
>>> 282: String keystorePath = SharedSecrets
>>>
On Fri, 15 Nov 2024 20:56:37 GMT, Sean Mullan wrote:
>> I would prefer if we could deal with getSavedProperty as a wider area follow
>> up, since that would creep out of scope for this particular PR.
>>
>> Ok with you, @liach ?
>>
>> Perhaps @seanjmullan has input on how to deal with VM.getSav
> Improve the documentation for classfile instructions. Includes links to all
> opcodes, usage notes for instructions, and other various fixes.
Chen Liang has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains four commits:
- Merge branch
On Fri, 15 Nov 2024 15:43:08 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR to clean up `RandomSupport`, `ClassFileDumper` and
>> `StaticProperty` in the `jdk.internal.util` namespace:
>>
>> * `RandomSupport` is updated to replace an `AccessController::doPrivileged`
>> call with `Boolean:
On Fri, 15 Nov 2024 20:34:31 GMT, Eirik Bjørsnøs wrote:
>> Either way is fine. I think we probably need to review the majority of uses
>> of VM.savedPropoerty as they mostly relate to SM boot circularity. So we
>> will change this one either now or later.
>
> I would prefer if we could deal w
On Fri, 15 Nov 2024 17:09:11 GMT, Chen Liang wrote:
>> The use of the properties in ClassFileDumper is all in support of debug
>> capabilities and is not sensitive.
>
> Either way is fine. I think we probably need to review the majority of uses
> of VM.savedPropoerty as they mostly relate to S
On Thu, 14 Nov 2024 20:45:49 GMT, Roger Riggs wrote:
> Refactored to remove use of doPrivileged() and use of SecurityManager.
> The DefaultForkJoinWorkerThreadFactory no longer uses the SM to target a
> common thread pool.
>
> A careful review is requested.
This pull request has now been integ
On Thu, 14 Nov 2024 22:09:59 GMT, Roger Riggs wrote:
> Remove use of doPrivileged and SecurityManager in java.util.
This pull request has now been integrated.
Changeset: c5b6ed8c
Author:Roger Riggs
URL:
https://git.openjdk.org/jdk/commit/c5b6ed8ca0d4f9862fd6a890bcd457f73582696d
Stat
> Removing a `AccessController.doPrivileged()` call from jdk.charsets module
> after JEP486 integration.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
fixed import
-
Changes:
- all: https://git.openjdk.org/jdk/pull/22
On Fri, 15 Nov 2024 17:46:07 GMT, Roger Riggs wrote:
>> Refactored to remove use of doPrivileged() and use of SecurityManager.
>> The DefaultForkJoinWorkerThreadFactory no longer uses the SM to target a
>> common thread pool.
>>
>> A careful review is requested.
>
> Roger Riggs has updated the
On Fri, 15 Nov 2024 19:26:15 GMT, Naoto Sato wrote:
> Removing a `AccessController.doPrivileged()` call from jdk.charsets module
> after JEP486 integration.
Looks fine.
-
Marked as reviewed by bpb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22162#pullrequestreview-243
On Thu, 14 Nov 2024 17:32:40 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which removes code depending on SecurityManager from
> the `java.lang.module` and `jdk.internal.module` packages:
>
> * `ModuleFinder::ofSystem` is updated to not check the
> `"accessSystemModules"` RuntimePermissi
On Fri, 15 Nov 2024 17:49:58 GMT, Chen Liang wrote:
>> Improve the documentation for classfile instructions. Includes links to all
>> opcodes, usage notes for instructions, and other various fixes.
>
> Chen Liang has updated the pull request with a new target base due to a merge
> or a rebase.
Removing a `AccessController.doPrivileged()` call from jdk.charsets module
after JEP486 integration.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/22162/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22162&range=00
Issue: https://bugs.ope
On Fri, 15 Nov 2024 11:35:40 GMT, Pavel Rappo wrote:
>> Prepare for JDK 25.
>
> Pavel Rappo has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains nine ad
> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
> linked list with segmented list of arrays. Arrays are easy targets for GC.
> There are possible improvements here, most glaring is parallelism that is
> currently knee-capped by global synchronization. The synchroniz
On Fri, 15 Nov 2024 17:53:53 GMT, Chen Liang wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Do not need -ea -esa in tests, our testing infra adds them already
>
> src/java.base/share/classes/jdk/internal/ref/C
On Fri, 15 Nov 2024 15:46:53 GMT, Roger Riggs wrote:
>> Deleting it would also mean removing or modifying a bunch of j.u./tck tests.
>> Perhaps deprecation is enough.
>
> ok, for future cleanup
Although it is barely conceivable that someone is using it for the sake of
capturing the current cla
On Fri, 15 Nov 2024 17:52:28 GMT, Roger Riggs wrote:
>> Remove use of doPrivileged and SecurityManager in java.util.
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Correct @see link syntax in AbstractResourceBundleProvider
On Thu, 14 Nov 2024 18:24:59 GMT, Jatin Bhateja wrote:
>> This patch optimizes LongVector multiplication by inferring VPMUL[U]DQ
>> instruction for following IR pallets.
>>
>>
>>MulVL ( AndV SRC1, 0x) ( AndV SRC2, 0x)
>>MulVL (URShiftVL SRC1 , 32) (
On Fri, 15 Nov 2024 17:46:07 GMT, Roger Riggs wrote:
>> Refactored to remove use of doPrivileged() and use of SecurityManager.
>> The DefaultForkJoinWorkerThreadFactory no longer uses the SM to target a
>> common thread pool.
>>
>> A careful review is requested.
>
> Roger Riggs has updated the
On Fri, 15 Nov 2024 10:11:38 GMT, Francesco Nigro wrote:
> ...in case having a lock-free structure can be of any help, in JCTools we
> have...
We should continue to lock the same lock in `insert()` and `remove()`, as it
creates the _happens-before_ between the
thread registering the `Cleaner`,
On Fri, 15 Nov 2024 15:56:33 GMT, Roger Riggs wrote:
>> I agree on both counts with Alan: The FJP changes are not quite right, and
>> in any case should be postponed until after current FJP PR, and then further
>> simplified, which would be easiest if I did this.
>
> @DougLea If you prefer, I c
On Fri, 15 Nov 2024 18:32:58 GMT, Roger Riggs wrote:
> This cleanup of the use of SecurityManager is in the jdk.unsupported module.
> Removed the permission check to call getReflectionFactory().
Good. We might need a CSR as this changes API specification.
-
PR Review: https://git.
> Make jpackage test lib more practical. List of changes:
>
> Support multiple args and var args in `@Parameter` annotation:
>
> @Test
> @Parameter({"12", "foo"})
> @Parameter({"-89", "bar", "more"})
> @Parameter({"-89", "bar", "more", "moore"})
> public void testVarArg(int a, String b, String ..
This cleanup of the use of SecurityManager is in the jdk.unsupported module.
Removed the permission check to call getReflectionFactory().
-
Commit messages:
- 8344327: SM cleanup in jdk.unsupported ReflectionFactory
Changes: https://git.openjdk.org/jdk/pull/22158/files
Webrev: htt
Move jpackage tests from "jdk.jpackage.tests" package to the default package.
Remove `WindowsHelper.getTempDirectory()`. It is faulty and found limited use.
Updated dependent tests accordingly.
-
Commit messages:
- Rollback excessive change
- Rollback excessive change
- Unused co
On Fri, 15 Nov 2024 15:43:08 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR to clean up `RandomSupport`, `ClassFileDumper` and
>> `StaticProperty` in the `jdk.internal.util` namespace:
>>
>> * `RandomSupport` is updated to replace an `AccessController::doPrivileged`
>> call with `Boolean:
On Fri, 15 Nov 2024 15:43:08 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR to clean up `RandomSupport`, `ClassFileDumper` and
>> `StaticProperty` in the `jdk.internal.util` namespace:
>>
>> * `RandomSupport` is updated to replace an `AccessController::doPrivileged`
>> call with `Boolean:
On Fri, 15 Nov 2024 10:19:46 GMT, Aleksey Shipilev wrote:
>> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
>> linked list with segmented list of arrays. Arrays are easy targets for GC.
>> There are possible improvements here, most glaring is parallelism that is
>>
On Fri, 15 Nov 2024 17:32:38 GMT, Alan Bateman wrote:
>> ok, removing package access check
>
> I see you've removed it from AtomicIntegerFieldUpdater. There are also
> checkPackageAccess usages in AtomicLongFieldUpdater and
> AtomicReferenceFieldUpdater.
also removed
-
PR Review
> Refactored to remove use of doPrivileged() and use of SecurityManager.
> The DefaultForkJoinWorkerThreadFactory no longer uses the SM to target a
> common thread pool.
>
> A careful review is requested.
Roger Riggs has updated the pull request incrementally with one additional
commit since th
On Fri, 15 Nov 2024 15:47:43 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java
>> line 399:
>>
>>> 397: if ((ccl != null) && (ccl != cl) &&
>>> 398: ((cl == null) || !isAncestor(cl, ccl))) {
>>>
> This PR split out large array/set construction into separate factory methods
> to avoid oversized method trying to construct several of those.
>
> In order to do that, we will need to generate those help methods on demand in
> the class builder. Here we have two approach, one is for dedup set,
On Fri, 15 Nov 2024 01:02:49 GMT, Joe Darcy wrote:
> Looks fine; please manually verify the expected javac warnings are given for
> misuse of Float16 in non-value ways.
I manually and successfully tested compilation and execution of source that
synchronized on an instance of Float16.
On Fri, 15 Nov 2024 00:25:20 GMT, Paul Sandoz wrote:
> Annotate `Float16` with `jdk.internal.ValueBased`. This requires we export
> the package `jdk.internal` in module `java.base` to module`
> jdk.incubator.vector`.
>
> Doing so enables the compiler and runtime to report warnings about improp
On Fri, 15 Nov 2024 16:31:54 GMT, Roger Riggs wrote:
>> VM.save props should only be used if there is a bootstrap issue.
>> If tampering is a concern, then the property should be added to
>> StaticProperties.
>
> The use of the properties in ClassFileDumper is all in support of debug
> capabili
On Fri, 15 Nov 2024 15:43:08 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR to clean up `RandomSupport`, `ClassFileDumper` and
>> `StaticProperty` in the `jdk.internal.util` namespace:
>>
>> * `RandomSupport` is updated to replace an `AccessController::doPrivileged`
>> call with `Boolean:
This PR permanently disable remote code downloading in JNDI/LDAP and JNDI/RMI
JDK providers, and contains the following changes:
- The following two properties are removed:
- `com.sun.jndi.ldap.object.trustURLCodebase`
- `com.sun.jndi.rmi.object.trustURLCodebase`
- JNDIs object factories l
On Fri, 15 Nov 2024 16:06:41 GMT, Roger Riggs wrote:
>> Remove use of doPrivileged and SecurityManager in java.util.
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Applied suggestions from review comments
src/java.base/sha
On Fri, 15 Nov 2024 16:38:20 GMT, Ioi Lam wrote:
>> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://openjdk.org/jeps/483).
>>
>>
>> Note: this is a combined PR of the following individual PRs
>> - https://github.com/openjdk/jdk/pull/20516
>> - https
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://openjdk.org/jeps/483).
>
>
> Note: this is a combined PR of the following individual PRs
> - https://github.com/openjdk/jdk/pull/20516
> - https://github.com/openjdk/jdk/pull/20517
> - https://github.co
On Fri, 15 Nov 2024 16:28:13 GMT, Roger Riggs wrote:
>> VM saved props is still better imo as user code cannot tamper it with
>> System.setProperty.
>
> VM.save props should only be used if there is a bootstrap issue.
> If tampering is a concern, then the property should be added to
> StaticPro
On Fri, 15 Nov 2024 16:23:28 GMT, Chen Liang wrote:
>> @liach Does this mean we can/should use `System.getProperty` here?
>
> VM saved props is still better imo as user code cannot tamper it with
> System.setProperty.
VM.save props should only be used if there is a bootstrap issue.
If tampering
On Fri, 15 Nov 2024 16:15:02 GMT, Chen Liang wrote:
>> src/java.base/share/classes/jdk/internal/util/ClassFileDumper.java line 82:
>>
>>> 80:
>>> 81: private ClassFileDumper(String key, String path) {
>>> 82: /*
>>
>> The comment might still be relevant if changed to System.getProp
On Fri, 15 Nov 2024 16:21:10 GMT, Eirik Bjørsnøs wrote:
>> It's fine now: previously user defined security manager was effectively
>> loading user code that uses java.lang.invoke, now users cannot specify
>> security managers, so this problem does not exist any more.
>
> @liach Does this mean w
On Fri, 15 Nov 2024 16:15:02 GMT, Chen Liang wrote:
>> src/java.base/share/classes/jdk/internal/util/ClassFileDumper.java line 82:
>>
>>> 80:
>>> 81: private ClassFileDumper(String key, String path) {
>>> 82: /*
>>
>> The comment might still be relevant if changed to System.getProp
On Fri, 15 Nov 2024 15:58:36 GMT, Roger Riggs wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove redundant suppression
>
> src/java.base/share/classes/jdk/internal/util/ClassFileDumper.java line 82:
>
>> 80:
On Tue, 12 Nov 2024 21:45:41 GMT, Brian Burkhalter wrote:
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
This pull request has now been integrated.
Changeset: 0b9b82af
Author:Brian Burkhalter
URL:
https://git.openjdk.org/jdk/commit/0b9b82af0376a3e81c118e9219b
> Remove use of doPrivileged and SecurityManager in java.util.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Applied suggestions from review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/22122/files
-
On Fri, 15 Nov 2024 14:50:21 GMT, Magnus Ihse Bursie wrote:
>> Currently, the man pages are stored as troff (a text format) in the open
>> repo, and a content-wise identical copy is stored as markdown (another text
>> format) in the closed repo.
>>
>> Since markdown is preferred to troff in te
On Fri, 15 Nov 2024 15:43:08 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR to clean up `RandomSupport`, `ClassFileDumper` and
>> `StaticProperty` in the `jdk.internal.util` namespace:
>>
>> * `RandomSupport` is updated to replace an `AccessController::doPrivileged`
>> call with `Boolean:
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://openjdk.org/jeps/483).
>
>
> Note: this is a combined PR of the following individual PRs
> - https://github.com/openjdk/jdk/pull/20516
> - https://github.com/openjdk/jdk/pull/20517
> - https://github.co
On Fri, 15 Nov 2024 15:42:29 GMT, Adam Sotona wrote:
> jdk.internal.java.PreviewFeature.CLASSFILE_API has been accidentally removed
> with JDK-8334714, however it should remain until used in bootstrap build.
>
> Please review.
>
> Thank you,
> Adam
This pull request has now been integrated.
On Fri, 15 Nov 2024 15:42:29 GMT, Adam Sotona wrote:
> jdk.internal.java.PreviewFeature.CLASSFILE_API has been accidentally removed
> with JDK-8334714, however it should remain until used in bootstrap build.
>
> Please review.
>
> Thank you,
> Adam
I missed it too.
Thanks!
-
PR
On Fri, 15 Nov 2024 15:42:29 GMT, Adam Sotona wrote:
> jdk.internal.java.PreviewFeature.CLASSFILE_API has been accidentally removed
> with JDK-8334714, however it should remain until used in bootstrap build.
>
> Please review.
>
> Thank you,
> Adam
Sorry for forgetting to leave that review ea
On Fri, 15 Nov 2024 13:30:34 GMT, Doug Lea wrote:
>> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1108:
>>
>>> 1106: implements ForkJoinWorkerThreadFactory {
>>> 1107: public final ForkJoinWorkerThread newThread(ForkJoinPool
>>> pool) {
>>> 1108:
> Refactored to remove use of doPrivileged() and use of SecurityManager.
> The DefaultForkJoinWorkerThreadFactory no longer uses the SM to target a
> common thread pool.
>
> A careful review is requested.
Roger Riggs has updated the pull request incrementally with one additional
commit since th
> Make jpackage test lib more practical. List of changes:
>
> Support multiple args and var args in `@Parameter` annotation:
>
> @Test
> @Parameter({"12", "foo"})
> @Parameter({"-89", "bar", "more"})
> @Parameter({"-89", "bar", "more", "moore"})
> public void testVarArg(int a, String b, String ..
On Fri, 15 Nov 2024 07:23:23 GMT, Alan Bateman wrote:
>> Refactored to remove use of doPrivileged() and use of SecurityManager.
>> The DefaultForkJoinWorkerThreadFactory no longer uses the SM to target a
>> common thread pool.
>>
>> A careful review is requested.
>
> src/java.base/share/classes
On Fri, 15 Nov 2024 13:30:34 GMT, Doug Lea wrote:
>> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1108:
>>
>>> 1106: implements ForkJoinWorkerThreadFactory {
>>> 1107: public final ForkJoinWorkerThread newThread(ForkJoinPool
>>> pool) {
>>> 1108:
On Fri, 15 Nov 2024 13:41:09 GMT, Doug Lea wrote:
>> This class is currently meaningless, perhaps it should be carefully removed
>> and the documentation for `priviledgedCallable` should be updated.
>
> Deleting it would also mean removing or modifying a bunch of j.u./tck tests.
> Perhaps depre
jdk.internal.java.PreviewFeature.CLASSFILE_API has been accidentally removed
with JDK-8334714, however it should remain until used in bootstrap build.
Please review.
Thank you,
Adam
-
Commit messages:
- 8344314: Revert removal of jdk.internal.java.PreviewFeature.CLASSFILE_API
Cha
On Fri, 15 Nov 2024 15:33:35 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 78:
>>
>>> 76: STRUCTURED_CONCURRENCY,
>>> 77: @JEP(number=466, title="ClassFile API", status="Second Preview")
>>> 78: CLASSFILE_API,
>>
>> Ju
On Fri, 15 Nov 2024 15:01:13 GMT, Chen Liang wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove redundant suppression
>
> src/java.base/share/classes/jdk/internal/util/ClassFileDumper.java line 129:
>
>> 127
> Please review this PR to clean up `RandomSupport`, `ClassFileDumper` and
> `StaticProperty` in the `jdk.internal.util` namespace:
>
> * `RandomSupport` is updated to replace an `AccessController::doPrivileged`
> call with `Boolean::getBoolean`. (Existing code uses
> `String::equalsIgnoreCase`
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote:
>> Currently, the man pages are stored as troff (a text format) in the open
>> repo, and a content-wise identical copy is stored as markdown (another text
>> format) in the closed repo.
>>
>> Since markdown is preferred to troff in te
> As a prerequisite for Hermetic Java, we need a statically linked `java`
> launcher. It should behave like the normal, dynamically linked `java`
> launcher, except that all JDK native libraries should be statically, not
> dynamically, linked.
>
> This patch is the first step towards this goal.
1 - 100 of 153 matches
Mail list logo
