Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v8]

2024-11-02 Thread Jiangli Zhou
On Sat, 2 Nov 2024 01:05:27 GMT, Jiangli Zhou wrote: > > > I finally noticed that you are testing a precompiled HelloWorld class, > > > and I have been running with a source file argument to have java compile > > > it on the fly. > > > When I try using a pre-compiled HelloWorld, the linux port

Re: RFR: 8343478: Remove unnecessary @SuppressWarnings annotations (core-libs) [v2]

2024-11-02 Thread Archie Cobbs
> Please review this patch which removes unnecessary `@SuppressWarnings` > annotations. Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains fo

Re: RFR: 8335991: Implement Simple Source Files and Instance Main Methods (Fourth Preview)

2024-11-02 Thread Jaikiran Pai
On Sat, 2 Nov 2024 17:08:41 GMT, Jan Lahoda wrote: > What Jaikiran is speaking about is the enum constant name, which hopefully(!) > does not have a meaning outside of the JDK. I had looked around the rendered javadoc and a few other places and I didn't notice the enum name showing up anywhere

Re: RFR: 8343437: ClassDesc.of incorrectly permitting empty names [v4]

2024-11-02 Thread Mandy Chung
On Sat, 2 Nov 2024 00:32:49 GMT, Chen Liang wrote: >> In the patch for [JDK-8338544](https://bugs.openjdk.org/browse/JDK-8338544) >> #20665, the validation methods `validateBinaryClassName` and >> `validateInternalClassName` only checks if a separator char is the initial >> or final char, or i

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v6]

2024-11-02 Thread ExE Boss
On Wed, 30 Oct 2024 19:28:32 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v15]

2024-11-02 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: ewrite the last section of the overwiew fo SortedMap documentation and a link fo NavigableMap

2024-11-02 Thread Chen Liang
In addition, I discovered that a few methods, subMap, headMap, tailMap, sequencedKeySet, keySet, can be provided default implementations with covariant overrides. This will bring convenience to both user implementations and API users, and adding covariant override is binary (but not source) com

Re: RFR: 8335991: Implement Simple Source Files and Instance Main Methods (Fourth Preview)

2024-11-02 Thread Jan Lahoda
On Sat, 2 Nov 2024 15:11:05 GMT, Alan Bateman wrote: >> src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 72: >> >>> 70: //--- >>> 71: @JEP(number=495, title="Simple Source Files and Instance Main >>> Methods", status="Fourth Preview") >>> 72: IMPLI

Re: ewrite the last section of the overwiew fo SortedMap documentation and a link fo NavigableMap

2024-11-02 Thread Chen Liang
I strongly agree. The use of SortedMap should be no longer preferred, like that for java.util.Stack/Vector. We should update the Javadoc to refer to NavigableMap as the main total-ordered version and refer to SortedMap as a legacy interface. In fact, we should probably override all SortedMap

RFR: 8343478: Remove unnecessary @SuppressWarnings annotations (core-libs)

2024-11-02 Thread Archie Cobbs
Please review this patch which removes unnecessary `@SuppressWarnings` annotations. - Commit messages: - Remove unnecessary @SuppressWarnings annotations. Changes: https://git.openjdk.org/jdk/pull/21852/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21852&range=00 Issue

Re: RFR: 8335991: Implement Simple Source Files and Instance Main Methods (Fourth Preview)

2024-11-02 Thread Alan Bateman
On Sat, 2 Nov 2024 10:41:23 GMT, Jaikiran Pai wrote: >> This is a partial implementation of JEP 495 - adjustments of the JEP >> metadata in `PreviewFeature`. There are no language changes associated with >> this JEP. Changes to the `java.io.IO` class are covered by >> https://github.com/openjd

RFR: 8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file

2024-11-02 Thread Alexey Semenyuk
Clean up of jpackage jtreg test declarations: - remove "@modules java.base/jdk.internal.util"; - remove `--add-opens` from @run; - replace "@library ../../../../helpers" and "@library ../helpers" with "@library /test/jdk/tools/jpackage/helpers"; - remove @library referring to unused libraries

Re: RFR: 8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file

2024-11-02 Thread Alexey Semenyuk
On Wed, 30 Oct 2024 19:07:54 GMT, Alexey Semenyuk wrote: > Clean up of jpackage jtreg test declarations: > - remove "@modules java.base/jdk.internal.util"; > - remove `--add-opens` from @run; > - replace "@library ../../../../helpers" and > "@library ../helpers" with "@library > /test/jdk/to

ewrite the last section of the overwiew fo SortedMap documentation and a link fo NavigableMap

2024-11-02 Thread Remi Forax
Hello, I was discussing with a student, she was trying to use the SortedMap interface but had trouble with tailMap() no being a strictly higher view from a key. The solution was to use NavigableMap instead of SortedMap because it provides more methods to get lower/higher subMap and entries from k

Integrated: 8340311: JPackage app-image exe launches multiple exe's in JDK 22+

2024-11-02 Thread Alexey Semenyuk
On Sat, 26 Oct 2024 01:16:05 GMT, Alexey Semenyuk wrote: > Support `win.norestart` application property in jpackage .cfg file. If found > in the .cfg file and set to `true`, it forces the Windows app launcher not to > restart the launcher process. > > Collateral changes to the tests: > - Adde

Re: RFR: 8342775: [Graal] java/util/concurrent/locks/Lock/OOMEInAQS.java fails OOME thrown from the UncaughtExceptionHandler

2024-11-02 Thread Jaikiran Pai
On Mon, 28 Oct 2024 18:45:59 GMT, Tom Rodriguez wrote: > Deoptimization with escape analysis can fail when trying to rematerialize > objects as described in JDK-8227309. In this test this can happen in Xcomp > mode in the framework of the test resulting in a test failure. Making the > number

Re: RFR: 8335991: Implement Simple Source Files and Instance Main Methods (Fourth Preview)

2024-11-02 Thread Jaikiran Pai
On Wed, 30 Oct 2024 13:01:29 GMT, Jan Lahoda wrote: > This is a partial implementation of JEP 495 - adjustments of the JEP metadata > in `PreviewFeature`. There are no language changes associated with this JEP. > Changes to the `java.io.IO` class are covered by > https://github.com/openjdk/jdk

Re: RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v17]

2024-11-02 Thread Alexander Zuev
On Fri, 1 Nov 2024 18:44:02 GMT, Phil Race wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Remove superfluous check for 64-bit on Windows in >> MacroAssembler::call_clobbered_xmm_registers >> - Remove win