On Sat, 2 Nov 2024 10:41:23 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> This is a partial implementation of JEP 495 - adjustments of the JEP >> metadata in `PreviewFeature`. There are no language changes associated with >> this JEP. Changes to the `java.io.IO` class are covered by >> https://github.com/openjdk/jdk/pull/21693. > > src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 72: > >> 70: //--- >> 71: @JEP(number=495, title="Simple Source Files and Instance Main >> Methods", status="Fourth Preview") >> 72: IMPLICIT_CLASSES, > > Hello Jan, although it's just an internal enum name, do you think we should > rename it to be closer to the JEP's title or is it not worth it? The title also shows up in list of preview APIs in the javadoc so changing seems correct. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21787#discussion_r1826585785
