On Thu, 31 Oct 2024 02:23:24 GMT, Ioi Lam wrote:
>> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://openjdk.org/jeps/483).
>>
>>
>> Note: this is a combined PR of the following individual PRs
>> - https://github.com/openjdk/jdk/pull/20516
>> - https
On Thu, 31 Oct 2024 07:18:35 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> u
On Thu, 31 Oct 2024 19:07:42 GMT, Chris Plummer wrote:
> I do wonder if mutex support can be implemented for Windows with
> Acquire/ReleaseSRWLockExclusive.
A `CriticalSection` is a mutex. A RWLock is not a "mutex".
-
PR Comment: https://git.openjdk.org/jdk/pull/21616#issuecommen
> Hi,
>
> This patch makes `MemorySessionImpl.state` a `Stable` field so that liveness
> check of non-closeable scopes such as the global scope can be elided.
>
> Currently, the `state` field is overloaded with 2 responsibilities, to act as
> a communication device between `close` and `checkVal
On Thu, 31 Oct 2024 18:09:55 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch makes `MemorySessionImpl.state` a `Stable` field so that liveness
>> check of non-closeable scopes such as the global scope can be elided.
>>
>> Currently, the `state` field is overloaded with 2 responsibilities, to
On Thu, 31 Oct 2024 21:50:50 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Thu, 31 Oct 2024 10:52:22 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Thu, 31 Oct 2024 10:52:22 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Thu, 31 Oct 2024 18:09:55 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch makes `MemorySessionImpl.state` a `Stable` field so that liveness
>> check of non-closeable scopes such as the global scope can be elided.
>>
>> Currently, the `state` field is overloaded with 2 responsibilities, to
On Thu, 31 Oct 2024 10:24:34 GMT, Severin Gehwolf wrote:
>> I've changed it to AssertionError, but can change it to UncheckedIOException
>> instead. Will take another pass on this issue tomorrow.
>
> Having looked at this again the patch now consistently uses `AssertionError`
> which should be
On Thu, 31 Oct 2024 19:06:16 GMT, ExE Boss wrote:
> Because heap segments don’t have to be backed by an array.
I don't really know how to read this. We're asking a nio buffer to give us back
a memory segment. There's two kinds of memory segment: heap segments and native
segments (as the javado
> The Type and AnnotatedType hierarchies have been enigmatic to new users:
> users have no clue how to categorize arbitrary type objects, when it is safe
> to cast to more specific types, and the exact conditions for method contracts.
>
> A manifest is [JDK-8306039](https://bugs.openjdk.org/brow
On Thu, 31 Oct 2024 19:35:48 GMT, Chen Liang wrote:
>> The Type and AnnotatedType hierarchies have been enigmatic to new users:
>> users have no clue how to categorize arbitrary type objects, when it is safe
>> to cast to more specific types, and the exact conditions for method
>> contracts.
>
On Thu, 31 Oct 2024 05:52:07 GMT, Alexey Semenyuk wrote:
>> Support `win.norestart` application property in jpackage .cfg file. If found
>> in the .cfg file and set to `true`, it forces the Windows app launcher not
>> to restart the launcher process.
>>
>> Collateral changes to the tests:
>>
On Thu, 31 Oct 2024 13:29:35 GMT, Claes Redestad wrote:
> Benchmarks using Indify was added to the JMH microbenchmarks corpus in the
> JDK 8 timeframe. This adds overhead to the microbenchmarks build and has been
> blocking/slowing progress on some indy-based prototyping as the indify tool
> i
On Thu, 31 Oct 2024 13:29:35 GMT, Claes Redestad wrote:
> Benchmarks using Indify was added to the JMH microbenchmarks corpus in the
> JDK 8 timeframe. This adds overhead to the microbenchmarks build and has been
> blocking/slowing progress on some indy-based prototyping as the indify tool
> i
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
On Thu, 31 Oct 2024 10:52:22 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
(renamed the subject back to original)
On 10/31/24 9:12 AM, Fabian Meumertzheim wrote:
This has been discussed when we did JEP 400: UTF-8 by Default and
decided not to do it, mainly because it affects filename/path encoding.
Changing `sun.jnu.encoding` apart from Windows system encoding will mak
On Tue, 29 Oct 2024 23:13:21 GMT, Alexander Matveev
wrote:
> - Added check for "--mac-sign" argument in cases when we do in-place signing
> of predefined app image to avoid potential bugs.
This pull request has now been integrated.
Changeset: 34655c67
Author:Alexander Matveev
URL:
On Wed, 30 Oct 2024 01:02:25 GMT, Alexander Matveev
wrote:
> - All verbose log messages in Executor will only be shown if mode is not
> quite to eliminate partial and unnecessary log messages.
This pull request has now been integrated.
Changeset: 5a5d9c51
Author:Alexander Matveev
URL:
On Thu, 31 Oct 2024 19:40:06 GMT, Justin Lu wrote:
>> Please review this PR which aims to improve the _j.util.Currency_
>> specification by using `@apiNote` and `@implSpec`.
>>
>> A corresponding CSR has been filed.
>
> Justin Lu has updated the pull request incrementally with one additional
>
On Wed, 30 Oct 2024 21:17:26 GMT, Severin Gehwolf wrote:
> OK. It's currently part of the JEP, though which should explain what it does.
> Open for suggestions, though. I've taken inspiration from JVM features which
> use a similar `+/-` model.
I think it'd better to make this message human-un
On Thu, 31 Oct 2024 19:13:31 GMT, Dean Long wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix typos in comments
>
> src/hotspot/share/runtime/vframe.inline.hpp line 130:
>
>> 128: // Waited event
On Thu, 31 Oct 2024 21:11:39 GMT, Fredrik Bredberg
wrote:
>> There was one value that meant to be for the regular freeze from java. But
>> it was not used so I removed it.
>
> Fair enough, but I would prefer if you start at zero. Just so people like me
> don't start scratching their head tryin
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
On Mon, 28 Oct 2024 16:16:14 GMT, Calvin Cheung wrote:
>> Summary of changes:
>>
>> Before dumping info the archive, all the module names from `--add-modules`
>> will be sorted and then concatenated into one string with comma as the
>> separator between module names.
>>
>> During runtime, sam
On Wed, 16 Oct 2024 22:46:40 GMT, Calvin Cheung wrote:
> Summary of changes:
>
> Before dumping info the archive, all the module names from `--add-modules`
> will be sorted and then concatenated into one string with comma as the
> separator between module names.
>
> During runtime, same funct
> Please review this fix for cgroups-based metrics reporting in the
> `jdk.internal.platform` package. This fix is supposed to address wrong
> reporting of certain limits if the limits aren't set at the leaf nodes.
>
> For example, on cg v2, the memory limit interface file is `memory.max`.
> Co
On Thu, 31 Oct 2024 20:05:18 GMT, Patricio Chilano Mateo
wrote:
>> src/hotspot/share/runtime/continuation.hpp line 66:
>>
>>> 64:
>>> 65: enum preempt_kind {
>>> 66: freeze_on_monitorenter = 1,
>>
>> Is there a reason why the first enumerator doesn't start at zero?
>
> There was one val
On Thu, 31 Oct 2024 13:29:35 GMT, Claes Redestad wrote:
> Benchmarks using Indify was added to the JMH microbenchmarks corpus in the
> JDK 8 timeframe. This adds overhead to the microbenchmarks build and has been
> blocking/slowing progress on some indy-based prototyping as the indify tool
> i
On Thu, 31 Oct 2024 13:29:35 GMT, Claes Redestad wrote:
> Benchmarks using Indify was added to the JMH microbenchmarks corpus in the
> JDK 8 timeframe. This adds overhead to the microbenchmarks build and has been
> blocking/slowing progress on some indy-based prototyping as the indify tool
> i
On Thu, 31 Oct 2024 10:52:22 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Thu, 31 Oct 2024 20:12:06 GMT, Dean Long wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix typos in comments
>
> test/hotspot/gtest/nmt/test_vmatree.cpp line 34:
>
>> 32:
>> 33: using Tree = VMATre
On Thu, 31 Oct 2024 19:59:00 GMT, Dean Long wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix typos in comments
>
> src/java.base/share/classes/sun/security/ssl/X509TrustManagerImpl.java line
> 57:
>
On Wed, 16 Oct 2024 18:45:38 GMT, Alexey Semenyuk wrote:
> Make jpackage correctly handle the output directory (`--dest`) that is:
> - a subdirectory of the input directory;
> - the same as the input directory.
>
> Make jpackage correctly handle temp directory (`--temp`) that is:
> - a subdir
On Mon, 28 Oct 2024 10:16:40 GMT, Aleksey Shipilev wrote:
> This is forked from
> [JDK-8342642](https://bugs.openjdk.org/browse/JDK-8342642) and filed as a
> general issue for archived boxed Integer cache when it's recreated at
> runtime. In short, current code drops the entire primitive cache
On Thu, 31 Oct 2024 07:48:40 GMT, Aleksey Shipilev wrote:
>> This is forked from
>> [JDK-8342642](https://bugs.openjdk.org/browse/JDK-8342642) and filed as a
>> general issue for archived boxed Integer cache when it's recreated at
>> runtime. In short, current code drops the entire primitive c
On Thu, 31 Oct 2024 20:13:31 GMT, Dean Long wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix typos in comments
>
> src/java.base/linux/classes/sun/nio/ch/EPollSelectorImpl.java line 108:
>
>> 106:
On Wed, 30 Oct 2024 22:44:48 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Wed, 30 Oct 2024 12:48:02 GMT, Fredrik Bredberg
wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with four
>> additional commits since the last revision:
>>
>> - Rename set/has_owner_anonymous to set/has_anonymous_owner
>> - Fix comments in javaThread.hpp and Th
On Thu, 31 Oct 2024 04:49:06 GMT, Alexey Semenyuk wrote:
>> Make jpackage correctly handle the output directory (`--dest`) that is:
>> - a subdirectory of the input directory;
>> - the same as the input directory.
>>
>> Make jpackage correctly handle temp directory (`--temp`) that is:
>> - a
> Upgrading the CLDR to version 46.0. A corresponding CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Addresses review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21772/files
On Wed, 30 Oct 2024 22:44:48 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Tue, 29 Oct 2024 18:12:43 GMT, Naoto Sato wrote:
> Upgrading the CLDR to version 46.0. A corresponding CSR has also been drafted.
Thanks, Justin
> Left minor comments.
They are both leftovers. Removed.
-
PR Comment: https://git.openjdk.org/jdk/pull/21772#issuecomment-245071671
On Wed, 30 Oct 2024 22:44:48 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Thu, 31 Oct 2024 18:06:22 GMT, Quan Anh Mai wrote:
>> src/java.base/share/classes/jdk/internal/foreign/ConfinedSession.java line
>> 44:
>>
>>> 42: private int asyncReleaseCount = 0;
>>> 43:
>>> 44: static final VarHandle ASYNC_RELEASE_COUNT=
>>> MhUtil.findVarHandle(MethodHandles.l
On Tue, 29 Oct 2024 18:12:43 GMT, Naoto Sato wrote:
> Upgrading the CLDR to version 46.0. A corresponding CSR has also been drafted.
Data changes look to be CLDR 46. Went through the tests as well.
Change in build to add the aliases of the preferred value for a deprecated zone
LGTM.
Left minor
On Thu, 31 Oct 2024 19:35:48 GMT, Chen Liang wrote:
>> The Type and AnnotatedType hierarchies have been enigmatic to new users:
>> users have no clue how to categorize arbitrary type objects, when it is safe
>> to cast to more specific types, and the exact conditions for method
>> contracts.
>
> Please review this PR which aims to improve the _j.util.Currency_
> specification by using `@apiNote` and `@implSpec`.
>
> A corresponding CSR has been filed.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
CSR review: implNote -> im
On Thu, 31 Oct 2024 19:40:06 GMT, Justin Lu wrote:
>> Please review this PR which aims to improve the _j.util.Currency_
>> specification by using `@apiNote` and `@implSpec`.
>>
>> A corresponding CSR has been filed.
>
> Justin Lu has updated the pull request incrementally with one additional
>
> The Type and AnnotatedType hierarchies have been enigmatic to new users:
> users have no clue how to categorize arbitrary type objects, when it is safe
> to cast to more specific types, and the exact conditions for method contracts.
>
> A manifest is [JDK-8306039](https://bugs.openjdk.org/brow
On Wed, 30 Oct 2024 22:44:48 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Wed, 30 Oct 2024 22:44:48 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Thu, 31 Oct 2024 07:13:56 GMT, Julian Waters wrote:
> > I do wonder if mutex support can be implemented for Windows with
> > Acquire/ReleaseSRWLockExclusive. I know it's not strictly needed, but it
> > would be nice to have. Shame threads.h is not available with some Visual
> > Studio versi
On Thu, 31 Oct 2024 17:20:11 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 12 additional
>> co
On Thu, 31 Oct 2024 07:18:35 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> u
On Wed, 30 Oct 2024 21:12:42 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Thu, 31 Oct 2024 10:52:22 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Thu, 31 Oct 2024 17:03:31 GMT, Maurizio Cimadamore
wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix benchmarks
>
> src/java.base/share/classes/jdk/internal/foreign/SharedSession.java line 90:
>
>> 88:
On Thu, 31 Oct 2024 17:41:22 GMT, Maurizio Cimadamore
wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add LoopOverRandom benchmarks
>
> src/java.base/share/classes/jdk/internal/foreign/ConfinedSession.java line 44
On Thu, 31 Oct 2024 17:23:51 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch makes `MemorySessionImpl.state` a `Stable` field so that liveness
>> check of non-closeable scopes such as the global scope can be elided.
>>
>> Currently, the `state` field is overloaded with 2 responsibilities, to
> Hi,
>
> This patch makes `MemorySessionImpl.state` a `Stable` field so that liveness
> check of non-closeable scopes such as the global scope can be elided.
>
> Currently, the `state` field is overloaded with 2 responsibilities, to act as
> a communication device between `close` and `checkVal
On Thu, 31 Oct 2024 17:23:51 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch makes `MemorySessionImpl.state` a `Stable` field so that liveness
>> check of non-closeable scopes such as the global scope can be elided.
>>
>> Currently, the `state` field is overloaded with 2 responsibilities, to
On Thu, 31 Oct 2024 17:24:23 GMT, Quan Anh Mai wrote:
> For some reasons, the compiler really dislikes the unsafe loop.
On my slower machine, the difference between the variants is bigger:
BenchmarkMode Cnt Score Error Units
LoopOverRandom.segment_loop
On Thu, 31 Oct 2024 17:23:51 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch makes `MemorySessionImpl.state` a `Stable` field so that liveness
>> check of non-closeable scopes such as the global scope can be elided.
>>
>> Currently, the `state` field is overloaded with 2 responsibilities, to
On Wed, 30 Oct 2024 20:34:04 GMT, Justin Lu wrote:
> Please review this PR which aims to improve the _j.util.Currency_
> specification by using `@apiNote` and `@implNote`.
>
> A corresponding CSR has been filed.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.open
On Thu, 31 Oct 2024 14:32:46 GMT, Per Minborg wrote:
>> This PR proposes to add a small text segment on the
>> `MemorySegment::reinterpret` overloads that takes an Arena stating the
>> responsibility of actually freeing reinterpreted segments lies with the
>> *original* arena.
>
> Per Minborg
On Thu, 31 Oct 2024 14:32:46 GMT, Per Minborg wrote:
>> This PR proposes to add a small text segment on the
>> `MemorySegment::reinterpret` overloads that takes an Arena stating the
>> responsibility of actually freeing reinterpreted segments lies with the
>> *original* arena.
>
> Per Minborg
On Thu, 31 Oct 2024 17:23:51 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch makes `MemorySessionImpl.state` a `Stable` field so that liveness
>> check of non-closeable scopes such as the global scope can be elided.
>>
>> Currently, the `state` field is overloaded with 2 responsibilities, to
> Hi,
>
> This patch makes `MemorySessionImpl.state` a `Stable` field so that liveness
> check of non-closeable scopes such as the global scope can be elided.
>
> Currently, the `state` field is overloaded with 2 responsibilities, to act as
> a communication device between `close` and `checkVal
On Thu, 31 Oct 2024 14:04:01 GMT, Per Minborg wrote:
>> This PR proposes to improve `MemorySegment::ofBuffer` making it more
>> amenable to inlining and generally improving performance.
>>
>> Testing successfully on tier1-3
>
> Per Minborg has updated the pull request with a new target base due
On Thu, 31 Oct 2024 12:56:54 GMT, Per Minborg wrote:
>> This PR proposes to improve `MemorySegment::ofBuffer` making it more
>> amenable to inlining and generally improving performance.
>>
>> Testing successfully on tier1-3
>
> Per Minborg has updated the pull request incrementally with one add
On Thu, 31 Oct 2024 15:52:04 GMT, Quan Anh Mai wrote:
> Hi,
>
> This patch makes `MemorySessionImpl.state` a `Stable` field so that liveness
> check of non-closeable scopes such as the global scope can be elided.
>
> Currently, the `state` field is overloaded with 2 responsibilities, to act as
On Tue, 29 Oct 2024 16:52:45 GMT, Tom Rodriguez wrote:
> The notification that finalize is complete should be done after printing the
> message because in Xcomp mode there might be a significant delay at the
> println so the object hasn't actually been finalized yet.
It probably should be vola
On Wed, 30 Oct 2024 20:34:04 GMT, Justin Lu wrote:
> Please review this PR which aims to improve the _j.util.Currency_
> specification by using `@apiNote` and `@implNote`.
>
> A corresponding CSR has been filed.
LGTM
-
Marked as reviewed by naoto (Reviewer).
PR Review: https://g
On Thu, 31 Oct 2024 02:26:42 GMT, David Holmes wrote:
>> src/hotspot/share/runtime/objectMonitor.inline.hpp line 207:
>>
>>> 205: }
>>> 206:
>>> 207: inline bool ObjectMonitor::has_successor() {
>>
>> Why are _succ accesses atomic here when previously they were not?
>
> General convention is t
On Thu, 31 Oct 2024 16:34:41 GMT, Patricio Chilano Mateo
wrote:
>> General convention is that racily accessed variables should be accessed via
>> Atomic::load/store to make it clear(er) they are racy accesses. But I agree
>> it seems odd when direct accesses to `_succ` in the main cpp file are
On Thu, 31 Oct 2024 00:52:02 GMT, Dean Long wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix typos in comments
>
> src/hotspot/share/runtime/continuationJavaClasses.inline.hpp line 189:
>
>> 187:
>>
On Wed, 30 Oct 2024 23:22:42 GMT, Dean Long wrote:
>> `PreemptStatus` is meant to be used with `tryPreempt()` which is not
>> implemented yet, i.e. there is no method yet that maps between these values
>> and the PreemptStatus enum. The closest is `Continuation.pinnedReason` which
>> we do use
On Thu, 31 Oct 2024 02:33:30 GMT, Dean Long wrote:
> OK, so you're saying it's the stack adjustment that's the problem. It sounds
> like there is code that is using rsp instead of last_Java_sp to compute the
> frame boundary. Isn't that a bug that should be fixed?
>
It's not a bug, it's just th
On Wed, 30 Oct 2024 23:02:28 GMT, Dean Long wrote:
>> We read this value from the freeze/thaw code in several places. Since the
>> only compiled native frame we allow to freeze is Object.wait0 the old value
>> would be zero too. But I think the correct thing is to just set it to zero
>> always
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
On Thu, 31 Oct 2024 05:43:11 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> u
On Thu, 24 Oct 2024 21:08:26 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Wed, 30 Oct 2024 00:44:14 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
> This has been discussed when we did JEP 400: UTF-8 by Default and
> decided not to do it, mainly because it affects filename/path encoding.
> Changing `sun.jnu.encoding` apart from Windows system encoding will make
> apps not being able to access those files/directories (e.g. home
> directory) if
On Wed, 30 Oct 2024 19:28:32 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 31 Oct 2024 05:43:11 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> u
On Thu, 31 Oct 2024 15:00:25 GMT, Sergey Chernyshev
wrote:
> Cgroup V1 subsustem fails to initialize mounted controllers properly in
> certain cases, that may lead to controllers left undetected/inactive. We
> observed the behavior in CloudFoundry deployments, it affects also host
> systems.
Hi,
This patch makes `MemorySessionImpl.state` a `Stable` field so that liveness
check of non-closeable scopes such as the global scope can be elided.
Currently, the `state` field is overloaded with 2 responsibilities, to act as a
communication device between `close` and `checkValidState`, as w
On Wed, 30 Oct 2024 19:28:32 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 31 Oct 2024 07:48:40 GMT, Aleksey Shipilev wrote:
>> This is forked from
>> [JDK-8342642](https://bugs.openjdk.org/browse/JDK-8342642) and filed as a
>> general issue for archived boxed Integer cache when it's recreated at
>> runtime. In short, current code drops the entire primitive c
On Thu, 31 Oct 2024 07:32:01 GMT, Aleksey Shipilev wrote:
>> The runtime cache would only store the additional boxed Integers not in the
>> archived cache, without affecting the archived boxed Integers. Something
>> like the following would work (I didn't test all corner cases):
>>
>>
>>
Cgroup V1 subsustem fails to initialize mounted controllers properly in certain
cases, that may lead to controllers left undetected/inactive. We observed the
behavior in CloudFoundry deployments, it affects also host systems.
The relevant /proc/self/mountinfo line is
2207 2196 0:43
/system.sl
> This PR proposes to add a small text segment on the
> `MemorySegment::reinterpret` overloads that takes an Arena stating the
> responsibility of actually freeing reinterpreted segments lies with the
> *original* arena.
Per Minborg has updated the pull request incrementally with one additional
On Thu, 31 Oct 2024 13:56:42 GMT, Chen Liang wrote:
>> Benchmarks using Indify was added to the JMH microbenchmarks corpus in the
>> JDK 8 timeframe. This adds overhead to the microbenchmarks build and has
>> been blocking/slowing progress on some indy-based prototyping as the indify
>> tool i
> This PR proposes to add a small text segment on the
> `MemorySegment::reinterpret` overloads that takes an Arena stating the
> responsibility of actually freeing reinterpreted segments lies with the
> *original* arena.
Per Minborg has updated the pull request incrementally with two additional
On Thu, 31 Oct 2024 10:25:11 GMT, Maurizio Cimadamore
wrote:
> Do you refer to char buffers backed by Strings?
If so, I wouldn't worry much about that -- after all, the logic in the code
already detects this condition and throws an exception... so it's still heap
buffer vs. direct buffer IMHO
On Mon, 28 Oct 2024 15:29:33 GMT, Chen Liang wrote:
> There are currently some issues with our handling of "load constant"
> instructions: namely, there is some problem with writing unbounded/external
> constants and handling of entry index changes, that we currently generate
> invalid bytecod
1 - 100 of 141 matches
Mail list logo
