On Mon, 28 Oct 2024 10:16:40 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
> This is forked from > [JDK-8342642](https://bugs.openjdk.org/browse/JDK-8342642) and filed as a > general issue for archived boxed Integer cache when it's recreated at > runtime. In short, current code drops the entire primitive cache when the CDS > archived version of the cache is too short. This poses a problem with code > that uses CDS archived cache instances, since the boxed equality would break > when comparing the CDS-archived value and the IntegerCache value recreated at > runtime. > > Ioi suggested a fix here: > https://github.com/openjdk/jdk/pull/21672#issuecomment-2434359711. I > separately arrived to the same idea. This PR implements it. `IntegerCache` > gets the special treatment, because it is the only cache that can be tuned. > Other caches just prevent the use of bad archived cache (which I think should > realistically never happen) without re-creating it. > > I tested this patch with original reproducer from > [JDK-8342642](https://bugs.openjdk.org/browse/JDK-8342642) -- and it starts > to pass. > > Additional testing: > - [x] macos-aarch64-server-fastdebug, > [JDK-8342642](https://bugs.openjdk.org/browse/JDK-8342642) reproducer now > passes > - [x] macos-aarch64-server-fastdebug, new regression test fails without the > fix, passes with it > - [x] linux-aarch64-server-fastdebug, `all` This pull request has now been integrated. Changeset: 7c36fa7e Author: Aleksey Shipilev <sh...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/7c36fa7e175c01dd994cd8f1ef9fd942dbddbce0 Stats: 108 lines in 8 files changed: 75 ins; 8 del; 25 mod 8343019: Primitive caches must use boxed instances from the archive Reviewed-by: jiangli, vlivanov, iklam ------------- PR: https://git.openjdk.org/jdk/pull/21737
