On Thu, 26 Sep 2024 21:25:07 GMT, Phil Race wrote:
> build team have indicated they do not support --enable-ubsan
What 'build team' are you talking about ? Some Oracle internal build team?
The ubsan support came in 2023, so nothing new (change was from Justin King)
https://github.com/openjdk/jd
> This PR support a -k, --keep options like tar that allows jar to avoid
> override existing files.
Henry Jen has updated the pull request incrementally with one additional commit
since the last revision:
Address review feedbacks
-
Changes:
- all: https://git.openjdk.org/jdk/p
On Tue, 24 Sep 2024 19:16:17 GMT, Lance Andersen wrote:
>> Henry Jen has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains one commit:
>>
>> 8335912: Add an operation mode to the jar command when extracting to not
>> overwriting exis
On Wed, 25 Sep 2024 01:10:04 GMT, Shaojin Wen wrote:
>> A very small optimization, split the large method inflate, split the
>> infrequently used paths into a method inflateCHAR
>
> Shaojin Wen has updated the pull request with a new target base due to a
> merge or a rebase. The pull request no
> This PR split out large array/set construction into separate factory methods
> to avoid oversized method trying to construct several of those.
>
> In order to do that, we will need to generate those help methods on demand in
> the class builder. Here we have two approach, one is for dedup set,
> 1. Construct Frames directly without BitSet
> 2. Use Frame[] instead of ArrayList
> 3. Use EMPTY_FRAME_ARRAY for initialization. No need to allocate objects when
> there is no frame.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
c
On Thu, 26 Sep 2024 23:46:04 GMT, Joe Darcy wrote:
> The is the initial version of a PR to defined an anchor point and index term
> of "wrapper classes."
For now, of the wrapper classes, I only updated the Integer with the proposed
new wording. Once a final wording is determined, I'll make the
The is the initial version of a PR to defined an anchor point and index term of
"wrapper classes."
-
Commit messages:
- JDK-8341064: Define archor point and index term for "wrapper classes"
Changes: https://git.openjdk.org/jdk/pull/21215/files
Webrev: https://webrevs.openjdk.org/
On Thu, 26 Sep 2024 21:03:20 GMT, Phil Race wrote:
>> test/jdk/java/util/TimeZone/DefaultTimeZoneTest.java line 80:
>>
>>> 78: 6. Turn on "Adjust for daylight saving time automatically"
>>> 79:
>>> 80: If the local time in the control panel and test window are
>>> alw
On Wed, 25 Sep 2024 12:17:59 GMT, Matthias Baesken wrote:
> There is some old awt/2d coding where warnings occur when running with ubsan
> enabled binaries.
> However at most of these locations the coding should work (at least on our
> supported platform set) so the warnings can be disabled at
On Thu, 26 Sep 2024 16:25:21 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review: update wording of instructions
>
> test/jdk/java/util/TimeZone/DefaultTimeZoneTest.java line 80:
>
>> 78:
>
> but I also don't sense people beating down the doors for that (even if the
> language had range literals, like `0..<100`).
True, that what I was thinking also: "is iteration over numeric range is so
important to challenge general versatility of API?", but
for (int j=index; j (start, end) and
On Wed, 25 Sep 2024 22:58:11 GMT, Joe Darcy wrote:
> Add citation of the second edition of "Hacker's Delight".
This pull request has now been integrated.
Changeset: 8225a5f5
Author:Joe Darcy
URL:
https://git.openjdk.org/jdk/commit/8225a5f58a62ddf4acbb879bfcb53cf7bfd8542f
Stats:
On Thu, 26 Sep 2024 17:11:24 GMT, Nizar Benalla wrote:
> I ran it and all the tags seem to be correct.
Thank you!
-
PR Comment: https://git.openjdk.org/jdk/pull/19826#issuecomment-2377551118
> Please review this PR which removes usages of Applet within the corelibs
> tests.
>
> Most changes are removed comments/updated var names. The JBS issue lists more
> files than the ones included in this pull request, please see the comment on
> the JBS issue for the reason why they were not i
On Thu, 26 Sep 2024 17:24:18 GMT, Justin Lu wrote:
>> Please review this PR which removes usages of Applet within the corelibs
>> tests.
>>
>> Most changes are removed comments/updated var names. The JBS issue lists
>> more files than the ones included in this pull request, please see the
>>
On Thu, 26 Sep 2024 17:06:38 GMT, Daniel Fuchs wrote:
> `test/jdk/sun/net/www/ParseUtil_6380332.java`: shouldn't we actually keep
> this test? I see that the code in ParseUtil which is tested here is still
> there, and I don't think we'd want to touch ParseUtil given potential
> compatibility
On Thu, 26 Sep 2024 08:16:50 GMT, Adam Sotona wrote:
>> Class-File API is leaving preview.
>> This is a removal of all `@PreviewFeature` annotations from Class-File API.
>> It also bumps all `@since` tags and removes
>> `jdk.internal.javac.PreviewFeature.Feature.CLASSFILE_API`.
>>
>> Please rev
On Thu, 26 Sep 2024 17:00:18 GMT, Justin Lu wrote:
>> Please review this PR which removes usages of Applet within the corelibs
>> tests.
>>
>> Most changes are removed comments/updated var names. The JBS issue lists
>> more files than the ones included in this pull request, please see the
>>
On Wed, 25 Sep 2024 23:32:08 GMT, Justin Lu wrote:
>> Please review this PR which removes usages of Applet within the corelibs
>> tests.
>>
>> Most changes are removed comments/updated var names. The JBS issue lists
>> more files than the ones included in this pull request, please see the
>>
On Thu, 15 Aug 2024 20:28:28 GMT, Dhamoder Nalla wrote:
>> Use the GetTempPath2 APIs instead of the GetTempPath APIs in native code
>> across the OpenJDK repository to retrieve the temporary directory path, as
>> GetTempPath2 provides enhanced security. While GetTempPath may still
>> function
On Wed, 25 Sep 2024 23:17:49 GMT, Joe Darcy wrote:
> Simple change to add a few more index tags on terms related to equality and
> equivalence.
This pull request has now been integrated.
Changeset: bb040ef4
Author:Joe Darcy
URL:
https://git.openjdk.org/jdk/commit/bb040ef4cc2b626f28
On Thu, 25 Jul 2024 00:24:59 GMT, Brian Burkhalter wrote:
> Add some verbiage stating that two buffered readers or input streams should
> not be used to read from the same reader or input stream, respectively.
This pull request has now been integrated.
Changeset: aeaa4f78
Author:Brian Burk
On Thu, 26 Sep 2024 11:51:19 GMT, Matthias Baesken wrote:
> > jni_md.h seems like a pretty big sledgehammer for something that seems to
> > only be in one file, for just java.desktop. Is this macro planned to be
> > used outside of java.desktop?
>
> Yes I have a couple (currently 2) more I wou
On Wed, 25 Sep 2024 12:17:59 GMT, Matthias Baesken wrote:
> There is some old awt/2d coding where warnings occur when running with ubsan
> enabled binaries.
> However at most of these locations the coding should work (at least on our
> supported platform set) so the warnings can be disabled at
On Thu, 26 Sep 2024 08:16:50 GMT, Adam Sotona wrote:
>> Class-File API is leaving preview.
>> This is a removal of all `@PreviewFeature` annotations from Class-File API.
>> It also bumps all `@since` tags and removes
>> `jdk.internal.javac.PreviewFeature.Feature.CLASSFILE_API`.
>>
>> Please rev
On Thu, 26 Sep 2024 13:41:31 GMT, Chen Liang wrote:
>> David M. Lloyd has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make sure that we record every error instead of stopping at the first
>> error in a particular CPE
>
> src/java.base/s
On Wed, 25 Sep 2024 13:43:49 GMT, Claes Redestad wrote:
>> This PR suggests refactoring `ZipFile.Source.initCEN` to move as much logic
>> as possible into the per-entry method processor. This inner method will be
>> called often and JIT optimized earlier in the bootstrap sequence.
>>
>> Startu
> Currently, `ParserVerifier#verifyConstantPool` uses a `switch` to produce a
> `Runnable`, which is consumed by a `Consumer` (instantiated within
> a loop) which runs the task inside if a `try`/`catch`. We can eliminate a
> number of lambdas and method references, plus some allocation pressure,
On Thu, 26 Sep 2024 13:30:07 GMT, David M. Lloyd wrote:
> Currently, `ParserVerifier#verifyConstantPool` uses a `switch` to produce a
> `Runnable`, which is consumed by a `Consumer` (instantiated within
> a loop) which runs the task inside if a `try`/`catch`. We can eliminate a
> number of lam
Currently, `ParserVerifier#verifyConstantPool` uses a `switch` to produce a
`Runnable`, which is consumed by a `Consumer` (instantiated within a
loop) which runs the task inside if a `try`/`catch`. We can eliminate a number
of lambdas and method references, plus some allocation pressure, in this
Sorry for the not-good news, but I'm not too surprised. Computational
domains like "32 bit integers" seem like they should have a lot in
common with algebraic structures like groups and rings, but when you
start poking at them, the compromises we make to fit them into hardware
registers start
Researching the of deriving some iterable representations from ranges, and
I am not here with the good news.
Unlike range algebra and boolean operations, which generalize
extremely well, iterability of ranges... Well, it's safe to say it
doesn't generalize at all. Analyzing key features people exp
Having thought about it some more and this type of information has more of a
tutorial-nature to it.
I'm going to try to find some time to focus on something like that ahead of
Java 24 and hopefully create something to this effect.
Cheers,
√
Viktor Klang
Software Architect, Java Platform Group
On Thu, 26 Sep 2024 08:50:37 GMT, Eirik Bjørsnøs wrote:
> > I think the changes look reasonable and make sense. Will need to an
> > internal run as well for a sanity check.
>
> @LanceAndersen Was your internal run successful for this change?
Yes I completed this late Tuesday and did not see an
On Thu, 26 Sep 2024 11:51:19 GMT, Matthias Baesken wrote:
> The exclusions should work (similar to HS) for the whole JDK C codebase.
Maybe we can offer a separate header ub.hpp next to jni_md.h that contains the
macro/attribute stuff.
Similar to sanitizers/ub.hpp in HS. This header is then in
On Thu, 26 Sep 2024 10:41:25 GMT, Julian Waters wrote:
> jni_md.h seems like a pretty big sledgehammer for something that seems to
> only be in one file, for just java.desktop. Is this macro planned to be used
> outside of java.desktop?
Yes I have a couple (currently 2) more I would like to ex
On Thu, 15 Aug 2024 20:28:28 GMT, Dhamoder Nalla wrote:
>> Use the GetTempPath2 APIs instead of the GetTempPath APIs in native code
>> across the OpenJDK repository to retrieve the temporary directory path, as
>> GetTempPath2 provides enhanced security. While GetTempPath may still
>> function
On Wed, 25 Sep 2024 12:17:59 GMT, Matthias Baesken wrote:
> There is some old awt/2d coding where warnings occur when running with ubsan
> enabled binaries.
> However at most of these locations the coding should work (at least on our
> supported platform set) so the warnings can be disabled at
On Thu, 26 Sep 2024 05:03:01 GMT, Joe Darcy wrote:
>> Add citation of the second edition of "Hacker's Delight".
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback.
Interesting Pull Request for sure :)
1. Construct Frames directly without BitSet
2. Use Frame[] instead of ArrayList
3. Use EMPTY_FRAME_ARRAY for initialization. No need to allocate objects when
there is no frame.
-
Commit messages:
- bug fix
- Use Frame[] instead of List
- frame out of BytecodeRange
- optimize Stac
On Tue, 10 Sep 2024 20:09:42 GMT, Lance Andersen wrote:
> I think the changes look reasonable and make sense. Will need to an internal
> run as well for a sanity check.
@LanceAndersen Was your internal run successful for this change?
-
PR Comment: https://git.openjdk.org/jdk/pull/
> Class-File API is leaving preview.
> This is a removal of all `@PreviewFeature` annotations from Class-File API.
> It also bumps all `@since` tags and removes
> `jdk.internal.javac.PreviewFeature.Feature.CLASSFILE_API`.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull re
43 matches
Mail list logo
