On Thu, 26 Sep 2024 13:41:31 GMT, Chen Liang <li...@openjdk.org> wrote:
>> David M. Lloyd has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make sure that we record every error instead of stopping at the first >> error in a particular CPE > > src/java.base/share/classes/jdk/internal/classfile/impl/verifier/ParserVerifier.java > line 99: > >> 97: imre.owner().asSymbol(); >> 98: imre.typeSymbol(); >> 99: verifyMethodName(imre.name().stringValue()); > > With the new try-catch, say if all lines end up erroneous, we will only get 1 > error instead of 3 like before. Fair point; given that there's only a couple of those though, maybe I could give them their own `try`/`catch`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21209#discussion_r1777109625
