On Mon, 10 Jun 2024 12:12:58 GMT, Shaojin Wen wrote:
> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
> primitive arrays by combining values into larger stores.
>
> This PR rewrites the code of appendNull and append(boolean) methods so that
> these two methods c
On Fri, 20 Sep 2024 18:16:57 GMT, Calvin Cheung wrote:
>> Prior to this patch, if `--module-path` is specified in the command line:
>> during CDS dump time, full module graph will not be included in the CDS
>> archive;
>> during run time, full module graph will not be used.
>>
>> With this patc
On Sat, 14 Sep 2024 02:45:47 GMT, Shaojin Wen wrote:
>> This is a large method. By splitting it into multiple methods with the same
>> name, the caller can automatically select based on the different types of
>> parameters, avoiding this large call that cannot be inlined, which can also
>> imp
Nope. Just bring up your experiences with the feature, and if it's valuable
enough, they will add it.
One good example is Stream::multiMap. Stream came out in Java 8, but that
feature came out in Java 16. So, the best thing to focus on is just
reporting your experiences as they occur.
On Wed, Sep
On Thu, 25 Jul 2024 22:18:03 GMT, Justin Lu wrote:
> Please review this PR which adds public StringBuilder overloads to the
> formatting methods of java.text.Format and implementing subclasses.
>
> While Format, NumberFormat, and DateFormat are abstract, these new methods
> are not added as ab
> A very small optimization, split the large method inflate, split the
> infrequently used paths into a method inflateCHAR
Shaojin Wen has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains eight commits:
- Merge remote-tracking branch 'or
On Thu, 29 Aug 2024 05:01:52 GMT, Shaojin Wen wrote:
> This is a large method. By splitting it into multiple methods with the same
> name, the caller can automatically select based on the different types of
> parameters, avoiding this large call that cannot be inlined, which can also
> improve
On Fri, 20 Sep 2024 16:35:07 GMT, Shaojin Wen wrote:
>> CheckLocal once, reduce redundant checkLocal, rewrite switch, reduce method
>> size, codeSize is reduced from 367 to 263.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
> Move `resource.wxl-file-name` property from `WinResources.properties` files
> to the new `WinResourcesNoL10N.properties` files. The later are supposed to
> be excluded from automatic translations.
Alexey Semenyuk has updated the pull request incrementally with one additional
commit since the
On Fri, 20 Sep 2024 19:19:39 GMT, Andrey Turbanov wrote:
>> Alexey Semenyuk has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Redo removal of `resource.wxl-file-name` property
>> - Revert "8338918: Remove non translated file name from W
On Fri, 20 Sep 2024 22:42:43 GMT, Alexey Semenyuk wrote:
>> Move `resource.wxl-file-name` property from `WinResources.properties` files
>> to the new `WinResourcesNoL10N.properties` files. The later are supposed to
>> be excluded from automatic translations.
>
> Alexey Semenyuk has updated the
On Tue, 16 Jul 2024 18:17:00 GMT, Roger Riggs wrote:
>> David M. Lloyd has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review feedback
>
> src/java.base/share/classes/jdk/internal/reflect/ReflectionFactory.java line
> 491:
>
>>
On Fri, 20 Sep 2024 20:27:00 GMT, Roger Riggs wrote:
>> David M. Lloyd has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comment
>
> src/java.base/share/classes/jdk/internal/reflect/ReflectionFactory.java line
> 470:
>
>>
> Issue [JDK-8164908](https://bugs.openjdk.org/browse/JDK-8164908) added
> support for functionality required to continue to support IIOP and custom
> serializers in light of additional module-based restrictions on reflection.
> It was expected that these libraries would use `sun.misc.Unsafe` in
On Fri, 20 Sep 2024 02:53:00 GMT, Alexey Semenyuk wrote:
>> Move `resource.wxl-file-name` property from `WinResources.properties` files
>> to the new `WinResourcesNoL10N.properties` files. The later are supposed to
>> be excluded from automatic translations.
>
> Alexey Semenyuk has updated the
On Thu, 29 Aug 2024 14:33:08 GMT, David M. Lloyd wrote:
>> Issue [JDK-8164908](https://bugs.openjdk.org/browse/JDK-8164908) added
>> support for functionality required to continue to support IIOP and custom
>> serializers in light of additional module-based restrictions on reflection.
>> It wa
On Tue, 17 Sep 2024 18:30:16 GMT, Dhamoder Nalla wrote:
> > Do we have any apps commonly run as a Windows SYSTEM account which expect
> > to attach to other Java apps run by a different Java version? You're
> > suggesting that will have no impact and agreed it would seem really
> > unusual. 8-
On Fri, 20 Sep 2024 02:53:00 GMT, Alexey Semenyuk wrote:
>> Move `resource.wxl-file-name` property from `WinResources.properties` files
>> to the new `WinResourcesNoL10N.properties` files. The later are supposed to
>> be excluded from automatic translations.
>
> Alexey Semenyuk has updated the
On Wed, 18 Sep 2024 01:15:40 GMT, David Holmes wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> trailing whitespace
>
> src/hotspot/share/cds/filemap.cpp line 931:
>
>> 929: bool FileMapInfo::is_jar_suffix(const c
> Prior to this patch, if `--module-path` is specified in the command line:
> during CDS dump time, full module graph will not be included in the CDS
> archive;
> during run time, full module graph will not be used.
>
> With this patch, the full module graph will be included in the CDS archive
>
On Fri, 20 Sep 2024 14:02:14 GMT, Nizar Benalla wrote:
>> This checker checks the values of the `@since` tag found in the
>> documentation comment for an element against the release in which the
>> element first appeared.
>>
>> Real since value of an API element is computed as the oldest relea
> Prior to this patch, if `--module-path` is specified in the command line:
> during CDS dump time, full module graph will not be included in the CDS
> archive;
> during run time, full module graph will not be used.
>
> With this patch, the full module graph will be included in the CDS archive
>
On Fri, 20 Sep 2024 15:54:12 GMT, Lance Andersen wrote:
>> Please review the following PR which addresses that ZipOutputStream should
>> validate the CEN header fields similar to what was done via
>> [JDK-8316141](https://bugs.openjdk.org/browse/JDK-8316141)
>>
>> As part of this change, the j
On Sun, 8 Sep 2024 07:52:26 GMT, Shaojin Wen wrote:
> Similar to ObjectInputStream, use JLA.countPositives and
> JLA.inflateBytesToChars to speed up readUTF
This pull request has now been integrated.
Changeset: 40fba148
Author:Shaojin Wen
URL:
https://git.openjdk.org/jdk/commit/40f
Hi Viktor,
I recently encountered a real-world use case for Stream Gatherers and
thought I'd mention it (apologies if you've seen these ideas already).
These might even be worth considering including as standard offerings.
Motivating example: Suppose you have a large list of people sorted by
Last
On Fri, 20 Sep 2024 16:35:05 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java
>> line 1069:
>>
>>> 1067: localsSize += 2;
>>> 1068: } else {
>>> 1069: if (desc == CD_int || desc == C
On Fri, 20 Sep 2024 02:53:00 GMT, Alexey Semenyuk wrote:
>> Move `resource.wxl-file-name` property from `WinResources.properties` files
>> to the new `WinResourcesNoL10N.properties` files. The later are supposed to
>> be excluded from automatic translations.
>
> Alexey Semenyuk has updated the
On Thu, 19 Sep 2024 07:40:43 GMT, Matthias Baesken wrote:
> Windows Server 2025 will be releases in a few months.
> The OS detection code of the JVM/JDK should recognize the new Windows server
> 2025 version.
> (currently Windows server 2022 is printed , that is wrong)
>
> The build numbers of
On Thu, 19 Sep 2024 21:43:01 GMT, Sandhya Viswanathan
wrote:
>> Currently the rearrange and selectFrom APIs check shuffle indices and throw
>> IndexOutOfBoundsException if there is any exceptional source index in the
>> shuffle. This causes the generated code to be less optimal. This PR modifi
On Fri, 20 Sep 2024 02:53:00 GMT, Alexey Semenyuk wrote:
>> Move `resource.wxl-file-name` property from `WinResources.properties` files
>> to the new `WinResourcesNoL10N.properties` files. The later are supposed to
>> be excluded from automatic translations.
>
> Alexey Semenyuk has updated the
On Fri, 20 Sep 2024 05:09:19 GMT, Shaojin Wen wrote:
>> PR #20772 introduced an optimization for writeUTF, which can also be used in
>> DataOutputStream::writeUTF.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> bug fix for
On Fri, 20 Sep 2024 16:13:06 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more compact
>
> src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java
> line 1069:
>
>> 10
> CheckLocal once, reduce redundant checkLocal, rewrite switch, reduce method
> size, codeSize is reduced from 367 to 263.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
more compact
-
Changes:
- all: https://git.open
On Fri, 20 Sep 2024 09:18:32 GMT, Shaojin Wen wrote:
> CheckLocal once, reduce redundant checkLocal, rewrite switch, reduce method
> size, codeSize is reduced from 367 to 263.
Tier 1-3 tests pass.
-
Marked as reviewed by liach (Reviewer).
PR Review: https://git.openjdk.org/jdk/pu
On Fri, 20 Sep 2024 16:13:06 GMT, Claes Redestad wrote:
>> CheckLocal once, reduce redundant checkLocal, rewrite switch, reduce method
>> size, codeSize is reduced from 367 to 263.
>
> src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java
> line 1069:
>
>> 1067:
On Fri, 20 Sep 2024 09:18:32 GMT, Shaojin Wen wrote:
> CheckLocal once, reduce redundant checkLocal, rewrite switch, reduce method
> size, codeSize is reduced from 367 to 263.
LGTM
src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java
line 1069:
> 1067:
On Thu, 19 Sep 2024 17:07:41 GMT, Chen Liang wrote:
> The `tag` field in `AbstractPoolEntry` is redundant, as it's always of the
> same value for each subtype. This is now replaced with an override. This can
> reduce the footprint of the entries..
>
> The removal of `hash` was considered but w
On Thu, 19 Sep 2024 17:07:41 GMT, Chen Liang wrote:
> The `tag` field in `AbstractPoolEntry` is redundant, as it's always of the
> same value for each subtype. This is now replaced with an override. This can
> reduce the footprint of the entries..
>
> The removal of `hash` was considered but w
On Fri, 20 Sep 2024 08:14:04 GMT, Per Minborg wrote:
>> This PR suggests introducing an internal class in `java.base` to simplify
>> the use of some `MethodHandles.Lookup` operations.
>>
>> While the utility of the methods might appear to be limited in classes with
>> many static `VarHandle`/`
On Fri, 20 Sep 2024 12:30:00 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial typo fix in `JarFile` class'
> javadoc?
This pull request has now been integrated.
Changeset: 90d3a64b
Author:Jaikiran Pai
URL:
https://git.openjdk.org/jdk/commit/90d3a64b0afd581098128
On Fri, 20 Sep 2024 12:30:00 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial typo fix in `JarFile` class'
> javadoc?
Thank you all for the reviews.
-
PR Comment: https://git.openjdk.org/jdk/pull/21108#issuecomment-2364052197
On Fri, 20 Sep 2024 12:30:00 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial typo fix in `JarFile` class'
> javadoc?
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/21108#pullrequestreview-2318683971
On Thu, 19 Sep 2024 17:07:41 GMT, Chen Liang wrote:
> The `tag` field in `AbstractPoolEntry` is redundant, as it's always of the
> same value for each subtype. This is now replaced with an override. This can
> reduce the footprint of the entries..
>
> The removal of `hash` was considered but w
> Please review the following PR which addresses that ZipOutputStream should
> validate the CEN header fields similar to what was done via
> [JDK-8316141](https://bugs.openjdk.org/browse/JDK-8316141)
>
> As part of this change, the javadoc for ZipEntry has been updated to indicate
> that the CE
Hi Archie, and Viktor
Thank you very much for your response and for referencing the test case I
shared earlier.
I can confirm that the test case is accurate, and the issue lies in the
explanation I provided below it. Upon reflection, I realized that certain parts
of my explanation were incorre
On Thu, 19 Sep 2024 17:07:41 GMT, Chen Liang wrote:
> The `tag` field in `AbstractPoolEntry` is redundant, as it's always of the
> same value for each subtype. This is now replaced with an override. This can
> reduce the footprint of the entries..
>
> The removal of `hash` was considered but w
On Fri, Sep 20, 2024 at 10:16 AM Viktor Klang
wrote:
> Before we do anything at all, does there exist a reproducer which would
> illustrate that the current behavior causes problems?
>
I believe this is the most recent one:
https://mail.openjdk.org/pipermail/core-libs-dev/2024-September/129031.h
On Fri, 20 Sep 2024 09:18:32 GMT, Shaojin Wen wrote:
> CheckLocal once, reduce redundant checkLocal, rewrite switch, reduce method
> size, codeSize is reduced from 367 to 263.
Looks good. Using `Util.parameterSlots` avoids redundant array allocation and
copies. 👍
-
PR Comment: ht
Hi Archie and Kim,
Thank you for your patience, I tried to get back to this as soon as possible.
Trying to swap this in again, looking at the code it would seem like
lockInterruptibly() by external threads can indeed get interleaved with
signaled waiters in the Condition's wait list.
It is wor
CheckLocal once, reduce redundant checkLocal, rewrite switch, reduce method
size, codeSize is reduced from 367 to 263.
-
Commit messages:
- optimize setLocalsFromArg
Changes: https://git.openjdk.org/jdk/pull/21106/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21106&range
Hi Kim,
Here is a quick summary of my thoughts...
Before diving into coding solutions, we need to make sure we're all on the
same page.
First: (Viktor) Do we all agree that "Interpretation B" accurately
describes how things are actually working today?
If "No" then we need to stop and understand
> This checker checks the values of the `@since` tag found in the documentation
> comment for an element against the release in which the element first
> appeared.
>
> Real since value of an API element is computed as the oldest release in which
> the given API element was introduced. That is:
On Fri, 20 Sep 2024 12:30:00 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial typo fix in `JarFile` class'
> javadoc?
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/21108#pullrequestreview-2318248221
On Fri, 20 Sep 2024 12:30:00 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial typo fix in `JarFile` class'
> javadoc?
Marked as reviewed by mullan (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/21108#pullrequestreview-2318183860
Can I please get a review of this trivial typo fix in `JarFile` class' javadoc?
-
Commit messages:
- 8340537: Typo in javadoc of java.util.jar.JarFile
Changes: https://git.openjdk.org/jdk/pull/21108/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21108&range=00
Issue: htt
On Fri, 20 Sep 2024 10:32:18 GMT, Jorn Vernee wrote:
> > The javadoc of the `Linker` also states that:
> > > [A group layout] G does not contain padding other than what is strictly
> > > required to align
> > > its non-padding layout elements, or to satisfy (2) [the size of {@code G}
> > > is a
On Fri, 20 Sep 2024 08:41:45 GMT, Maurizio Cimadamore
wrote:
> The javadoc of the `Linker` also states that:
>
> > [A group layout] G does not contain padding other than what is strictly
> > required to align
> > its non-padding layout elements, or to satisfy (2) [the size of {@code G}
> > is
On Tue, 17 Sep 2024 14:12:58 GMT, Per Minborg wrote:
> This PR prevents sequence layout with padding to be used with the Linker.
src/java.base/share/classes/java/lang/foreign/Linker.java line 252:
> 250: * the alignment constraint of {@code S} is set to its
> 251: * natural alignment,
>
On Thu, 19 Sep 2024 14:08:04 GMT, Claes Redestad wrote:
> This PR changes proxy code gen to avoid generating
> `Class.forName("java.lang.Object")`, instead emitting an ldc for the class
> literal, `ldc(CD_Object)`, java code equivalent `Object.class`.
>
> More types could profitably use `ldc(
On Thu, 19 Sep 2024 14:08:04 GMT, Claes Redestad wrote:
> This PR changes proxy code gen to avoid generating
> `Class.forName("java.lang.Object")`, instead emitting an ldc for the class
> literal, `ldc(CD_Object)`, java code equivalent `Object.class`.
>
> More types could profitably use `ldc(
On Thu, 19 Sep 2024 07:40:43 GMT, Matthias Baesken wrote:
> Windows Server 2025 will be releases in a few months.
> The OS detection code of the JVM/JDK should recognize the new Windows server
> 2025 version.
> (currently Windows server 2022 is printed , that is wrong)
>
> The build numbers of
On Thu, 19 Sep 2024 21:25:21 GMT, Maurizio Cimadamore
wrote:
>> This PR moves the section on restricted methods from the the javadoc of
>> `java.lang.foreign` package into a standalone static [javadoc
>> page](https://cr.openjdk.org/~mcimadamore/jdk/restricted_javadoc_section/docs/api/java.bas
On Tue, 17 Sep 2024 14:12:58 GMT, Per Minborg wrote:
> This PR prevents sequence layout with padding to be used with the Linker.
The javadoc of the `Linker` also states that:
> [A group layout] G does not contain padding other than what is strictly
> required to align
its non-padding layo
This PR prevents sequence layout with padding to be used with the Linker.
-
Commit messages:
- Merge branch 'master' into linker-padding-layout-only
- Improve excception message
- Document a sequence layout cannot contain a padding layout
- Update copyright year
- Prevent embeded
> This PR suggests introducing an internal class in `java.base` to simplify the
> use of some `MethodHandles.Lookup` operations.
>
> While the utility of the methods might appear to be limited in classes with
> many static `VarHandle`/`MethodHandle` variables, it should be noted that the
> clas
> This PR suggests introducing an internal class in `java.base` to simplify the
> use of some `MethodHandles.Lookup` operations.
>
> While the utility of the methods might appear to be limited in classes with
> many static `VarHandle`/`MethodHandle` variables, it should be noted that the
> clas
On Tue, 17 Sep 2024 14:25:42 GMT, Per Minborg wrote:
>> This PR suggests introducing an internal class in `java.base` to simplify
>> the use of some `MethodHandles.Lookup` operations.
>>
>> While the utility of the methods might appear to be limited in classes with
>> many static `VarHandle`/`
67 matches
Mail list logo
