On Mon, 16 Sep 2024 01:17:21 GMT, David Holmes wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix code comment style where appropriate
>
> src/java.base/share/native/libjli/java.c line 1421:
>
>> 1419: ) {
>> 142
> Can I please get a review of this change which proposes to remove the
> (internal) `SelectVersion()` function from the java launcher and also update
> the code comments in the launcher to match the current implementation?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8340114, the
> `Sel
On Mon, 16 Sep 2024 04:44:39 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which cleans up the `java`
>> launcher to remove checks/support for outdated options?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8339918, these 6 options
>> have been outdated and unsu
On Mon, 16 Sep 2024 01:08:19 GMT, David Holmes wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> typos
>
> src/java.base/share/native/libjli/java.c line 38:
>
>> 36: * One job of the launcher is to remove command l
On Mon, 16 Sep 2024 04:44:39 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which cleans up the `java`
>> launcher to remove checks/support for outdated options?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8339918, these 6 options
>> have been outdated and unsu
> Can I please get a review for this change which cleans up the `java` launcher
> to remove checks/support for outdated options?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8339918, these 6 options have
> been outdated and unsupported for several releases now. 2 of them even throw
> an
On Mon, 16 Sep 2024 04:28:43 GMT, David Holmes wrote:
>> Done. There also was `-v` and `-v:...` in this example which aren't
>> supported either (not even in JDK 8). So I've removed those as well.
>
> What about:
>
> token.startsWith("-ms") || token.startsWith("-mx") ||
>
On Mon, 16 Sep 2024 04:15:28 GMT, Jaikiran Pai wrote:
>> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTY.java line 991:
>>
>>> 989:// Old-style options (These should remain in place
>>> as long as
>>> 990:// the standard VM accepts them)
>>
On Mon, 16 Sep 2024 03:59:37 GMT, David Holmes wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove -noasyncgc from com.sun.tools.example.debug.tty.TTY
>
> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tt
> Can I please get a review for this change which cleans up the `java` launcher
> to remove checks/support for outdated options?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8339918, these 6 options have
> been outdated and unsupported for several releases now. 2 of them even throw
> an
On Mon, 16 Sep 2024 03:56:39 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which cleans up the `java`
>> launcher to remove checks/support for outdated options?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8339918, these 6 options
>> have been outdated and unsu
> Can I please get a review for this change which cleans up the `java` launcher
> to remove checks/support for outdated options?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8339918, these 6 options have
> been outdated and unsupported for several releases now. 2 of them even throw
> an
On Sat, 14 Sep 2024 20:52:03 GMT, David Holmes wrote:
>> src/java.base/share/man/java.1 line 3918:
>>
>>> 3916: option \f[V]-XX:-ScavengeBeforeFullGC\f[R].
>>> 3917: .TP
>>> 3918: \f[V]-Xfuture\f[R]
>>
>> Maybe also remove the -X help (or at least change its description) in
>> https://github.c
> Can I please get a review for this change which cleans up the `java` launcher
> to remove checks/support for outdated options?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8339918, these 6 options have
> been outdated and unsupported for several releases now. 2 of them even throw
> an
On Fri, 26 Apr 2024 22:27:21 GMT, Chen Liang wrote:
>> Please review this patch that:
>> 1. Implemented `forEach` to optimize for 1 or 2 element collections.
>> 2. Implemented `spliterator` to optimize for a single element.
>>
>> The default implementations for multiple-element immutable collect
> Hi All,
>
> As per the discussion on panama-dev mailing list[1], patch adds the support
> for following new two vector permutation APIs.
>
>
> Declaration:-
> Vector.selectFrom(Vector v1, Vector v2)
>
>
> Semantics:-
> Using index values stored in the lanes of "this" vector, assembl
On Sun, 15 Sep 2024 07:16:17 GMT, Emanuel Peter wrote:
> > > Can you please **define** somewhere what it means to `prune indexes`? It
> > > does not help me much more than the previous "massaging indexes" you had
> > > before I asked you to change it.
> > > > Also: I'm a little worried about th
On Mon, 16 Sep 2024 01:29:45 GMT, Jaikiran Pai wrote:
>> src/java.base/share/native/libjli/java.c line 1345:
>>
>>> 1343: if (JLI_StrCCmp(arg, "-Djava.class.path=") == 0) {
>>> 1344: _have_classpath = JNI_TRUE;
>>> 1345: } else if (JLI_StrCmp(arg, "-Djava.
> Can I please get a review of this change which proposes to remove the
> (internal) `SelectVersion()` function from the java launcher and also update
> the code comments in the launcher to match the current implementation?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8340114, the
> `Sel
On Mon, 16 Sep 2024 01:21:32 GMT, David Holmes wrote:
> And it is a bit hard to track all the changes especially in relation to
> splashscreen.
If it helps, the webrev instead of the github UI might be better to review this
change. Unless of course you were already using that one.
> src/java.
On Fri, 13 Sep 2024 12:29:26 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to remove the
> (internal) `SelectVersion()` function from the java launcher and also update
> the code comments in the launcher to match the current implementation?
>
> As noted in
On Sun, 15 Sep 2024 12:59:21 GMT, Claes Redestad wrote:
>> Simple internal refactor to load a few classes less on startup. Arguably
>> cleaner and avoids some iterator allocations.
>
> Claes Redestad has updated the pull request incrementally with one additional
> commit since the last revision
On Sun, 15 Sep 2024 12:59:21 GMT, Claes Redestad wrote:
>> Simple internal refactor to load a few classes less on startup. Arguably
>> cleaner and avoids some iterator allocations.
>
> Claes Redestad has updated the pull request incrementally with one additional
> commit since the last revision
On Sun, 15 Sep 2024 12:59:21 GMT, Claes Redestad wrote:
>> Simple internal refactor to load a few classes less on startup. Arguably
>> cleaner and avoids some iterator allocations.
>
> Claes Redestad has updated the pull request incrementally with one additional
> commit since the last revision
On Sun, 15 Sep 2024 12:59:21 GMT, Claes Redestad wrote:
>> Simple internal refactor to load a few classes less on startup. Arguably
>> cleaner and avoids some iterator allocations.
>
> Claes Redestad has updated the pull request incrementally with one additional
> commit since the last revision
> Please review the following PR which addresses that ZipOutputStream should
> validate the CEN header fields similar to what was done via
> [JDK-8316141](https://bugs.openjdk.org/browse/JDK-8316141)
>
> As part of this change, the javadoc for ZipEntry has been updated to indicate
> that the CE
On Fri, 13 Sep 2024 20:20:56 GMT, Chen Liang wrote:
>> Please review the following PR which addresses that ZipOutputStream should
>> validate the CEN header fields similar to what was done via
>> [JDK-8316141](https://bugs.openjdk.org/browse/JDK-8316141)
>>
>> As part of this change, the javad
> Simple internal refactor to load a few classes less on startup. Arguably
> cleaner and avoids some iterator allocations.
Claes Redestad has updated the pull request incrementally with one additional
commit since the last revision:
Improve edge invariant checks
-
Changes:
- a
On Sat, 14 Sep 2024 20:35:30 GMT, Chen Liang wrote:
>> The public methods used to throw `IllegalArgumentException` when duplicate
>> class options were passed though, as a result of using [`Set.of(…)`].
>>
>> [`Set.of(…)`]:
>> https://docs.oracle.com/en/java/javase/22/docs/api/java.base/java/u
On Fri, 13 Sep 2024 18:27:07 GMT, Jatin Bhateja wrote:
> > Can you please **define** somewhere what it means to `prune indexes`? It
> > does not help me much more than the previous "massaging indexes" you had
> > before I asked you to change it.
> > > Also: I'm a little worried about the semant
30 matches
Mail list logo
