On Mon, 16 Sep 2024 04:28:43 GMT, David Holmes <[email protected]> wrote:
>> Done. There also was `-v` and `-v:...` in this example which aren't
>> supported either (not even in JDK 8). So I've removed those as well.
>
> What about:
>
> token.startsWith("-ms") || token.startsWith("-mx") ||
> token.startsWith("-ss") || token.startsWith("-oss") ) {
>
> ? `-oss` is gone as of 9. The others are not need as the -X counterpart can
> be used.
One of my next plans, as part of the launcher options cleanup
https://bugs.openjdk.org/browse/JDK-8286851, was to create a task to deprecate
for removal -ms and -mx. I was thinking of removing these usage in this code,
as part of that effort. But yes, I can remove these options from this example
here as part of this PR - I'll go ahead and do it now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20945#discussion_r1760520434
