On Tue, 13 Aug 2024 01:39:33 GMT, Shaojin Wen wrote:
>> This PR implements the same algorithm as the current generateMHInlineCopy
>> based on bytecode to improve startup performance.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
> This PR implements the same algorithm as the current generateMHInlineCopy
> based on bytecode to improve startup performance.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
add jtreg HiddenClassUnloading
-
Changes:
On Mon, 12 Aug 2024 16:11:46 GMT, Viktor Klang wrote:
>> 8336384: AbstractQueuedSynchronizer.acquire should cancel acquire when
>> failing due to a LinkageError or other errors
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 12 Aug 2024 21:37:45 GMT, Doug Lea wrote:
>> src/java.base/share/classes/java/util/concurrent/locks/AbstractQueuedLongSynchronizer.java
>> line 381:
>>
>>> 379: else
>>> 380: break;
>>> 381: } catch (Error | RuntimeException ex
On Mon, 12 Aug 2024 13:51:25 GMT, Chen Liang wrote:
>> Rafael Winterhalter has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR. The pull request
>> contains one new
> When a type uses a type variable without a declaration, no exception is
> thrown. This change triggers a `TypeNotFoundException` to be thrown.
Rafael Winterhalter has updated the pull request incrementally with one
additional commit since the last revision:
8337302: Add missing visibility m
On Fri, 2 Aug 2024 04:26:45 GMT, Chen Liang wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix performance regression caused by args.erase()
>
> Because we load the class in the bootstrap loader so it can access ja
On Thu, 8 Aug 2024 17:20:06 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> following new vector operators.
>>
>>
>> . SATURATING_UADD : Saturating unsigned addition.
>> . SATURATING_ADD: Saturating sig
On Thu, 8 Aug 2024 06:57:28 GMT, Jatin Bhateja wrote:
> Hi All,
>
> As per the discussion on panama-dev mailing list[1], patch adds the support
> for following new two vector permutation APIs.
>
>
> Declaration:-
> Vector.selectFrom(Vector v1, Vector v2)
>
>
> Semantics:-
> Using in
On Mon, 12 Aug 2024 16:08:31 GMT, Viktor Klang wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Catching both Error and RuntimeException
>
> src/java.base/share/classes/java/util/concurrent/locks/AbstractQueuedLongS
> This PR implements the same algorithm as the current generateMHInlineCopy
> based on bytecode to improve startup performance.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
new Lookup(String.class)
-
Changes:
- all:
> This PR implements the same algorithm as the current generateMHInlineCopy
> based on bytecode to improve startup performance.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
revert MemberName
-
Changes:
- all: https:
On Mon, 12 Aug 2024 19:26:46 GMT, Claes Redestad wrote:
>> src/java.base/share/classes/java/lang/invoke/MemberName.java line 961:
>>
>>> 959: return null;
>>> 960: }
>>> 961: if (allowedModes != LM_TRUSTED) {
>>
>> ❌ You must revert changes to
> This PR implements the same algorithm as the current generateMHInlineCopy
> based on bytecode to improve startup performance.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
add comments
-
Changes:
- all: https://git
On Mon, 12 Aug 2024 07:31:09 GMT, Rafael Winterhalter
wrote:
>> When a type uses a type variable without a declaration, no exception is
>> thrown. This change triggers a `TypeNotFoundException` to be thrown.
>
> Rafael Winterhalter has refreshed the contents of this pull request, and
> previou
On Mon, 12 Aug 2024 19:15:14 GMT, Shaojin Wen wrote:
>> This PR implements the same algorithm as the current generateMHInlineCopy
>> based on bytecode to improve startup performance.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 12 Aug 2024 16:21:48 GMT, Chen Liang wrote:
>> Shaojin Wen has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - fix comments
>> - remove unused code
>
> src/java.base/share/classes/java/lang/invoke/MemberName.java line 961:
>
>> 9
On Fri, 2 Aug 2024 04:26:45 GMT, Chen Liang wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix performance regression caused by args.erase()
>
> Because we load the class in the bootstrap loader so it can access ja
On Fri, 9 Aug 2024 15:54:51 GMT, Roger Riggs wrote:
> Addressing latent issues with ReferencedKeyTest
> - During the `methods()` tests the keys should be strongly held to avoid
> inadvertent GC collection and subsequent test failures (JDK-8336926)
> - Merge changes from Valhalla to use String (i
On Thu, 8 Aug 2024 18:15:29 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [8338014](https://bugs.openjdk.org/browse/JDK-8338014)
> improving the use of `@jvms` tags by adding `JVMS` prior to the tag.
>
> Thanks,
> Sonia
I think we can just make `{@jvms }` inline version
On Mon, 15 Jul 2024 04:05:55 GMT, Chen Liang wrote:
> A straightforward optimization, to share the signature parsing of method,
> constructor, and field between the root and the copied objects, like how
> method handle accessors are shared.
Yep, there's #19281 exactly for that purpose:
https:
> This PR implements the same algorithm as the current generateMHInlineCopy
> based on bytecode to improve startup performance.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
StringConcat1
-
Changes:
- all: https://gi
On Thu, 20 Jun 2024 19:17:25 GMT, jengebr wrote:
>> Improve `java/util/concurrent/CopyOnWriteArrayList` by eliminating needless
>> cloning of Object[0] instances. This cloning is intended to prevent callers
>> from changing array contents, but many `CopyOnWriteArrayList`s are allocated
>> to s
> This PR implements the same algorithm as the current generateMHInlineCopy
> based on bytecode to improve startup performance.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
Update src/java.base/share/classes/java/lang/StringConcatH
On Mon, 12 Aug 2024 15:58:14 GMT, Axel Boldt-Christmas
wrote:
>> When inflating a monitor the `ObjectMonitor*` is written directly over the
>> `markWord` and any overwritten data is displaced into a displaced
>> `markWord`. This is problematic for concurrent GCs which needs extra care or
>> l
On Mon, 12 Aug 2024 18:42:25 GMT, Joe Darcy wrote:
>> Hi all,
>>
>> This PR addresses [8338014](https://bugs.openjdk.org/browse/JDK-8338014)
>> improving the use of `@jvms` tags by adding `JVMS` prior to the tag.
>>
>> Thanks,
>> Sonia
>
> Looks fine; increasing review count to also include
On Mon, 12 Aug 2024 17:44:50 GMT, Shaojin Wen wrote:
>> This PR implements the same algorithm as the current generateMHInlineCopy
>> based on bytecode to improve startup performance.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
On Thu, 25 Jul 2024 00:43:09 GMT, Shaojin Wen wrote:
>> The solution is to call `.erase()` on the input method handle, and call
>> `viewAsType` on the result method handle.
>
> Sorry, I don't understand what you mean. The following code can't solve the
> above build error
>
>
> public static
On Mon, 12 Aug 2024 16:16:10 GMT, Shaojin Wen wrote:
>> This PR implements the same algorithm as the current generateMHInlineCopy
>> based on bytecode to improve startup performance.
>
> Shaojin Wen has updated the pull request incrementally with two additional
> commits since the last revision
On Mon, 12 Aug 2024 18:42:45 GMT, Chen Liang wrote:
>> Hi all,
>>
>> This PR addresses [8338014](https://bugs.openjdk.org/browse/JDK-8338014)
>> improving the use of `@jvms` tags by adding `JVMS` prior to the tag.
>>
>> Thanks,
>> Sonia
>
> src/java.base/share/classes/java/lang/classfile/at
On Mon, 12 Aug 2024 18:42:25 GMT, Joe Darcy wrote:
>> Hi all,
>>
>> This PR addresses [8338014](https://bugs.openjdk.org/browse/JDK-8338014)
>> improving the use of `@jvms` tags by adding `JVMS` prior to the tag.
>>
>> Thanks,
>> Sonia
>
> Looks fine; increasing review count to also include
On Mon, 12 Aug 2024 18:35:45 GMT, Shaojin Wen wrote:
> Should we change the title of the PR to `Implementing an efficient string
> concatenation hidden class strategy based on ClassFile API`?
Yes, or something shorter like `"8336856: Efficient hidden class-based string
concatenation strategy"`
On Tue, 30 Jul 2024 07:47:55 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Fix by Severin Gehwolf.
>> Testcase by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Inline a
On Thu, 8 Aug 2024 18:15:29 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [8338014](https://bugs.openjdk.org/browse/JDK-8338014)
> improving the use of `@jvms` tags by adding `JVMS` prior to the tag.
>
> Thanks,
> Sonia
Changes requested by liach (Reviewer).
src/java.b
On Thu, 8 Aug 2024 18:15:29 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [8338014](https://bugs.openjdk.org/browse/JDK-8338014)
> improving the use of `@jvms` tags by adding `JVMS` prior to the tag.
>
> Thanks,
> Sonia
Looks fine; increasing review count to also includ
On Mon, 12 Aug 2024 17:44:50 GMT, Shaojin Wen wrote:
>> This PR implements the same algorithm as the current generateMHInlineCopy
>> based on bytecode to improve startup performance.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
Hi all,
This PR addresses [8338014](https://bugs.openjdk.org/browse/JDK-8338014)
improving the use of `@jvms` tags by adding `JVMS` prior to the tag.
Thanks,
Sonia
-
Commit messages:
- Merge branch 'openjdk:master' into JDK-8338014
- Copyright update
- 8338014: Improve usage
On Thu, 13 Jun 2024 14:31:06 GMT, David M. Lloyd wrote:
> Issue [JDK-8164908](https://bugs.openjdk.org/browse/JDK-8164908) added
> support for functionality required to continue to support IIOP and custom
> serializers in light of additional module-based restrictions on reflection.
> It was ex
> This PR implements the same algorithm as the current generateMHInlineCopy
> based on bytecode to improve startup performance.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
fix comments
-
Changes:
- all: https://git
On Mon, 12 Aug 2024 16:16:10 GMT, Shaojin Wen wrote:
>> This PR implements the same algorithm as the current generateMHInlineCopy
>> based on bytecode to improve startup performance.
>
> Shaojin Wen has updated the pull request incrementally with two additional
> commits since the last revision
On Mon, 12 Aug 2024 16:52:53 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/java/lang/StringConcatHelper.java line 83:
>>
>>> 81:
>>> 82: @ForceInline
>>> 83: private final String concat(char value) {
>>
>> These mostly help avoid a bit of class spinning on startup, rig
On Mon, 12 Aug 2024 15:46:13 GMT, Alan Bateman wrote:
> please do not integrate this change until I get time
Sure, of course I will not.
Thanks to @magicus and @dfuch for helping to make it better.
-
PR Comment: https://git.openjdk.org/jdk/pull/20317#issuecomment-2284529067
The Exchanger class uses spin-waits that are hostile to some uses of
VirtualThreads. Improving this requires a means of estimating whether there are
many VirtualThreads with few carriers, which can be supported by adding a
method in class ForkJoinWorkerThread. This enables a reworking of the exc
On Mon, 12 Aug 2024 14:47:13 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix comments
>
> src/java.base/share/classes/java/lang/StringConcatHelper.java line 83:
>
>> 81:
>> 82: @For
On Fri, 9 Aug 2024 15:54:51 GMT, Roger Riggs wrote:
> Addressing latent issues with ReferencedKeyTest
> - During the `methods()` tests the keys should be strongly held to avoid
> inadvertent GC collection and subsequent test failures (JDK-8336926)
> - Merge changes from Valhalla to use String (i
> This PR implements the same algorithm as the current generateMHInlineCopy
> based on bytecode to improve startup performance.
Shaojin Wen has updated the pull request incrementally with two additional
commits since the last revision:
- fix comments
- remove unused code
-
Chang
On Mon, 12 Aug 2024 16:08:31 GMT, Viktor Klang wrote:
>> 8336384: AbstractQueuedSynchronizer.acquire should cancel acquire when
>> failing due to a LinkageError or other errors
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
> 8336384: AbstractQueuedSynchronizer.acquire should cancel acquire when
> failing due to a LinkageError or other errors
Viktor Klang has updated the pull request incrementally with one additional
commit since the last revision:
Catching both Error and RuntimeException
-
Changes
On Mon, 12 Aug 2024 15:57:42 GMT, Alan Bateman wrote:
>> Or use (Error | RuntimeException ex)?
>
> That would be okay too as there are no checked exceptions here.
@AlanBateman If we really want it airtight I think we need to catch Throwable
and sneaky-rethrow it? 🤔
-
PR Review Com
On Mon, 12 Aug 2024 15:28:47 GMT, Doug Lea wrote:
>> src/java.base/share/classes/java/util/concurrent/locks/AbstractQueuedLongSynchronizer.java
>> line 381:
>>
>>> 379: else
>>> 380: break;
>>> 381: } catch (Error ex) {// r
> When inflating a monitor the `ObjectMonitor*` is written directly over the
> `markWord` and any overwritten data is displaced into a displaced `markWord`.
> This is problematic for concurrent GCs which needs extra care or looser
> semantics to use this displaced data. In Lilliput this data als
> This PR implements the same algorithm as the current generateMHInlineCopy
> based on bytecode to improve startup performance.
Shaojin Wen has updated the pull request incrementally with four additional
commits since the last revision:
- Update src/java.base/share/classes/java/lang/invoke/Str
On Fri, 9 Aug 2024 17:59:12 GMT, Brian Burkhalter wrote:
>> This proposed change would move the native objects required for NIO file
>> interaction from the libnio native library to the libjava native library on
>> Linux, macOS, and Windows.
>
> Brian Burkhalter has updated the pull request inc
On Fri, 9 Aug 2024 17:59:12 GMT, Brian Burkhalter wrote:
>> This proposed change would move the native objects required for NIO file
>> interaction from the libnio native library to the libjava native library on
>> Linux, macOS, and Windows.
>
> Brian Burkhalter has updated the pull request inc
On Mon, 12 Aug 2024 14:02:52 GMT, Alan Bateman wrote:
>> 8336384: AbstractQueuedSynchronizer.acquire should cancel acquire when
>> failing due to a LinkageError or other errors
>
> src/java.base/share/classes/java/util/concurrent/locks/AbstractQueuedLongSynchronizer.java
> line 381:
>
>> 379:
On Thu, 8 Aug 2024 11:43:07 GMT, Shaojin Wen wrote:
>> This PR implements the same algorithm as the current generateMHInlineCopy
>> based on bytecode to improve startup performance.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
On Fri, 9 Aug 2024 17:59:12 GMT, Brian Burkhalter wrote:
>> This proposed change would move the native objects required for NIO file
>> interaction from the libnio native library to the libjava native library on
>> Linux, macOS, and Windows.
>
> Brian Burkhalter has updated the pull request inc
On Fri, 2 Aug 2024 16:31:48 GMT, Chen Liang wrote:
>> 1. Add notes and docs about the difference between resolved constants and
>> constant pool descriptors for annotation constants (e.g. `char` vs
>> `IntegerEntry`)
>> 2. Improved value specification to specify their tags.
>> 3. Improved value
On Thu, 8 Aug 2024 11:43:07 GMT, Shaojin Wen wrote:
>> This PR implements the same algorithm as the current generateMHInlineCopy
>> based on bytecode to improve startup performance.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 15 Jul 2024 00:45:25 GMT, Axel Boldt-Christmas
wrote:
>> src/hotspot/share/runtime/lightweightSynchronizer.cpp line 477:
>>
>>> 475: if (obj->mark_acquire().has_monitor()) {
>>> 476: if (_length > 0 && _contended_oops[_length-1] == obj) {
>>> 477: //
>>> assert(VM_Ver
On Tue, 23 Jul 2024 16:44:06 GMT, Coleen Phillimore wrote:
>> I wanted to avoid having to add `NoSafepointVerifier` implementation details
>> in the synchroniser code. I guess `ContinuationWrapper` already does this.
>>
>> Simply creating a `NoSafepointVerifier` when you expect no safepoint is
On Wed, 17 Jul 2024 06:48:03 GMT, David Holmes wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with 10
>> additional commits since the last revision:
>>
>> - Remove try_read
>> - Add explicit to single parameter constructors
>> - Remove superfluous access specifier
> When inflating a monitor the `ObjectMonitor*` is written directly over the
> `markWord` and any overwritten data is displaced into a displaced `markWord`.
> This is problematic for concurrent GCs which needs extra care or looser
> semantics to use this displaced data. In Lilliput this data als
On Tue, 23 Jul 2024 13:20:27 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/runtime/lightweightSynchronizer.cpp line 77:
>>
>>> 75: using ConcurrentTable = ConcurrentHashTable>> MEMFLAGS::mtObjectMonitor>;
>>> 76:
>>> 77: ConcurrentTable* _table;
>>
>> So you have a class ObjectMonitor
On Mon, 15 Jul 2024 04:05:55 GMT, Chen Liang wrote:
> A straightforward optimization, to share the signature parsing of method,
> constructor, and field between the root and the copied objects, like how
> method handle accessors are shared.
There are a lot of transient volatile fields in this
On Mon, 24 Jun 2024 14:33:51 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Mon, 12 Aug 2024 13:41:24 GMT, Viktor Klang wrote:
> 8336384: AbstractQueuedSynchronizer.acquire should cancel acquire when
> failing due to a LinkageError or other errors
src/java.base/share/classes/java/util/concurrent/locks/AbstractQueuedLongSynchronizer.java
line 381:
> 379:
On Mon, 12 Aug 2024 07:31:09 GMT, Rafael Winterhalter
wrote:
>> When a type uses a type variable without a declaration, no exception is
>> thrown. This change triggers a `TypeNotFoundException` to be thrown.
>
> Rafael Winterhalter has refreshed the contents of this pull request, and
> previou
On Mon, 15 Jul 2024 04:05:55 GMT, Chen Liang wrote:
> A straightforward optimization, to share the signature parsing of method,
> constructor, and field between the root and the copied objects, like how
> method handle accessors are shared.
Keep alive.
-
PR Comment: https://git.o
On Mon, 12 Aug 2024 13:41:24 GMT, Viktor Klang wrote:
> 8336384: AbstractQueuedSynchronizer.acquire should cancel acquire when
> failing due to a LinkageError or other errors
@DougLea @AlanBateman FYI
-
PR Comment: https://git.openjdk.org/jdk/pull/20548#issuecomment-2284029040
8336384: AbstractQueuedSynchronizer.acquire should cancel acquire when failing
due to a LinkageError or other errors
-
Commit messages:
- Improve resilience of AQS and AQLS acquire in the face of errors
Changes: https://git.openjdk.org/jdk/pull/20548/files
Webrev: https://webrevs
On Thu, 11 Jul 2024 16:46:13 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
I'm not sure what's unclear in "any character except a, b, or c" or "any
character except one in the Greek block".
A line terminator is neither 'a' nor 'b' nor 'c', nor is it in the Greek
block.
Your example works the same in JDK 8, 11, 17, 21, 22, with or without
the additional MULTILINE or D
> An indify tool in j.l.i tests (also in vmTestBase) convert some source-code
> private static methods with MT_ MH_, and INDY_ prefixes into MethodHandle,
> MethodType, and CallSite constants.
> ### Purpose of Indify
>
> - **Transformation Tool**: `Indify` transforms existing class files to
>
> When a type uses a type variable without a declaration, no exception is
> thrown. This change triggers a `TypeNotFoundException` to be thrown.
Rafael Winterhalter has refreshed the contents of this pull request, and
previous commits have been removed. The incremental views will show difference
75 matches
Mail list logo
