On Fri, 9 Aug 2024 15:54:51 GMT, Roger Riggs <rri...@openjdk.org> wrote:
> Addressing latent issues with ReferencedKeyTest > - During the `methods()` tests the keys should be strongly held to avoid > inadvertent GC collection and subsequent test failures (JDK-8336926) > - Merge changes from Valhalla to use String (identity objects) for keys > instead of Integer and Long that are value objects. (JDK-8336390) The changes look good to me. ------------- Marked as reviewed by never (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/20527#pullrequestreview-2233515552