> The testcase requires root permissions.
>
> Fix by Severin Gehwolf.
> Testcase by Jan Kratochvil.
Jan Kratochvil has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains four commits:
- Implement vm.cgroup.tools
- Use Metrics.systemMetri
On Wed, 24 Jul 2024 16:42:52 GMT, Alexey Semenyuk wrote:
>> tools/jpackage/windows/WinChildProcessTest.java was failing intermittently,
>> fixed the issue and changes are tested.
>
> @sashamatveev please review
@alexeysemenyukoracle @sashamatveev Can you please sponsor?
-
PR Comme
On Tue, 30 Jul 2024 05:59:44 GMT, Vanitha B P wrote:
>> tools/jpackage/windows/WinChildProcessTest.java was failing intermittently,
>> fixed the issue and changes are tested.
>
> Vanitha B P has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
> tools/jpackage/windows/WinChildProcessTest.java was failing intermittently,
> fixed the issue and changes are tested.
Vanitha B P has updated the pull request incrementally with one additional
commit since the last revision:
Vanitha B P
-
Changes:
- all: https://git.openjdk.
On Thu, 25 Jul 2024 23:11:15 GMT, Chen Liang wrote:
> Removes 6 `AccessFlags` factories that do not take class-file versions as its
> arguments.
>
> `AccessFlags` is a wrapper around a bit mask to support modifier streaming in
> ClassFile API. It additionally supports advanced validation based
> Removes 6 `AccessFlags` factories that do not take class-file versions as its
> arguments.
>
> `AccessFlags` is a wrapper around a bit mask to support modifier streaming in
> ClassFile API. It additionally supports advanced validation based on location.
>
> However, as class file versions evo
On Mon, 1 Jul 2024 19:20:48 GMT, Chen Liang wrote:
> Clarify that only `Class` is returned for core reflection implementation, and
> the return type is `Type` to support other implementations, such as ones
> modeling unloaded or remote types.
Keep-alive.
-
PR Comment: https://git
On Mon, 1 Jul 2024 18:22:48 GMT, Chen Liang wrote:
> Clarify that `ParameterizedType.getOwnerType()` always return `null` in a few
> scenarios.
Keep-alive.
-
PR Comment: https://git.openjdk.org/jdk/pull/19977#issuecomment-2257160095
On Mon, 29 Jul 2024 20:51:39 GMT, Raffaello Giulietti
wrote:
>>> The following variant should be preferred, as it has a readable figure on
>>> p. 21, whereas the same figure in the variant linked in the PR seems broken
>>> for some reason. https://inria.hal.science/inria-00072113/document
>>
Hi Bernd,
The issue with the infinite directory tree you observe looks like a
duplicate of [1].
You can add "--verbose" option to jpackage command line to get more
details on what is going on with jpackage.
There is no way to configure the list of directories where native
launcher is looki
On Thu, 25 Jul 2024 22:41:08 GMT, Chen Liang wrote:
> As discussed in offline meeting, the max stack and locals information are
> part of the code attribute and not meaningful for buffered code elements.
> Computation would be costly and these see no real usage during
> transformations. Thus,
On Mon, 29 Jul 2024 12:32:10 GMT, Chen Liang wrote:
>> As discussed in offline meeting, the max stack and locals information are
>> part of the code attribute and not meaningful for buffered code elements.
>> Computation would be costly and these see no real usage during
>> transformations. Th
On Mon, 29 Jul 2024 18:25:54 GMT, fabioromano1 wrote:
>> src/java.base/share/classes/java/math/MutableBigInteger.java line 550:
>>
>>> 548: */
>>> 549: void safeRightShift(int n) {
>>> 550: if (n >= bitLength()) {
>>
>> The commit message for this reads `More accurate condition
Hello,
I noticed some jpackage pecularities:
1 - if you use "-i ." (and no target) it will not ignore its target
directory and recursively copy itself generating a massive deep directory
tree hard to remove.
Sample command:
jpackage --type app-image -n MyApp --main-class myapp.Main --main-ja
In #20241, it's noted that `ClassFile.verify` can return a mix-and-match of
mutable and immutable lists.
Though the mutability of the list returned by `verify` has no particular
importance, as the mutable list is constructed on every call and does not
mutate the models, there are a few scenario
On Fri, 26 Jul 2024 19:17:34 GMT, Justin Lu wrote:
> Please review this PR which is a simple doc only change to
> java.text.DecimalFormat.
>
> Mainly, the DecimalFormat constructors have wording that recommends using the
> NumberFormat factory methods for a standard formatting. This would be b
On Mon, 29 Jul 2024 16:48:32 GMT, Raffaello Giulietti
wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> If the input is a square, then s0 == 0, so testing for non-zero remainder
>> is redundant
>
> src/java.base/sh
On Mon, 29 Jul 2024 16:50:32 GMT, Raffaello Giulietti
wrote:
> Also, I wonder if it wouldn't be simpler for `len` to represent the `int`
> length of the square root rather than the `int` length of the argument. It
> would be more consistent with the Bertot, Magaud, Zimmermann paper and might
Hi Anthony,
Thank you for your patience, and for providing feedback, it is always much
appreciated.
>When writing factory methods for Gatherers, there's sometimes a
degenerate case that requires returning a no-op Gatherer. So I'd like a
way to mark a no-op Gatherer as such, allowing the Stream
On Mon, 29 Jul 2024 16:50:10 GMT, Raffaello Giulietti
wrote:
> The following variant should be preferred, as it has a readable figure on p.
> 21, whereas the same figure in the variant linked in the PR seems broken for
> some reason. https://inria.hal.science/inria-00072113/document
What is t
On Mon, 29 Jul 2024 17:00:09 GMT, Raffaello Giulietti
wrote:
> Sorry, not `<<` but `*`
or `(x.intLen & 1) << 5`
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19710#discussion_r1695649080
On Mon, 29 Jul 2024 14:27:28 GMT, Lance Andersen wrote:
> ... we really need more datapoint to better understand the risks/benefits in
> order to make an informed decision.
Agreed.
Here's some what I've come up with after a little bit of research:
First, we shouldn't confuse GZIP with ZIP fil
On Mon, 29 Jul 2024 16:49:04 GMT, Raffaello Giulietti
wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> If the input is a square, then s0 == 0, so testing for non-zero remainder
>> is redundant
>
> src/java.base/sh
On Mon, 29 Jul 2024 13:18:16 GMT, fabioromano1 wrote:
>> I have implemented the Zimmermann's square root algorithm, available in
>> works [here](https://inria.hal.science/inria-00072854/en/) and
>> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root).
>>
>> The
On Mon, 29 Jul 2024 15:49:10 GMT, Naoto Sato wrote:
> This fix is to address the tier_1 test run on Windows taking much longer time
> than before. The test case creates child processes that remain behind after
> the test run has completed, which is problematic on Windows as the make
> command
On Mon, 29 Jul 2024 15:49:10 GMT, Naoto Sato wrote:
> This fix is to address the tier_1 test run on Windows taking much longer time
> than before. The test case creates child processes that remain behind after
> the test run has completed, which is problematic on Windows as the make
> command
On Mon, 29 Jul 2024 15:49:10 GMT, Naoto Sato wrote:
> This fix is to address the tier_1 test run on Windows taking much longer time
> than before. The test case creates child processes that remain behind after
> the test run has completed, which is problematic on Windows as the make
> command
On Mon, 29 Jul 2024 15:49:10 GMT, Naoto Sato wrote:
> This fix is to address the tier_1 test run on Windows taking much longer time
> than before. The test case creates child processes that remain behind after
> the test run has completed, which is problematic on Windows as the make
> command
On Mon, 29 Jul 2024 15:49:10 GMT, Naoto Sato wrote:
> This fix is to address the tier_1 test run on Windows taking much longer time
> than before. The test case creates child processes that remain behind after
> the test run has completed, which is problematic on Windows as the make
> command
This fix is to address the tier_1 test run on Windows taking much longer time
than before. The test case creates child processes that remain behind after the
test run has completed, which is problematic on Windows as the make command
waits for the process to terminate. Confirmed tier_1/part_1 fi
On Mon, 29 Jul 2024 13:52:57 GMT, Archie Cobbs wrote:
> > So where does that leave us:
> > Keep the code as is and document the current behavior
> > Continue to add additional test coverage for the current API
> > We probably do not need a new constructor given it probably adds no new
> > additi
> Please review this fix for cgroups-based metrics reporting in the
> `jdk.internal.platform` package. This fix is supposed to address wrong
> reporting of certain limits if the limits aren't set at the leaf nodes.
>
> For example, on cg v2, the memory limit interface file is `memory.max`.
> Co
On Mon, 22 Jul 2024 13:48:29 GMT, Severin Gehwolf wrote:
>> Jan Kratochvil has refreshed the contents of this pull request, and previous
>> commits have been removed. Incremental views are not available.
>
> test/hotspot/jtreg/containers/cgroup/NestedCgroup.java line 193:
>
>> 191: }
>>
> The testcase requires root permissions.
>
> Fix by Severin Gehwolf.
> Testcase by Jan Kratochvil.
Jan Kratochvil has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 260 commits:
- Implement vm.cgroup.tools
- Use Metrics.systemMetric
On Mon, 29 Jul 2024 13:06:24 GMT, Lance Andersen wrote:
> So where does that leave us:
>
>Keep the code as is and document the current behavior
>Continue to add additional test coverage for the current API
>We probably do not need a new constructor given it probably adds no new
> ad
> I have implemented the Zimmermann's square root algorithm, available in works
> [here](https://inria.hal.science/inria-00072854/en/) and
> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root).
>
> The algorithm is proved to be asymptotically faster than the New
On Sat, 27 Jul 2024 15:00:51 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>
On Mon, 29 Jul 2024 07:36:15 GMT, Jaikiran Pai wrote:
>> So how should we proceed this? This problem is critical for some modularized
>> applications as I said before.
>>
>> I agree that we need to consider the approach for this, but it is worth to
>> provide the fix even if it is short-term,
On Mon, 29 Jul 2024 12:32:10 GMT, Chen Liang wrote:
>> As discussed in offline meeting, the max stack and locals information are
>> part of the code attribute and not meaningful for buffered code elements.
>> Computation would be costly and these see no real usage during
>> transformations. Th
> As discussed in offline meeting, the max stack and locals information are
> part of the code attribute and not meaningful for buffered code elements.
> Computation would be costly and these see no real usage during
> transformations. Thus, the proposed solution is to move these APIs to be
> C
On Mon, 29 Jul 2024 02:22:11 GMT, Chen Liang wrote:
>> As discussed in offline meeting, the max stack and locals information are
>> part of the code attribute and not meaningful for buffered code elements.
>> Computation would be costly and these see no real usage during
>> transformations. Th
On Mon, 29 Jul 2024 02:22:11 GMT, Chen Liang wrote:
>> As discussed in offline meeting, the max stack and locals information are
>> part of the code attribute and not meaningful for buffered code elements.
>> Computation would be costly and these see no real usage during
>> transformations. Th
On Sun, 28 Jul 2024 06:24:38 GMT, Yasumasa Suenaga wrote:
>> We cannot pass GNU style options like `--enable-preview` to `jlink
>> --add-option`. It is hard to use for complex application.
>>
>> We have workaround for this issue (see JBS), but I think it is better to fix
>> on JDK side.
>
> So
On Fri, 19 Jul 2024 15:36:10 GMT, Liam Miller-Cushon wrote:
>> This change fixes a zip64 bug in the launcher that is prevent it from
>> reading the manifest of jars where the 'relative offset of local header'
>> field in the central directory entry is >4GB. As described in APPNOTE.TXT
>> 4.5.3
44 matches
Mail list logo
