Re: want to try out small idea; where is the implementing class for Stream interface?

2024-07-20 Thread Bernd Eckenfels
Anil wrote on 21. July 2024 04:44 (GMT +02:00): > However, I am unable to find the implementing class of java.util.Stream. You find the package in Java.base module: https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/java/util/stream Gruß Bernd — https://bernd.eckenfels.net

Re: want to try out small idea; where is the implementing class for Stream interface?

2024-07-20 Thread Chen Liang
Hi Anil, are you using intellij and setting up the project with idea.sh? Idea has a bug where its indexing breaks completely; you need to type something in the code, like a typo in method name, to force it to refresh. On Sat, Jul 20, 2024, 9:45 PM Anil <1dropafl...@gmail.com> wrote: > Hi, > I had

want to try out small idea; where is the implementing class for Stream interface?

2024-07-20 Thread Anil
Hi, I had a small idea on debugging of streams and was trying to implement it to see if it works. I am able to build the OpenJDK (on Windows 11, Cygwin64). However, I am unable to find the implementing class of java.util.Stream. Can you please help? thanks, Anil Philip

Re: RFR: 8335939: Hide element writing across the ClassFile API [v3]

2024-07-20 Thread Chen Liang
> `WritableElement` has always been one of the biggest peculiarities of > ClassFile API: it exposes element writing yet has no corresponding reading > ability exposed. Its existence creates a lot of API noise, increasing > maintenance cost in the long run. (This is an iceberg whose tip was expos

Re: RFR: 8336831: Optimize StringConcatHelper.simpleConcat [v5]

2024-07-20 Thread Chen Liang
On Fri, 19 Jul 2024 21:42:09 GMT, Shaojin Wen wrote: >> Currently simpleConcat is implemented using mix and prepend, but in this >> simple scenario, it can be implemented in a simpler way and can improve >> performance. > > Shaojin Wen has updated the pull request incrementally with two additio

Re: RFR: 8336039: Doccheck: HTML warnings, broken links and missing files in java.base documentation [v4]

2024-07-20 Thread Alan Bateman
On Fri, 19 Jul 2024 14:20:48 GMT, Nizar Benalla wrote: >> Can I get a review for this change that fixes some broken links in javadoc >> comments? The new docs are hosted >> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/). >> >> It's mostly fixing some relative li

Re: RFR: 8336831: Optimize StringConcatHelper.simpleConcat [v5]

2024-07-20 Thread Chen Liang
On Sat, 20 Jul 2024 13:16:16 GMT, Brett Okken wrote: >> src/java.base/share/classes/java/lang/StringConcatHelper.java line 387: >> >>> 385: byte[] buf = newArray(newLength); >>> 386: s1.getBytes(buf, 0, coder); >>> 387: s2.getBytes(buf, s1.length(), coder); >> >> Does s1

Re: RFR: 8336831: Optimize StringConcatHelper.simpleConcat [v5]

2024-07-20 Thread Brett Okken
On Sat, 20 Jul 2024 13:11:33 GMT, Brett Okken wrote: >> Shaojin Wen has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Update src/java.base/share/classes/java/lang/String.java >> >>Co-authored-by: Chen Liang >> - add comments >

Re: RFR: 8336831: Optimize StringConcatHelper.simpleConcat [v5]

2024-07-20 Thread Brett Okken
On Fri, 19 Jul 2024 21:42:09 GMT, Shaojin Wen wrote: >> Currently simpleConcat is implemented using mix and prepend, but in this >> simple scenario, it can be implemented in a simpler way and can improve >> performance. > > Shaojin Wen has updated the pull request incrementally with two additio