On Sat, 20 Jul 2024 13:11:33 GMT, Brett Okken <d...@openjdk.org> wrote:
>> Shaojin Wen has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Update src/java.base/share/classes/java/lang/String.java >> >> Co-authored-by: Chen Liang <li...@openjdk.org> >> - add comments > > src/java.base/share/classes/java/lang/StringConcatHelper.java line 387: > >> 385: byte[] buf = newArray(newLength); >> 386: s1.getBytes(buf, 0, coder); >> 387: s2.getBytes(buf, s1.length(), coder); > > Does s1 length need to be shifted by coder for dstBegin? Nope - I see the index is char based https://github.com/openjdk/jdk/blob/69901157e4dae9018abd727956f60fd11b8fa252/src/java.base/share/classes/java/lang/String.java#L4821C15-L4821C23 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20253#discussion_r1685432480
