> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
On Sat, 15 Jun 2024 02:45:40 GMT, Chen Liang wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use JLA replace Unsafe
>
> src/java.base/share/classes/jdk/internal/math/ToDecimal.java line 41:
>
>> 39: public sealed c
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
On Fri, 14 Jun 2024 10:19:47 GMT, Albert Mingkun Yang wrote:
>> Obsolete OldSize and related code. An internal variable `OldSize` is kept to
>> capture the capacity of old-gen size.
>
> Albert Mingkun Yang has updated the pull request with a new target base due
> to a merge or a rebase. The pul
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
On Sat, 15 Jun 2024 03:02:19 GMT, Chen Liang wrote:
>> The current versions of FloatToDecimal and DoubleToDecimal allocate
>> additional objects. Reducing these allocations can improve the performance
>> of Float/Double.toString and AbstractStringBuilder's append(float/double).
>>
>> This patc
On Sat, 15 Jun 2024 01:59:42 GMT, Shaojin Wen wrote:
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is
On Sat, 15 Jun 2024 01:59:42 GMT, Shaojin Wen wrote:
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is
The current versions of FloatToDecimal and DoubleToDecimal allocate additional
objects. Reducing these allocations can improve the performance of
Float/Double.toString and AbstractStringBuilder's append(float/double).
This patch is just a code refactoring to reduce object allocation, but does no
On Thu, 30 May 2024 13:00:21 GMT, Magnus Ihse Bursie wrote:
> This patch contains a set of changes to improve static builds. They will pave
> the way for implementing a full static-only java launcher. The changes here
> will:
>
> 1) Make sure non-exported symbols are made local in the static l
On Thu, 30 May 2024 13:00:21 GMT, Magnus Ihse Bursie wrote:
> This patch contains a set of changes to improve static builds. They will pave
> the way for implementing a full static-only java launcher. The changes here
> will:
>
> 1) Make sure non-exported symbols are made local in the static l
This patch contains a set of changes to improve static builds. They will pave
the way for implementing a full static-only java launcher. The changes here
will:
1) Make sure non-exported symbols are made local in the static libraries. This
means that the risk of symbol conflict is the same for s
On Fri, 14 Jun 2024 10:39:45 GMT, Ferenc Rakoczi wrote:
>> This PR removes some unnecessary conversions between byte arrays and long
>> arrays during SHA3 digest computations.
>
> Ferenc Rakoczi has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Fri, 14 Jun 2024 10:39:45 GMT, Ferenc Rakoczi wrote:
>> This PR removes some unnecessary conversions between byte arrays and long
>> arrays during SHA3 digest computations.
>
> Ferenc Rakoczi has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Fri, 14 Jun 2024 09:47:31 GMT, Ferenc Rakoczi wrote:
>> src/java.base/share/classes/sun/security/provider/SHA3.java line 73:
>>
>>> 71: // The following array is allocated to size WIDTH bytes, but we only
>>> 72: // ever use the first blockSize bytes it (for bytes <-> long
>>> conver
> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
> primitive arrays by combining values into larger stores.
>
> This PR rewrites the code of appendNull and append(boolean) methods so that
> these two methods can be optimized by C2.
Shaojin Wen has updated the pul
> Currently, javap crashes for class files that have set non-zero values for
> undefined access flag bits, as
> `java.lang.reflect.AccessFlag.maskToAccessFlag` and
> `java.lang.classfile.AccessFlags.flags` fail. In contrast, the JVMS, though
> asking for these bits to be set to 0, requires VM t
On Thu, 30 May 2024 02:28:56 GMT, Leonid Mesnik wrote:
> The message is generated if cores (or any other tools) section doesn't exist
> or is empty. However, there is no any tool for cores processing now defined.
> So ERROR message is generating, confusing users.
> The fix is to don't print err
On Fri, 14 Jun 2024 14:51:53 GMT, Weijun Wang wrote:
>> It needs to recognise and throw RuntimeException so that a SecurityException
>> isn't wrapped in a PrivilegedActionException (which gets caught by those
>> blocks of code which call extractException(pe) and look at what Exception
>> it c
> JMX uses APIs related to the Security Mananger which are deprecated. Use of
> AccessControlContext will be removed when Security Manager is removed.
>
> Until then, updates are needed to not require setting
> -Djava.security.manager=allow to use JMX authentication.
Kevin Walls has updated t
On Fri, 14 Jun 2024 14:00:58 GMT, Kevin Walls wrote:
>> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java
>> line 1461:
>>
>>> 1459: throw rte;
>>> 1460: } else {
>>> 1461: throw new PrivilegedActionException(e);
On Fri, 14 Jun 2024 12:41:20 GMT, Kevin Walls wrote:
> Does noPermissionsACC add anything?
I don't know. My principal for this code change is that nothing is changed for
the SM-is-allowed case.
-
PR Comment: https://git.openjdk.org/jdk/pull/19624#issuecomment-2168203868
On Fri, 14 Jun 2024 12:03:07 GMT, Weijun Wang wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Separate SM allowed and not allowed cases
>
> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnec
On Wed, 12 Jun 2024 20:52:51 GMT, Sean Mullan wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>>Undo test policy updates
>
> src/java.management/share/classes/javax/management/monitor/Monitor.java line
> 1543:
>
>>
> JMX uses APIs related to the Security Mananger which are deprecated. Use of
> AccessControlContext will be removed when Security Manager is removed.
>
> Until then, updates are needed to not require setting
> -Djava.security.manager=allow to use JMX authentication.
Kevin Walls has updated t
On Fri, 14 Jun 2024 12:44:17 GMT, Kevin Walls wrote:
>> src/java.management/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java
>> line 353:
>>
>>> 351: } else {
>>> 352: return Subject.getSubject(AccessController.getContext());
>>> 353: }
>>
>> `Sub
> JMX uses APIs related to the Security Mananger which are deprecated. Use of
> AccessControlContext will be removed when Security Manager is removed.
>
> Until then, updates are needed to not require setting
> -Djava.security.manager=allow to use JMX authentication.
Kevin Walls has updated t
On Thu, 2 May 2024 09:48:51 GMT, Christian Stein wrote:
> Please review the change to update to using `jtreg` **7.4**.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredV
On Fri, 14 Jun 2024 10:52:40 GMT, Magnus Ihse Bursie wrote:
>> Ah, I had not realized that there was more than 1 newline. GitHub's UI
>> confused me here, so we're good to go
>
> GitHub's UI assumes the final line has an line break. If it is missing, it
> displays a red 🚫 at the end of the last
On Thu, 6 Jun 2024 11:53:10 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to remove the
> `CHECK_EXCEPTION_NULL_FAIL` macro from the `java` launcher code?
>
> This addresses https://bugs.openjdk.org/browse/JDK-8333714. As noted in that
> JBS issue, in a re
On Fri, 14 Jun 2024 12:04:06 GMT, Weijun Wang wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Separate SM allowed and not allowed cases
>
> src/java.management/share/classes/com/sun/jmx/remote/internal/ServerNotifFo
On Fri, 14 Jun 2024 12:09:46 GMT, Weijun Wang wrote:
> I don't quite understand why there is no more `noPermissionsACC` in
> `Monotor.java`. This looks like the only behavior change when SM is allowed.
> The other source change looks fine to me.
Does noPermissionsACC add anything? Maybe I'm r
On Thu, 13 Jun 2024 20:54:25 GMT, Kevin Walls wrote:
>> JMX uses APIs related to the Security Mananger which are deprecated. Use of
>> AccessControlContext will be removed when Security Manager is removed.
>>
>> Until then, updates are needed to not require setting
>> -Djava.security.manager
On Fri, 7 Jun 2024 13:34:45 GMT, Julian Waters wrote:
>> I find the extra trailing newlines through below shell command:
>>
>> for i in `find . -iname "Makefile*" | sed "/./build/d"` ; do tail -n 2 $i |
>> grep -c "^$" | grep -q "^1$" ; if [[ 0 -eq $? ]] ; then echo $i ; fi ; done
>>
>>
>> Th
On Thu, 2 May 2024 09:48:51 GMT, Christian Stein wrote:
> Please review the change to update to using `jtreg` **7.4**.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredV
> This PR removes some unnecessary conversions between byte arrays and long
> arrays during SHA3 digest computations.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revision:
Accept more review suggestions
-
Changes:
- all:
> Obsolete OldSize and related code. An internal variable `OldSize` is kept to
> capture the capacity of old-gen size.
Albert Mingkun Yang has updated the pull request with a new target base due to
a merge or a rebase. The pull request now contains one commit:
obsolete-old-size
-
On Wed, 12 Jun 2024 21:03:17 GMT, Sean Mullan wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>>Undo test policy updates
>
> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java
>
On Thu, 13 Jun 2024 20:25:22 GMT, Valerie Peng wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix clone(), accept review suggestions.
>
> src/java.base/share/classes/sun/security/provider/SHA3.java line 73:
>
>
On Fri, 14 Jun 2024 05:56:05 GMT, Andrey Turbanov wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix clone(), accept review suggestions.
>
> src/java.base/share/classes/sun/security/provider/SHA3.java line 152:
Please review the change to update to using `jtreg` **7.4**.
The primary change is to the `jib-profiles.js` file, which specifies the
version of jtreg to use, for those systems that rely on this file. In addition,
the `requiredVersion` has been updated in the various `TEST.ROOT` files.
Testing:
On Wed, 5 Jun 2024 20:08:10 GMT, Robert Toyonaga wrote:
> ### Summary
> This change ensures we don't get undefined behavior when
> calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html).
> `isspace` accepts an `int` argument that "the application shall ensur
On Fri, 14 Jun 2024 06:49:34 GMT, Alan Bateman wrote:
> Yes, on my list.
Thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/14787#issuecomment-2167591811
On Fri, 14 Jun 2024 01:17:29 GMT, Shaojin Wen wrote:
>> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
>> primitive arrays by combining values into larger stores.
>>
>> This PR rewrites the code of appendNull and append(boolean) methods so that
>> these two meth
46 matches
Mail list logo
