On Thu, 6 Jun 2024 21:21:23 GMT, David Holmes wrote:
>> ### Summary
>> This change ensures we don't get undefined behavior when
>> calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html).
>> `isspace` accepts an `int` argument that "the application shall ensu
On Thu, 6 Jun 2024 21:44:44 GMT, Scott Gibbons wrote:
>> @asgibbons I generally just stop pushing ANY RFE's a week or two before the
>> fork. Even if you did run the fuzzer with it - there are often last-minute
>> changes. And your code here is rather large, so even if you are confident,
>> th
On Thu, 6 Jun 2024 18:16:14 GMT, Raffaello Giulietti
wrote:
> A documentation-only change to match the original intent and the implemented
> behavior.
Yes, this one needs a CSR.
-
Marked as reviewed by alanb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19583#pullreque
Misc small doc updates and addition of `@Overrides` annotations.
-
Commit messages:
- JDK-8333768: Minor doc updates to java.lang.{Float, Double}
Changes: https://git.openjdk.org/jdk/pull/19590/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19590&range=00
Issue: https://
Thanks for asking, Volker.
At this stage we're still bootstrapping the project and going through internal
processes to publish its OpenJDK repositories with code. We’re also juggling
other projects. I can let you know once the mailing list and repository are
available. In the meantime, feel fre
On Thu, 6 Jun 2024 14:02:03 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to improve
>> the code snippet that's in `java.util.zip.Deflater` and
>> `java.util.zip.Inflater` to better explain the usage of those classes? This
>> addresses https://bug
On Sat, 1 Jun 2024 04:33:57 GMT, Jaikiran Pai wrote:
> Can I please get a review of this doc-only change which proposes to improve
> the code snippet that's in `java.util.zip.Deflater` and
> `java.util.zip.Inflater` to better explain the usage of those classes? This
> addresses https://bugs.op
On Thu, 6 Jun 2024 18:16:14 GMT, Raffaello Giulietti
wrote:
> A documentation-only change to match the original intent and the implemented
> behavior.
Oh, this needs a CSR too, since it's a change to a normative assertion. Should
be pretty simple though.
-
PR Comment: https://gi
On Thu, 6 Jun 2024 19:30:21 GMT, Jorn Vernee wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> mt -> md (desc)
>
> src/java.base/share/classes/jdk/internal/constant/ConstantUtils.java line 76:
>
>> 74: * type and
> This test intends to verify the behavior of JdkConsole for the java.base
> module, wrt restoring the echo. The test assumes the internal methods that
> sets/gets the echo status of the platform.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last re
On Thu, 30 May 2024 16:20:02 GMT, Emanuel Peter wrote:
>> @vnkozlov OK. I'll defer to you all. I've contacted the author of the
>> fuzzer to see what I can do to set up a local instance. Would this be
>> sufficient to increase confidence for future submissions? We can run it
>> perpetually
> In java.base, especially in bytecode generators, we have many different
> methods converting known valid Class and MethodType into ClassDesc and
> MethodTypeDesc. These conversions should be consolidated into the same
> utility method for the ease of future maintenance.
Chen Liang has updated
On Wed, 5 Jun 2024 20:08:10 GMT, Robert Toyonaga wrote:
> ### Summary
> This change ensures we don't get undefined behavior when
> calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html).
> `isspace` accepts an `int` argument that "the application shall ensur
On Thu, 6 Jun 2024 17:08:50 GMT, Naoto Sato wrote:
>> test/jdk/java/io/Console/restoreEcho.exp line 57:
>>
>>> 55: test "$rpprompt" "$rpinput" "-echo" "$rpexpected"
>>> 56: # See if the initialEcho is restored with `stty -a`
>>> 57: expect " $initialEcho "
>>
>> If you leave out those whitespac
On Thu, 6 Jun 2024 17:41:20 GMT, Scott Gibbons wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix copyright & a couple of comment typos
>
> Hi, everyone. I see that JDK 23 has now been forked, and new commits go
On Mon, 3 Jun 2024 22:32:54 GMT, Justin Lu wrote:
> Please review this PR which handles incorrect CompactNumberFormat integer
> only parsing when there is no suffix.
>
> See the following snippet,
>
>
> var fmt = NumberFormat.getCompactNumberInstance(Locale.US,
> NumberFormat.Style.SHORT)
>
On Thu, 6 Jun 2024 17:51:50 GMT, Naoto Sato wrote:
> Turned out that removing the classpath ends up not finding the test class:
>
> ```
> Error: Could not find or load main class RestoreEchoTest
> Caused by: java.lang.ClassNotFoundException: RestoreEchoTest
> ];
> ```
Hm... this is surprising.
On Thu, 6 Jun 2024 18:16:14 GMT, Raffaello Giulietti
wrote:
> A documentation-only change to match the original intent and the implemented
> behavior.
Looks good. The old version with the lookahead and lookbehind was hard to
understand and it was inaccurate as well. The descriptive text is ea
On Thu, 6 Jun 2024 19:09:36 GMT, Claes Redestad wrote:
> There are some pre-existing places where we call
> `ReferenceClassDescImpl.ofValidated` directly that could probably be switched
> over to `ConstantUtils.classDesc` for slightly nicer code. Or - if it matters
> - add a `referenceClassDes
On Thu, 6 Jun 2024 19:24:14 GMT, Chen Liang wrote:
>> In java.base, especially in bytecode generators, we have many different
>> methods converting known valid Class and MethodType into ClassDesc and
>> MethodTypeDesc. These conversions should be consolidated into the same
>> utility method fo
On Thu, 6 Jun 2024 19:01:02 GMT, Claes Redestad wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> mt -> md (desc)
>
> src/java.base/share/classes/jdk/internal/foreign/abi/BindingSpecializer.java
> line 471:
>
>> 469:
> In java.base, especially in bytecode generators, we have many different
> methods converting known valid Class and MethodType into ClassDesc and
> MethodTypeDesc. These conversions should be consolidated into the same
> utility method for the ease of future maintenance.
Chen Liang has updated
On Thu, 6 Jun 2024 18:56:51 GMT, Claes Redestad wrote:
>> In java.base, especially in bytecode generators, we have many different
>> methods converting known valid Class and MethodType into ClassDesc and
>> MethodTypeDesc. These conversions should be consolidated into the same
>> utility metho
On Thu, 6 Jun 2024 18:35:01 GMT, Chen Liang wrote:
> In java.base, especially in bytecode generators, we have many different
> methods converting known valid Class and MethodType into ClassDesc and
> MethodTypeDesc. These conversions should be consolidated into the same
> utility method for th
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick wrote:
>> This provides a slightly more accurate bounding limit for
>> `computeNextExponentialSoftCapped` when calling it from
>> `computeNextGaussian`. This could cause the `while
>> (computeNextExponentialSoftCapped(rng, limit) < limit)` check
> Core reflection's generic signature parsing uses an ancient library with
> outdated visitor pattern on a tree model and contains unnecessary
> boilerplates. This is a duplication of ClassFile API's signature model. We
> should just move to ClassFile API, which is more throughoutly tested as we
In java.base, especially in bytecode generators, we have many different methods
converting known valid Class and MethodType into ClassDesc and MethodTypeDesc.
These conversions should be consolidated into the same utility method for the
ease of future maintenance.
-
Commit messages
> This test intends to verify the behavior of JdkConsole for the java.base
> module, wrt restoring the echo. The test assumes the internal methods that
> sets/gets the echo status of the platform.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last re
On Thu, 30 May 2024 16:16:45 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
A documentation-only change to match the original intent and the implemented
behavior.
-
Commit messages:
- 8333599: Improve description of \b matcher in j.u.r.Pattern
Changes: https://git.openjdk.org/jdk/pull/19583/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19583&ran
On Thu, 6 Jun 2024 14:02:03 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to improve
>> the code snippet that's in `java.util.zip.Deflater` and
>> `java.util.zip.Inflater` to better explain the usage of those classes? This
>> addresses https://bug
On Thu, 6 Jun 2024 17:08:45 GMT, Naoto Sato wrote:
>> test/jdk/java/io/Console/RestoreEchoTest.java line 72:
>>
>>> 70: "--add-opens=java.base/jdk.internal.io=ALL-UNNAMED",
>>> 71: "-Djdk.console=java.base",
>>> 72: "-classpath", testClasses,
>>
>
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote:
> Hi all,
> This PR several extra empty spaces and extra empty lines in several
> Makefiles. It's trivial fix, no risk.
>
> Thanks.
Changes requested by liach (Author).
test/jdk/java/rmi/reliability/benchmark/bench/rmi/Makefile line 1:
> 1:
On Thu, 30 May 2024 16:16:45 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
Just bumping this one more time. I intend to start by opening a JIRA to add
the two proposed methods to `ReflectionFactory`, and go from there. I guess
that we might need a JEP for the proposed serialization restrictions, which
is going to be considerably more involved, so I'm putting that off as a
On Thu, 6 Jun 2024 09:05:23 GMT, Pavel Rappo wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed unnecessary add-opens
>
> test/jdk/java/io/Console/RestoreEchoTest.java line 66:
>
>> 64: OutputAnalyzer o
> This test intends to verify the behavior of JdkConsole for the java.base
> module, wrt restoring the echo. The test assumes the internal methods that
> sets/gets the echo status of the platform.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last re
> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
> order to do this, after a GZIP trailer frame is read, it attempts to read a
> GZIP header frame and, if successful, proceeds onward to d
On Mon, 15 Apr 2024 19:01:08 GMT, Joe Darcy wrote:
> Get JDK 24 underway.
This pull request has now been integrated.
Changeset: 75dc2f85
Author:Joe Darcy
Committer: Jesper Wilhelmsson
URL:
https://git.openjdk.org/jdk/commit/75dc2f8518d0adea30f7065d6732b807c0220756
Stats: 2083 l
### Summary
This change ensures we don't get undefined behavior when
calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html).
`isspace` accepts an `int` argument that "the application shall ensure is a
character representable as an unsigned char or equal to th
On Thu, 6 Jun 2024 09:47:30 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> i
On Fri, 31 May 2024 14:55:57 GMT, Daniel Fuchs wrote:
> HandlersOnComplexResetUpdate and HandlersOnComplexUpdate tests verify that
> loggers are GC'ed (or not GC'ed) after a reset or an update. For that they
> poll a ReferenceQueue in a loop. The number of iteration is adjusted
> according to
On Thu, 6 Jun 2024 10:48:51 GMT, Aleksey Shipilev wrote:
> I think only Oracle CIs run these tests through jtreg wrappers?
We do run them in our CI. Not sure who else runs them that way.
-
PR Comment: https://git.openjdk.org/jdk/pull/19565#issuecomment-2152799029
On Thu, 6 Jun 2024 12:46:36 GMT, jengebr wrote:
>> Improve `java/util/concurrent/CopyOnWriteArrayList` by eliminating needless
>> cloning of Object[0] instances. This cloning is intended to prevent callers
>> from changing array contents, but many `CopyOnWriteArrayList`s are allocated
>> to si
Hello Lambda Experts,
I am looking for clarifications on the following questions.
1. I observed in my tests that lambda classes generated for inline lambda
expressions (ex: LambdaUtil::print), are STRONGLY linked to defining class
loader and never gets collected on GC. This behaviour is sam
On Thu, 6 Jun 2024 12:46:36 GMT, jengebr wrote:
>> Improve `java/util/concurrent/CopyOnWriteArrayList` by eliminating needless
>> cloning of Object[0] instances. This cloning is intended to prevent callers
>> from changing array contents, but many `CopyOnWriteArrayList`s are allocated
>> to si
On Wed, 5 Jun 2024 14:56:26 GMT, jengebr wrote:
> clone() performs a shallow copy, so there is currently no Object[] allocated
> and therefore nothing to optimize.
Yes, I believe so.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19527#discussion_r1629666551
> Can I please get a review of this doc-only change which proposes to improve
> the code snippet that's in `java.util.zip.Deflater` and
> `java.util.zip.Inflater` to better explain the usage of those classes? This
> addresses https://bugs.openjdk.org/browse/JDK-8026127.
>
> The commit in the PR
On Thu, 6 Jun 2024 10:42:20 GMT, Alan Bateman wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix default description of keep-packaged-modules
>
> I've read through all src changes. I think Sundar is looking at
> Can I please get a review for this change which proposes to remove the
> `CHECK_EXCEPTION_NULL_FAIL` macro from the `java` launcher code?
>
> This addresses https://bugs.openjdk.org/browse/JDK-8333714. As noted in that
> JBS issue, in a recent PR discussion, it was suggested
> https://github.
Hello Lambda Experts,
I am looking for clarifications on the following questions.
1. I observed in my tests that lambda classes generated for inline lambda
expressions (ex: LambdaUtil::print), are STRONGLY linked to defining class
loader and never gets collected on GC. This behaviour is sa
Can I please get a review for this change which proposes to remove the
`CHECK_EXCEPTION_NULL_FAIL` macro from the `java` launcher code?
This addresses https://bugs.openjdk.org/browse/JDK-8333714. As noted in that
JBS issue, in a recent PR discussion, it was suggested
https://github.com/openjdk/
On Wed, 5 Jun 2024 17:48:25 GMT, Naoto Sato wrote:
>> This test intends to verify the behavior of JdkConsole for the java.base
>> module, wrt restoring the echo. The test assumes the internal methods that
>> sets/gets the echo status of the platform.
>
> Naoto Sato has updated the pull request
> Improve `java/util/concurrent/CopyOnWriteArrayList` by eliminating needless
> cloning of Object[0] instances. This cloning is intended to prevent callers
> from changing array contents, but many `CopyOnWriteArrayList`s are allocated
> to size zero, or are otherwise maintained empty, so cloning
On Thu, 6 Jun 2024 10:42:20 GMT, Alan Bateman wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix default description of keep-packaged-modules
>
> I've read through all src changes. I think Sundar is looking at
On Thu, 6 Jun 2024 06:41:48 GMT, ExE Boss wrote:
>> Sean Gwizdak has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> commits since
On Wed, 5 Jun 2024 19:21:56 GMT, Jorn Vernee wrote:
> These 4 tests were failing due to an incompatibility with jcstress. They were
> problemlisted in past (https://bugs.openjdk.org/browse/JDK-8326062).
>
> Now that jcstress has been updated
> (https://github.com/openjdk/jdk/pull/19332) with t
On Thu, 6 Jun 2024 09:47:30 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> i
> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
> method handles.
>
> This patch converts ASM calls to Classfile API.
>
> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>
> Any comments and suggestions are welcome.
>
> Please review.
>
> Tha
On Thu, 6 Jun 2024 09:47:30 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> i
On Thu, 6 Jun 2024 09:33:43 GMT, Magnus Ihse Bursie wrote:
> As Erik says. You need to add something like: `DEFAULT_DESC: [the inverse of
> --enable-runtime-link-image]`.
https://github.com/openjdk/jdk/pull/14787/commits/7a8f839e55c5109deeb5022d2338b37387c95c85
does that. Sorry it clashed with
> Please review this patch which adds a jlink mode to the JDK which doesn't
> need the packaged modules being present. A.k.a run-time image based jlink.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jm
> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
> method handles.
>
> This patch converts ASM calls to Classfile API.
>
> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>
> Any comments and suggestions are welcome.
>
> Please review.
>
> Tha
On Wed, 5 Jun 2024 17:31:44 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> i
On Thu, 30 May 2024 12:50:36 GMT, Claes Redestad wrote:
> Extracting duplicate method references to static field reduce proxy class
> spinning and loading. In this case 2 less classes loaded when using
> `findAny()` on each type of stream.
The intermediate `Predicate`s and `Supplier`s don’t ne
> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
> method handles.
>
> This patch converts ASM calls to Classfile API.
>
> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>
> Any comments and suggestions are welcome.
>
> Please review.
>
> Tha
> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
> method handles.
>
> This patch converts ASM calls to Classfile API.
>
> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>
> Any comments and suggestions are welcome.
>
> Please review.
>
> Tha
> Can I please get a review of this doc-only change which proposes to improve
> the code snippet that's in `java.util.zip.Deflater` and
> `java.util.zip.Inflater` to better explain the usage of those classes? This
> addresses https://bugs.openjdk.org/browse/JDK-8026127.
>
> The commit in the PR
> This patch changes the algorithm of `Node::dominates` to make the result more
> precise, and allows the iterators of `ConcurrentHashMap` to be scalar
> replaced.
>
> The previous algorithm will return a conservative result when encountering a
> dead control flow, and only try the first two in
On Wed, 5 Jun 2024 05:40:12 GMT, Tobias Hartmann wrote:
>> MaxXing has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert last commit, and push the `LoadNode` back to the worklist to wait
>> for the dead code to be removed.
>
> Impressi
70 matches
Mail list logo
