On Thu, 6 Jun 2024 18:56:51 GMT, Claes Redestad <redes...@openjdk.org> wrote:
>> In java.base, especially in bytecode generators, we have many different >> methods converting known valid Class and MethodType into ClassDesc and >> MethodTypeDesc. These conversions should be consolidated into the same >> utility method for the ease of future maintenance. > > src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 469: > >> 467: // o instanceof Wrapped(float) >> 468: cb.aload(SELECTOR_OBJ); >> 469: >> cb.instanceOf(classDesc(Wrapper.forBasicType(classLabel) > > I have a patch somewhere to cache the wrapper class desc in > `sun.invoke.util.Wrapper`, both as a micro-optimization and to help > disambigutate the unfortunately named (my bad) `Wrapper::classDescriptor` > method. Maybe we can roll that into this..? Feel free, or you can get your patch merged first and then I base off yours if yours is ready. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19585#discussion_r1630091038
