On Wed, 6 Mar 2024 18:26:16 GMT, Lei Zhu wrote:
> When the specified key did not associated with a value, should check the
> `key` and `value` type.
This pull request has now been integrated.
Changeset: b5e1615c
Author:Korov
Committer: Per Minborg
URL:
https://git.openjdk.org/jdk/
On Thu, 7 Mar 2024 05:33:16 GMT, Lei Zhu wrote:
>> When the specified key did not associated with a value, should check the
>> `key` and `value` type.
>
> Lei Zhu has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Use testNG builtin functiona
On Mon, 27 May 2024 12:40:07 GMT, Chen Liang wrote:
> @minborg Is it possible for you to review this collection bugfix?
Will do! Thanks for the heads up.
-
PR Comment: https://git.openjdk.org/jdk/pull/18141#issuecomment-2134446236
> Please review this PR, which supersedes a now withdrawn
> https://github.com/openjdk/jdk/pull/14831.
>
> This PR replaces `ArraysSupport.vectorizedHashCode` with a set of more
> user-friendly methods. Here's a summary:
>
> - Made the operand constants (i.e. `T_BOOLEAN` and friends) and the
>
> This change overrides mutator methods in the implementation returned by
> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
Liam Miller-Cushon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
br
On Mon, 27 May 2024 12:18:23 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/util/ImmutableCollections.java line 1323:
>>
>>> 1321: @Override
>>> 1322: public int hashCode() {
>>> 1323: return MapN.this.hashCode();
>>
>> The hash co
Please review this PR, which supersedes a now withdrawn
https://github.com/openjdk/jdk/pull/14831.
This PR replaces `ArraysSupport.vectorizedHashCode` with a set of more
user-friendly methods. Here's a summary:
- Made the operand constants (i.e. `T_BOOLEAN` and friends) and the
`vectorizedHash
On Tue, 11 Jul 2023 16:35:51 GMT, Pavel Rappo wrote:
> This PR adds an internal method to calculate hash code from the provided
> integer array, offset and length into that array, and the initial hash code
> value.
>
> Current options for calculating a hash code for int[] are inflexible. It's
> This is the implementation changes for JEP 471.
>
> The methods in sun.misc.Unsafe for on-heap and off-heap access are deprecated
> for removal. This means a removal warning at compile time. No methods have
> been removed. A deprecated message is added to each of the methods but
> unlikely to
On Mon, 27 May 2024 16:08:04 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java line 822:
>>
>>> 820:.iconst_0() // false
>>> 821:.aload(0)// classLoader
>>> 822:.invokestatic(CD_Class, "forName",
>>> MTD_
On Mon, 27 May 2024 12:24:31 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> performance improvements
>
> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java line 822:
>
>> 820:
> [JDK-8294961](https://bugs.openjdk.org/browse/JDK-8294961) changed to use
> classfile API for reflection proxy-generation. Actual implementation of
> `ProxyGenerator` is focused on performance, however it causes JDK bootstrap
> regressions. `ProxyGenerator.TEMPLATE` class model is statically c
> There aren't any API or implementations changes in third preview but the JEP
> number/title needs to be bumped for the javadoc page.
Alan Bateman has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by
On Tue, 12 Mar 2024 10:44:54 GMT, Yudi Zheng wrote:
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
This pull request has now been integrated.
Changeset: ed81a478
Author:Yudi Zhe
On Fri, 24 May 2024 15:12:28 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request with a new target base due to a merge
On Thu, 7 Mar 2024 05:33:16 GMT, Lei Zhu wrote:
>> When the specified key did not associated with a value, should check the
>> `key` and `value` type.
>
> Lei Zhu has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Use testNG builtin functiona
On Mon, 27 May 2024 11:47:15 GMT, Adam Sotona wrote:
>> [JDK-8294961](https://bugs.openjdk.org/browse/JDK-8294961) changed to use
>> classfile API for reflection proxy-generation. Actual implementation of
>> `ProxyGenerator` is focused on performance, however it causes JDK bootstrap
>> regress
> [JDK-8294961](https://bugs.openjdk.org/browse/JDK-8294961) changed to use
> classfile API for reflection proxy-generation. Actual implementation of
> `ProxyGenerator` is focused on performance, however it causes JDK bootstrap
> regressions. `ProxyGenerator.TEMPLATE` class model is statically c
On Thu, 23 May 2024 18:52:53 GMT, Alan Bateman wrote:
> Yes, I want to help you get this one over the line.
Thanks! Appreciate that.
-
PR Comment: https://git.openjdk.org/jdk/pull/14787#issuecomment-2133375454
On Mon, 27 May 2024 07:24:47 GMT, Per Minborg wrote:
>> This change overrides mutator methods in the implementation returned by
>> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
>
> src/java.base/share/classes/java/util/ImmutableCollections.java line 1323:
>
>> 1321:
> This checker checks the values of the `@since` tag found in the documentation
> comment for an element against the release in which the element first
> appeared.
>
> Real since value of an API element is computed as the oldest release in which
> the given API element was introduced. That is:
On Sun, 26 May 2024 07:24:16 GMT, SendaoYan wrote:
>> Hi all,
>> When there is no `/usr/bin/expect` in system, `throw new SkippedException`
>> will not make the jvm exit in `@BeforeAll` junit stage, thus this will cause
>> this testcase run failed. So I make change from `throw new SkippedExce
> [JDK-8294961](https://bugs.openjdk.org/browse/JDK-8294961) changed to use
> classfile API for reflection proxy-generation. Actual implementation of
> `ProxyGenerator` is focused on performance, however it causes JDK bootstrap
> regressions. `ProxyGenerator.TEMPLATE` class model is statically c
On Sun, 26 May 2024 07:24:16 GMT, SendaoYan wrote:
>> Hi all,
>> When there is no `/usr/bin/expect` in system, `throw new SkippedException`
>> will not make the jvm exit in `@BeforeAll` junit stage, thus this will cause
>> this testcase run failed. So I make change from `throw new SkippedExce
> [JDK-8294961](https://bugs.openjdk.org/browse/JDK-8294961) changed to use
> classfile API for reflection proxy-generation. Actual implementation of
> `ProxyGenerator` is focused on performance, however it causes JDK bootstrap
> regressions. `ProxyGenerator.TEMPLATE` class model is statically c
On Fri, 24 May 2024 12:16:25 GMT, Ludvig Janiuk wrote:
> Adding commetns to clarify that the failure_handler selftests are intended to
> be run manually. Ideally this would include a more thorough description of
> the exepcted outputs, but this is what I have time to add right now.
This pull r
> Adding commetns to clarify that the failure_handler selftests are intended to
> be run manually. Ideally this would include a more thorough description of
> the exepcted outputs, but this is what I have time to add right now.
Ludvig Janiuk has updated the pull request incrementally with three
On Fri, 24 May 2024 14:34:39 GMT, Ludvig Janiuk wrote:
> Also log the directory in which the command used by failure_handler was
> executed. While often the same, it isn't always, and so it this should
> simplify troubleshooting for someone looking at this at a glance without
> being a failure
On Fri, 24 May 2024 19:26:29 GMT, Erik Joelsson wrote:
>> Adding commetns to clarify that the failure_handler selftests are intended
>> to be run manually. Ideally this would include a more thorough description
>> of the exepcted outputs, but this is what I have time to add right now.
>
> test/
[JDK-8294961](https://bugs.openjdk.org/browse/JDK-8294961) changed to use
classfile API for reflection proxy-generation. Actual implementation of
`ProxyGenerator` is focused on performance, however it causes JDK bootstrap
regressions. `ProxyGenerator.TEMPLATE` class model is statically created a
On Wed, 27 Mar 2024 17:36:28 GMT, Liam Miller-Cushon wrote:
> This change overrides mutator methods in the implementation returned by
> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
src/java.base/share/classes/java/util/ImmutableCollections.java line 1323:
> 1321:
31 matches
Mail list logo
