On Fri, 24 May 2024 19:26:29 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Adding commetns to clarify that the failure_handler selftests are intended >> to be run manually. Ideally this would include a more thorough description >> of the exepcted outputs, but this is what I have time to add right now. > > test/failure_handler/README line 115: > >> 113: generated artifacts and cannot be run as part of a CI. They are tests >> which timeout, crash, >> 114: fail in various ways and you can check the failure_handler output >> yourself. They might also >> 115: leave processes running on your machine so be extra careful about >> cleaning up. > > These lines are longer than the text blocks in the rest of this file. Could > you adjust formatting to match? Sure, thanks for noticing. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19393#discussion_r1615787886
