On Wed, 3 Apr 2024 10:04:36 GMT, Alan Bateman wrote:
> This change drops the adjustments to the virtual thread scheduler's target
> parallelism when virtual threads do file operations on files that are opened
> for buffered I/O. These operations are usually just too short to have any
> benefit
On Wed, 10 Apr 2024 00:41:39 GMT, Brian Burkhalter wrote:
> changes look to be the most complicated here but I don't see any problems.
I have some changes come that should make this easier to read, I'll update the
PR in a few days.
-
PR Comment: https://git.openjdk.org/jdk/pull/1
On Tue, 9 Apr 2024 01:13:49 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which proposes to address
> the intermittent failures in
> `java/util/Properties/StoreReproducibilityTest.java`? This should address
> https://bugs.openjdk.org/browse/JDK-8329729.
>
> The
On Tue, 9 Apr 2024 16:29:07 GMT, Naoto Sato wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Naoto's suggestion - use Instant.MIN and Instant.MAX instead of hardcoded
>> values
>
> src/java.base/share/classes/java/
On Wed, 3 Apr 2024 10:04:36 GMT, Alan Bateman wrote:
> This change drops the adjustments to the virtual thread scheduler's target
> parallelism when virtual threads do file operations on files that are opened
> for buffered I/O. These operations are usually just too short to have any
> benefit
On Sun, 7 Apr 2024 05:14:08 GMT, Francesco Nigro wrote:
>> I went ahead and tried a pure-Java implementation, and it is faster for
>> small sizes (up to 8) and only about 1.5x slower for larger sizes, so that
>> might make for an interesting fallback if there is no customized assembler
>> impl
On Tue, 9 Apr 2024 21:03:57 GMT, Pavel Rappo wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update the copyright year to 2024
>
> Trivially, what's the reason you capitalised the word "tags" in the PR title
> an
On Tue, 9 Apr 2024 20:50:18 GMT, Chen Liang wrote:
>> `/covered`
>
> @nizarbenalla Why don't you add since tags for `superclassSignature` and
> `superinterfaceSignatures` methods, both of which have their signatures
> changed like the two `of` methods?
@liach good find! maybe I should look mor
On Mon, 11 Mar 2024 19:31:45 GMT, Srinivas Vamsi Parasa
wrote:
>> Hi Vladimir (@iaroslavski),
>>
>> Please see the data below.
>>
>> Thanks,
>> Vamsi
>>
>> > xmlns:o="urn:schemas-microsoft-com:office:office"
>> xmlns:x="urn:schemas-microsoft-com:office:excel"
>> xmlns="http://www.w3.org/TR/RE
On Wed, 20 Mar 2024 02:10:35 GMT, Nizar Benalla wrote:
>> # Issue
>> - [JDK-8326836](https://bugs.openjdk.org/browse/JDK-8326836): changes were
>> made to the method signatures but this modification isn't reflected in the @
>> since tags. The @ since tags need to be updated.
>>
>> I changed th
On Mon, 11 Mar 2024 15:50:41 GMT, Nizar Benalla wrote:
>> # Issue
>> - [JDK-8326836](https://bugs.openjdk.org/browse/JDK-8326836): changes were
>> made to the method signatures but this modification isn't reflected in the @
>> since tags. The @ since tags need to be updated.
>>
>> I changed th
On Tue, 9 Apr 2024 11:34:45 GMT, Maurizio Cimadamore
wrote:
> This PR removes support for the string template feature from the Java
> compiler and the Java SE API, as discussed here:
>
> https://mail.openjdk.org/pipermail/amber-spec-experts/2024-April/004106.html
src/java.base/share/classes/j
> Allow support for both .a and .so files in AIX.
> If .so file is not found, allow fallback to .a extension.
> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
Suchismith Roy has updated the pull request incrementally with two additional
commits since the last revision:
-
On Tue, 9 Apr 2024 15:28:08 GMT, Matthias Baesken wrote:
> We have already good JLI tracing capabilities. But GetApplicationHome and
> GetApplicationHomeFromDll lack some tracing and should be enhanced.
This looks very ad hoc. Not opposed to expanding the set of trace messages when
this env va
On Tue, 9 Apr 2024 10:07:46 GMT, Viktor Klang wrote:
>> This PR implements Gatherer-inspired encoding of `flatMap` that shows that
>> it is both competitive performance-wise as well as improve correctness.
>>
>> Below is the performance of `Stream::flatMap` (for reference types):
>>
>> Before
On Tue, 9 Apr 2024 08:37:29 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8212895?
>>
>> As noted in that issue, the `ChronoField.INSTANT_SECONDS` currently is
>> initialized to have a minimu
On Tue, 9 Apr 2024 15:15:52 GMT, Jaikiran Pai wrote:
>> This change drops the adjustments to the virtual thread scheduler's target
>> parallelism when virtual threads do file operations on files that are opened
>> for buffered I/O. These operations are usually just too short to have any
>> ben
On Tue, 9 Apr 2024 15:28:08 GMT, Matthias Baesken wrote:
> We have already good JLI tracing capabilities. But GetApplicationHome and
> GetApplicationHomeFromDll lack some tracing and should be enhanced.
Btw. I noticed that GetModuleFileName return value is not checked, should this
be done (at
On Mon, 8 Apr 2024 10:50:00 GMT, Evgeny Nikitin wrote:
> Improve RNG usage in said tests:
>
> 1. The RNG is not created by our Utils class, as suggested in our JTReg tests;
> 2. The seed, accordingly, is not a fixed value now, but truly random;
> 3. The tests that had been creating their own Ran
We have already good JLI tracing capabilities. But GetApplicationHome and
GetApplicationHomeFromDll lack some tracing and should be enhanced.
-
Commit messages:
- JDK-8329862
Changes: https://git.openjdk.org/jdk/pull/18699/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18
On Tue, 9 Apr 2024 14:50:00 GMT, Alan Bateman wrote:
> It's to increase the target parallelism for the duration of the transfer
> rather than specific read operations.
Do you think we would need to do something similar in`PipeInputStream` that
belongs to `Process`?
-
PR Review Co
On Wed, 3 Apr 2024 10:04:36 GMT, Alan Bateman wrote:
> This change drops the adjustments to the virtual thread scheduler's target
> parallelism when virtual threads do file operations on files that are opened
> for buffered I/O. These operations are usually just too short to have any
> benefit
On Tue, 9 Apr 2024 14:59:00 GMT, Jaikiran Pai wrote:
> Was the use the word `tryCompensate` intentional here? I don't see that
> method in this class or in the implementation of
> `CarrierThread.beginBlocking()`
The FJP method is named tryCompensate and the same method name was used here at
o
On Wed, 3 Apr 2024 10:04:36 GMT, Alan Bateman wrote:
> This change drops the adjustments to the virtual thread scheduler's target
> parallelism when virtual threads do file operations on files that are opened
> for buffered I/O. These operations are usually just too short to have any
> benefit
On Wed, 3 Apr 2024 10:04:36 GMT, Alan Bateman wrote:
> This change drops the adjustments to the virtual thread scheduler's target
> parallelism when virtual threads do file operations on files that are opened
> for buffered I/O. These operations are usually just too short to have any
> benefit
On Tue, 9 Apr 2024 13:58:31 GMT, Jaikiran Pai wrote:
>> This change drops the adjustments to the virtual thread scheduler's target
>> parallelism when virtual threads do file operations on files that are opened
>> for buffered I/O. These operations are usually just too short to have any
>> ben
On Tue, 9 Apr 2024 13:39:47 GMT, Adam Sotona wrote:
> Class-File API `ClassPrinter` prints many useful info about bootstrap methods
> and invoke dynamic instructions, however bootstrap methods arguments are
> missing.
> This patch fixes bootstrap methods and invoke dynamic instructions printing
On Tue, 9 Apr 2024 14:21:59 GMT, Brian Goetz wrote:
>> Class-File API `ClassPrinter` prints many useful info about bootstrap
>> methods and invoke dynamic instructions, however bootstrap methods arguments
>> are missing.
>> This patch fixes bootstrap methods and invoke dynamic instructions prin
On Tue, 9 Apr 2024 13:53:11 GMT, Jaikiran Pai wrote:
>> This change drops the adjustments to the virtual thread scheduler's target
>> parallelism when virtual threads do file operations on files that are opened
>> for buffered I/O. These operations are usually just too short to have any
>> ben
On Wed, 3 Apr 2024 08:48:43 GMT, Adam Sotona wrote:
> Some of the Class-File API options were not mentioned in the package summary
> and one exception mentioned `ClassFile.DeadLabelsOption` javadoc was wrong.
> This patch fixes the javadoc.
>
> Please review.
>
> Thank you,
> Adam
This pull r
On Tue, 9 Apr 2024 14:22:37 GMT, Brian Goetz wrote:
>> Some of the Class-File API options were not mentioned in the package summary
>> and one exception mentioned `ClassFile.DeadLabelsOption` javadoc was wrong.
>> This patch fixes the javadoc.
>>
>> Please review.
>>
>> Thank you,
>> Adam
>
>
On Tue, 9 Apr 2024 14:20:51 GMT, Jaikiran Pai wrote:
>> This change drops the adjustments to the virtual thread scheduler's target
>> parallelism when virtual threads do file operations on files that are opened
>> for buffered I/O. These operations are usually just too short to have any
>> ben
On Tue, 9 Apr 2024 09:32:38 GMT, Adam Sotona wrote:
>> `IllegalArgumentException` thrown by some static factory methods of the
>> following `java.lang.classfile.instruction` interfaces are not documented:
>>
>> - `ArrayLoadInstruction`
>> - `ArrayStoreInstruction`
>> - `BranchInstruction`
>> -
On Wed, 3 Apr 2024 08:48:43 GMT, Adam Sotona wrote:
> Some of the Class-File API options were not mentioned in the package summary
> and one exception mentioned `ClassFile.DeadLabelsOption` javadoc was wrong.
> This patch fixes the javadoc.
>
> Please review.
>
> Thank you,
> Adam
Marked as r
On Tue, 9 Apr 2024 13:39:47 GMT, Adam Sotona wrote:
> Class-File API `ClassPrinter` prints many useful info about bootstrap methods
> and invoke dynamic instructions, however bootstrap methods arguments are
> missing.
> This patch fixes bootstrap methods and invoke dynamic instructions printing
On Wed, 3 Apr 2024 10:04:36 GMT, Alan Bateman wrote:
> This change drops the adjustments to the virtual thread scheduler's target
> parallelism when virtual threads do file operations on files that are opened
> for buffered I/O. These operations are usually just too short to have any
> benefit
On Wed, 3 Apr 2024 10:04:36 GMT, Alan Bateman wrote:
> This change drops the adjustments to the virtual thread scheduler's target
> parallelism when virtual threads do file operations on files that are opened
> for buffered I/O. These operations are usually just too short to have any
> benefit
On Mon, 26 Feb 2024 17:48:53 GMT, Chen Liang wrote:
>> API changes as discussed on the mailing list:
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-November/000419.html
>>
>> Additional questions:
>> 1. Whether to rename `WildcardIndicator.DEFAULT` to `NONE`
>
> Chen Liang has upd
On Wed, 20 Mar 2024 02:10:35 GMT, Nizar Benalla wrote:
>> # Issue
>> - [JDK-8326836](https://bugs.openjdk.org/browse/JDK-8326836): changes were
>> made to the method signatures but this modification isn't reflected in the @
>> since tags. The @ since tags need to be updated.
>>
>> I changed th
On Wed, 3 Apr 2024 10:04:36 GMT, Alan Bateman wrote:
> This change drops the adjustments to the virtual thread scheduler's target
> parallelism when virtual threads do file operations on files that are opened
> for buffered I/O. These operations are usually just too short to have any
> benefit
On Wed, 3 Apr 2024 10:04:36 GMT, Alan Bateman wrote:
> This change drops the adjustments to the virtual thread scheduler's target
> parallelism when virtual threads do file operations on files that are opened
> for buffered I/O. These operations are usually just too short to have any
> benefit
On Tue, 9 Apr 2024 08:34:39 GMT, Jaikiran Pai wrote:
>> Should `INSTANT_SECONDS("InstantSeconds", SECONDS, FOREVER,
>> ValueRange.of(Instant.MIN.getEpochSecond(), Instant.MAX.getEpochSecond())),
>> ` work?
>
> Hello Naoto, that's a very good point. I was too caught up with the constant
> values
On Tue, 9 Apr 2024 08:37:29 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8212895?
>>
>> As noted in that issue, the `ChronoField.INSTANT_SECONDS` currently is
>> initialized to have a minimu
Class-File API `ClassPrinter` prints many useful info about bootstrap methods
and invoke dynamic instructions, however bootstrap methods arguments are
missing.
This patch fixes bootstrap methods and invoke dynamic instructions printing.
`ClassPrinterTest` is extended to print bootstrap method and
> This is an implementation of JEP JDK-8315129: Module Import Declarations
> (Preview). Please see the JEP for details:
> https://bugs.openjdk.org/browse/JDK-8315129
>
> It is mostly straightforward - the module imports are parsed, and then
> expanded to import-on-demand in `TypeEnter`.
> There
This patch suggests a workaround to an issue with huge SCF MH expression trees
taking excessive JIT compilation resources by reviving (part of) the simple
bytecode-generating strategy that was originally available as an all-or-nothing
strategy choice.
Instead of reintroducing a binary strategy
This PR removes support for the string template feature from the Java compiler
and the Java SE API, as discussed here:
https://mail.openjdk.org/pipermail/amber-spec-experts/2024-April/004106.html
-
Commit messages:
- Drop spurious changes
- Merge branch 'master' into template_remo
> This is an implementation of JEP JDK-8315129: Module Import Declarations
> (Preview). Please see the JEP for details:
> https://bugs.openjdk.org/browse/JDK-8315129
>
> It is mostly straightforward - the module imports are parsed, and then
> expanded to import-on-demand in `TypeEnter`.
> There
On Thu, 8 Feb 2024 13:18:41 GMT, Adam Sotona wrote:
> ClassFile API provides two sets of instructions implementations (bound and
> unbound).
> Unbound implementation of `IncrementInstruction::constant` returns invalid
> value.
> This bug discovered a hole in the ClassFile API test coverage.
>
On Tue, 9 Apr 2024 10:04:44 GMT, Viktor Klang wrote:
>> This PR implements Gatherer-inspired encoding of `flatMap` that shows that
>> it is both competitive performance-wise as well as improve correctness.
>>
>> Below is the performance of `Stream::flatMap` (for reference types):
>>
>> Before
> This PR implements Gatherer-inspired encoding of `flatMap` that shows that it
> is both competitive performance-wise as well as improve correctness.
>
> Below is the performance of `Stream::flatMap` (for reference types):
>
> Before this PR:
>
>
> Benchmark(size) Mode Cnt
On Thu, 4 Apr 2024 12:18:07 GMT, Viktor Klang wrote:
> This PR implements Gatherer-inspired encoding of `flatMap` that shows that it
> is both competitive performance-wise as well as improve correctness.
>
> Below is the performance of `Stream::flatMap` (for reference types):
>
> Before this P
On Mon, 8 Apr 2024 19:45:14 GMT, Martin Doerr wrote:
>> Suchismith Roy has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> test change
>
> test/jdk/java/lang/RuntimeTests/loadLibrary/aix/LoadAIXLibraryFromArchiveObject.java
> line 36:
>
>>
On Mon, 8 Apr 2024 16:47:24 GMT, Paul Sandoz wrote:
> > @PaulSandoz @AlanBateman I've added a commit to this PR which removes the
> > use of Gatherer for Stream::flatMap, but instead implements flatMap for all
> > of the pipelines using the same encoding which Gatherer would use. It seems
> >
On Mon, 8 Apr 2024 10:20:11 GMT, Viktor Klang wrote:
> @PaulSandoz @AlanBateman I've added a commit to this PR which removes the use
> of Gatherer for Stream::flatMap, but instead implements flatMap for all of
> the pipelines using the same encoding which Gatherer would use. It seems very
> co
On Thu, 4 Apr 2024 12:18:07 GMT, Viktor Klang wrote:
> This PR implements Gatherer-inspired encoding of `flatMap` that shows that it
> is both competitive performance-wise as well as improve correctness.
>
> Below is the performance of `Stream::flatMap` (for reference types):
>
> Before this P
This PR implements Gatherer-inspired encoding of `flatMap` that shows that it
is both competitive performance-wise as well as improve correctness.
Below is the performance of `Stream::flatMap` (for reference types):
Before this PR:
Benchmark(size) Mode CntScore Err
On Wed, 3 Apr 2024 22:31:39 GMT, Mandy Chung wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Move CreateLinkableRuntimePlugin to build folder
>>
>> Keep runtime link supporting classes in package
>> jdk.t
On Wed, 3 Apr 2024 08:15:52 GMT, Adam Sotona wrote:
> `Opcode.IFNONNULL.primaryTypeKind()` wrongly returned `IntType` instead of
> the right `ReferenceType`.
> Primary type kinds of `BRANCH` opcodes have yet no functional effect in the
> Class-File API.
> This simple patch fixes the typo.
>
>
> `IllegalArgumentException` thrown by some static factory methods of the
> following `java.lang.classfile.instruction` interfaces are not documented:
>
> - `ArrayLoadInstruction`
> - `ArrayStoreInstruction`
> - `BranchInstruction`
> - `ConvertInstruction`
> - `DiscontinuedInstruction`
> - `Field
On Mon, 8 Apr 2024 16:36:49 GMT, Vicente Romero wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding tests as suggested.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java
> line 101:
>
> This is a patch for javac, that adds the Derived Record Creation expressions.
> The current draft specification for the feature is:
> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>
> The current CSR is here:
> https://bugs.openjdk.org/browse/JDK
On Fri, 9 Feb 2024 10:47:08 GMT, Adam Sotona wrote:
>> ClassFile API provides two sets of instructions implementations (bound and
>> unbound).
>> Unbound implementation of `IncrementInstruction::constant` returns invalid
>> value.
>> This bug discovered a hole in the ClassFile API test coverag
On Wed, 3 Apr 2024 08:15:52 GMT, Adam Sotona wrote:
> `Opcode.IFNONNULL.primaryTypeKind()` wrongly returned `IntType` instead of
> the right `ReferenceType`.
> Primary type kinds of `BRANCH` opcodes have yet no functional effect in the
> Class-File API.
> This simple patch fixes the typo.
>
>
On Fri, 5 Apr 2024 18:30:30 GMT, Joe Darcy wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflecting review feedback:
>> - pre-generating the JCVarDecls in Attr, to aid Flow
>> - adding a note on how the desugar
On Tue, 27 Feb 2024 08:45:12 GMT, Adam Sotona wrote:
> Task providing Class-File API transition to Second Preview.
This pull request has now been integrated.
Changeset: 19a99d02
Author:Adam Sotona
URL:
https://git.openjdk.org/jdk/commit/19a99d023e32fa9f4d26b76bd36993719e1dfe21
Stats
On Tue, 9 Apr 2024 01:34:56 GMT, Naoto Sato wrote:
>> Hello Roger,
>>
>>> The code should reference the constants in Instant.java (though may need to
>>> make them package private.)
>>
>> The `ChronoField` class and the `Instant` class reside in separate packages,
>> so making these two field
> Can I please get a review of this change which proposes to fix the issue
> noted in https://bugs.openjdk.org/browse/JDK-8212895?
>
> As noted in that issue, the `ChronoField.INSTANT_SECONDS` currently is
> initialized to have a minimum and maximum values of `Long.MIN_VALUE` and
> `LONG.MAX_VA
On Tue, 9 Apr 2024 01:27:29 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which proposes to address
>> the intermittent failures in
>> `java/util/Properties/StoreReproducibilityTest.java`? This should address
>> https://bugs.openjdk.org/browse/JDK-8329729.
>>
> Can I please get a review of this test-only change which proposes to address
> the intermittent failures in
> `java/util/Properties/StoreReproducibilityTest.java`? This should address
> https://bugs.openjdk.org/browse/JDK-8329729.
>
> These failures in `StoreReproducibilityTest` have been obs
On Fri, 5 Apr 2024 02:40:16 GMT, Dean Long wrote:
> That way C2 can do all its usual optimizations, like unrolling,
> vectorization, and redundant store elimination (if it is an on-heap primitive
> array that was just allocated, then there is no need to zero the parts that
> are being "set").
71 matches
Mail list logo
