On Fri, 5 Apr 2024 18:30:30 GMT, Joe Darcy <da...@openjdk.org> wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflecting review feedback: >> - pre-generating the JCVarDecls in Attr, to aid Flow >> - adding a note on how the desugared code looks like > > src/java.compiler/share/classes/javax/lang/model/element/ElementKind.java > line 135: > >> 133: COMPONENT_LOCAL_VARIABLE; >> 134: >> 135: // Maintenance note: check if the default implementation of > > From a quick look, I don't think Elements.getOutermostTypeElement needs > updating for COMPONENT_LOCAL_VARIABLE, but it would be good to add a test > case. Tests added: https://github.com/openjdk/jdk/pull/18509/commits/e09306885e5c6cd2aba7779025fc7efcb8991e8e Thanks! > src/java.compiler/share/classes/javax/lang/model/util/ElementKindVisitorPreview.java > line 91: > >> 89: >> 90: /** >> 91: * {@inheritDoc ElementKindVisitor6} > > If possible, would be good to add some minimal testing/use of the element > kind visitors on component local variables. Tests added: https://github.com/openjdk/jdk/pull/18509/commits/e09306885e5c6cd2aba7779025fc7efcb8991e8e Thanks! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18509#discussion_r1557243414 PR Review Comment: https://git.openjdk.org/jdk/pull/18509#discussion_r1557243525
