On Wed, 3 Apr 2024 20:17:39 GMT, Joe Darcy wrote:
> When new language features are added, the javax.lang.model may need to be
> updated. For certain classes of features, the API update includes introducing
> a new set of concrete visitors to handle the language feature.
>
> The API scaffolding
On Thu, 4 Apr 2024 05:48:25 GMT, Alan Bateman wrote:
> The visitor classes are themselves preview APIs. Is this the first time that
> preview APIs have been proposed without a JEP? Just wondering how much
> visibility this preview API will get.
To clarify the intention, the visitor classes are
On Wed, 3 Apr 2024 20:17:39 GMT, Joe Darcy wrote:
> When new language features are added, the javax.lang.model may need to be
> updated. For certain classes of features, the API update includes introducing
> a new set of concrete visitors to handle the language feature.
>
> The API scaffolding
On Tue, 19 Mar 2024 16:55:14 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Wed, 3 Apr 2024 21:38:03 GMT, Joe Darcy wrote:
>> src/java.compiler/share/classes/javax/lang/model/util/SimpleElementVisitorPreview.java
>> line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2019, 2024, Oracle and/or its affiliates. All rights
>>> reserved.
>>
>> general, please check the copyri
On Wed, 3 Apr 2024 21:05:20 GMT, Vicente Romero wrote:
>> When new language features are added, the javax.lang.model may need to be
>> updated. For certain classes of features, the API update includes
>> introducing a new set of concrete visitors to handle the language feature.
>>
>> The API s
On Wed, 3 Apr 2024 20:17:39 GMT, Joe Darcy wrote:
> When new language features are added, the javax.lang.model may need to be
> updated. For certain classes of features, the API update includes introducing
> a new set of concrete visitors to handle the language feature.
>
> The API scaffolding
On Wed, 3 Apr 2024 20:17:39 GMT, Joe Darcy wrote:
> When new language features are added, the javax.lang.model may need to be
> updated. For certain classes of features, the API update includes introducing
> a new set of concrete visitors to handle the language feature.
>
> The API scaffolding
When new language features are added, the javax.lang.model may need to be
updated. For certain classes of features, the API update includes introducing a
new set of concrete visitors to handle the language feature.
The API scaffolding to support the new feature tends to be considerably larger
t
On Wed, 3 Apr 2024 07:02:31 GMT, Tomáš Zezula wrote:
> Problem:
> The debugging stack traces in `jdk.internal.vm.TranslatedException` do not
> work in libjvmci because they are enabled via the
> `jdk.internal.vm.TranslatedException.debug` system property. However, HotSpot
> system properties a
On Wed, 3 Apr 2024 11:47:45 GMT, Mahendra Chhipa wrote:
> Updated following tests to use ProcessTools methods:
> test/jdk/java/lang/Thread/UncaughtExceptionsTest.java
> test/jdk/java/lang/annotation/LoaderLeakTest.java
> test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java
> test/jdk/j
On Wed, 3 Apr 2024 19:57:21 GMT, Tomáš Zezula wrote:
>> Problem:
>> The debugging stack traces in `jdk.internal.vm.TranslatedException` do not
>> work in libjvmci because they are enabled via the
>> `jdk.internal.vm.TranslatedException.debug` system property. However,
>> HotSpot system propert
On Wed, 3 Apr 2024 19:01:14 GMT, Brian Burkhalter wrote:
> Clarify the behavior of `append` for a `null` `CharSequence` parameter and
> clean up a couple of other typos.
Marked as reviewed by naoto (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18607#pullrequestreview-1
> Problem:
> The debugging stack traces in `jdk.internal.vm.TranslatedException` do not
> work in libjvmci because they are enabled via the
> `jdk.internal.vm.TranslatedException.debug` system property. However, HotSpot
> system properties are not accessible via `System.getProperty()` in libjvmc
On Wed, 3 Apr 2024 19:01:14 GMT, Brian Burkhalter wrote:
> Clarify the behavior of `append` for a `null` `CharSequence` parameter and
> clean up a couple of other typos.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18607#pullrequestreview-19
Clarify the behavior of `append` for a `null` `CharSequence` parameter and
clean up a couple of other typos.
-
Commit messages:
- 8328183: Minor mistakes in docs of PrintStream.append()
Changes: https://git.openjdk.org/jdk/pull/18607/files
Webrev: https://webrevs.openjdk.org/?rep
On Wed, 3 Apr 2024 19:01:14 GMT, Brian Burkhalter wrote:
> Clarify the behavior of `append` for a `null` `CharSequence` parameter and
> clean up a couple of other typos.
Item 4 in [this
comment](https://bugs.openjdk.org/browse/JDK-8328183?focusedId=14657943&page=com.atlassian.jira.plugin.syste
On Mon, 18 Mar 2024 16:47:24 GMT, Bill Huang wrote:
> This task addresses an essential aspect of our testing infrastructure: the
> proper handling and cleanup of temporary files and socket files created
> during test execution. The motivation behind these changes is to prevent the
> accumulati
On Tue, 2 Apr 2024 23:43:24 GMT, Joe Darcy wrote:
> Happened to notice a semantic typo in the description of
> MathContext.DECIMAL128, use of "decimal64" where "decimal128" was intended,
> and added some additional information to make the related descriptions more
> informative.
This pull req
On Mon, 29 May 2023 07:25:26 GMT, Jan Lahoda wrote:
>> The pattern matching switches are using a bootstrap method
>> `SwitchBootstrap.typeSwitch` to implement the jumps in the switch.
>> Basically, for a switch like:
>>
>> switch (obj) {
>> case String s when s.isEmpty() -> {}
>> case
On Wed, 3 Apr 2024 12:32:21 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
On Wed, 3 Apr 2024 13:58:23 GMT, Tomáš Zezula wrote:
>> Problem:
>> The debugging stack traces in `jdk.internal.vm.TranslatedException` do not
>> work in libjvmci because they are enabled via the
>> `jdk.internal.vm.TranslatedException.debug` system property. However,
>> HotSpot system propert
On Wed, 3 Apr 2024 14:55:07 GMT, Raffaello Giulietti
wrote:
>> Happened to notice a semantic typo in the description of
>> MathContext.DECIMAL128, use of "decimal64" where "decimal128" was intended,
>> and added some additional information to make the related descriptions more
>> informative.
> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
> this change.
>
> Overall, making this an intrinsic improves overall performance of
> `Unsafe::setMemory` by up to 4x for all buffer sizes.
On Tue, 2 Apr 2024 10:37:02 GMT, Per Minborg wrote:
> This PR proposes to make empty immutable lists always throw UOE on
> `removeFirst` and `removeLast`.
test/jdk/java/util/Collection/MOAT.java line 573:
> 571: c::removeLast);
> 572: }
> 573:
Would this test better if in
On Wed, 3 Apr 2024 07:35:46 GMT, Suchismith Roy wrote:
>> Hello @suchismith1993,
>>
>>> > I adjust the comments which also answer your question. Please add an
>>> > AIX-only test to verify this behavior.
>>>
>>> By test you mean provide the use case for pure .a files ?
>>
>> In the JDK repo,
On Tue, 2 Apr 2024 23:43:24 GMT, Joe Darcy wrote:
> Happened to notice a semantic typo in the description of
> MathContext.DECIMAL128, use of "decimal64" where "decimal128" was intended,
> and added some additional information to make the related descriptions more
> informative.
Marked as rev
On Tue, 2 Apr 2024 23:43:24 GMT, Joe Darcy wrote:
> Happened to notice a semantic typo in the description of
> MathContext.DECIMAL128, use of "decimal64" where "decimal128" was intended,
> and added some additional information to make the related descriptions more
> informative.
src/java.base
> Problem:
> The debugging stack traces in `jdk.internal.vm.TranslatedException` do not
> work in libjvmci because they are enabled via the
> `jdk.internal.vm.TranslatedException.debug` system property. However, HotSpot
> system properties are not accessible via `System.getProperty()` in libjvmc
> Allow support for both .a and .so files in AIX.
> If .so file is not found, allow fallback to .a extension.
> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
Suchismith Roy has updated the pull request incrementally with one additional
commit since the last revision:
co
> `IllegalArgumentException` thrown by some static factory methods of the
> following `java.lang.classfile.instruction` interfaces are not documented:
>
> - `ArrayLoadInstruction`
> - `ArrayStoreInstruction`
> - `BranchInstruction`
> - `ConvertInstruction`
> - `DiscontinuedInstruction`
> - `Field
On Wed, 3 Apr 2024 11:42:04 GMT, ExE Boss wrote:
> The following factory methods are also missing `@throws
> IllegalArgumentException`:
>
> * `ConstantInstruction::ofIntrinsic`
> * `ConstantInstruction::ofArgument`
> * `ConstantInstruction::ofLoad`
Great catch, I'll add them, thank you!
-
Updated following tests to use ProcessTools methods:
test/jdk/java/lang/Thread/UncaughtExceptionsTest.java
test/jdk/java/lang/annotation/LoaderLeakTest.java
test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java
test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java
test/jdk/
On Wed, 3 Apr 2024 10:06:31 GMT, Adam Sotona wrote:
>> `IllegalArgumentException` thrown by some static factory methods of the
>> following `java.lang.classfile.instruction` interfaces are not documented:
>>
>> - `ArrayLoadInstruction`
>> - `ArrayStoreInstruction`
>> - `BranchInstruction`
>> -
> `IllegalArgumentException` thrown by some static factory methods of the
> following `java.lang.classfile.instruction` interfaces are not documented:
>
> - `ArrayLoadInstruction`
> - `ArrayStoreInstruction`
> - `BranchInstruction`
> - `ConvertInstruction`
> - `DiscontinuedInstruction`
> - `Field
On Wed, 27 Mar 2024 22:04:30 GMT, Jonathan Gibbons wrote:
> Please review the updates to support a proposed new
> `-Xlint:dangling-doc-comments` option.
>
> The work can be thought of as in 3 parts:
>
> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
> is possible
On Tue, 2 Apr 2024 19:19:59 GMT, Volodymyr Paprotski wrote:
>> Performance. Before:
>>
>> Benchmark(algorithm) (dataSize) (keyLength)
>> (provider) Mode Cnt ScoreError Units
>> SignatureBench.ECDSA.signSHA256withECDSA1024 256
>
Hi,
The vote for Per-Ake Minborg (pminborg) [1] is now closed.
Yes: 11
Veto: 0
Abstain: 0
According to the Bylaws definition of Lazy Consensus, this is
sufficient to approve the nomination.
best regards,
-- daniel
[1] https://mail.openjdk.org/pipermail/core-libs-dev/2024-March/12061
On Tue, 2 Apr 2024 09:37:52 GMT, Adam Sotona wrote:
> `IllegalArgumentException` thrown by some static factory methods of the
> following `java.lang.classfile.instruction` interfaces are not documented:
>
> - `ArrayLoadInstruction`
> - `ArrayStoreInstruction`
> - `BranchInstruction`
> - `Conver
Some of the Class-File API options were not mentioned in the package summary
and one exception mentioned `ClassFile.DeadLabelsOption` javadoc was wrong.
This patch fixes the javadoc.
Please review.
Thank you,
Adam
-
Commit messages:
- 8325371: Missing ClassFile.Option in package s
`Opcode.IFNONNULL.primaryTypeKind()` wrongly returned `IntType` instead of the
right `ReferenceType`.
Primary type kinds of `BRANCH` opcodes have yet no functional effect in the
Class-File API.
This simple patch fixes the typo.
Please review.
Thank you,
Adam
-
Commit messages:
-
On Tue, 2 Apr 2024 08:36:15 GMT, Jaikiran Pai wrote:
> test/jdk/java/lang/RuntimeTests/loadLibrary
I see. Thank you. Got to check some test cases files and how they are
structured.
For this case, i feel the use case would be to have a pure .a file. Usually
there is not such pure .a files that
On Tue, 2 Apr 2024 12:50:19 GMT, ExE Boss wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing tests.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java
> line 1415:
>
>> 1413:
Problem:
The debugging stack traces in the `jdk.internal.vm.TranslatedException` do not
work in the libjvmci compiler becuase they are enabled using the system
property `jdk.internal.vm.TranslatedException.debug`. However, the libjvmci
compiler does not copy HotSpot VM system properties. Instead
44 matches
Mail list logo
