On Wed, 3 Apr 2024 11:47:45 GMT, Mahendra Chhipa <mchh...@openjdk.org> wrote:
> Updated following tests to use ProcessTools methods:
> test/jdk/java/lang/Thread/UncaughtExceptionsTest.java
> test/jdk/java/lang/annotation/LoaderLeakTest.java
> test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java
> test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java
> test/jdk/javax/naming/spi/providers/InitialContextTest.java
Changes in `HijrahConfigTest.java` look good
test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java line 71:
> 69: // Run tests
> 70: Path launcher = outputPath.resolve("bin").resolve("java");
> 71: OutputAnalyzer analyzer =
> ProcessTools.executeCommand(launcher.toAbsolutePath().toString(),"-ea",
> "-esa", "HijrahConfigCheck");
Nit: need a space before `"-ea"`
test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java line 72:
> 70: Path launcher = outputPath.resolve("bin").resolve("java");
> 71: OutputAnalyzer analyzer =
> ProcessTools.executeCommand(launcher.toAbsolutePath().toString(),"-ea",
> "-esa", "HijrahConfigCheck");
> 72: analyzer.shouldHaveExitValue(0);
The variable `analyzer` may not be needed
-------------
PR Review: https://git.openjdk.org/jdk/pull/18602#pullrequestreview-1977861951
PR Review Comment: https://git.openjdk.org/jdk/pull/18602#discussion_r1550389295
PR Review Comment: https://git.openjdk.org/jdk/pull/18602#discussion_r1550389971
