On Tue, 19 Mar 2024 22:26:22 GMT, Stuart Marks wrote:
>> I think you are overthinking this somewhat Ramki. I don't see a practical
>> (non discrete-math) distinction between "some" and "any", so would not
>> object to that single word change if it helps. But "potential" should remain
>> as it
> I added `@since` tags for methods/constructors that do not match the `@since`
> of the enclosing class.
>
> The `write` method already existed in `PrintStream` in earlier versions and
> instances of it could always call this method, since it extends
> `FilterOutputStream` [which has the
> me
> # Issue
> - [JDK-8326836](https://bugs.openjdk.org/browse/JDK-8326836): changes were
> made to the method signatures but this modification isn't reflected in the @
> since tags. The @ since tags need to be updated.
>
> I changed the @\since tags to better accurately show when the methods were
> This code change adds an alternative implementation of user-based
> authorization `Subject` APIs that doesn't depend on Security Manager APIs.
> Depending on if the Security Manager is allowed, the methods store the
> current subject differently. See the spec change in the `Subject.java` file
On Tue, 19 Mar 2024 22:19:50 GMT, David Holmes wrote:
>> In fact, it appears as if the problem is with the use of "any", which is
>> universal in strength, whereas the intention here is existential in strength
>> (as suggested by. my wording). Indeed, you might achieve the same effect by
>> re
On Tue, 19 Mar 2024 16:38:49 GMT, Y. Srinivas Ramakrishna
wrote:
>> Sorry, my use of words was sloppy here. I think I did mean loose or somewhat
>> informal and therefore slippery.
>>
>> What I was saying is that using terms such as "any continuing computation"
>> doesn't make sense because t
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
Yudi Zheng has updated the pull request incrementally with one additional
commit since the last revision:
address comment.
-
On Tue, 19 Mar 2024 12:12:30 GMT, Shaojin Wen wrote:
>> I think splitting `CharArraySequence` into two versions is somewhat dubious
>> as more observable types at call sites may mean the performance gain in
>> targeted micros is lost. How much of an improvement did you observe from
>> this? Ag
On Tue, 19 Mar 2024 19:06:36 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Tue, 19 Mar 2024 19:06:36 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Tue, 12 Mar 2024 14:03:01 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> restore comment
>
> I think splitting `CharArraySequence` into two versions is somewhat dubious
> as more observable
> Moving array construction within BigInteger.implMultiplyToLen intrinsic
> candidate to its caller simplifies the intrinsic implementation in JIT
> compiler.
Yudi Zheng has updated the pull request incrementally with one additional
commit since the last revision:
address comment.
-
On Mon, 18 Mar 2024 16:55:28 GMT, Damon Fenacci wrote:
> Quite a simplification! Have you checked if there are any performance
> differences?
Ran
https://github.com/oracle/graal/blob/master/compiler/src/org.graalvm.micro.benchmarks/src/micro/benchmarks/BigIntegerBenchmark.java
The results are
Vote: yes
Mandy
On 3/19/24 8:19 AM, Daniel Fuchs wrote:
Hi,
I hereby nominate Per-Ake Minborg (pminborg) [1] to Membership in the
Core Libraries Group [4].
Per-Ake is an OpenJDK Reviewer, a committer in the
Leyden and Panama projects, and a member of Oracle’s
Java Core Libraries team.
Per-
On Tue, 19 Mar 2024 16:55:14 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
Vote: Yes
On 3/19/24 11:19 AM, Daniel Fuchs wrote:
I hereby nominate Per-Ake Minborg (pminborg) [1] to Membership in the
Core Libraries Group [4].
On Tue, 19 Mar 2024 17:02:36 GMT, Nizar Benalla wrote:
>> # Issue
>> - JDK-8326853 Incorrect @\since Tags for Charset Related Methods Added in
>> JDK 10
>>
>> I changed the @\since tags to better accurately show when the methods and
>> constructors were introduced.
>
> Nizar Benalla has update
> This task addresses an essential aspect of our testing infrastructure: the
> proper handling and cleanup of temporary files and socket files created
> during test execution. The motivation behind these changes is to prevent the
> accumulation of unnecessary files in the default temporary direc
On Tue, 19 Mar 2024 17:02:36 GMT, Nizar Benalla wrote:
>> # Issue
>> - JDK-8326853 Incorrect @\since Tags for Charset Related Methods Added in
>> JDK 10
>>
>> I changed the @\since tags to better accurately show when the methods and
>> constructors were introduced.
>
> Nizar Benalla has update
On Tue, 19 Mar 2024 17:05:50 GMT, Nizar Benalla wrote:
>> src/java.base/share/classes/java/nio/channels/Channels.java line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2000, 2023, 2024, Oracle and/or its affiliates. All
>>> rights reserved.
>>
>> Thanks for updating, but needs a little adjustment.
On Tue, 19 Mar 2024 16:13:49 GMT, Justin Lu wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update the latter years for the Oracle copyrights
>
> src/java.base/share/classes/java/nio/channels/Channels.java line 2:
Vote: yes
Joe (joehw)
On 3/19/24 8:19 AM, Daniel Fuchs wrote:
Hi,
I hereby nominate Per-Ake Minborg (pminborg) [1] to Membership in the
Core Libraries Group [4].
> # Issue
> - JDK-8326853 Incorrect @\since Tags for Charset Related Methods Added in JDK
> 10
>
> I changed the @\since tags to better accurately show when the methods and
> constructors were introduced.
Nizar Benalla has updated the pull request incrementally with two additional
commits sinc
> Please review this patch which adds a jlink mode to the JDK which doesn't
> need the packaged modules being present. A.k.a run-time image based jlink.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jm
Vote: yes
On 3/19/2024 8:19 AM, Daniel Fuchs wrote:
Hi,
I hereby nominate Per-Ake Minborg (pminborg) [1] to Membership in the
Core Libraries Group [4].
Per-Ake is an OpenJDK Reviewer, a committer in the
Leyden and Panama projects, and a member of Oracle’s
Java Core Libraries team.
Per-Ake
On Tue, 19 Mar 2024 16:20:55 GMT, Y. Srinivas Ramakrishna
wrote:
>> https://docs.oracle.com/javase/specs/jls/se21/html/jls-12.html#jls-12.6.1
>>
>>> A reachable object is any object that can be accessed in any potential
>>> continuing computation from any live thread.
>>
>> It may be "loose"
On Tue, 19 Mar 2024 02:53:37 GMT, David Holmes wrote:
>> src/java.base/share/classes/java/lang/ref/package-info.java line 137:
>>
>>> 135: *
>>> 136: * A reachable object is any object that can be accessed in
>>> any potential
>>> 137: * continuing computation from any live thread (as stated
On Thu, 14 Mar 2024 21:59:54 GMT, Christoph Langer wrote:
>> During analysing a customer case I figured out that we have an inconsistency
>> between documentation and actual behavior in class
>> com.sun.jndi.ldap.Connection. The [method documentation of
>> com.sun.jndi.ldap.Connection::createS
On Tue, 19 Mar 2024 10:54:41 GMT, Nizar Benalla wrote:
>> # Issue
>> - JDK-8326853 Incorrect @\since Tags for Charset Related Methods Added in
>> JDK 10
>>
>> I changed the @\since tags to better accurately show when the methods and
>> constructors were introduced.
>
> Nizar Benalla has update
On Tue, 19 Mar 2024 10:01:31 GMT, Suchismith Roy wrote:
>>> > In AIX, we have an usecase where shared libraries have certain member
>>> > objects to be referred to. E.g libclang.a(shr_64.o) .
>>>
>>> Would you happen to know any official documentation which explains that AIX
>>> syntax?
>>>
>
Vote: yes
On Mon, 18 Mar 2024 17:40:26 GMT, Mandy Chung wrote:
> A simple fix. This is caused by a bug in `VerifyAccess::isClassAccessible`
> that checks if a class is exported from `java.base` before the exports are
> fully setup.It should check if the module system is fully initialized
> before
> I added `@since` tags for methods/constructors that do not match the `@since`
> of the enclosing class.
>
> The `write` method already existed in `PrintStream` in earlier versions and
> instances of it could always call this method, since it extends
> `FilterOutputStream` [which has the
> me
Vote: yes
Naoto
On 3/19/24 8:19 AM, Daniel Fuchs wrote:
Hi,
I hereby nominate Per-Ake Minborg (pminborg) [1] to Membership in the
Core Libraries Group [4].
Per-Ake is an OpenJDK Reviewer, a committer in the
Leyden and Panama projects, and a member of Oracle’s
Java Core Libraries team.
Per-
On Tue, 19 Mar 2024 14:59:19 GMT, Goetz Lindenmaier wrote:
> …rve enough space for 2097152KB object heap
>
> I would like to fix this as the two related issues mentioned in the JBS bug.
> We see it currently in most GHA runs.
Marked as reviewed by sgehwolf (Reviewer).
-
PR Review:
Vote: yes
On 2024-03-19 16:19, Daniel Fuchs wrote:
Hi,
I hereby nominate Per-Ake Minborg (pminborg) [1] to Membership in the
Core Libraries Group [4].
Per-Ake is an OpenJDK Reviewer, a committer in the
Leyden and Panama projects, and a member of Oracle’s
Java Core Libraries team.
Per-Ake ha
On Mon, 18 Mar 2024 14:53:44 GMT, Pavel Rappo wrote:
> Please review this simple bugfix to properly construct links to preview JEPs.
>
> The most straightforward fix I could think of was to pass `String` rather
> than `int` (`Integer`) to a method, which eventually calls
> `java.text.MessageFo
Vote: yes
On Mar 19, 2024, at 11:19 AM, Daniel Fuchs wrote:
Hi,
I hereby nominate Per-Ake Minborg (pminborg) [1] to Membership in the Core
Libraries Group [4].
Per-Ake is an OpenJDK Reviewer, a committer in the
Leyden and Panama projects, and a member of Oracle’s
Java Core Libraries team.
Pe
Hi,
I hereby nominate Per-Ake Minborg (pminborg) [1] to Membership in the
Core Libraries Group [4].
Per-Ake is an OpenJDK Reviewer, a committer in the
Leyden and Panama projects, and a member of Oracle’s
Java Core Libraries team.
Per-Ake has been actively participating in the development of
t
On Tue, 19 Mar 2024 14:59:19 GMT, Goetz Lindenmaier wrote:
> …rve enough space for 2097152KB object heap
>
> I would like to fix this as the two related issues mentioned in the JBS bug.
> We see it currently in most GHA runs.
LGTM.
-
Marked as reviewed by mdoerr (Reviewer).
PR Re
On Tue, 19 Mar 2024 14:59:19 GMT, Goetz Lindenmaier wrote:
> …rve enough space for 2097152KB object heap
>
> I would like to fix this as the two related issues mentioned in the JBS bug.
> We see it currently in most GHA runs.
lgtm
-
Marked as reviewed by rriggs (Reviewer).
PR Rev
…rve enough space for 2097152KB object heap
I would like to fix this as the two related issues mentioned in the JBS bug.
We see it currently in most GHA runs.
-
Commit messages:
- 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve
enough space for 2097152KB ob
On Tue, 12 Mar 2024 14:03:01 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> restore comment
>
> I think splitting `CharArraySequence` into two versions is somewhat dubious
> as more observable
On Tue, 19 Mar 2024 11:21:14 GMT, Nizar Benalla wrote:
>> I added `@since` tags for methods/constructors that do not match the
>> `@since` of the enclosing class.
>>
>> The `write` method already existed in `PrintStream` in earlier versions and
>> instances of it could always call this method,
On Mon, 18 Mar 2024 14:02:20 GMT, Jan Lahoda wrote:
>> Hello Jaikiran,
>> in jdk21 DHPPublicKey did have a
>> [getParams()](https://github.com/openjdk/jdk21/blob/890adb6410dab4606a4f26a942aed02fb2f55387/src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java#L244)
>> method, so it
On Sun, 17 Mar 2024 01:20:17 GMT, Nizar Benalla wrote:
>> src/java.base/share/classes/javax/crypto/interfaces/DHPublicKey.java line 68:
>>
>>> 66: *
>>> 67: * @return {@inheritDoc java.security.AsymmetricKey}
>>> 68: * @since 22
>>
>> Hello Nizar, are the removal of `@since` in t
> I added `@since` tags for methods/constructors that do not match the `@since`
> of the enclosing class.
>
> The `write` method already existed in `PrintStream` in earlier versions and
> instances of it could always call this method, since it extends
> `FilterOutputStream` [which has the
> me
On Sat, 16 Mar 2024 00:20:51 GMT, Jaikiran Pai wrote:
>> Nizar Benalla has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Revert "fix rest of private/public since tags"
>>
>>This reverts commit 2c04a9d8e773616b7b6239335d4e5eb955
On Sun, 3 Mar 2024 17:01:53 GMT, Doug Simon wrote:
> The `java/util/concurrent/Executors/UnreferencedExecutor.java` test can fail
> when run on libgraal and `-Xcomp` is specified. The problem is that libgraal
> in `-Xcomp` temporarily causes some extra memory pressure (probably due to
> [JDK-8
The `java/util/concurrent/Executors/UnreferencedExecutor.java` test can fail
when run on libgraal and `-Xcomp` is specified. The problem is that libgraal in
`-Xcomp` temporarily causes some extra memory pressure (probably due to
[JDK-8310218](https://bugs.openjdk.org/browse/JDK-8310218)) which c
> Please review this patch which adds a jlink mode to the JDK which doesn't
> need the packaged modules being present. A.k.a run-time image based jlink.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jm
On Mon, 18 Mar 2024 12:44:46 GMT, Nizar Benalla wrote:
>> # Issue
>> - JDK-8326853 Incorrect @\since Tags for Charset Related Methods Added in
>> JDK 10
>>
>> I changed the @\since tags to better accurately show when the methods and
>> constructors were introduced.
>
> Nizar Benalla has update
> # Issue
> - JDK-8326853 Incorrect @\since Tags for Charset Related Methods Added in JDK
> 10
>
> I changed the @\since tags to better accurately show when the methods and
> constructors were introduced.
Nizar Benalla has updated the pull request incrementally with one additional
commit since
On Mon, 18 Mar 2024 20:18:09 GMT, Mandy Chung wrote:
> This is what I understand from your implementation:
>
> 1. create a regular JDK image under
> `support/images/runtime-link-initial-jdk` using jlink from the exploded JDK
> build
>
> 2. create a linkable JDK image under `images/jdk
On Tue, 19 Mar 2024 09:58:04 GMT, Suchismith Roy wrote:
>>> In AIX, we have an usecase where shared libraries have certain member
>>> objects to be referred to. E.g libclang.a(shr_64.o) .
>>
>> Would you happen to know any official documentation which explains that AIX
>> syntax?
>>
>>> When
On Mon, 18 Mar 2024 17:40:04 GMT, Jaikiran Pai wrote:
> > In AIX, we have an usecase where shared libraries have certain member
> > objects to be referred to. E.g libclang.a(shr_64.o) .
>
> Would you happen to know any official documentation which explains that AIX
> syntax?
>
https://www.ib
On Tue, 19 Mar 2024 00:07:37 GMT, Justin Lu wrote:
>> Please review this PR and associated
>> [CSR](https://bugs.openjdk.org/browse/JDK-8327703) which introduces strict
>> parsing for NumberFormat.
>>
>> The concrete subclasses that will utilize this leniency value are
>> `DecimalFormat` and
On Mon, 18 Mar 2024 22:51:55 GMT, Claes Redestad wrote:
>> This PR proposes to remove the native method `StringUTF16::isBigEndian` and
>> its corresponding C implementation and instead rely on the
>> `jdk.internal.misc.Unsafe::isBigEndian` method.
>>
>> This PR passes tier1-3 tests.
>
>> Initi
On Mon, 18 Mar 2024 14:09:09 GMT, Per Minborg wrote:
> This PR proposes to remove the native method `StringUTF16::isBigEndian` and
> its corresponding C implementation and instead rely on the
> `jdk.internal.misc.Unsafe::isBigEndian` method.
>
> This PR passes tier1-3 tests.
This pull request
59 matches
Mail list logo
