On Fri, 8 Mar 2024 02:54:49 GMT, Alex Menkov wrote:
> RecordComponent class has _attributes_count field.
> The only user of the field is JvmtiClassFileReconstituter. Incorrect value of
> the field causes producing incorrect data for Record attribute.
> Parsing Record attribute ClassFileParser sk
On Thu, 7 Mar 2024 22:59:38 GMT, Calvin Cheung wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>> sinc
On Sat, 2 Mar 2024 01:18:06 GMT, Ioi Lam wrote:
> A few clean ups:
>
> 1. Rename functions like "`s_loading_full_module_graph()` to
> `is_using_full_module_graph()`. The meaning of "loading" is not clear: it
> might be interpreted as to cover only the period where the artifact is being
> load
> A few clean ups:
>
> 1. Rename functions like "`s_loading_full_module_graph()` to
> `is_using_full_module_graph()`. The meaning of "loading" is not clear: it
> might be interpreted as to cover only the period where the artifact is being
> loaded, but not the period after the artifact is compl
On Fri, 8 Mar 2024 06:51:21 GMT, Calvin Cheung wrote:
>> To avoid the CDS dump error message, a fix is during dumping a classlist,
>> check if an invoker can be archived.
>> If not, don't write the invoker info into the classlist, i.e. don't call
>> `logLambdaFormInvoker()`. While generating h
On Mon, 4 Mar 2024 21:19:26 GMT, Elif Aslan wrote:
> This change is intended to address the segmentation fault issue that occurs
> when jspawnhelper is called without arguments,.
> There is a new test added to verify the behavior in such cases.
>
> `[ec2-user@ip-172-16-0-10 jdk]$ make CONF=lin
On Fri, 8 Mar 2024 17:24:24 GMT, Elif Aslan wrote:
>> This change is intended to address the segmentation fault issue that occurs
>> when jspawnhelper is called without arguments,.
>> There is a new test added to verify the behavior in such cases.
>>
>> `[ec2-user@ip-172-16-0-10 jdk]$ make CON
On Thu, 7 Mar 2024 23:31:46 GMT, Justin Lu wrote:
> Please review this PR which is a trivial update to the IANA sub tag registry
> to version 2024-03-07. Tests pass as expected after update.
>
> Associated announcement ->
> https://mm.icann.org/pipermail/ietf-languages-announcements/2024-March
On Fri, 8 Mar 2024 19:54:31 GMT, Naoto Sato wrote:
> Removing left over "applet" mention in the package-info doc.
Marked as reviewed by jlu (Committer).
-
PR Review: https://git.openjdk.org/jdk/pull/18173#pullrequestreview-1925828046
On Fri, 8 Mar 2024 19:54:31 GMT, Naoto Sato wrote:
> Removing left over "applet" mention in the package-info doc.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18173#pullrequestreview-1925813600
On Fri, 8 Mar 2024 19:54:31 GMT, Naoto Sato wrote:
> Removing left over "applet" mention in the package-info doc.
bye bye
-
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18173#pullrequestreview-1925798262
On Fri, 8 Mar 2024 19:54:31 GMT, Naoto Sato wrote:
> Removing left over "applet" mention in the package-info doc.
Farewell applets.
-
Marked as reviewed by bpb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18173#pullrequestreview-1925759402
Removing left over "applet" mention in the package-info doc.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/18173/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18173&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8327705
Stats: 2 lin
On Fri, 8 Mar 2024 17:24:24 GMT, Elif Aslan wrote:
>> This change is intended to address the segmentation fault issue that occurs
>> when jspawnhelper is called without arguments,.
>> There is a new test added to verify the behavior in such cases.
>>
>> `[ec2-user@ip-172-16-0-10 jdk]$ make CON
On Fri, 8 Mar 2024 17:19:41 GMT, Severin Gehwolf wrote:
>> I tried out the latest commit (a797ea69).
>>
>> The output "The default module path, '$java.home/jmods' not present. Use
>> --verbose to show the full list of plugin options applied" is bit confusing
>> as it looks like jlink failed bu
On Thu, 7 Mar 2024 23:31:46 GMT, Justin Lu wrote:
> Please review this PR which is a trivial update to the IANA sub tag registry
> to version 2024-03-07. Tests pass as expected after update.
>
> Associated announcement ->
> https://mm.icann.org/pipermail/ietf-languages-announcements/2024-March
On Tue, 27 Feb 2024 15:23:09 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Fri, 8 Mar 2024 15:48:08 GMT, Magnus Ihse Bursie wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the JDK build.
>> T
On Fri, 8 Mar 2024 10:10:23 GMT, Magnus Ihse Bursie wrote:
>> I think what matters for this test test most is which platforms we build
>> `jspawnhelper` for, and those platforms indeed are:
>>
>>
>> ifeq ($(call isTargetOs, macosx aix linux), true)
>> $(eval $(call SetupJdkExecutable, BUILD_
On Thu, 7 Mar 2024 19:28:13 GMT, Naoto Sato wrote:
> A simple doc update to include a leap day example in the `Calendar` class.
This pull request has now been integrated.
Changeset: 87b40c6a
Author:Naoto Sato
URL:
https://git.openjdk.org/jdk/commit/87b40c6ad2b0fa972fa6c5699a52045e82
On Wed, 6 Mar 2024 13: 43: 00 GMT, Magnus Ihse Bursie wrote: >> Currently, our symbol visibility handling for tests are sloppy; we only handle it properly on Windows. We need to bring it up to the same levels as
ZjQcmQRYFpfptBannerStart
This Message Is From an External
On Sat, 2 Mar 2024 00: 34: 32 GMT, Justin Lu wrote: > Please review this PR and corresponding CSR which prevents an OutOfMemoryError by restricting the initial maximum fraction digits for an empty pattern DecimalFormat.
ZjQcmQRYFpfptBannerStart
This Message Is From an
On Fri, 8 Mar 2024 17: 35: 45 GMT, Severin Gehwolf wrote: >> make/Images. gmk line 144: >> >>> 142: OUTPUT_DIR := $(JDK_IMAGE_DIR), \ >>> 143: SUPPORT_DIR := $(JDK_RUN_TIME_IMAGE_SUPPORT_DIR),
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
On Fri, 8 Mar 2024 16: 51: 11 GMT, Magnus Ihse Bursie wrote: >> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision: >> >> Only show runtime
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
On Fri, 8 Mar 2024 02: 41: 06 GMT, SendaoYan wrote: >> Date. toString() uses Locale. US explicitly for printing the time zone, so replace Locale. ROOT to Locale. US in this testcase for fix the test failure. >>
ZjQcmQRYFpfptBannerStart
This Message Is From an External
On Fri, 8 Mar 2024 16:52:33 GMT, Magnus Ihse Bursie wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Only show runtime image suffix for JDK modules
>
> make/Images.gmk line 96:
>
>> 94:
>> 95: ifeq ($(JLINK_KEE
> This change is intended to address the segmentation fault issue that occurs
> when jspawnhelper is called without arguments,.
> There is a new test added to verify the behavior in such cases.
>
> `[ec2-user@ip-172-16-0-10 jdk]$ make CONF=linux-x86_64-server-fastdebug test
> TEST=test/jdk/java
On Fri, 8 Dec 2023 15:44:07 GMT, Alan Bateman wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 46 commits:
>>
>> - Add @enablePreview for JImageValidator that uses classfile API
>> - Fix SystemModulesPlu
On Wed, 6 Mar 2024 13:43:00 GMT, Magnus Ihse Bursie wrote:
>> Currently, our symbol visibility handling for tests are sloppy; we only
>> handle it properly on Windows. We need to bring it up to the same levels as
>> product code. This is a prerequisite for
>> [JDK-8327045](https://bugs.openjdk
On Tue, 27 Feb 2024 15:23:09 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Tue, 27 Feb 2024 15:23:09 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Fri, 8 Dec 2023 15:44:07 GMT, Alan Bateman wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 46 commits:
>>
>> - Add @enablePreview for JImageValidator that uses classfile API
>> - Fix SystemModulesPlu
On Thu, 7 Mar 2024 19:28:13 GMT, Naoto Sato wrote:
> A simple doc update to include a leap day example in the `Calendar` class.
Marked as reviewed by rriggs (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18158#pullrequestreview-1925260836
On Fri, 8 Mar 2024 15:48:08 GMT, Magnus Ihse Bursie wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the JDK build.
>> T
On Fri, 8 Mar 2024 06:51:21 GMT, Calvin Cheung wrote:
>> To avoid the CDS dump error message, a fix is during dumping a classlist,
>> check if an invoker can be archived.
>> If not, don't write the invoker info into the classlist, i.e. don't call
>> `logLambdaFormInvoker()`. While generating h
On Fri, 8 Mar 2024 15:48:08 GMT, Magnus Ihse Bursie wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the JDK build.
>> T
> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
> clang by another name, and it uses the clang toolchain in the JDK build. Thus
> the old xlc toolchain is no longer supported, and should be r
On Fri, 8 Mar 2024 15:44:48 GMT, Magnus Ihse Bursie wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the JDK build.
>> T
On Fri, 8 Mar 2024 15:41:16 GMT, Magnus Ihse Bursie wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert SEARCH_PATH changes
>
> make/autoconf/toolchain.m4 line 444:
>
>> 442: COMPILER_NAME=$2
>> 443:
On Fri, 8 Mar 2024 15:29:58 GMT, Magnus Ihse Bursie wrote:
> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
> clang by another name, and it uses the clang toolchain in the JDK build. Thus
>
As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building the
JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect clang by
another name, and it uses the clang toolchain in the JDK build. Thus the old
xlc toolchain is no longer supported, and should be removed.
On Fri, 8 Mar 2024 15:29:58 GMT, Magnus Ihse Bursie wrote:
> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
> clang by another name, and it uses the clang toolchain in the JDK build. Thus
>
> `GZIPInputStream`, when looking for a concatenated stream, relies on what the
> underlying `InputStream` says is how many bytes are `available()`. But this
> is inappropriate because `InputStream.available()` is just an estimate and is
> allowed (for example) to always return zero.
>
> The fi
On Fri, 8 Mar 2024 13:58:25 GMT, Erik Joelsson wrote:
> Looks good, but why are the tests failing?
**macos-x64 / test (langtools/tier1)** fails when installing homebrew:
Error: Failure while executing; `/usr/bin/env
/usr/local/Homebrew/Library/Homebrew/shims/shared/curl --disable --cookie
/d
On Fri, 8 Mar 2024 10:17:08 GMT, Magnus Ihse Bursie wrote:
> We should match the building of jspawnhelper in
> make/modules/java.base/Launcher.gmk with the usage for all unix platforms in
> src/java.base/unix/classes/java/lang/ProcessImpl.java.
>
> Granted, the list of OSes in the makefile amo
On Fri, 8 Mar 2024 10:17:08 GMT, Magnus Ihse Bursie wrote:
> We should match the building of jspawnhelper in
> make/modules/java.base/Launcher.gmk with the usage for all unix platforms in
> src/java.base/unix/classes/java/lang/ProcessImpl.java.
>
> Granted, the list of OSes in the makefile amo
On Wed, 6 Mar 2024 22:58:54 GMT, Viktor Klang wrote:
> The common ForkJoinPool creating threads as a result of submitting tasks is
> preventing class unloading when the thread construction is initiated from a
> class loaded in a separate classloader. This fix avoids that when no
> SecurityMana
On Thu, 7 Mar 2024 21:53:07 GMT, Jan Lahoda wrote:
>> Currently, JDK modules load by the bootstrap and platform ClassLoaders are
>> automatically granted the native access. I am working on an upgrade of JLine
>> inside the `jdk.internal.le` module, and I would like to replace the current
>> na
On Mon, 4 Mar 2024 13:52:13 GMT, Jan Lahoda wrote:
> Currently, JDK modules load by the bootstrap and platform ClassLoaders are
> automatically granted the native access. I am working on an upgrade of JLine
> inside the `jdk.internal.le` module, and I would like to replace the current
> native
On Fri, 8 Mar 2024 10:17:08 GMT, Magnus Ihse Bursie wrote:
> We should match the building of jspawnhelper in
> make/modules/java.base/Launcher.gmk with the usage for all unix platforms in
> src/java.base/unix/classes/java/lang/ProcessImpl.java.
>
> Granted, the list of OSes in the makefile amo
On Fri, 8 Mar 2024 10:17:08 GMT, Magnus Ihse Bursie wrote:
> We should match the building of jspawnhelper in
> make/modules/java.base/Launcher.gmk with the usage for all unix platforms in
> src/java.base/unix/classes/java/lang/ProcessImpl.java.
>
> Granted, the list of OSes in the makefile amo
We should match the building of jspawnhelper in
make/modules/java.base/Launcher.gmk with the usage for all unix platforms in
src/java.base/unix/classes/java/lang/ProcessImpl.java.
Granted, the list of OSes in the makefile amounts to the current list of all
Unix OSes in the JDK, but there is no
On Fri, 8 Mar 2024 09:19:43 GMT, Aleksey Shipilev wrote:
>> Yes indeed, it is used for all Unix OSes (that is, everything but Windows).
>
> I think what matters for this test test most is which platforms we build
> `jspawnhelper` for, and those platforms indeed are:
>
>
> ifeq ($(call isTarget
On Mon, 19 Feb 2024 18:35:58 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which proposes that we officially deprecate the
> following four methods in the `java.util.zip` package:
>
> * `Inflater.getTotalIn()`
> * `Inflater.getTotalOut()`
> * `Deflater.getTotalIn()`
> * `Deflater.getTotalO
On Sat, 2 Mar 2024 18:51:16 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which proposes that we officially deprecate the
>> following four methods in the `java.util.zip` package:
>>
>> * `Inflater.getTotalIn()`
>> * `Inflater.getTotalOut()`
>> * `Deflater.getTotalIn()`
>> * `Deflater.get
> Please consider this PR which suggests we rename `ZipEntry.extraAttributes`
> to `ZipEntry.externalFileAttributes`.
>
> This field was introduced in
> [JDK-8218021](https://bugs.openjdk.org/browse/JDK-8218021), originally under
> the name `ZipEntry.posixPerms`.
> [JDK-8250968](https://bugs.o
On Fri, 8 Mar 2024 07:35:27 GMT, Magnus Ihse Bursie wrote:
>> test/jdk/java/lang/ProcessBuilder/JspawnhelperWarnings.java line 29:
>>
>>> 27: * @test
>>> 28: * @bug 8325567
>>> 29: * @requires (os.family == "linux") | (os.family == "aix")
>>
>> Unless I'm mistaken, jspawn helper is used on M
On Thu, 7 Mar 2024 20:04:13 GMT, Vladimir Petko wrote:
> I wonder if it would make sense to add a test with a correct argument format?
I would say that is what current jspawnhelper tests already test, and it is
also tested implicitly with `Process` tests. Let's keep this test for testing
that
On Wed, 6 Mar 2024 09:26:25 GMT, Matthias Baesken wrote:
> We define the RESTARTABLE macro again and again at a lot of places in the JDK
> native codebase. This could be centralized to avoid repeating it again and
> again !
This pull request has now been integrated.
Changeset: fb4610e6
Author
On Wed, 6 Mar 2024 13:53:06 GMT, Magnus Ihse Bursie wrote:
> I am currently running tier 4-10
This is now done. A handful of tests failed, but all are due to transient
environmental problems, known errors, or seemingly intermittent product errors
-- none are due to symbol visibility.
So I'd a
On Thu, 7 Mar 2024 21:53:07 GMT, Jan Lahoda wrote:
>> Currently, JDK modules load by the bootstrap and platform ClassLoaders are
>> automatically granted the native access. I am working on an upgrade of JLine
>> inside the `jdk.internal.le` module, and I would like to replace the current
>> na
61 matches
Mail list logo
