This Message Is From an External Sender
This message came from outside your organization.
On Fri, 8 Mar 2024 02:41:06 GMT, SendaoYan <s...@openjdk.org> wrote:
>> Date.toString() uses Locale.US explicitly for printing the time zone, so replace Locale.ROOT to Locale.US in this testcase for fix the test failure. >> >> This testcase fixed has been verified. >> >> Only change the testcase, risk is low. > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > 1. modify copyright year to 2024; 2. delete unmatch comment Changes requested by naoto (Reviewer). test/jdk/java/util/Properties/PropertiesStoreTest.java line 59: > 57: private static final String DATE_FORMAT_PATTERN = "EEE MMM dd HH:mm:ss zzz uuuu"; > 58: // use a neutral locale, since when the date comment was written by Properties.store(...), > 59: // it internally calls the Date.toString() which always writes in a locale insensitive manner Instead of blindly removing the comment, I'd suggest reflecting the fact that `Date.toString()` uses `Locale.US` for time zone names. ------------- PR Review: https://git.openjdk.org/jdk/pull/18155#pullrequestreview-1925420427 PR Review Comment: https://git.openjdk.org/jdk/pull/18155#discussion_r1518034168
