On Tue, 13 Feb 2024 22:30:28 GMT, Weijun Wang wrote:
>> Many crypto service classes require a `SecureRandom` object at
>> initialization. This test goes through each of them and calculates
>> (generate, encrypt, sign,...) twice with the same `SecureRandom` object and
>> ensures the output is t
On Tue, 13 Feb 2024 22:30:28 GMT, Weijun Wang wrote:
>> Many crypto service classes require a `SecureRandom` object at
>> initialization. This test goes through each of them and calculates
>> (generate, encrypt, sign,...) twice with the same `SecureRandom` object and
>> ensures the output is t
On Fri, 16 Feb 2024 23:35:10 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8317756)
>> which defines the behavior for creating ChoiceFormats with incorrect
>> patterns. The wording is added to both the ChoiceFormat constructor and
>> ChoiceFormat:
On Thu, 8 Feb 2024 20:04:20 GMT, Vladimir Yaroslavskiy wrote:
>> Hi Vladimir (@iaroslavski),
>>
>> The new ArraysSortNew.Java has compilation issues:
>>
>>
>> error: DualPivotQuicksort is not public in java.util; cannot be accessed
>> from outside package
>> java.util.DualPivotQu
On Fri, 16 Feb 2024 22:38:11 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> replace spec tag with note
>
> src/java.base/share/classes/java/text/ChoiceFormat.java line 235:
>
>> 233: *
>> 234:
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8317756)
> which defines the behavior for creating ChoiceFormats with incorrect
> patterns. The wording is added to both the ChoiceFormat constructor and
> ChoiceFormat::applyPattern method.
>
> While ideally the inconsistent
> This change mirrors what we did for ConcurrentHashMap in
> https://github.com/openjdk/jdk/pull/17116. When we add all entries from one
> map to anther, we should resize that map to the size of the sum of both maps.
>
> I used the command below to run the benchmarks. I set a high heap to reduce
On Fri, 2 Feb 2024 17:38:13 GMT, Joshua Cao wrote:
>> Add notes for `HashMap::putAll()` conservative resizing.
>>
>> Note: everything below this line is from the original change. After
>> discussion, we decided to keep the conservative resizing, but we should add
>> an `@implNote` for the deci
On Fri, 16 Feb 2024 21:53:26 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8317756)
>> which defines the behavior for creating ChoiceFormats with incorrect
>> patterns. The wording is added to both the ChoiceFormat constructor and
>> ChoiceFormat:
On Mon, 5 Feb 2024 10:58:17 GMT, Magnus Ihse Bursie wrote:
>> Inspired by (the later backed-out)
>> [JDK-8296115](https://bugs.openjdk.org/browse/JDK-8296115), I propose to
>> enable `-Wpedantic` for clang. This has already found some irregularities in
>> the code, like mistakenly using `#impo
On Thu, 21 Sep 2023 12:51:56 GMT, Raffaello Giulietti
wrote:
> By correctly sizing an intermediate `byte[]` and making use of the internal
> `newStringNoRepl()` method, one allocation per conversion can be avoided when
> the runtime uses compact strings.
This pull request has been closed with
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8317756)
> which defines the behavior for creating ChoiceFormats with incorrect
> patterns. The wording is added to both the ChoiceFormat constructor and
> ChoiceFormat::applyPattern method.
>
> While ideally the inconsistent
Hi,
Initially, the Deflater and Inflater classes in java.util.zip only
supported up to 2GB of inflated or deflated data, the reason being that
their getTotalIn and getTotalOut methods returns an int.
Around 2004, this limitation was remedied by introducing the new methods
getBytesRead and getByte
On Fri, 16 Feb 2024 15:31:07 GMT, Claes Redestad wrote:
>> Adding a fast-path for ASCII-only modified UTF-8 strings deserialied via
>> Data- and ObjectInputStream
>>
>> Testing: tier1-3
>
> Claes Redestad has updated the pull request incrementally with two additional
> commits since the last r
On Wed, 14 Feb 2024 23:05:25 GMT, Justin Lu wrote:
> Please review this PR which fixes / finishes the rest of the IntlTest test
> framework removal in java.text and java.util.i18n tests.
>
> For context, the IntlTest class only ran methods prefixed by _test_ or _Test_
> with public visibility
On Mon, 5 Feb 2024 21:39:06 GMT, Magnus Ihse Bursie wrote:
> Here is the full list:
> https://clang.llvm.org/docs/DiagnosticsReference.html#wpedantic
I know about that list, and that's not what I was asking for. I want to
understand the impact on *our* code. What warnings are arising from *our*
On Fri, 16 Feb 2024 12:43:25 GMT, Magnus Ihse Bursie wrote:
>> Since jcheck only checks file in a commit, there is a possibility of us
>> getting files in the repository that would not be accepted by jcheck. This
>> can happen when extending the set of files checked by jcheck, or if jcheck
>>
On Fri, 16 Feb 2024 10:27:11 GMT, Christoph Langer wrote:
>> During analysing a customer case I figured out that we have an inconsistency
>> between documentation and actual behavior in class
>> com.sun.jndi.ldap.Connection. The [method documentation of
>> com.sun.jndi.ldap.Connection::createS
On Thu, 15 Feb 2024 18:54:46 GMT, Brian Burkhalter wrote:
> Revert `@replace` snippet annotation construct to value of `replacement`
> attribute.
This pull request has now been integrated.
Changeset: 7a762520
Author:Brian Burkhalter
URL:
https://git.openjdk.org/jdk/commit/7a7625200
On Fri, 16 Feb 2024 15:54:27 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList jcstress tests that are failing due to
> JDK-8325984.
Thanks!
-
Marked as reviewed by jvernee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17890#pullrequestreview-1885494458
On Fri, 16 Feb 2024 15:54:27 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList jcstress tests that are failing due to
> JDK-8325984.
This pull request has now been integrated.
Changeset: 00b5c707
Author:Daniel D. Daugherty
URL:
https://git.openjdk.org/jdk/commit/00b5c
On Fri, 16 Feb 2024 15:56:41 GMT, Alexander Zvegintsev
wrote:
>> A trivial fix to ProblemList jcstress tests that are failing due to
>> JDK-8325984.
>
> Marked as reviewed by azvegint (Reviewer).
@azvegint - Thanks for the fast review!
-
PR Comment: https://git.openjdk.org/jdk/pu
On Fri, 16 Feb 2024 15:54:27 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList jcstress tests that are failing due to
> JDK-8325984.
Marked as reviewed by azvegint (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/17890#pullrequestreview-1885479796
A trivial fix to ProblemList jcstress tests that are failing due to JDK-8325984.
-
Commit messages:
- 8326062: ProblemList jcstress tests that are failing due to JDK-8325984
Changes: https://git.openjdk.org/jdk/pull/17890/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17890
On Fri, 16 Feb 2024 15:31:07 GMT, Claes Redestad wrote:
>> Adding a fast-path for ASCII-only modified UTF-8 strings deserialied via
>> Data- and ObjectInputStream
>>
>> Testing: tier1-3
>
> Claes Redestad has updated the pull request incrementally with two additional
> commits since the last r
> Adding a fast-path for ASCII-only modified UTF-8 strings deserialied via
> Data- and ObjectInputStream
>
> Testing: tier1-3
Claes Redestad has updated the pull request incrementally with two additional
commits since the last revision:
- Update test/micro/org/openjdk/bench/java/io/DataInputS
On Thu, 15 Feb 2024 13:07:20 GMT, Claes Redestad wrote:
>> Adding a fast-path for ASCII-only modified UTF-8 strings deserialied via
>> Data- and ObjectInputStream
>>
>> Testing: tier1-3
>
> Claes Redestad has updated the pull request incrementally with one additional
> commit since the last re
On Thu, 15 Feb 2024 13:07:20 GMT, Claes Redestad wrote:
>> Adding a fast-path for ASCII-only modified UTF-8 strings deserialied via
>> Data- and ObjectInputStream
>>
>> Testing: tier1-3
>
> Claes Redestad has updated the pull request incrementally with one additional
> commit since the last re
On Fri, 16 Feb 2024 12:43:25 GMT, Magnus Ihse Bursie wrote:
>> Since jcheck only checks file in a commit, there is a possibility of us
>> getting files in the repository that would not be accepted by jcheck. This
>> can happen when extending the set of files checked by jcheck, or if jcheck
>>
On Thu, 15 Feb 2024 17:53:41 GMT, Naoto Sato wrote:
>> `\u000b` is VT (vertical tab)
>> `\u0009` or `\t` perhaps?
>
> Right. `\t` is better to avoid such a mistake.
Ok, fixed.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/17871#discussion_r1492403403
> Since jcheck only checks file in a commit, there is a possibility of us
> getting files in the repository that would not be accepted by jcheck. This
> can happen when extending the set of files checked by jcheck, or if jcheck
> changes how it checks files (perhaps due to bug fixes).
>
> I hav
> During analysing a customer case I figured out that we have an inconsistency
> between documentation and actual behavior in class
> com.sun.jndi.ldap.Connection. The [method documentation of
> com.sun.jndi.ldap.Connection::createSocket](https://github.com/openjdk/jdk/blob/3ebe6c192a5dd5cc46ae2
On Thu, 15 Feb 2024 13:35:24 GMT, Richard Reingruber wrote:
>> Set `interrupted` in `Thread::interrupt` before reading `nioBlocker` for
>> correct (Dekker scheme) synchronization with concurrent execution of
>> [`AbstractInterruptibleChannel::begin`](https://github.com/openjdk/jdk/blob/59062402
On Tue, 16 Jan 2024 10:57:46 GMT, Richard Reingruber wrote:
> Set `interrupted` in `Thread::interrupt` before reading `nioBlocker` for
> correct (Dekker scheme) synchronization with concurrent execution of
> [`AbstractInterruptibleChannel::begin`](https://github.com/openjdk/jdk/blob/59062402b9c
34 matches
Mail list logo
