On Tue, 13 Feb 2024 22:30:28 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Many crypto service classes require a `SecureRandom` object at
>> initialization. This test goes through each of them and calculates
>> (generate, encrypt, sign,...) twice with the same `SecureRandom` object and
>> ensures the output is the same.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> assertNotEqualsByteArray
test/lib/jdk/test/lib/Asserts.java line 290:
> 288: public static void assertNotEqualsByteArray(byte[] lhs, byte[] rhs,
> String msg) {
> 289: if (Arrays.equals(lhs, rhs)) {
> 290: msg = Objects.toString(msg, "assertEqualsByteArray")
method name in the message not matching the method?
test/lib/jdk/test/lib/Asserts.java line 292:
> 290: msg = Objects.toString(msg, "assertEqualsByteArray")
> 291: + ": expected " + HexFormat.of().formatHex(lhs)
> 292: + " to equal " + HexFormat.of().formatHex(rhs);
"to NOT equal"?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17776#discussion_r1493106466
PR Review Comment: https://git.openjdk.org/jdk/pull/17776#discussion_r1493106604
