> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319344)
> which adds MessageFormat pattern support for the following subformats:
> ListFormat, CompactNumberFormat, and DateTimeFormatter. This change is
> intended to provide pattern support for the more recently added JDK F
During analysing a customer case I figured out that we have an inconsistency
between documentation and actual behavior in class
com.sun.jndi.ldap.Connection. The [method documentation of
com.sun.jndi.ldap.Connection::createSocket](https://github.com/openjdk/jdk/blob/3ebe6c192a5dd5cc46ae2d263713c
On Thu, 8 Feb 2024 21:29:19 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319344)
>> which adds MessageFormat pattern support for the following subformats:
>> ListFormat, CompactNumberFormat, and DateTimeFormatter. This change is
>> intended to p
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote:
> This is an attempt to finally implement the idea brought forward in
> JDK-8295729: Properties files is essentially source code. It should have the
> same whitespace checks as all other source code, so we don't get spurious
> trailin
On Fri, 9 Feb 2024 12:31:27 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which suggests we speed up the `Zip64SizeTest` using a
>> small-sized ZIP64 ZIP file specifically created to reproduce the issue being
>> tested.
>>
>> The disk space requirement of this test is known to cause prob
On Thu, 8 Feb 2024 20:57:51 GMT, Alexey Semenyuk wrote:
> Tested with the use case from the CR.
>
> The idea of the fix is to prevent grandchildren processes from being
> automatically attached to the job killing all processes attached to it when
> the job object is destroyed.
>
> Filed a fol
On Fri, 9 Feb 2024 13:42:02 GMT, Magnus Ihse Bursie wrote:
>> This is an attempt to finally implement the idea brought forward in
>> JDK-8295729: Properties files is essentially source code. It should have
>> the same whitespace checks as all other source code, so we don't get
>> spurious tra
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote:
> This is an attempt to finally implement the idea brought forward in
> JDK-8295729: Properties files is essentially source code. It should have the
> same whitespace checks as all other source code, so we don't get spurious
> trailin
On Fri, 2 Feb 2024 17:38:13 GMT, Joshua Cao wrote:
>> This change mirrors what we did for ConcurrentHashMap in
>> https://github.com/openjdk/jdk/pull/17116. When we add all entries from one
>> map to anther, we should resize that map to the size of the sum of both maps.
>>
>> I used the comman
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote:
> This is an attempt to finally implement the idea brought forward in
> JDK-8295729: Properties files is essentially source code. It should have the
> same whitespace checks as all other source code, so we don't get spurious
> trailin
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote:
> This is an attempt to finally implement the idea brought forward in
> JDK-8295729: Properties files is essentially source code. It should have the
> same whitespace checks as all other source code, so we don't get spurious
> trailin
This is an attempt to finally implement the idea brought forward in
JDK-8295729: Properties files is essentially source code. It should have the
same whitespace checks as all other source code, so we don't get spurious
trailing whitespace changes or leading tabs instead of spaces.
With Skara
> Please review this PR which suggests we speed up the `Zip64SizeTest` using a
> small-sized ZIP64 ZIP file specifically created to reproduce the issue being
> tested.
>
> The disk space requirement of this test is known to cause problems in some
> builds, see [JDK-8259866](https://bugs.openjdk
On Fri, 9 Feb 2024 11:59:13 GMT, Lance Andersen wrote:
> Again minor but perhaps articulate that after this call, the extra data will
> be(obvious to you and I but probably not to others...)
Added `zipdetails` describing the resulting ZIP64 structure to the
`updateCENHeaderToZip64` method docu
On Fri, 9 Feb 2024 11:55:16 GMT, Lance Andersen wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Spell fix for "Contents"
>> - Add comments to explain how we temporarily use the 'unknown' tag to
>> prevent Zip
On Fri, 9 Feb 2024 12:17:17 GMT, Eirik Bjørsnøs wrote:
>> test/jdk/java/util/zip/ZipFile/Zip64SizeTest.java line 114:
>>
>>> 112:
>>> 113: // Make an extra field with the correct size for an 8-byte
>>> 'uncompressed size'
>>> 114: // Zip64 field. Temporarily use the 'un
> Please review this PR which suggests we speed up the `Zip64SizeTest` using a
> small-sized ZIP64 ZIP file specifically created to reproduce the issue being
> tested.
>
> The disk space requirement of this test is known to cause problems in some
> builds, see [JDK-8259866](https://bugs.openjdk
On Fri, 9 Feb 2024 10:33:30 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which suggests we speed up the `Zip64SizeTest` using a
>> small-sized ZIP64 ZIP file specifically created to reproduce the issue being
>> tested.
>>
>> The disk space requirement of this test is known to cause prob
On Thu, 8 Feb 2024 07:44:18 GMT, Magnus Ihse Bursie wrote:
>> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we
>> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK
>> native libraries.
>
> Magnus Ihse Bursie has updated the pull request increme
> ClassFile API provides two sets of instructions implementations (bound and
> unbound).
> Unbound implementation of `IncrementInstruction::constant` returns invalid
> value.
> This bug discovered a hole in the ClassFile API test coverage.
>
> This patch provides very simple fix of `IncrementIn
On Fri, 9 Feb 2024 06:39:31 GMT, Jaikiran Pai wrote:
>> Eirik Bjørsnøs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 13 additional
>> commits
> Please review this PR which suggests we speed up the `Zip64SizeTest` using a
> small-sized ZIP64 ZIP file specifically created to reproduce the issue being
> tested.
>
> The disk space requirement of this test is known to cause problems in some
> builds, see [JDK-8259866](https://bugs.openjdk
On Thu, 8 Feb 2024 13:18:41 GMT, Adam Sotona wrote:
> ClassFile API provides two sets of instructions implementations (bound and
> unbound).
> Unbound implementation of `IncrementInstruction::constant` returns invalid
> value.
> This bug discovered a hole in the ClassFile API test coverage.
>
23 matches
Mail list logo
