On Fri, 9 Feb 2024 12:17:17 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:
>> test/jdk/java/util/zip/ZipFile/Zip64SizeTest.java line 114: >> >>> 112: >>> 113: // Make an extra field with the correct size for an 8-byte >>> 'uncompressed size' >>> 114: // Zip64 field. Temporarily use the 'unknown' tag 0x9902 >>> to make >> >> I would suggest adding a reference to the following in the APPNOTE.TXT to >> make clearer where that value came from >> >>> 4.6.1 Third party mappings commonly used are: >> >> another suggestion would be to show the CEN here with this change I think >> would make it easier for someone who is not as familiar with APPNOTE.TXT > > The CEN structure is already descibed in the method-level documentation. > Would you prefer I move it into the code? Not sure I would like to repeat it, > and I think perhaps it's better to have the whole structure in once place, > instead of splitting it (since the Zip64 extra corresponds to the CEN header > fields). > > What do you think? > I would suggest adding a reference to the following in the APPNOTE.TXT to > make clearer where that value came from Added a reference to "Third Party Mappings". (It's not super-important that we chose 'unknown' here, it just seemed a reasonable choice for something ZipEntry cannot see into) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/12948#discussion_r1484248708
